GNU bug report logs - #57642
[PATCH] gnu: linux: Fix unnecessary let clause in make-linux-libre.

Previous Next

Package: guix;

Reported by: muradm <mail <at> muradm.net>

Date: Wed, 7 Sep 2022 12:03:01 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57642 in the body.
You can then email your comments to 57642 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-guix <at> gnu.org:
bug#57642; Package guix. (Wed, 07 Sep 2022 12:03:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to muradm <mail <at> muradm.net>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Wed, 07 Sep 2022 12:03:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: bug-guix <at> gnu.org
Subject: [PATCH] gnu: linux: Fix unnecessary let clause in make-linux-libre.
Date: Wed,  7 Sep 2022 15:02:16 +0300

* gnu/packages/linux.scm (make-linux-libre*)[arguments]:
Remove unnecessary let clause in 'configure phase.
---
 gnu/packages/linux.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index f4880f164c..ee6e592183 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -852,8 +852,7 @@ (define* (make-linux-libre* version gnu-revision source supported-systems
                            #$(and extra-version
                                   (string-append "-" extra-version)))
 
-                   (let ((build  (assoc-ref %standard-phases 'build))
-                         (config (assoc-ref inputs "kconfig")))
+                   (let ((config (assoc-ref inputs "kconfig")))
 
                      ;; Use a custom kernel configuration file or a default
                      ;; configuration file.
-- 
2.37.2
Reply sent to Mathieu Othacehe <othacehe <at> gnu.org>:
You have taken responsibility. (Wed, 07 Sep 2022 12:54:02 GMT) Full text and rfc822 format available.
Notification sent to muradm <mail <at> muradm.net>:
bug acknowledged by developer. (Wed, 07 Sep 2022 12:54:02 GMT) Full text and rfc822 format available.

Message #10 received at 57642-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: muradm <mail <at> muradm.net>
Cc: 57642-done <at> debbugs.gnu.org
Subject: Re: bug#57642: [PATCH] gnu: linux: Fix unnecessary let clause in
 make-linux-libre.
Date: Wed, 07 Sep 2022 14:53:28 +0200

Hey,

> * gnu/packages/linux.scm (make-linux-libre*)[arguments]:
> Remove unnecessary let clause in 'configure phase.

You should send such patches to "guix-patches <at> gnu.org" instead as it is
not a bug report nor correction. Pushed as 2183db8d2 :).

Thanks,

Mathieu
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 06 Oct 2022 11:24:12 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 199 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.