GNU bug report logs - #57646
[PATCH 0/3] teams: Add scope support.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Mathieu Othacehe <othacehe@HIDDEN>; Keywords: patch; Done: Mathieu Othacehe <othacehe@HIDDEN>; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 57646-done <at> debbugs.gnu.org:


Received: (at 57646-done) by debbugs.gnu.org; 25 Sep 2022 11:55:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Sep 25 07:55:06 2022
Received: from localhost ([127.0.0.1]:46033 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ocQDu-0002c1-Jg
	for submit <at> debbugs.gnu.org; Sun, 25 Sep 2022 07:55:06 -0400
Received: from eggs.gnu.org ([209.51.188.92]:50620)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1ocQDt-0002bS-Gh
 for 57646-done <at> debbugs.gnu.org; Sun, 25 Sep 2022 07:55:01 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:40428)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1ocQDo-00010V-AW; Sun, 25 Sep 2022 07:54:56 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=ZeSoTyv/EvakVRY4QfqLXnZM1Al7LVArYToOFPJFhn0=; b=rejxqRakrD2RTw3PEsZw
 Ater7GdhUNCnhFW9n0NfEpoUrqF/XHk354TK3ZjiPQOpy1ZgjUzoUQk0PaoZ1GSPLPjPUEIjFtEkZ
 JdUryGCjjPYPQDT1HwcIkeMyXtdYY820Cu3YUFd7dz2KlRm7kezbSnZPPY+Wq0jSoA/y3+5jf9nqM
 YDXLbXooQHvyIYDldBbMEt+vLGpFzgaE7W6f7tFx3JgmUiKOayydgFRngRFV1XcQHKHeG5yivLsWu
 u/AocwoFdV79lH5uwbIe0A86crioXdyferN6ryCYME8ra0sUq3dzOybpBxrAGccOQirx1Q33Klzi6
 XB+zL3bV9g3sXA==;
Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2775.rev.sfr.net
 ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2775]:60720 helo=meije)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1ocQDn-0002N4-TD; Sun, 25 Sep 2022 07:54:56 -0400
From: Mathieu Othacehe <othacehe@HIDDEN>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Subject: Re: bug#57646: [PATCH 0/3] teams: Add scope support.
References: <20220907151622.4912-1-othacehe@HIDDEN>
 <20220912135545.24795-1-othacehe@HIDDEN> <87bkr5ax9p.fsf_-_@HIDDEN>
Date: Sun, 25 Sep 2022 13:54:53 +0200
In-Reply-To: <87bkr5ax9p.fsf_-_@HIDDEN> ("Ludovic =?utf-8?Q?Court=C3=A8s?=
 =?utf-8?Q?=22's?= message of "Sat, 24 Sep 2022 12:21:06 +0200")
Message-ID: <87pmfjk6sy.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57646-done
Cc: 57646-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


Hey,

> I took a look at v2 and it looks great to me!  I think you can push.

Pushed, with a mail to guix-devel to inform people!

Thanks,

Mathieu




Notification sent to Mathieu Othacehe <othacehe@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Mathieu Othacehe <othacehe@HIDDEN>:
You have taken responsibility. Full text available.

Message received at 57646 <at> debbugs.gnu.org:


Received: (at 57646) by debbugs.gnu.org; 24 Sep 2022 10:21:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 24 06:21:24 2022
Received: from localhost ([127.0.0.1]:42417 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oc2Hj-00051d-QJ
	for submit <at> debbugs.gnu.org; Sat, 24 Sep 2022 06:21:24 -0400
Received: from eggs.gnu.org ([209.51.188.92]:43558)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1oc2Hi-00051R-G4
 for 57646 <at> debbugs.gnu.org; Sat, 24 Sep 2022 06:21:22 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:55116)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1oc2Hd-0007Ku-2b
 for 57646 <at> debbugs.gnu.org; Sat, 24 Sep 2022 06:21:17 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=HsBerNizeBvSjqgP5nvYuPh9ZrXxARVALBzPRtHCt/c=; b=JKasdjm+2Iais7Ts2n5S
 6O97mxlmtxnMnPN5I0Qc1znk/+ehGh3pkext1G6i0O7bvnBImQs6ZAwVOuxvuUjW1PnmuHn6W1kU3
 iCdlAEArxGjpN49U10nnXqHiXnxQAJsFg5hBvIDhysZlWEJkFtXnhavwq0z7b1uGtdJaszjYOT3pI
 Pg8wCyqX6FleZEdf5VicCkHdAwMsqQiUap1DrYIOaIuFWRd4wE+JG009UJzuMNmH99FecF6Tp6hqa
 o4zFtEdlUsUxovErlk2oIIa1dW9O8wpY34TCSlEDm0ByE0fyDWkeAeTmK2SjLKA/VhQzUAJDUWLI2
 p8wwKLA0LdWNzw==;
Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:53592
 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1oc2HT-0002dK-PM; Sat, 24 Sep 2022 06:21:16 -0400
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Mathieu Othacehe <othacehe@HIDDEN>
Subject: Re: bug#57646: [PATCH 0/3] teams: Add scope support.
References: <20220907151622.4912-1-othacehe@HIDDEN>
 <20220912135545.24795-1-othacehe@HIDDEN>
Date: Sat, 24 Sep 2022 12:21:06 +0200
In-Reply-To: <20220912135545.24795-1-othacehe@HIDDEN> (Mathieu Othacehe's
 message of "Mon, 12 Sep 2022 15:55:42 +0200")
Message-ID: <87bkr5ax9p.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57646
Cc: 57646 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

I took a look at v2 and it looks great to me!  I think you can push.

Thanks,
Ludo=E2=80=99.




Information forwarded to guix-patches@HIDDEN:
bug#57646; Package guix-patches. Full text available.

Message received at 57646 <at> debbugs.gnu.org:


Received: (at 57646) by debbugs.gnu.org; 12 Sep 2022 13:56:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 12 09:56:09 2022
Received: from localhost ([127.0.0.1]:47478 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oXjuz-0008G7-7y
	for submit <at> debbugs.gnu.org; Mon, 12 Sep 2022 09:56:09 -0400
Received: from eggs.gnu.org ([209.51.188.92]:44914)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1oXjuu-0008CB-3W
 for 57646 <at> debbugs.gnu.org; Mon, 12 Sep 2022 09:56:04 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:42398)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>) id 1oXjuo-0004M4-Sg
 for 57646 <at> debbugs.gnu.org; Mon, 12 Sep 2022 09:55:58 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To:
 From; bh=9hVuSg+JjeMw5OGaaV8wl3Jw+vjucRHsUnMikpQa8z8=; b=NIl24Ma8+Z1JaZIjlafE
 7TUpQDTo3WEEGRIPgyOjUSxTM14JI5Pk8HIEiLsCSszCw8TyJ9u8OyyQ8SO4A08d8jyjnmIWWWALY
 xDaC/31IDwISTupV9DyA5xb2FdFmXgxX3Znda1uqmhuVjBo0I4baf1ypJWx8shoR6eIE45JaJH3+k
 kQOjkKUdYbY+62sx1IbXiJq9CgLGsjqRvR1U07IiWj3r0lM8nLVNhJQ/b8+YffsK2zWROaRWvB+mZ
 qBHvCEE+A2826aQCDPnJuyk5+GB0LUOtYaOy0QWyfZBSyM6cESzCS8pwLZ1yq/iOfx5d9+LXPdkDW
 zAV2t5pQMV/23w==;
Received: from [2a02:587:1d33:7300:4fa4:945e:237e:7b1f] (port=42636
 helo=localhost.localdomain)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1oXjuo-0005y1-9x; Mon, 12 Sep 2022 09:55:58 -0400
From: Mathieu Othacehe <othacehe@HIDDEN>
To: 57646 <at> debbugs.gnu.org
Subject: [PATCH v2 4/4] etc: installer: Define installer team scope.
Date: Mon, 12 Sep 2022 15:55:45 +0200
Message-Id: <20220912135545.24795-4-othacehe@HIDDEN>
X-Mailer: git-send-email 2.37.2
In-Reply-To: <20220912135545.24795-1-othacehe@HIDDEN>
References: <20220912135545.24795-1-othacehe@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57646
Cc: Mathieu Othacehe <othacehe@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

* etc/teams.scm.in (installer): Define it.
---
 etc/teams.scm.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/etc/teams.scm.in b/etc/teams.scm.in
index 347af86005..5fe7121f56 100644
--- a/etc/teams.scm.in
+++ b/etc/teams.scm.in
@@ -255,7 +255,9 @@ (define-team translations
 
 (define-team installer
   (team 'installer
-        #:name "Installer script and system installer"))
+        #:name "Installer script and system installer"
+        #:scope
+        (list (make-regexp "^guix/installer(\\.scm$|/)"))))
 
 (define-team home
   (team 'home
-- 
2.37.2





Information forwarded to guix-patches@HIDDEN:
bug#57646; Package guix-patches. Full text available.

Message received at 57646 <at> debbugs.gnu.org:


Received: (at 57646) by debbugs.gnu.org; 12 Sep 2022 13:56:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 12 09:56:09 2022
Received: from localhost ([127.0.0.1]:47476 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oXjuy-0008G3-KO
	for submit <at> debbugs.gnu.org; Mon, 12 Sep 2022 09:56:09 -0400
Received: from eggs.gnu.org ([209.51.188.92]:44912)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1oXjut-0008B2-1Y
 for 57646 <at> debbugs.gnu.org; Mon, 12 Sep 2022 09:56:03 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:54200)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>) id 1oXjun-0004Lw-Qu
 for 57646 <at> debbugs.gnu.org; Mon, 12 Sep 2022 09:55:57 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To:
 From; bh=A54WXm3hjU5mEKolguXF5RCldzSBIHuiAkRYkmNQMuc=; b=k2wXjrBZ3XVrVD5DEZ1l
 6D2YyjtkpJ2oun/31XCLgeBhJvVJpyyeVkTwdqFAoAeC4hxHEOdUuGR0ma8ixhjUREy7sa0Epo/Z1
 p4cY/0CJLu+BFlBKv5xoagF1HiJEWRgxq9nLlyr0JnfyjA5NYdt6LDWooGRuxHdvglUk/ojOxUCXF
 zqDm0DSypUafj5Dr1xZwsSgmPGA7gIeLK5LH5vmE0SFIpoAtG0Y+8QS8AnfDXp4R/a5p/nICwKMHP
 AdryvPBBFD94d7WYI4EJbdGdbTGhOnEXoMUwwmpKLnecd0JBmzC861LFm2mxYnuDoKNYawJMd0IL8
 2VZ3mfXTlEfGpA==;
Received: from [2a02:587:1d33:7300:4fa4:945e:237e:7b1f] (port=42636
 helo=localhost.localdomain)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1oXjun-0005y1-8V; Mon, 12 Sep 2022 09:55:57 -0400
From: Mathieu Othacehe <othacehe@HIDDEN>
To: 57646 <at> debbugs.gnu.org
Subject: [PATCH v2 3/4] etc: teams: Define core team scope.
Date: Mon, 12 Sep 2022 15:55:44 +0200
Message-Id: <20220912135545.24795-3-othacehe@HIDDEN>
X-Mailer: git-send-email 2.37.2
In-Reply-To: <20220912135545.24795-1-othacehe@HIDDEN>
References: <20220912135545.24795-1-othacehe@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57646
Cc: Mathieu Othacehe <othacehe@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

* etc/teams.scm.in (core): Define it.
---
 etc/teams.scm.in | 83 +++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 82 insertions(+), 1 deletion(-)

diff --git a/etc/teams.scm.in b/etc/teams.scm.in
index 34cc547b26..347af86005 100644
--- a/etc/teams.scm.in
+++ b/etc/teams.scm.in
@@ -162,7 +162,88 @@ (define-team kernel
 
 (define-team core
   (team 'core
-        #:name "Core / Tools / Internals"))
+        #:name "Core / Tools / Internals"
+        #:scope
+        (list "guix/avahi.scm"
+              "guix/base16.scm"
+              "guix/base32.scm"
+              "guix/base64.scm"
+              "guix/bzr-download.scm"
+              "guix/cache.scm"
+              "guix/channels.scm"
+              "guix/ci.scm"
+              "guix/colors.scm"
+              "guix/combinators.scm"
+              "guix/config.scm"
+              "guix/cpio.scm"
+              "guix/cpu.scm"
+              "guix/cve.scm"
+              "guix/cvs-download.scm"
+              "guix/deprecation.scm"
+              "guix/derivations.scm"
+              "guix/describe.scm"
+              "guix/diagnostics.scm"
+              "guix/discovery.scm"
+              "guix/docker.scm"
+              "guix/download.scm"
+              "guix/elf.scm"
+              "guix/ftp-client.scm"
+              "guix/gexp.scm"
+              "guix/git-authenticate.scm"
+              "guix/git-download.scm"
+              "guix/git.scm"
+              "guix/glob.scm"
+              "guix/gnu-maintenance.scm"
+              "guix/gnupg.scm"
+              "guix/grafts.scm"
+              "guix/graph.scm"
+              "guix/hash.scm"
+              "guix/hg-download.scm"
+              "guix/http-client.scm"
+              "guix/i18n.scm"
+              "guix/inferior.scm"
+              "guix/ipfs.scm"
+              "guix/least-authority.scm"
+              "guix/licenses.scm"
+              "guix/lint.scm"
+              "guix/man-db.scm"
+              "guix/memoization.scm"
+              "guix/modules.scm"
+              "guix/monad-repl.scm"
+              "guix/monads.scm"
+              "guix/narinfo.scm"
+              "guix/nar.scm"
+              "guix/openpgp.scm"
+              "guix/packages.scm"
+              "guix/pki.scm"
+              "guix/platform.scm"
+              "guix/profiles.scm"
+              "guix/profiling.scm"
+              "guix/progress.scm"
+              "guix/quirks.scm"
+              "guix/read-print.scm"
+              "guix/records.scm"
+              "guix/remote.scm"
+              "guix/repl.scm"
+              "guix/search-paths.scm"
+              "guix/self.scm"
+              "guix/serialization.scm"
+              "guix/sets.scm"
+              "guix/ssh.scm"
+              "guix/status.scm"
+              "guix/store.scm"
+              "guix/substitutes.scm"
+              "guix/svn-download.scm"
+              "guix/swh.scm"
+              "guix/tests.scm"
+              "guix/transformations.scm"
+              "guix/ui.scm"
+              "guix/upstream.scm"
+              "guix/utils.scm"
+              "guix/workers.scm"
+              (make-regexp "^guix/platforms/")
+              (make-regexp "^guix/scripts/")
+              (make-regexp "^guix/store/"))))
 
 (define-team games
   (team 'games
-- 
2.37.2





Information forwarded to guix-patches@HIDDEN:
bug#57646; Package guix-patches. Full text available.

Message received at 57646 <at> debbugs.gnu.org:


Received: (at 57646) by debbugs.gnu.org; 12 Sep 2022 13:56:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 12 09:56:04 2022
Received: from localhost ([127.0.0.1]:47472 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oXjut-0008Fk-Pi
	for submit <at> debbugs.gnu.org; Mon, 12 Sep 2022 09:56:04 -0400
Received: from eggs.gnu.org ([209.51.188.92]:44908)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1oXjuq-00089G-SO
 for 57646 <at> debbugs.gnu.org; Mon, 12 Sep 2022 09:56:02 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:54196)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>) id 1oXjul-0004Lj-Ln
 for 57646 <at> debbugs.gnu.org; Mon, 12 Sep 2022 09:55:55 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to:
 references; bh=HdQKlbdah978Indr12Gwbv2xGixALUyFyR/eeov7e4A=; b=gM+8PuLsJ9HcMa
 HPD5IEEsHFgumjRJsxOJBYzyvJza7bg3od0+NUb9DDGVaN+zhQ0It8AP/4wg95fogluNhned54XLe
 Fmpj4gFTdhJRbHsmyx1+fRwYHn4hCnm95cwWHBSF96ZjWII83CHeK1NhFonn9f/8CBbYh23w2+c5g
 uYMv/A8aspGY0whBW1hJbMpSEtJDKlXvKmE6mdPl/EFFT+49I0V1fzuZqDA3WHszZorpSCBhhRVS7
 Ijg5a8bEWMksm8QwORSNJb+I2FuwWYdB3VuKU0khRUOjJg9s+UCLSjvnNOj1iFe4fvBPn1rJpw3HR
 bJ8h4hg7TBcOYYn+mx8A==;
Received: from [2a02:587:1d33:7300:4fa4:945e:237e:7b1f] (port=42636
 helo=localhost.localdomain)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1oXjul-0005y1-2T; Mon, 12 Sep 2022 09:55:55 -0400
From: Mathieu Othacehe <othacehe@HIDDEN>
To: 57646 <at> debbugs.gnu.org
Subject: [PATCH v2 1/4] etc: teams: Add scope support.
Date: Mon, 12 Sep 2022 15:55:42 +0200
Message-Id: <20220912135545.24795-1-othacehe@HIDDEN>
X-Mailer: git-send-email 2.37.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57646
Cc: Mathieu Othacehe <othacehe@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Add a scope list to each team.  This list defines all the files and
directories that are mentored by the team.

Also add a cc-members command that takes two Git revision strings as input,
add returns the members that should be CC'ed given the files impacted between
the two revisions.

* etc/teams.scm.in (<team>)[scope]: New field.
(team, list-teams): Adapt those procedures.
(find-team-by-scope, diff-revisions): New procedures.
(main): Add a "cc-members" command.
* doc/contributing.texi ("Teams"): Document it.
("Sending a Patch Series"): Adapt it.
---
 doc/contributing.texi | 41 ++++++++++++++++++++++++
 etc/teams.scm.in      | 74 +++++++++++++++++++++++++++++++++++++------
 2 files changed, 106 insertions(+), 9 deletions(-)

diff --git a/doc/contributing.texi b/doc/contributing.texi
index 17a54f94cc..7712f63d67 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -1406,6 +1406,47 @@ for more information.  You can install @command{git send-email} with
 @command{guix install git:send-email}.
 @c Debbugs bug: https://debbugs.gnu.org/db/15/15361.html
 
+To maximize the chances that you patch series is reviewed, the preferred
+submission way is to use the @code{etc/teams.scm} script to notify the
+appropriate team members (@pxref{Teams}).
+
+@unnumberedsubsec Teams
+@anchor{Teams}
+@cindex teams
+
+There are several teams mentoring different parts of the Guix source
+code.  To list all those teams, you can run from a Guix checkout:
+
+@example
+$ ./etc/teams.scm list-teams
+id: mentors
+name: Mentors
+description: A group of mentors who chaperone contributions by newcomers.
+members:
++ Christopher Baines <mail@@cbaines.net>
++ Ricardo Wurmus <rekado@@elephly.net>
++ Mathieu Othacehe <othacehe@@gnu.org>
++ jgart <jgart@@dismail.de>
++ Ludovic Courtès <ludo@@gnu.org>
+@dots{}
+@end example
+
+You can run the following command to have the @code{Mentors} team put in
+CC of a patch series:
+
+@example
+$ git send-email --to XXX@@debbugs.gnu.org $(./etc/teams.scm cc mentors) *.patch
+@end example
+
+The appropriate team or teams can also be inferred from the modified
+files.  For instance, if you want to send the two latest commits of the
+current Git repository to review, you can run:
+
+@example
+$ guix shell -D guix
+[env]$ git send-email --to XXX@@debbugs.gnu.org $(./etc/teams.scm cc-members HEAD~2 HEAD) *.patch
+@end example
+
 @node Tracking Bugs and Patches
 @section Tracking Bugs and Patches
 
diff --git a/etc/teams.scm.in b/etc/teams.scm.in
index 9f220cc489..22177422c2 100644
--- a/etc/teams.scm.in
+++ b/etc/teams.scm.in
@@ -4,6 +4,7 @@
 
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2022 Ricardo Wurmus <rekado@HIDDEN>
+;;; Copyright © 2022 Mathieu Othacehe <othacehe@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -22,23 +23,27 @@
 
 ;;; Commentary:
 
-;; This code defines development teams and team members.
+;; This code defines development teams and team members, as well as their
+;; scope.
 
 ;;; Code:
 
 (use-modules (srfi srfi-1)
              (srfi srfi-9)
+             (srfi srfi-26)
              (ice-9 format)
              (ice-9 match)
-             (guix ui))
+             (guix ui)
+             (git))
 
 (define-record-type <team>
-  (make-team id name description members)
+  (make-team id name description members scope)
   team?
   (id          team-id)
   (name        team-name)
   (description team-description)
-  (members     team-members set-team-members!))
+  (members     team-members set-team-members!)
+  (scope       team-scope))
 
 (define-record-type <person>
   (make-person name email)
@@ -49,11 +54,13 @@ (define-record-type <person>
 (define* (person name #:optional email)
   (make-person name email))
 
-(define* (team id #:key name description (members '()))
+(define* (team id #:key name description (members '())
+               (scope '()))
   (make-team id
              (or name (symbol->string id))
              description
-             members))
+             members
+             scope))
 
 (define %teams
   (make-hash-table))
@@ -272,6 +279,22 @@ (define (find-team name)
       (error (format #false
                            "no such team: ~a~%" name))))
 
+(define (find-team-by-scope files)
+  "Return the team(s) which scope matches at least one of the FILES, as list
+of file names as string."
+  (hash-fold
+   (lambda (key team acc)
+     (if (any (lambda (file)
+                (any (lambda (scope)
+                       ;; XXX: Add regex support?
+                       (string-prefix? scope file))
+                     (team-scope team)))
+              files)
+         (cons team acc)
+         acc))
+   '()
+   %teams))
+
 (define (cc . teams)
   "Return arguments for `git send-email' to notify the members of the given
 TEAMS when a patch is received by Debbugs."
@@ -293,7 +316,7 @@ (define port* (or port (current-output-port)))
    (team-members team)))
 
 (define (list-teams)
-  "Print all teams and their members."
+  "Print all teams, their scope and their members."
   (define port* (current-output-port))
   (define width* (%text-width))
   (hash-for-each
@@ -303,7 +326,7 @@ (define width* (%text-width))
 id: ~a
 name: ~a
 description: ~a
-members:
+~amembers:
 "
              (team-id team)
              (team-name team)
@@ -312,15 +335,48 @@ (define width* (%text-width))
                           (string->recutils
                            (fill-paragraph text width*
                                            (string-length "description: ")))))
-                 "<none>"))
+                 "<none>")
+             (match (team-scope team)
+               (() "")
+               (scope (format #f "scope: ~{~s ~}~%" scope))))
      (list-members team port* "+ ")
      (newline))
    %teams))
 
+
+(define (diff-revisions rev-start rev-end)
+  "Return the list of added, modified or removed files between REV-START
+and REV-END, two git revision strings."
+  (let* ((repository (repository-open (getcwd)))
+         (commit1 (commit-lookup repository
+                                 (object-id
+                                  (revparse-single repository rev-start))))
+         (commit2 (commit-lookup repository
+                                 (object-id
+                                  (revparse-single repository rev-end))))
+         (diff (diff-tree-to-tree repository
+                                  (commit-tree commit1)
+                                  (commit-tree commit2)))
+         (files '()))
+    (diff-foreach
+     diff
+     (lambda (delta progress)
+       (set! files
+             (cons (diff-file-path (diff-delta-old-file delta)) files))
+       0)
+     (const 0)
+     (const 0)
+     (const 0))
+    files))
+
+
 (define (main . args)
   (match args
     (("cc" . team-names)
      (apply cc (map find-team team-names)))
+    (("cc-members" rev-start rev-end)
+     (apply cc (find-team-by-scope
+                (diff-revisions rev-start rev-end))))
     (("list-teams" . args)
      (list-teams))
     (("list-members" . team-names)
-- 
2.37.2





Information forwarded to guix-patches@HIDDEN:
bug#57646; Package guix-patches. Full text available.

Message received at 57646 <at> debbugs.gnu.org:


Received: (at 57646) by debbugs.gnu.org; 12 Sep 2022 13:56:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 12 09:56:03 2022
Received: from localhost ([127.0.0.1]:47470 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oXjut-0008Fi-GA
	for submit <at> debbugs.gnu.org; Mon, 12 Sep 2022 09:56:03 -0400
Received: from eggs.gnu.org ([209.51.188.92]:44910)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1oXjus-0008AK-4p
 for 57646 <at> debbugs.gnu.org; Mon, 12 Sep 2022 09:56:02 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:54198)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1oXjum-0004Lp-Re; Mon, 12 Sep 2022 09:55:56 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To:
 From; bh=W37E064o1Rxf0RVHvnPSmhaEIvbb8ihL3ynDXnneGlM=; b=Sdj2kmmjn239QEtGKSg/
 GwaXrJ6T5wJ8z6ydISSBzVawQsu507Zt9WGb202/8ttxZhqPtGx0o6ca1LOC+55bsYxy5X97yJeYG
 bmk3dqe1YEBoACnB33MB+Sj+OT12FjkdV1OxXhdZSwbbSRD6iqyhbbGa0ZM2kFBQMhAwgjEzAleFv
 wvhucw3n26MBl7FPsS+Px8OQERdPmy6r0O4CkrrLtuzyteEvJMqeiYXeUI+4zVpjKcaS9U/HvjVZK
 bn5W2Ssxl+kmrYGrm9je/8FJKKg1A2xSdvi9LTADMrciVrmlnEFq1Eib1Wci3IOXqbB67QNg5DfCe
 F9LQzzU6vbLwLQ==;
Received: from [2a02:587:1d33:7300:4fa4:945e:237e:7b1f] (port=42636
 helo=localhost.localdomain)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1oXjum-0005y1-7i; Mon, 12 Sep 2022 09:55:56 -0400
From: Mathieu Othacehe <othacehe@HIDDEN>
To: 57646 <at> debbugs.gnu.org
Subject: [PATCH v2 2/4] etc: teams: Add regular expression support to scopes.
Date: Mon, 12 Sep 2022 15:55:43 +0200
Message-Id: <20220912135545.24795-2-othacehe@HIDDEN>
X-Mailer: git-send-email 2.37.2
In-Reply-To: <20220912135545.24795-1-othacehe@HIDDEN>
References: <20220912135545.24795-1-othacehe@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57646
Cc: Mathieu Othacehe <othacehe@HIDDEN>,
 Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

From: Liliana Marie Prikler <liliana.prikler@HIDDEN>

* etc/teams.scm (find-teams-by-scope): Differentiate between raw strings
and regexps.  Make raw string matches strict.

Signed-off-by: Mathieu Othacehe <othacehe@HIDDEN>
---
 etc/teams.scm.in | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/etc/teams.scm.in b/etc/teams.scm.in
index 22177422c2..34cc547b26 100644
--- a/etc/teams.scm.in
+++ b/etc/teams.scm.in
@@ -32,6 +32,7 @@
              (srfi srfi-9)
              (srfi srfi-26)
              (ice-9 format)
+             (ice-9 regex)
              (ice-9 match)
              (guix ui)
              (git))
@@ -285,9 +286,11 @@ (define (find-team-by-scope files)
   (hash-fold
    (lambda (key team acc)
      (if (any (lambda (file)
-                (any (lambda (scope)
-                       ;; XXX: Add regex support?
-                       (string-prefix? scope file))
+                (any (match-lambda
+                       ((? string? scope)
+                        (string=? scope file))
+                       ((? regexp? scope)
+                        (regexp-exec scope file)))
                      (team-scope team)))
               files)
          (cons team acc)
-- 
2.37.2





Information forwarded to guix-patches@HIDDEN:
bug#57646; Package guix-patches. Full text available.

Message received at 57646 <at> debbugs.gnu.org:


Received: (at 57646) by debbugs.gnu.org; 12 Sep 2022 13:49:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 12 09:49:43 2022
Received: from localhost ([127.0.0.1]:44676 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oXjok-0007Mp-Oy
	for submit <at> debbugs.gnu.org; Mon, 12 Sep 2022 09:49:43 -0400
Received: from eggs.gnu.org ([209.51.188.92]:53650)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1oXjoi-0007MZ-Lt
 for 57646 <at> debbugs.gnu.org; Mon, 12 Sep 2022 09:49:42 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:58078)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1oXjod-0003Bu-2f; Mon, 12 Sep 2022 09:49:35 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=Wpk3SNJgcNd+vGHcxcZk22fiBL7eFuFx+EnaXW3Wy+A=; b=og5GBW38r6xM5ZciGus7
 rfRTholXj7liII1V+ZNMDgHhiYjUU9PqDwBpMoLsrJl/uONE+vHmViMkRvMTYckoqMDUl9PQ8A/Og
 coRwhl+pLmPT56zeDL/xDLcx1VkIAdbH2cyJL6PMWYYAYB4amauUrivHqhEEIvvwzU+SQoAs1V6At
 vfCVBsQyvgO7eXRDFyD5QwWVeGgLbDDAuwk4DBRzt4+rWQH4ue4YXBuVWxJn9VhFaWKUkikoW3H9o
 upZEBV/lHHcSoQCKbIjatnyIDljkHvEHIklrZwRBQD2i8+yyuvi313ACoFVz4dufKTjdcxh4FOStf
 fm/b30074niTCQ==;
Received: from [2a02:587:1d33:7300:4fa4:945e:237e:7b1f] (port=52988 helo=meije)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1oXjoc-0004zm-H7; Mon, 12 Sep 2022 09:49:34 -0400
From: Mathieu Othacehe <othacehe@HIDDEN>
To: Ricardo Wurmus <rekado@HIDDEN>
Subject: Re: [PATCH] etc: teams: Add regular expression support to scopes.
References: <34c99df65a63bafd7868ad025a85ebb3a4457ac2.camel@HIDDEN>
 <87leqpsw9q.fsf@HIDDEN> <87a674nakk.fsf@HIDDEN>
Date: Mon, 12 Sep 2022 15:49:32 +0200
In-Reply-To: <87a674nakk.fsf@HIDDEN> (Ricardo Wurmus's message of "Mon,
 12 Sep 2022 12:30:35 +0200")
Message-ID: <878rmoaej7.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57646
Cc: 57646 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


Hey,

> * the dependency on Guile-Git means that the script must be run inside a
>   suitable environment now, whereas previously it had no dependencies
>   other than Guile.  If we can assume that people use Guix perhaps we
>   should do what doc/build.scm does and use Guix to arrange for
>   dependencies to be available.

Right, for now I went for the easiest solution and proposed the following
example in the documentation:

--8<---------------cut here---------------start------------->8---
$ guix shell -D guix
[env]$ git send-email $(./etc/teams.scm cc-members HEAD~2 HEAD) *.patch
--8<---------------cut here---------------end--------------->8---

> * I don=E2=80=99t like the =E2=80=9Cif=E2=80=9D + =E2=80=9Cnull?=E2=80=9D=
 pattern:
>
> +             (if (not (null? (team-scope team)))
> +                 (format #f "scope: ~{~s ~}~%" (team-scope team))
> +                 ""))
>
>   I=E2=80=99d prefer using match:
>
>   (match (team-scope team)
>     (() "")
>     (scope (format #f "scope: ~{~s ~}~%" scope)
>
> * With Liliana=E2=80=99s added support for regexes, the previous patch to=
 record
>   scopes for the installer etc should be adjusted.

Fixed!

Thanks,

Mathieu




Information forwarded to guix-patches@HIDDEN:
bug#57646; Package guix-patches. Full text available.

Message received at 57646 <at> debbugs.gnu.org:


Received: (at 57646) by debbugs.gnu.org; 12 Sep 2022 10:36:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 12 06:36:57 2022
Received: from localhost ([127.0.0.1]:44216 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oXgoD-0007pi-96
	for submit <at> debbugs.gnu.org; Mon, 12 Sep 2022 06:36:57 -0400
Received: from sender4-of-o50.zoho.com ([136.143.188.50]:21031)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rekado@HIDDEN>) id 1oXgoB-0007pY-I9
 for 57646 <at> debbugs.gnu.org; Mon, 12 Sep 2022 06:36:56 -0400
ARC-Seal: i=1; a=rsa-sha256; t=1662979008; cv=none; 
 d=zohomail.com; s=zohoarc; 
 b=VOoMl8h3QSwwOJhcnSeMaCFAR5j/JwnwoRfCspY3a7Qx6bKnm53ptCxL+u1YA5Z6p78imgVBzPsiW46n633mspBna7of9MimjNcC5mvM/NE7C0KFEoTQDWg+KiuTcChIfTW6t5bZtDGbV4DHtf/MlniPDCI3xJoGOWK3iWzxrJw=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
 s=zohoarc; t=1662979008;
 h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To;
 bh=3SYDGKUKIzA6AWbuWdnUsHSYD3Tp3G+q6yQ1shuIpaU=; 
 b=Pkwze6RKhKchvWlF8mNj3sdGYENuxiQOvglsjMzFw+uy9OPUXPK0Dqfg1MOX3jn407Js+1StWP6MZ9a1SfZTdDQQzdrsedGKA74wUOktzC6xJ9vQdYGK4fOYBe7R7YSkaT1tPnZYIJecW/UbhADdpGEZ2+6QA4/k3xHIfK8SnuU=
ARC-Authentication-Results: i=1; mx.zohomail.com;
 dkim=pass  header.i=elephly.net;
 spf=pass  smtp.mailfrom=rekado@HIDDEN;
 dmarc=pass header.from=<rekado@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1662979008; 
 s=zoho; d=elephly.net; i=rekado@HIDDEN;
 h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;
 bh=3SYDGKUKIzA6AWbuWdnUsHSYD3Tp3G+q6yQ1shuIpaU=;
 b=jKRMfNaQLfbuui6g+Oy4sid5eT1bBdoYMHx8fptE0TKFLPDafFdIIKYAUaTETwge
 o87xvyzoFdNb3Lntz8wPID79r+4IPEQfnGXGMwNYWLvAOWXeYiWIWI9vlF7L1l+CkIB
 oGXcSfR9pc3xcF1XUsBEZwXdbnrVq+TMf97EEIhg=
Received: from localhost (253-111-142-46.pool.kielnet.net [46.142.111.253]) by
 mx.zohomail.com with SMTPS id 166297900703548.52216052085839;
 Mon, 12 Sep 2022 03:36:47 -0700 (PDT)
References: <34c99df65a63bafd7868ad025a85ebb3a4457ac2.camel@HIDDEN>
 <87leqpsw9q.fsf@HIDDEN>
User-agent: mu4e 1.8.7; emacs 28.1
From: Ricardo Wurmus <rekado@HIDDEN>
To: Mathieu Othacehe <othacehe@HIDDEN>
Subject: Re: [PATCH] etc: teams: Add regular expression support to scopes.
Date: Mon, 12 Sep 2022 12:30:35 +0200
In-reply-to: <87leqpsw9q.fsf@HIDDEN>
X-URL: https://elephly.net
X-PGP-Key: https://elephly.net/rekado.pubkey
X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
Message-ID: <87a674nakk.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-ZohoMailClient: External
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 57646
Cc: 57646 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


Hi Mathieu,

> Thanks for the improvement :) Ricardo, any thoughts on this series?

This looks like a good idea to me, thanks!

Just three comments:

* the dependency on Guile-Git means that the script must be run inside a
  suitable environment now, whereas previously it had no dependencies
  other than Guile.  If we can assume that people use Guix perhaps we
  should do what doc/build.scm does and use Guix to arrange for
  dependencies to be available.

* I don=E2=80=99t like the =E2=80=9Cif=E2=80=9D + =E2=80=9Cnull?=E2=80=9D p=
attern:

+             (if (not (null? (team-scope team)))
+                 (format #f "scope: ~{~s ~}~%" (team-scope team))
+                 ""))

  I=E2=80=99d prefer using match:

  (match (team-scope team)
    (() "")
    (scope (format #f "scope: ~{~s ~}~%" scope)

* With Liliana=E2=80=99s added support for regexes, the previous patch to r=
ecord
  scopes for the installer etc should be adjusted.


--=20
Ricardo




Information forwarded to guix-patches@HIDDEN:
bug#57646; Package guix-patches. Full text available.

Message received at 57646 <at> debbugs.gnu.org:


Received: (at 57646) by debbugs.gnu.org; 11 Sep 2022 16:37:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Sep 11 12:37:00 2022
Received: from localhost ([127.0.0.1]:43284 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oXPx6-00055N-Im
	for submit <at> debbugs.gnu.org; Sun, 11 Sep 2022 12:37:00 -0400
Received: from eggs.gnu.org ([209.51.188.92]:39064)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1oXPx3-000559-NA
 for 57646 <at> debbugs.gnu.org; Sun, 11 Sep 2022 12:36:59 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:58034)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1oXPwy-0005QR-9s; Sun, 11 Sep 2022 12:36:52 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=Mp1/2U3AnUHDsG/2WZqd1SFjIOqXvebDl53tpx+XC/g=; b=H0Xf1FoXxX45KV+HvgwQ
 eH5EXNUAykcEwhCvPFJTCKF87ka2d7H6ZNs8XCJBg84gUgXu08IcsI9GTLaDXOettOh+xmJY6Ay8r
 G9Qr5sI41TrMB47b1/B3jTN30iQ3MSyNK1H5YlXDQ9xJ4RIO3iVFwzpbAFAl/GdcaGWgK6uKJkMhV
 Yuz7GPlbesMOkCTTWllAP0Vf++7R1/CmLyyZhZEgi+m4UUbb4kVtA7uKm2BKjIJsRBA9N8P3faEO5
 tXAa6Tut+nlkv5m2FQ++dU0v3ZQuLK/n4rgW9U56AoV7hQ7k82iHNZbh+4kMGjwAhs5hihdhzMhBV
 Ja4Ra119gOTMSg==;
Received: from [2a02:587:1d33:7300:4fa4:945e:237e:7b1f] (port=39372 helo=meije)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1oXPwx-00029L-Pf; Sun, 11 Sep 2022 12:36:52 -0400
From: Mathieu Othacehe <othacehe@HIDDEN>
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Subject: Re: [PATCH] etc: teams: Add regular expression support to scopes.
References: <34c99df65a63bafd7868ad025a85ebb3a4457ac2.camel@HIDDEN>
Date: Sun, 11 Sep 2022 18:36:49 +0200
In-Reply-To: <34c99df65a63bafd7868ad025a85ebb3a4457ac2.camel@HIDDEN>
 (Liliana Marie Prikler's message of "Fri, 9 Sep 2022 17:27:23 +0200")
Message-ID: <87leqpsw9q.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57646
Cc: Ricardo Wurmus <rekado@HIDDEN>, 57646 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


Hey Liliana,

> this is a fixup to your 1/3 patch, making it so that regexps are supported.
> Note, that for the installer team you should now define the scope as
> (list "gnu/installer.scm" (make-regexp "^guix/installer/")) or simply
> (list (make-regexp "^guix/installer(\\.scm$|/)")).

Thanks for the improvement :) Ricardo, any thoughts on this series?

Mathieu




Information forwarded to guix-patches@HIDDEN:
bug#57646; Package guix-patches. Full text available.

Message received at 57646 <at> debbugs.gnu.org:


Received: (at 57646) by debbugs.gnu.org; 9 Sep 2022 15:40:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 09 11:40:48 2022
Received: from localhost ([127.0.0.1]:35063 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oWg7b-0003zM-5Q
	for submit <at> debbugs.gnu.org; Fri, 09 Sep 2022 11:40:47 -0400
Received: from mail-ej1-f66.google.com ([209.85.218.66]:41908)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>) id 1oWg7V-0003z5-2q
 for 57646 <at> debbugs.gnu.org; Fri, 09 Sep 2022 11:40:45 -0400
Received: by mail-ej1-f66.google.com with SMTP id gh9so4883630ejc.8
 for <57646 <at> debbugs.gnu.org>; Fri, 09 Sep 2022 08:40:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=mime-version:message-id:content-transfer-encoding:cc:to:subject
 :date:from:from:to:cc:subject:date;
 bh=Xsno39Pdjndm+/0eWUPTIA8O9CiIzGo3ZVbrpxLrpZA=;
 b=hJcclgtNGYpGJLEIWRXD1hip3+p3LpMR4oH04dzMgYft9pF4Kzg/88WQwB/2EdmIPc
 agd5DpurEJXLt2nxxATjZAqcupQiqBnt8LIvwlJNyV+i8HdI9hwb9xlDPlQ+RRLK5hGM
 cC9+tD8h7eVcwJQXbzDAhW1+uzmkKDKghf3LR9YQqLN8sk3csicnahHRbM9O2lIH1TXm
 Lle3/enx1tyfIOK4box804meuhdMKxzlAT3Ym7SBtcWAAd88wRb3+En+s8DATDS//zcz
 CgsSuufN/AslAWPPUY+qtN5lhplSKgMqO3dHoyiAKukmwPW5X8ueSMadCrlAVL6a/UMQ
 Zr8w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=mime-version:message-id:content-transfer-encoding:cc:to:subject
 :date:from:x-gm-message-state:from:to:cc:subject:date;
 bh=Xsno39Pdjndm+/0eWUPTIA8O9CiIzGo3ZVbrpxLrpZA=;
 b=Ip/YphxyP08/ymbIJAbVyDzrsK78vFCEt5lPpX4EzpgWbGJPXlpqoG17yrqJ2+jVPB
 wW4ZKmBcZA9VRQzcUVl2ZjW+qozpdBwpMqT9D+cafFodDVsU/yZM4CDyf0Y13pmZSA75
 seMZ+GY+f0aKnkpnMMB08gbMsBfBfroSMrAjfCZ2hM/ita+bDIoJypOlpFtsmTX5TUP+
 AYQXa4AxEkmBJR3OiuNqhiUjWs3TiekEf1hM+ffsHPG+Jjeo0DSETx9ECNP9lN7NAvm7
 mQV7mzvMfElhCubrbTyFWqxD4W4BPwm7NXPf7TWMGH5WU5Z18p/TZHywQFwGrNK+vG3f
 hfcw==
X-Gm-Message-State: ACgBeo3ob+Qiut2VhFisx0vbtSIY6UCuxIER4DgpjSwrg3Hr8ZxH0NzL
 7+jN5ZI/RD0wyBC1l1mkKFU=
X-Google-Smtp-Source: AA6agR7tx/B/XRltZlP7dJFGqhTq6kIMBhmcCPVpGJKTSQ2a28Wsm/vEh/UTDC3upOtidMU9hvtlLQ==
X-Received: by 2002:a17:907:3f88:b0:73e:484d:9d6c with SMTP id
 hr8-20020a1709073f8800b0073e484d9d6cmr10668076ejc.283.1662738034935; 
 Fri, 09 Sep 2022 08:40:34 -0700 (PDT)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93]) by smtp.gmail.com with ESMTPSA id
 w20-20020a170906185400b007713951ca7asm397344eje.165.2022.09.09.08.40.34
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 09 Sep 2022 08:40:34 -0700 (PDT)
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Fri, 9 Sep 2022 17:27:23 +0200
Subject: [PATCH] etc: teams: Add regular expression support to scopes.
to: Mathieu Othacehe <othacehe@HIDDEN>
Content-Transfer-Encoding: 7bit
Message-ID: <34c99df65a63bafd7868ad025a85ebb3a4457ac2.camel@HIDDEN>
MIME-Version: 1.0
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 57646
Cc: 57646 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* etc/teams.scm (find-teams-by-scope): Differentiate between raw strings
and regexps.  Make raw string matches strict.
---
Hi Mathieu,

this is a fixup to your 1/3 patch, making it so that regexps are supported.
Note, that for the installer team you should now define the scope as
(list "gnu/installer.scm" (make-regexp "^guix/installer/")) or simply
(list (make-regexp "^guix/installer(\\.scm$|/)")).

Cheers

 etc/teams.scm.in | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/etc/teams.scm.in b/etc/teams.scm.in
index 37937a02ff..24664e9c0e 100644
--- a/etc/teams.scm.in
+++ b/etc/teams.scm.in
@@ -32,6 +32,7 @@
              (srfi srfi-9)
              (srfi srfi-26)
              (ice-9 format)
+             (ice-9 regex)
              (ice-9 match)
              (guix ui)
              (git))
@@ -281,9 +282,11 @@ (define (find-team-by-scope files)
   (hash-fold
    (lambda (key team acc)
      (if (any (lambda (file)
-                (any (lambda (scope)
-                       ;; XXX: Add regex support?
-                       (string-prefix? scope file))
+                (any (match-lambda
+                       ((? string? scope)
+                        (string=? scope file))
+                       ((? regexp? scope)
+                        (regexp-exec scope file)))
                      (team-scope team)))
               files)
          (cons team acc)
-- 
2.37.2





Information forwarded to guix-patches@HIDDEN:
bug#57646; Package guix-patches. Full text available.

Message received at 57646 <at> debbugs.gnu.org:


Received: (at 57646) by debbugs.gnu.org; 7 Sep 2022 15:24:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 07 11:24:45 2022
Received: from localhost ([127.0.0.1]:55846 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oVwuy-0002wh-Qz
	for submit <at> debbugs.gnu.org; Wed, 07 Sep 2022 11:24:45 -0400
Received: from eggs.gnu.org ([209.51.188.92]:33858)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1oVwuv-0002w6-Dp
 for 57646 <at> debbugs.gnu.org; Wed, 07 Sep 2022 11:24:41 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:42182)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>) id 1oVwuq-0007l4-8C
 for 57646 <at> debbugs.gnu.org; Wed, 07 Sep 2022 11:24:36 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To:
 From; bh=fan3xoBoDmbbbBt3RF7xi7m6sf7sZu3upbO3Cnf2eno=; b=CoXDY9jaC1Alx47u7Vqs
 Pre6hlDubPBFqtojE1+0Euhq7iSPlIWoRXLGHe+hGjqwjDNr7y21fYCY9WzbqxKPa31WwA8NHnSbS
 kmJST4izth+QTDoxTsyYUaLAXfPp2e8Y8j7qQL5F7gBCkpBkHcA7VJX0Mmeq9u7djw95V81KpE8bR
 TiQEhn4BYteZa3J8QDc/1UPBEW8o0ONeLJJfnC1lFBpatvjo3UaVbFIoiIljJkjajFZEafvr5q/yu
 NnBs7EEP+39k/YA+y+Bwt2xMDDJ2FhsSTVdKH5ByEIgXs/qo36OR5+OS6SsD3AHWv1NUXMO9cy3z4
 tinf4idSG9op+g==;
Received: from ppp079167215024.access.hol.gr ([79.167.215.24]:59606
 helo=localhost.localdomain)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1oVwup-0005B6-Nz; Wed, 07 Sep 2022 11:24:36 -0400
From: Mathieu Othacehe <othacehe@HIDDEN>
To: 57646 <at> debbugs.gnu.org
Subject: [PATCH 3/3] etc: installer: Define installer team scope.
Date: Wed,  7 Sep 2022 17:21:50 +0200
Message-Id: <20220907152150.5687-3-othacehe@HIDDEN>
X-Mailer: git-send-email 2.37.2
In-Reply-To: <20220907152150.5687-1-othacehe@HIDDEN>
References: <20220907152150.5687-1-othacehe@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57646
Cc: Mathieu Othacehe <othacehe@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

* etc/teams.scm.in (installer): Define it.
---
 etc/teams.scm.in | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/etc/teams.scm.in b/etc/teams.scm.in
index 0979e5cade..42da1ab1fc 100644
--- a/etc/teams.scm.in
+++ b/etc/teams.scm.in
@@ -255,7 +255,10 @@ (define-team translations
 
 (define-team installer
   (team 'installer
-        #:name "Installer script and system installer"))
+        #:name "Installer script and system installer"
+        #:scope
+        '("gnu/installer.scm"
+          "gnu/installer/")))
 
 (define-team home
   (team 'home
-- 
2.37.2





Information forwarded to guix-patches@HIDDEN:
bug#57646; Package guix-patches. Full text available.

Message received at 57646 <at> debbugs.gnu.org:


Received: (at 57646) by debbugs.gnu.org; 7 Sep 2022 15:24:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 07 11:24:42 2022
Received: from localhost ([127.0.0.1]:55844 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oVwuw-0002wT-E2
	for submit <at> debbugs.gnu.org; Wed, 07 Sep 2022 11:24:42 -0400
Received: from eggs.gnu.org ([209.51.188.92]:33856)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1oVwuu-0002w5-Oi
 for 57646 <at> debbugs.gnu.org; Wed, 07 Sep 2022 11:24:41 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:42180)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>) id 1oVwup-0007kv-Ij
 for 57646 <at> debbugs.gnu.org; Wed, 07 Sep 2022 11:24:35 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To:
 From; bh=q53gHzZ7yMkeORuVRmgNoCo/M3PkeQaFmZevinMdd5g=; b=SOmC0QeuCBhrquWh9nif
 tUxwkMe3P0Wt4SjCn0YmV9807KuoqtG1dGnHXZ2GnSlTodHWo46E8vquAwoIWTxD66cGqDok4/GUm
 r5pIx3m+G5LfID4MoUtUxovsvlnFatf8VRtoMN1OhjQ5Hbxj0QjU+6a5hf5HVYmNzOXZ6B5pl1Nm0
 ZWkvEwYuFlHmBjv9+Qsx7DPI3KzTVacvPcEKoCzePw4gSl46PdFe6+QSutFglAR/UP+ymVqpOBWLA
 V70CR9QS4V9soWCJsR/fz+2lYb0EKsgXhu9snFVh+hh9dw1/+BatvRDiK+9MZ/6VVwdFuJrZKrvzF
 2hPGUIb/bKoVHg==;
Received: from ppp079167215024.access.hol.gr ([79.167.215.24]:59606
 helo=localhost.localdomain)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1oVwuo-0005B6-ST; Wed, 07 Sep 2022 11:24:35 -0400
From: Mathieu Othacehe <othacehe@HIDDEN>
To: 57646 <at> debbugs.gnu.org
Subject: [PATCH 2/3] etc: teams: Define core team scope.
Date: Wed,  7 Sep 2022 17:21:49 +0200
Message-Id: <20220907152150.5687-2-othacehe@HIDDEN>
X-Mailer: git-send-email 2.37.2
In-Reply-To: <20220907152150.5687-1-othacehe@HIDDEN>
References: <20220907152150.5687-1-othacehe@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57646
Cc: Mathieu Othacehe <othacehe@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

* etc/teams.scm.in (core): Define it.
---
 etc/teams.scm.in | 84 +++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 83 insertions(+), 1 deletion(-)

diff --git a/etc/teams.scm.in b/etc/teams.scm.in
index 37937a02ff..0979e5cade 100644
--- a/etc/teams.scm.in
+++ b/etc/teams.scm.in
@@ -161,7 +161,89 @@ (define-team kernel
 
 (define-team core
   (team 'core
-        #:name "Core / Tools / Internals"))
+        #:name "Core / Tools / Internals"
+        #:scope
+        '("guix/avahi.scm"
+          "guix/base16.scm"
+          "guix/base32.scm"
+          "guix/base64.scm"
+          "guix/bzr-download.scm"
+          "guix/cache.scm"
+          "guix/channels.scm"
+          "guix/ci.scm"
+          "guix/colors.scm"
+          "guix/combinators.scm"
+          "guix/config.scm"
+          "guix/cpio.scm"
+          "guix/cpu.scm"
+          "guix/cve.scm"
+          "guix/cvs-download.scm"
+          "guix/deprecation.scm"
+          "guix/derivations.scm"
+          "guix/describe.scm"
+          "guix/diagnostics.scm"
+          "guix/discovery.scm"
+          "guix/docker.scm"
+          "guix/download.scm"
+          "guix/elf.scm"
+          "guix/ftp-client.scm"
+          "guix/gexp.scm"
+          "guix/git-authenticate.scm"
+          "guix/git-download.scm"
+          "guix/git.scm"
+          "guix/glob.scm"
+          "guix/gnu-maintenance.scm"
+          "guix/gnupg.scm"
+          "guix/grafts.scm"
+          "guix/graph.scm"
+          "guix/hash.scm"
+          "guix/hg-download.scm"
+          "guix/http-client.scm"
+          "guix/i18n.scm"
+          "guix/inferior.scm"
+          "guix/ipfs.scm"
+          "guix/least-authority.scm"
+          "guix/licenses.scm"
+          "guix/lint.scm"
+          "guix/man-db.scm"
+          "guix/memoization.scm"
+          "guix/modules.scm"
+          "guix/monad-repl.scm"
+          "guix/monads.scm"
+          "guix/narinfo.scm"
+          "guix/nar.scm"
+          "guix/openpgp.scm"
+          "guix/packages.scm"
+          "guix/pki.scm"
+          "guix/platform.scm"
+          "guix/platforms/"
+          "guix/profiles.scm"
+          "guix/profiling.scm"
+          "guix/progress.scm"
+          "guix/quirks.scm"
+          "guix/read-print.scm"
+          "guix/records.scm"
+          "guix/remote.scm"
+          "guix/repl.scm"
+          "guix/scripts/"
+          "guix/search-paths.scm"
+          "guix/self.scm"
+          "guix/serialization.scm"
+          "guix/sets.scm"
+          "guix/ssh.scm"
+          "guix/status.scm"
+          "guix/store.scm"
+          "guix/store/"
+          "guix/substitutes.scm"
+          "guix/svn-download.scm"
+          "guix/swh.scm"
+          "guix/tests.scm"
+          "guix/tests/"
+          "guix/transformations.scm"
+          "guix/ui.scm"
+          "guix/upstream.scm"
+          "guix/utils.scm"
+          "guix/workers.scm")))
 
 (define-team games
   (team 'games
-- 
2.37.2





Information forwarded to guix-patches@HIDDEN:
bug#57646; Package guix-patches. Full text available.

Message received at 57646 <at> debbugs.gnu.org:


Received: (at 57646) by debbugs.gnu.org; 7 Sep 2022 15:24:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 07 11:24:42 2022
Received: from localhost ([127.0.0.1]:55842 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oVwuv-0002wR-UD
	for submit <at> debbugs.gnu.org; Wed, 07 Sep 2022 11:24:42 -0400
Received: from eggs.gnu.org ([209.51.188.92]:50544)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1oVwut-0002w2-Nb
 for 57646 <at> debbugs.gnu.org; Wed, 07 Sep 2022 11:24:40 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:42178)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>) id 1oVwuo-0007kg-HJ
 for 57646 <at> debbugs.gnu.org; Wed, 07 Sep 2022 11:24:34 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to:
 references; bh=Cy3EiO4dOhd9wlG/Z9o68dWi6QXN+WgS534gKCh91/I=; b=aAN+triOtRSKrK
 9MwnSlSifvW42avLc0hZUVPX/riqqEFweJZzkjSv859FCN2zxCViVeqjytU2gccJ8UyY18lhi03UZ
 XRFvy7zU5sBJ8WR5OpzmnspN7s61uTRMj5mq/ag1KrJfNKw6la9JbFdY8eXEGRLEOErN8WY7NCt42
 tkWuq+rbpp9D14Q3uO+vapgvcC4SE9GJe1NuzR+kMjwvnJNjWaA+q2fxNrKVzN84QJ3sAbb243pi+
 NzmbI66hcuRtpRkIXPL4NmaxIPWebSk93d2lkE3DRWshNmzZozOpItcSyK5kg/Two5RPeFR/kh4gt
 oKGk9wHH2cfrwftFb+Gg==;
Received: from ppp079167215024.access.hol.gr ([79.167.215.24]:59606
 helo=localhost.localdomain)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1oVwuo-0005B6-0b; Wed, 07 Sep 2022 11:24:34 -0400
From: Mathieu Othacehe <othacehe@HIDDEN>
To: 57646 <at> debbugs.gnu.org
Subject: [PATCH 1/3] etc: teams: Add scope support.
Date: Wed,  7 Sep 2022 17:21:48 +0200
Message-Id: <20220907152150.5687-1-othacehe@HIDDEN>
X-Mailer: git-send-email 2.37.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 57646
Cc: Mathieu Othacehe <othacehe@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Add a scope list to each team.  This list defines all the files and
directories that are mentored by the team.

Also add a cc-members command that takes two Git revision strings as input,
add returns the members that should be CC'ed given the files impacted between
the two revisions.

* etc/teams.scm.in (<team>)[scope]: New field.
(team, list-teams): Adapt those procedures.
(find-team-by-scope, diff-revisions): New procedures.
(main): Add a "cc-members" command.
---
 etc/teams.scm.in | 74 ++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 65 insertions(+), 9 deletions(-)

diff --git a/etc/teams.scm.in b/etc/teams.scm.in
index 38b7ab8e1d..37937a02ff 100644
--- a/etc/teams.scm.in
+++ b/etc/teams.scm.in
@@ -4,6 +4,7 @@
 
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2022 Ricardo Wurmus <rekado@HIDDEN>
+;;; Copyright © 2022 Mathieu Othacehe <othacehe@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -22,23 +23,27 @@
 
 ;;; Commentary:
 
-;; This code defines development teams and team members.
+;; This code defines development teams and team members, as well as their
+;; scope.
 
 ;;; Code:
 
 (use-modules (srfi srfi-1)
              (srfi srfi-9)
+             (srfi srfi-26)
              (ice-9 format)
              (ice-9 match)
-             (guix ui))
+             (guix ui)
+             (git))
 
 (define-record-type <team>
-  (make-team id name description members)
+  (make-team id name description members scope)
   team?
   (id          team-id)
   (name        team-name)
   (description team-description)
-  (members     team-members set-team-members!))
+  (members     team-members set-team-members!)
+  (scope       team-scope))
 
 (define-record-type <person>
   (make-person name email)
@@ -49,11 +54,13 @@ (define-record-type <person>
 (define* (person name #:optional email)
   (make-person name email))
 
-(define* (team id #:key name description (members '()))
+(define* (team id #:key name description (members '())
+               (scope '()))
   (make-team id
              (or name (symbol->string id))
              description
-             members))
+             members
+             scope))
 
 (define %teams
   (make-hash-table))
@@ -268,6 +275,22 @@ (define (find-team name)
       (error (format #false
                            "no such team: ~a~%" name))))
 
+(define (find-team-by-scope files)
+  "Return the team(s) which scope matches at least one of the FILES, as list
+of file names as string."
+  (hash-fold
+   (lambda (key team acc)
+     (if (any (lambda (file)
+                (any (lambda (scope)
+                       ;; XXX: Add regex support?
+                       (string-prefix? scope file))
+                     (team-scope team)))
+              files)
+         (cons team acc)
+         acc))
+   '()
+   %teams))
+
 (define (cc . teams)
   "Return arguments for `git send-email' to notify the members of the given
 TEAMS when a patch is received by Debbugs."
@@ -289,7 +312,7 @@ (define port* (or port (current-output-port)))
    (team-members team)))
 
 (define (list-teams)
-  "Print all teams and their members."
+  "Print all teams, their scope and their members."
   (define port* (current-output-port))
   (define width* (%text-width))
   (hash-for-each
@@ -299,7 +322,7 @@ (define width* (%text-width))
 id: ~a
 name: ~a
 description: ~a
-members:
+~amembers:
 "
              (team-id team)
              (team-name team)
@@ -308,15 +331,48 @@ (define width* (%text-width))
                           (string->recutils
                            (fill-paragraph text width*
                                            (string-length "description: ")))))
-                 "<none>"))
+                 "<none>")
+             (if (not (null? (team-scope team)))
+                 (format #f "scope: ~{~s ~}~%" (team-scope team))
+                 ""))
      (list-members team port* "+ ")
      (newline))
    %teams))
 
+
+(define (diff-revisions rev-start rev-end)
+  "Return the list of added, modified or removed files between REV-START
+and REV-END, two git revision strings."
+  (let* ((repository (repository-open (getcwd)))
+         (commit1 (commit-lookup repository
+                                 (object-id
+                                  (revparse-single repository rev-start))))
+         (commit2 (commit-lookup repository
+                                 (object-id
+                                  (revparse-single repository rev-end))))
+         (diff (diff-tree-to-tree repository
+                                  (commit-tree commit1)
+                                  (commit-tree commit2)))
+         (files '()))
+    (diff-foreach
+     diff
+     (lambda (delta progress)
+       (set! files
+             (cons (diff-file-path (diff-delta-old-file delta)) files))
+       0)
+     (const 0)
+     (const 0)
+     (const 0))
+    files))
+
+
 (define (main . args)
   (match args
     (("cc" . team-names)
      (apply cc (map find-team team-names)))
+    (("cc-members" rev-start rev-end)
+     (apply cc (find-team-by-scope
+                (diff-revisions rev-start rev-end))))
     (("list-teams" . args)
      (list-teams))
     (("list-members" . team-names)
-- 
2.37.2





Information forwarded to guix-patches@HIDDEN:
bug#57646; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 7 Sep 2022 15:20:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 07 11:20:32 2022
Received: from localhost ([127.0.0.1]:55832 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oVwqu-0002pL-8L
	for submit <at> debbugs.gnu.org; Wed, 07 Sep 2022 11:20:32 -0400
Received: from lists.gnu.org ([209.51.188.17]:34758)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1oVwqt-0002pF-DR
 for submit <at> debbugs.gnu.org; Wed, 07 Sep 2022 11:20:31 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:38844)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>) id 1oVwqs-0001M4-Ij
 for guix-patches@HIDDEN; Wed, 07 Sep 2022 11:20:31 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:44870)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>) id 1oVwqs-0007Id-AM
 for guix-patches@HIDDEN; Wed, 07 Sep 2022 11:20:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to:
 references; bh=1LndROhViFJMoWc/GG+ApeehL/9xfsTWUlE9IOALHL4=; b=GkueX/InS0lAmO
 Pz5XIaOyTxksopWw8/d9CsWuikknqAG8YQXtbmTCCW9fLXUg90Mz0VvR4g6zJpnASKyXH93OBA19t
 omQvB6ln5JgdSawqvWasfnV+BktxKNgkDUIpqqZJRlD/FPj+ryttB5QWsxhTX3LSs6P0I6bZC4YQK
 lOQiGKS85M7XTdVgGkhl93xLDLlYr6zCgbw9Ugct8ESO1G8Az6O9eRB5KqCVokCA7SigKu4HFMity
 bQFinjlkRqEq8t4Gg04rbYCLllYLPsIr1gU87guKytZQsrQBpGqpJgdBFIBPZ/DC6d0XZa0xvHB9W
 HZ5hIhjZ8YnKYmqI3upg==;
Received: from ppp079167215024.access.hol.gr ([79.167.215.24]:39576
 helo=localhost.localdomain)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1oVwqX-0004fK-FY; Wed, 07 Sep 2022 11:20:25 -0400
From: Mathieu Othacehe <othacehe@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH 0/3] teams: Add scope support.
Date: Wed,  7 Sep 2022 17:16:22 +0200
Message-Id: <20220907151622.4912-1-othacehe@HIDDEN>
X-Mailer: git-send-email 2.37.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
Cc: Mathieu Othacehe <othacehe@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hello,

This adds scope support to the teams script. Each team can define the set of
files and directories that it mentors.

The user can then run:

git send-email $(./etc/teams cc-members HEAD^^ HEAD) *.patch

to automatically CC the members that mentoring the impacted files.

This series also proposes a scope for the core and installer teams.

To go further each team could define its own scope and we could
add the above command to the documentation to maximize the
chances that the right members are CC'ed for each new patch.

Thanks,

Mathieu

Mathieu Othacehe (3):
  etc: teams: Add scope support.
  etc: teams: Define core team scope.
  etc: installer: Define installer team scope.

 etc/teams.scm.in | 163 +++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 152 insertions(+), 11 deletions(-)

-- 
2.37.2





Acknowledgement sent to Mathieu Othacehe <othacehe@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#57646; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 25 Sep 2022 12:00:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.