Received: (at 57652) by debbugs.gnu.org; 8 Sep 2022 12:34:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 08 08:34:25 2022
Received: from localhost ([127.0.0.1]:57485 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oWGjh-0006hg-2j
for submit <at> debbugs.gnu.org; Thu, 08 Sep 2022 08:34:25 -0400
Received: from smtp02.smtpout.orange.fr ([80.12.242.124]:61537
helo=smtp.smtpout.orange.fr)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <da_vid@HIDDEN>) id 1oWGjZ-0006hQ-Gg
for 57652 <at> debbugs.gnu.org; Thu, 08 Sep 2022 08:34:23 -0400
Received: from [192.168.1.53] ([84.99.156.79]) by smtp.orange.fr with ESMTPA
id WGjWoM0OV9qatWGjWoU7Xe; Thu, 08 Sep 2022 14:34:16 +0200
X-ME-Helo: [192.168.1.53]
X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI=
X-ME-Date: Thu, 08 Sep 2022 14:34:16 +0200
X-ME-IP: 84.99.156.79
Message-ID: <7b0977cd-a236-c9ad-887a-f23c98ed4a6e@HIDDEN>
Date: Thu, 8 Sep 2022 14:34:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
Thunderbird/102.2.1
Subject: =?UTF-8?Q?Re=3a_bug=2357652=3a_29=2e0=2e50=3b_Warning_setting_attri?=
=?UTF-8?B?YnV0ZSBvZiBmYWNlIOKAmHRlcm3igJk=?=
To: Eli Zaretskii <eliz@HIDDEN>
References: <5f92d116-3cfd-e4b4-0caf-b2337fa1bd7f@HIDDEN>
<878rmua277.fsf@HIDDEN> <319e3926-7c22-cabd-43dd-a02f3a01c734@HIDDEN>
<83czc6fe9t.fsf@HIDDEN>
Content-Language: fr, en-US
From: David Ponce <da_vid@HIDDEN>
In-Reply-To: <83czc6fe9t.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 57652
Cc: luangruo@HIDDEN, 57652 <at> debbugs.gnu.org, gregory@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On 08/09/2022 10:42, Eli Zaretskii wrote:
>> Cc: 57652 <at> debbugs.gnu.org, gregory@HIDDEN
>> Date: Thu, 8 Sep 2022 10:22:31 +0200
>> From: David Ponce <da_vid@HIDDEN>
>>
>> "Apart from the values given below, each face attribute can have the
>> value ‘unspecified’. This special value means that the face doesn’t
>> specify that attribute directly. An ‘unspecified’ attribute tells Emacs
>> to refer instead to a parent face (see the description ‘:inherit’
>> attribute below); or, failing that, to an underlying face (*note
>> Displaying Faces::). (However, ‘unspecified’ is not a valid value in
>> ‘defface’.)"
>>
>> So it seems that unspecified is not allowed in defface.
>
> Where does it say that unspecified is not allowed? (And this doc
> string is from set-face-attribute, not from defface.)
I mentioned what is currently in the Emacs Lisp reference manual
(lisp.info): (elisp)Top > Display > Faces > Face Attributes
>> So, how to specify a missing attribute excepted by using nil in the
>> defface used in term.el?
>
> If you don't have anything to say about an attribute, just don't
> mention it in defface. That's what unspecified means, as the doc
> string says. So I'm unsure why you would need "to specify a missing
> attribute".
It is not me, it is how it is currently implemented in term.el:
(defcustom term-default-fg-color nil
"If non-nil, default color for foreground in Term mode."
:group 'term
:type '(choice (const nil) (string :tag "color")))
(make-obsolete-variable 'term-default-fg-color "use the face `term'
instead."
"24.3")
(defcustom term-default-bg-color nil
"If non-nil, default color for foreground in Term mode."
:group 'term
:type '(choice (const nil) (string :tag "color")))
(make-obsolete-variable 'term-default-bg-color "use the face `term'
instead."
"24.3")
(defface term
`((t
:foreground ,term-default-fg-color
:background ,term-default-bg-color
:inherit default))
"Default face to use in Term mode."
:group 'term)
bug-gnu-emacs@HIDDEN:bug#57652; Package emacs.
Full text available.
Received: (at 57652) by debbugs.gnu.org; 8 Sep 2022 12:11:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 08 08:11:10 2022
Received: from localhost ([127.0.0.1]:57433 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oWGNB-000634-Ra
for submit <at> debbugs.gnu.org; Thu, 08 Sep 2022 08:11:10 -0400
Received: from knopi.disroot.org ([178.21.23.139]:42034)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <akib@HIDDEN>) id 1oWGN6-00062t-Cg
for 57652 <at> debbugs.gnu.org; Thu, 08 Sep 2022 08:11:09 -0400
Received: from localhost (localhost [127.0.0.1])
by disroot.org (Postfix) with ESMTP id BBA4D49FEC;
Thu, 8 Sep 2022 14:11:03 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
with UTF8SMTP id Bd0lIUxhz8iQ; Thu, 8 Sep 2022 14:11:02 +0200 (CEST)
From: Akib Azmain Turja <akib@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
t=1662638960; bh=FisYz0kzFFg55asvoUbvhKScAxT7hE4you1TaFbyFfs=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=Y5mA2iwzvrn9yTwcB7iMIAx1rHPb0lAFnFWYY9Z8Icv3kYAkIXtnkh1Rc1GFjb4lV
yYbMGbPc2e548gnpLCjdxEIhoAGkhFr8NJTLy1zXMRfuB2+bcK+y/ui74dhK8Jyl3u
S+CI3wxAEfrqrUeBrUSS1YgOoffVKrgEaB7dWAvqN8k0R4mXb8VMxngFUZjtueiRhn
9zLITdwtlZf6+qhK9UTsEDq2h5Q0PLcG9siTE7SeJCa9jRAtpX5LHkTTf0QEcTDP1U
3BA6UBO4LtCti3Pkb8S/ol1hiNE5Lqe6ozoe+9sjmHTo6u+Jpm9Eme2fKsLYaR4KC4
5LfRuT7MwnXIg==
To: David Ponce <da_vid@HIDDEN>
Subject: Re: bug#57652: 29.0.50; Warning setting attribute of face
=?utf-8?B?4oCYdGVybeKAmQ==?=
In-Reply-To: <319e3926-7c22-cabd-43dd-a02f3a01c734@HIDDEN> (David Ponce's
message of "Thu, 8 Sep 2022 10:22:31 +0200")
References: <5f92d116-3cfd-e4b4-0caf-b2337fa1bd7f@HIDDEN>
<878rmua277.fsf@HIDDEN>
<319e3926-7c22-cabd-43dd-a02f3a01c734@HIDDEN>
Date: Thu, 08 Sep 2022 17:44:28 +0600
Message-ID: <87czc69jkz.fsf@HIDDEN>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
micalg=pgp-sha256; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 57652
Cc: Po Lu <luangruo@HIDDEN>, 57652 <at> debbugs.gnu.org, gregory@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
David Ponce <da_vid@HIDDEN> writes:
> On 08/09/2022 07:02, Po Lu wrote:
>> David Ponce <da_vid@HIDDEN> writes:
>>=20
>>> diff --git a/term.el b/term.el
>>> index 797fb18074..c564a5429a 100644
>>> --- a/term.el
>>> +++ b/term.el
>>> @@ -755,17 +755,19 @@ ansi-term-color-vector
>>> term-color-bright-cyan
>>> term-color-bright-white])
>>>
>>> -(defcustom term-default-fg-color nil
>>> - "If non-nil, default color for foreground in Term mode."
>>> +(defcustom term-default-fg-color 'unspecified
>>> + "Default color for foreground in Term mode."
>>> :group 'term
>>> - :type '(choice (const nil) (string :tag "color")))
>>> + :type '(choice (const unspecified)
>>> + (string :tag "color")))
>> Doesn't that change behavior?
>> i.e. wouldn't it be better to test that term-default-fg-color is not
>> nil
>> wherever the face is actually made that color?
>
> To be honest I don't know. I reread the spec that says:
>
> "Apart from the values given below, each face attribute can have the
> value =E2=80=98unspecified=E2=80=99. This special value means that the f=
ace doesn=E2=80=99t
> specify that attribute directly. An =E2=80=98unspecified=E2=80=99 attrib=
ute tells Emacs
> to refer instead to a parent face (see the description =E2=80=98:inherit=
=E2=80=99
> attribute below); or, failing that, to an underlying face (*note
> Displaying Faces::). (However, =E2=80=98unspecified=E2=80=99 is not a va=
lid value in
> =E2=80=98defface=E2=80=99.)"
>
> So it seems that unspecified is not allowed in defface. So, how to
> specify a missing attribute excepted by using nil in the defface used
> in term.el?
>
> (defface term
> `((t
> :foreground ,term-default-fg-color
> :background ,term-default-bg-color
> :inherit default))
> "Default face to use in Term mode."
> :group 'term)
>
> Thanks!
>
>
>
>
How about the following?
=2D-8<---------------cut here---------------start------------->8---
(defface term
`((t
,@(when term-default-fg-color
'(:foreground ,term-default-fg-color))
,@(when term-default-bg-color
'(:background ,term-default-bg-color))
:inherit default))
"Default face to use in Term mode."
:group 'term)
=2D-8<---------------cut here---------------end--------------->8---
It would not mention the attributes if the colors are nil.
=2D-=20
Akib Azmain Turja
Find me on Mastodon at @akib@HIDDEN
This message is signed by me with my GnuPG key. Its fingerprint is:
7001 8CE5 819F 17A3 BBA6 66AF E74F 0EFA 922A E7F5
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEyVTKmrtL6kNBe3FRVTX89U2IYWsFAmMZ1ZwACgkQVTX89U2I
YWt7ERAAmzEc1BrZxqZqFew0o1s8HIcfZJNRAwKuon60idqMcAtNJ8KkbCUynb30
TJU/2uH0nVe3qm5b6hpi6bgOsTiIzbOf7/abXB9DtlzTvv4jcvNymmv7DZiQdyXY
hgBH4iXYxlL0taqSLD9pqk+7/qwDh5718SCMamj7XBzh7SaPr9BJy6yfPu3MKWd1
M4CX1gs4dpUEmBIx+tWnHwF8iwQlznw08+GURKoRMuEhd1pXurEJxEjCBa2rnFuW
w8UbfziJdMigkCJW37ZN+LWkckmaHmdJGgv0TEVcGik+ncnvjIi46QILr8cc0Y6J
s46moW72+1y/1RRPfDyr2Kv86wt0Ek+2Seei6W5d/8wEaU3M5jLqTthdLesmQGEi
Vdz2GEfGnt15GK5YuXmiFxoAjsTlN5gYgalQL4CNJpSsUYq0lSgEMkJ0cqcX/+Dp
a9y5zU6o4kRgTrijsimpizoSaGSCZuqeh9z9xNywJ2JtZH76CAOH/eCvVdBo9PrV
1yj8oqthfsY3gXrvFaf+TottB3EDLHZXWWP4nY5tFt0NkPsu0sbrCQzkRVm9NU45
2HwNEbdecJeWsBcRKf4lR4QzbkGu9JzpOsvy3xNY8dKZtB9VHwZRrXbF4XDMLr++
0rdfg/5bpLJ16OvmF9F4ucsI9eixvGa/zjx0hj8PFcfV5TbtrjI=
=nYTX
-----END PGP SIGNATURE-----
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#57652; Package emacs.
Full text available.Received: (at 57652) by debbugs.gnu.org; 8 Sep 2022 08:43:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 08 04:43:09 2022 Received: from localhost ([127.0.0.1]:57203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oWD7s-0006l6-QZ for submit <at> debbugs.gnu.org; Thu, 08 Sep 2022 04:43:09 -0400 Received: from smtp04.smtpout.orange.fr ([80.12.242.126]:59600 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <da_vid@HIDDEN>) id 1oWD7q-0006kw-K7 for 57652 <at> debbugs.gnu.org; Thu, 08 Sep 2022 04:43:07 -0400 Received: from [192.168.1.53] ([84.99.156.79]) by smtp.orange.fr with ESMTPA id WD7ooPxhrOizNWD7ooxqmB; Thu, 08 Sep 2022 10:43:05 +0200 X-ME-Helo: [192.168.1.53] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Thu, 08 Sep 2022 10:43:05 +0200 X-ME-IP: 84.99.156.79 Message-ID: <c6168588-7923-885e-e648-0cc8822ddca4@HIDDEN> Date: Thu, 8 Sep 2022 10:43:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: =?UTF-8?Q?Re=3a_bug=2357652=3a_29=2e0=2e50=3b_Warning_setting_attri?= =?UTF-8?B?YnV0ZSBvZiBmYWNlIOKAmHRlcm3igJk=?= From: David Ponce <da_vid@HIDDEN> To: Po Lu <luangruo@HIDDEN> References: <5f92d116-3cfd-e4b4-0caf-b2337fa1bd7f@HIDDEN> <878rmua277.fsf@HIDDEN> <319e3926-7c22-cabd-43dd-a02f3a01c734@HIDDEN> Content-Language: fr, en-US In-Reply-To: <319e3926-7c22-cabd-43dd-a02f3a01c734@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 57652 Cc: 57652 <at> debbugs.gnu.org, gregory@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 08/09/2022 10:22, David Ponce wrote: > On 08/09/2022 07:02, Po Lu wrote: >> David Ponce <da_vid@HIDDEN> writes: >> >>> diff --git a/term.el b/term.el >>> index 797fb18074..c564a5429a 100644 >>> --- a/term.el >>> +++ b/term.el >>> @@ -755,17 +755,19 @@ ansi-term-color-vector >>> term-color-bright-cyan >>> term-color-bright-white]) >>> >>> -(defcustom term-default-fg-color nil >>> - "If non-nil, default color for foreground in Term mode." >>> +(defcustom term-default-fg-color 'unspecified >>> + "Default color for foreground in Term mode." >>> :group 'term >>> - :type '(choice (const nil) (string :tag "color"))) >>> + :type '(choice (const unspecified) >>> + (string :tag "color"))) >> >> Doesn't that change behavior? >> >> i.e. wouldn't it be better to test that term-default-fg-color is not nil >> wherever the face is actually made that color? > > To be honest I don't know. I reread the spec that says: > > "Apart from the values given below, each face attribute can have the > value ‘unspecified’. This special value means that the face doesn’t > specify that attribute directly. An ‘unspecified’ attribute tells Emacs > to refer instead to a parent face (see the description ‘:inherit’ > attribute below); or, failing that, to an underlying face (*note > Displaying Faces::). (However, ‘unspecified’ is not a valid value in > ‘defface’.)" > > So it seems that unspecified is not allowed in defface. So, how to > specify a missing attribute excepted by using nil in the defface used in > term.el? > > (defface term > `((t > :foreground ,term-default-fg-color > :background ,term-default-bg-color > :inherit default)) > "Default face to use in Term mode." > :group 'term) > > Thanks! > Also it seems that nil attribute is allowed in some cases in defface, because when I show the definition of the default face as a lisp expression I get: ((t (:family "Source Code Pro" :foundry "ADBO" :width normal :height 102 :weight regular :slant normal :underline nil :overline nil :extend nil :strike-through nil :box nil :inverse-video nil :foreground "black" :background "white" :stipple nil :inherit nil))) Thanks!
bug-gnu-emacs@HIDDEN:bug#57652; Package emacs.
Full text available.Received: (at 57652) by debbugs.gnu.org; 8 Sep 2022 08:42:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 08 04:42:59 2022 Received: from localhost ([127.0.0.1]:57199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oWD7j-0006kM-En for submit <at> debbugs.gnu.org; Thu, 08 Sep 2022 04:42:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oWD7h-0006k8-TK for 57652 <at> debbugs.gnu.org; Thu, 08 Sep 2022 04:42:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58082) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oWD7c-0003DV-Ku; Thu, 08 Sep 2022 04:42:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=GQsHGO7BH0pi54bbb3FOUdGhUNfOV4Tc/GV1yTgwAQY=; b=VsEV3wdB0Xs/Hox98t/1 s97TjuIbEloB+gd604TiSp7r5AjtpyjS7kvlqjoxaEc7f58vDYlpJ6WfUybkZ0sxSEWez+00qX3j/ ofzQ56v7+TjjgesIJhsx6I6IUsn2SN9GYqaunYJXOZ8Y1TY5O76EtpKIzf+CF+8McfiesDm6Z0xcv aAd4qgbzZPsQaXIy+j3M+kLVzze/DaeS0H3k/7ob7C+QSgUZpHXPh7mOLmVItErpT2EDHcvVVg7MK fjp699ohMTWGOutLsHcrEWk2eLuwNMYm44DWLfnKvVzaeSGCOZ/Zc+Uso/RFNkq4nzdUo9DRHaZT9 /lIicz44MvE3Gg==; Received: from [87.69.77.57] (port=1926 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oWD7c-0007nq-3a; Thu, 08 Sep 2022 04:42:52 -0400 Date: Thu, 08 Sep 2022 11:42:38 +0300 Message-Id: <83czc6fe9t.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: David Ponce <da_vid@HIDDEN> In-Reply-To: <319e3926-7c22-cabd-43dd-a02f3a01c734@HIDDEN> (message from David Ponce on Thu, 8 Sep 2022 10:22:31 +0200) Subject: Re: bug#57652: 29.0.50; Warning setting attribute of face =?utf-8?B?4oCYdGVybeKAmQ==?= References: <5f92d116-3cfd-e4b4-0caf-b2337fa1bd7f@HIDDEN> <878rmua277.fsf@HIDDEN> <319e3926-7c22-cabd-43dd-a02f3a01c734@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57652 Cc: luangruo@HIDDEN, 57652 <at> debbugs.gnu.org, gregory@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: 57652 <at> debbugs.gnu.org, gregory@HIDDEN > Date: Thu, 8 Sep 2022 10:22:31 +0200 > From: David Ponce <da_vid@HIDDEN> > > "Apart from the values given below, each face attribute can have the > value ‘unspecified’. This special value means that the face doesn’t > specify that attribute directly. An ‘unspecified’ attribute tells Emacs > to refer instead to a parent face (see the description ‘:inherit’ > attribute below); or, failing that, to an underlying face (*note > Displaying Faces::). (However, ‘unspecified’ is not a valid value in > ‘defface’.)" > > So it seems that unspecified is not allowed in defface. Where does it say that unspecified is not allowed? (And this doc string is from set-face-attribute, not from defface.) > So, how to specify a missing attribute excepted by using nil in the > defface used in term.el? If you don't have anything to say about an attribute, just don't mention it in defface. That's what unspecified means, as the doc string says. So I'm unsure why you would need "to specify a missing attribute".
bug-gnu-emacs@HIDDEN:bug#57652; Package emacs.
Full text available.
Received: (at 57652) by debbugs.gnu.org; 8 Sep 2022 08:22:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 08 04:22:35 2022
Received: from localhost ([127.0.0.1]:57164 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oWCnz-0006EY-7b
for submit <at> debbugs.gnu.org; Thu, 08 Sep 2022 04:22:35 -0400
Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:62487
helo=smtp.smtpout.orange.fr)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <da_vid@HIDDEN>) id 1oWCnx-0006EQ-SE
for 57652 <at> debbugs.gnu.org; Thu, 08 Sep 2022 04:22:34 -0400
Received: from [192.168.1.53] ([84.99.156.79]) by smtp.orange.fr with ESMTPA
id WCnvoSzq49RnzWCnvoWtHV; Thu, 08 Sep 2022 10:22:32 +0200
X-ME-Helo: [192.168.1.53]
X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI=
X-ME-Date: Thu, 08 Sep 2022 10:22:32 +0200
X-ME-IP: 84.99.156.79
Message-ID: <319e3926-7c22-cabd-43dd-a02f3a01c734@HIDDEN>
Date: Thu, 8 Sep 2022 10:22:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
Thunderbird/102.2.1
Subject: =?UTF-8?Q?Re=3a_bug=2357652=3a_29=2e0=2e50=3b_Warning_setting_attri?=
=?UTF-8?B?YnV0ZSBvZiBmYWNlIOKAmHRlcm3igJk=?=
To: Po Lu <luangruo@HIDDEN>
References: <5f92d116-3cfd-e4b4-0caf-b2337fa1bd7f@HIDDEN>
<878rmua277.fsf@HIDDEN>
Content-Language: fr, en-US
From: David Ponce <da_vid@HIDDEN>
In-Reply-To: <878rmua277.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 57652
Cc: 57652 <at> debbugs.gnu.org, gregory@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On 08/09/2022 07:02, Po Lu wrote:
> David Ponce <da_vid@HIDDEN> writes:
>
>> diff --git a/term.el b/term.el
>> index 797fb18074..c564a5429a 100644
>> --- a/term.el
>> +++ b/term.el
>> @@ -755,17 +755,19 @@ ansi-term-color-vector
>> term-color-bright-cyan
>> term-color-bright-white])
>>
>> -(defcustom term-default-fg-color nil
>> - "If non-nil, default color for foreground in Term mode."
>> +(defcustom term-default-fg-color 'unspecified
>> + "Default color for foreground in Term mode."
>> :group 'term
>> - :type '(choice (const nil) (string :tag "color")))
>> + :type '(choice (const unspecified)
>> + (string :tag "color")))
>
> Doesn't that change behavior?
>
> i.e. wouldn't it be better to test that term-default-fg-color is not nil
> wherever the face is actually made that color?
To be honest I don't know. I reread the spec that says:
"Apart from the values given below, each face attribute can have the
value ‘unspecified’. This special value means that the face doesn’t
specify that attribute directly. An ‘unspecified’ attribute tells Emacs
to refer instead to a parent face (see the description ‘:inherit’
attribute below); or, failing that, to an underlying face (*note
Displaying Faces::). (However, ‘unspecified’ is not a valid value in
‘defface’.)"
So it seems that unspecified is not allowed in defface. So, how to
specify a missing attribute excepted by using nil in the defface used in
term.el?
(defface term
`((t
:foreground ,term-default-fg-color
:background ,term-default-bg-color
:inherit default))
"Default face to use in Term mode."
:group 'term)
Thanks!
bug-gnu-emacs@HIDDEN:bug#57652; Package emacs.
Full text available.Received: (at 57652) by debbugs.gnu.org; 8 Sep 2022 05:02:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 08 01:02:40 2022 Received: from localhost ([127.0.0.1]:56956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oW9gW-0000vK-Gs for submit <at> debbugs.gnu.org; Thu, 08 Sep 2022 01:02:40 -0400 Received: from sonic314-22.consmr.mail.ne1.yahoo.com ([66.163.189.148]:43247) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <luangruo@HIDDEN>) id 1oW9gT-0000v4-QH for 57652 <at> debbugs.gnu.org; Thu, 08 Sep 2022 01:02:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1662613350; bh=oKtzdC9gnMGcmRwF1TeyWuf6S0gP6AJuchWTRCM39k4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=UBJ5Rxc3UX4a8j7NJHbC1wD9zcfEf0TMo32oKyDTaRYYdFoYsOIRdkhxSk6LNxrDmHNhJUbItexgGci+WO0g9KP43s269ydtDhSzmojDdwCZn2pqVuzCTvXdPDGhII8TFCU9BOYjZ90OITwlgVaTS5UEkXSeTxhFZ7Yz4D8c3adL0SKdvzFy4ZWbbHVp1zbAxRaxPx5QgJGtUWfPtn/6Mmv42lVL714MO/XzgjLsdEaz6xLi3qhIVOP7YJAIV5CTtjAu+szPvpVTKUehir3g1XLvp+UttzJsVnr0wH7bpxd/n/1/vWQ5IgaZ10CRv0P52F4f5bYjLWxiFGRO1N3Puw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1662613350; bh=BA/jVD1YNDNLmD7iQrBqdv0BIVVSruQ/rvO4KxkMRKr=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=JFpXcKUVC6SaK7RZ7E+c9QH7+ibJz4iAH0iHwK3fPjJPcx1K0s4qZ0FDQfwvmaA+tD+m4W7wAabn4YFFtpTMH/Qcih56tzFGNIBD4w0Fay/qurB6aLbeeMudn5fPvL+XwGGWFlAIW028SRoz5/Vlxrjm4xZn2wtlIK8oCHjIl4w95rHtduwBhgSvG+E4405URDowb1wtKnfhjs4D9CFAIbQTLgn3pqKGVBu9DflVgT5QYIGAsd9Y/eebV58uFReEgMoVXDGMDpnyBrx8+Kp1HG+hc7vw4vevUCH70BoioL2+wsh/gahLxe4BF3czg5W6POp+q9Q/iv6BGTqU5IN4QA== X-YMail-OSG: oXEUi5UVM1nwOi.fVHSz.Qt0fpm.Nn9gPfqMgGRJhUDHHVSAEVadI9T1rXY5s3n XTXIKiZOMpTpF_nV84OFPsACpzYNdOP4lJqtstUotoMSegUB9jDRLDzhzHgANr4yqt2DaAtGn3D6 Ddg27KKwY.u_GntiOOR0SX2baS3falZfOavMg_OD_WCW3.UUr6Xbr_1Xnw12jmeTPkTZL9aMYpXO DnfM2ZPtVtJKOHwKbXD400p1hB3vOLYEWNb2ovPjDefYy1IfPNCUlupZ8nxOCBK8lIsSNWLrn1WY 3_o4ugY_kJSzyEoaYZG2yfySSbo2GliZ.XcHPQ3YbUQth_mIITCHM359NhVZjOv_NPIfxMtBmUDT yv6dRcshC2Ekkg9AMMEIGDSoQ5OXCqDRYuYGIX4Zx5vqwBF90YNyngvYrCRek_cj1AkW1jjchYhf PW0ltoklGBucdFbJ0MeuI3_sNGEIeA8WCGzpktiWhPMRoPOCoLYjzknsASxZkIQpsudEMe6uQKry faMbGmc4DeHFMOcf96RsogMwgnEDcLDJzJ7xykOHlrLsKOMlSuDzIttfeCgmTjp9p80To0hJmb1v dscdcENT1Os.F07Tgd.uVJnY2oI_E.VwPqDhqRBT7fci9J9P_wwMFMXotrOuTJ0HysJwbRQyW_2x XMZcv6S9RfK7Oj0G8LHvZ_BRmCa.r_X6wUN21tDr_WHhJKnD4kVvfqg2Ypuc4QPe5_mYp6NeQ03h fr2YUDiEH2bO8xrLea9wW1H2PvjLF5rQtYjI803M7_8V6QyxciY4e.hNbL0EPgTYdTuKo1c73QTz 3vJXLWzc53m70459ctd91yHC7r.V.2qZJDDSY5RGmvCkBeKHZ1418gyS417ESAvex13dBMv_32Jc WxtIQT_Lw8lge7yVOuhKUg4XRAG1ccRQ4kmvMqWv0IPjStAnFoYhgOGw2F2.m06LphFBzK9UpMMS B0VQ4xaeW9.eas1TQzBokRZzoFtM8uSeRIAuloajXQ79bc0wNBGUTE3erxA_Zc8cge2QyQZfEzzS efUdOT.VnS_c9Ub_z2p0loJJ2UBJ9hakZTaW3XJu7CjzwibwnC7Yt2nmeREAeXIivK.mt3B9gMyG 6fimNLMs6kwY9j9v2IKZaaf6Lpk3Dzu.d6IT_DNGbv1zP0AqF6aRUHi1HuNGwL6kg8Oz8sM_UR3i z9sdksptkU9FAZ8E3DxkOA19dAHgWU3UMy3pFvA8z5m7u5SqM0O9Lyokmi7WwbUqkNiyhrJ3AmQu 5z9I0WD4MkJ1R0__aqkGkfX1phhECKVth5rHZsih6vvyY6yDCU1xiSk1rfC6lb9E3KKfaWir0U8s gLGDcJT0rncb5xIZEDFAbslUN2TjpDW6.dWCO55Bmo4opbOE4CvDMl3Ne.DRtaJi8Z572ykV6j0H 3Tura2aSwsG0Nd0sk2XdvlXN2cc2NwlA0VIdND9h9NnCLQTssso8eRz7Rtigdg8Gtm8W5KjZvAOC TRSQ_jJ6hsO7S2MZwNzgbOUelBqWonnaDS0Yr2YntJU3_eRIJyLlJTm20_bC.7_ABS3YJ.Tex_J4 KXPC3nTBmOe1PORngeOsrSyaQRnKrHlb5_dHxDdnnET51K.GO9WM2WecsgFVy2D4WQprMyqfenQJ xflkH8pzApWvIZPRDehKbYRWtAYgVCAK5XlkicftkIectKtdXGYcKo5deFng.61nN7yKjiIehlLZ YThNaXpsdacJCBkSmOcPF2eDT6fEatSPaq2cd62.S_P32i33JvZy52Tfpyvrot.Wq1Uq_K6pXBks mKD5CADuB._QjorZRG3A4NVfaw76bJFzZETK2Hf8mFcdY9Mp2qX8Vhcy4pzHMJjbXWVD_6BtRMgX j6_H0hAKeqinGf91UXPXnstMIqcc8v8QVqwpR.7bskKFDzkYwMeDrBe._0IZVVMxTWzYMq48aaoC TEszswbk_M4IGDFeL2UDuqpAcU1ISbPLU_bZMhbmtP.hsmQocJ3Wjbq2gqwQ5mA5ICG9mqoB8NFE EUoDR56E60yG4BwyZfbGscv9Ed5xexWbSw4aylmm3Xx4UmHJnWe1pvUnBRWn574jpPmZOI9b3Yyk qcdDAHrasxUQuMfm7YNyqO8XjOQAQfqozVIEsX4_n_ePbF.XPQaogBpopAMaJw0OnQ4D.y7VEGj0 zKnLhBEbZV2vI9yCZruj1BJo96skUsbCR08vP21VtvBaJ7cs_OuhtfsiSgHJuS.KeYUrEoBZaS6o 27b6Y1e3cfuzAR7GHXeoUS5LVwlTs9h6U4NMYB0xmrZq4CDtFbUC2A.Xn0C9uo0AspVSUkzWkmRq Kx0ybKw-- X-Sonic-MF: <luangruo@HIDDEN> Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Thu, 8 Sep 2022 05:02:30 +0000 Received: by hermes--canary-production-sg3-6bb8946c47-ts4tq (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 5dbd4b1ed2d283af73c3adc880a963c9; Thu, 08 Sep 2022 05:02:25 +0000 (UTC) From: Po Lu <luangruo@HIDDEN> To: David Ponce <da_vid@HIDDEN> Subject: Re: bug#57652: 29.0.50; Warning setting attribute of face =?utf-8?B?4oCYdGVybeKAmQ==?= References: <5f92d116-3cfd-e4b4-0caf-b2337fa1bd7f@HIDDEN> Date: Thu, 08 Sep 2022 13:02:20 +0800 In-Reply-To: <5f92d116-3cfd-e4b4-0caf-b2337fa1bd7f@HIDDEN> (David Ponce's message of "Wed, 7 Sep 2022 20:49:06 +0200") Message-ID: <878rmua277.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20612 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 764 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 57652 Cc: 57652 <at> debbugs.gnu.org, gregory@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) David Ponce <da_vid@HIDDEN> writes: > diff --git a/term.el b/term.el > index 797fb18074..c564a5429a 100644 > --- a/term.el > +++ b/term.el > @@ -755,17 +755,19 @@ ansi-term-color-vector > term-color-bright-cyan > term-color-bright-white]) > > -(defcustom term-default-fg-color nil > - "If non-nil, default color for foreground in Term mode." > +(defcustom term-default-fg-color 'unspecified > + "Default color for foreground in Term mode." > :group 'term > - :type '(choice (const nil) (string :tag "color"))) > + :type '(choice (const unspecified) > + (string :tag "color"))) Doesn't that change behavior? i.e. wouldn't it be better to test that term-default-fg-color is not nil wherever the face is actually made that color?
bug-gnu-emacs@HIDDEN:bug#57652; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 7 Sep 2022 18:49:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 07 14:49:32 2022
Received: from localhost ([127.0.0.1]:56298 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oW07A-0008S4-2n
for submit <at> debbugs.gnu.org; Wed, 07 Sep 2022 14:49:32 -0400
Received: from lists.gnu.org ([209.51.188.17]:34776)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <da_vid@HIDDEN>) id 1oW078-0008Rx-2R
for submit <at> debbugs.gnu.org; Wed, 07 Sep 2022 14:49:30 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:54336)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <da_vid@HIDDEN>) id 1oW077-0005Pp-S6
for bug-gnu-emacs@HIDDEN; Wed, 07 Sep 2022 14:49:29 -0400
Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:61277
helo=smtp.smtpout.orange.fr)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <da_vid@HIDDEN>) id 1oW06s-0007w6-2M
for bug-gnu-emacs@HIDDEN; Wed, 07 Sep 2022 14:49:28 -0400
Received: from [192.168.1.53] ([84.99.156.162]) by smtp.orange.fr with ESMTPA
id W06kozW7ebJVVW06loD5Jy; Wed, 07 Sep 2022 20:49:09 +0200
X-ME-Helo: [192.168.1.53]
X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI=
X-ME-Date: Wed, 07 Sep 2022 20:49:09 +0200
X-ME-IP: 84.99.156.162
Message-ID: <5f92d116-3cfd-e4b4-0caf-b2337fa1bd7f@HIDDEN>
Date: Wed, 7 Sep 2022 20:49:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
Thunderbird/102.2.1
Content-Language: fr, en-US
To: bug-gnu-emacs@HIDDEN
From: David Ponce <da_vid@HIDDEN>
Subject: =?UTF-8?Q?29=2e0=2e50=3b_Warning_setting_attribute_of_face_?=
=?UTF-8?B?4oCYdGVybeKAmQ==?=
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=80.12.242.131; envelope-from=da_vid@HIDDEN;
helo=smtp.smtpout.orange.fr
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.7 (-)
X-Debbugs-Envelope-To: submit
Cc: gregory@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.7 (--)
Hello,
Since below commit:
Gregory Heytings <gregory@HIDDEN> 2022-09-02 22:30:25 +0200
commit d0a66f3e0e668d8c12c54436740c62f8e238a664
Display a warning for some uses of nil in face attributes.
* src/xfaces.c (HANDLE_INVALID_NIL_VALUE): New macro, which displays
a warning for invalid uses of nil as a face attribute value.
(Finternal_set_lisp_face_attribute): Use the macro for the attributes
:foreground, :distant-foreground and :background.
When opening a term window (M-x term) for the 1st time, the below
messages are displayed in the *Messages* buffer:
Warning: setting attribute ‘:foreground’ of face ‘term’: nil value is
invalid, use ‘unspecified’ instead.
Warning: setting attribute ‘:background’ of face ‘term’: nil value is
invalid, use ‘unspecified’ instead.
The small patch below fixed the issue for me:
diff --git a/term.el b/term.el
index 797fb18074..c564a5429a 100644
--- a/term.el
+++ b/term.el
@@ -755,17 +755,19 @@ ansi-term-color-vector
term-color-bright-cyan
term-color-bright-white])
-(defcustom term-default-fg-color nil
- "If non-nil, default color for foreground in Term mode."
+(defcustom term-default-fg-color 'unspecified
+ "Default color for foreground in Term mode."
:group 'term
- :type '(choice (const nil) (string :tag "color")))
+ :type '(choice (const unspecified)
+ (string :tag "color")))
(make-obsolete-variable 'term-default-fg-color "use the face `term'
instead."
"24.3")
-(defcustom term-default-bg-color nil
- "If non-nil, default color for foreground in Term mode."
+(defcustom term-default-bg-color 'unspecified
+ "Default color for foreground in Term mode."
:group 'term
- :type '(choice (const nil) (string :tag "color")))
+ :type '(choice (const unspecified)
+ (string :tag "color")))
(make-obsolete-variable 'term-default-bg-color "use the face `term'
instead."
"24.3")
Thanks!
Configured using:
'configure --with-x-toolkit=gtk3 --with-cairo
PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/usr/lib/pkgconfig'
Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB
Important settings:
value of $LC_TIME: fr_FR.utf8
value of $LANG: fr_FR.UTF-8
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
shell-dirtrack-mode: t
tooltip-mode: t
global-eldoc-mode: t
eldoc-mode: t
show-paren-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
line-number-mode: t
indent-tabs-mode: t
transient-mark-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
Load-path shadows:
None found.
David Ponce <da_vid@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#57652; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.