GNU bug report logs - #57667
[PATCH] gnu: Add emacs-flymake-collection.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57667 in the body.
You can then email your comments to 57667 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: Add emacs-flymake-collection.
Date: Wed,  7 Sep 2022 22:49:31 -0500

* gnu/packages/emacs-xyz.scm (emacs-flymake-collection): New variable.
---
 gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2af9fd945b..2d4f451d8a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1822,6 +1822,27 @@ (define-public emacs-flycheck
 provides an optional IDE-like error list.")
     (license license:gpl3+)))                     ;+GFDLv1.3+ for the manual
 
+(define-public emacs-flymake-collection
+  (package
+    (name "emacs-flymake-collection")
+    (version "20220612.1340")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://melpa.org/packages/flymake-collection-"
+                           version ".tar"))
+       (sha256
+        (base32 "1ivf7hqjnpgya6bkn83134yhw6nc29fic642jb73w60j461l2a69"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/mohkale/flymake-collection/")
+    (synopsis "Collection of checkers for flymake")
+    (description
+"This package tries to provide a comprehensive list of
+diagnostic-functions for use with flymake, give users the tools to
+easily define new syntax checkers and help selectively enable or disable
+diagnostic-functions based on major-modes.")
+    (license license:expat)))
+
 (define-public emacs-flymake-flycheck
   (package
     (name "emacs-flymake-flycheck")
-- 
2.37.3

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>
Cc: jgart <jgart <at> dismail.de>, 57667 <at> debbugs.gnu.org
Subject: Re: [bug#57667] [PATCH] gnu: Add emacs-flymake-collection.
Date: Fri, 09 Sep 2022 09:24:34 +0200

Hello,

jgart via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-flymake-collection): New variable.

Thanks. Some comments below.

> +(define-public emacs-flymake-collection
> +  (package
> +    (name "emacs-flymake-collection")
> +    (version "20220612.1340")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://melpa.org/packages/flymake-collection-"
> +                           version ".tar"))

We don't fetch tarballs from MELPA because those are not stable. Could
you use Github as upstream instead?

> +       (sha256
> +        (base32 "1ivf7hqjnpgya6bkn83134yhw6nc29fic642jb73w60j461l2a69"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/mohkale/flymake-collection/")
> +    (synopsis "Collection of checkers for flymake")

Nitpick: Flymake

> +    (description
> +"This package tries to provide a comprehensive list of

This package provides…

> +diagnostic-functions for use with flymake, give users the tools to
> +easily define new syntax checkers and help selectively enable or disable
> +diagnostic-functions based on major-modes.")

Nitpick: major modes

Regards,
-- 
Nicolas Goaziou

Message #14 received at 57667 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: jgart <at> dismail.de
Cc: 57667 <at> debbugs.gnu.org, Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: bug#57667: [PATCH] gnu: Add emacs-flymake-collection.
Date: Wed, 28 Sep 2022 14:26:14 -0400

Hi jgart!

Nicolas had done the review below:

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Hello,
>
> jgart via Guix-patches via <guix-patches <at> gnu.org> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-flymake-collection): New variable.
>
> Thanks. Some comments below.
>
>> +(define-public emacs-flymake-collection
>> +  (package
>> +    (name "emacs-flymake-collection")
>> +    (version "20220612.1340")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "https://melpa.org/packages/flymake-collection-"
>> +                           version ".tar"))
>
> We don't fetch tarballs from MELPA because those are not stable. Could
> you use Github as upstream instead?
>
>> +       (sha256
>> +        (base32 "1ivf7hqjnpgya6bkn83134yhw6nc29fic642jb73w60j461l2a69"))))
>> +    (build-system emacs-build-system)
>> +    (home-page "https://github.com/mohkale/flymake-collection/")
>> +    (synopsis "Collection of checkers for flymake")
>
> Nitpick: Flymake
>
>> +    (description
>> +"This package tries to provide a comprehensive list of
>
> This package provides…
>
>> +diagnostic-functions for use with flymake, give users the tools to
>> +easily define new syntax checkers and help selectively enable or disable
>> +diagnostic-functions based on major-modes.")
>
> Nitpick: major modes

Could you please address the comments and send a v2?

Thank you,

Maxim

Message #17 received at 57667 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 57667 <at> debbugs.gnu.org, Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: bug#57667: [PATCH] gnu: Add emacs-flymake-collection.
Date: Wed, 28 Sep 2022 15:38:29 -0500

On Wed, 28 Sep 2022 14:26:14 -0400 Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
> Could you please address the comments and send a v2?

I'm having an issue building the latest release related to autoloads. I
opened an email thread to talk about it.

I'll look for that and reply again.

Message #22 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>
Cc: 57667-done <at> debbugs.gnu.org, jgart <jgart <at> dismail.de>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#57667] [PATCH] gnu: Add emacs-flymake-collection.
Date: Sun, 30 Oct 2022 10:55:34 +0100

Hello,

jgart via Guix-patches via <guix-patches <at> gnu.org> writes:

> On Wed, 28 Sep 2022 14:26:14 -0400 Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
>> Could you please address the comments and send a v2?
>
> I'm having an issue building the latest release related to autoloads. I
> opened an email thread to talk about it.
>
> I'll look for that and reply again.

I went ahead, fixed the package definition and pushed it.

Thank you for the initial work.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.