GNU bug report logs - #57671
[PATCH] gnu: Add mpdevil.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57671 in the body.
You can then email your comments to 57671 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add mpdevil.
Date: Thu, 8 Sep 2022 10:48:25 +0200

* gnu/packages/mpd.scm (mpdevil): New variable.
---
 gnu/packages/mpd.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 046471f32d..c7d9b4646c 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -523,3 +523,38 @@ (define-public mcg
 album-experience.")
     (home-page "https://gitlab.com/coderkun/mcg")
     (license license:gpl3+)))
+
+(define-public mpdevil
+  (package
+    (name "mpdevil")
+    (version "1.7.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/SoongNoonien/mpdevil")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32 "1va8fqlz8qb68gvacnzmp4asnipi11316n1cv2wb41sml9d7v00j"))))
+    (build-system meson-build-system)
+    (arguments
+     (list
+      #:glib-or-gtk? #t
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'glib-or-gtk-wrap 'python-and-gi-wrap
+            (lambda* (#:key outputs #:allow-other-keys)
+              (let ((prog (string-append (assoc-ref outputs "out")
+                                         "/bin/mpdevil")))
+                (wrap-program prog
+                  `("GUIX_PYTHONPATH" = (,(getenv "GUIX_PYTHONPATH")))
+                  `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH"))))))))))
+    (inputs (list gtk+ python python-mpd2 python-pygobject))
+    (native-inputs (list `(,glib "bin")))
+    (home-page "https://github.com/SoongNoonien/mpdevil")
+    (synopsis "Music browser for the MPD")
+    (description "mpdevil is a music browser for the Music Player Daemon (MPD),
+which is focused on playing local music without the need of managing playlists.
+Instead of maintaining a client side database of your music library,
+mpdevil loads all tags and covers on demand.")
+    (license license:gpl3+)))
-- 
2.37.2

Message #8 received at 57671 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 57671 <at> debbugs.gnu.org
Subject: Re: [bug#57671] [PATCH] gnu: Add mpdevil.
Date: Sat, 10 Sep 2022 10:50:04 +0100

[Message part 1 (text/plain, inline)]

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> * gnu/packages/mpd.scm (mpdevil): New variable.
> ---
>  gnu/packages/mpd.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)

There's one lint warning that can be fixed, but apart from that this
looks good to me.

> diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
> index 046471f32d..c7d9b4646c 100644
> --- a/gnu/packages/mpd.scm
> +++ b/gnu/packages/mpd.scm
> @@ -523,3 +523,38 @@ (define-public mcg
>  album-experience.")
>      (home-page "https://gitlab.com/coderkun/mcg")
>      (license license:gpl3+)))
> +
> +(define-public mpdevil
> +  (package
> +    (name "mpdevil")
> +    (version "1.7.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/SoongNoonien/mpdevil")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32 "1va8fqlz8qb68gvacnzmp4asnipi11316n1cv2wb41sml9d7v00j"))))
> +    (build-system meson-build-system)
> +    (arguments
> +     (list
> +      #:glib-or-gtk? #t
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'glib-or-gtk-wrap 'python-and-gi-wrap
> +            (lambda* (#:key outputs #:allow-other-keys)
> +              (let ((prog (string-append (assoc-ref outputs "out")
> +                                         "/bin/mpdevil")))
> +                (wrap-program prog
> +                  `("GUIX_PYTHONPATH" = (,(getenv "GUIX_PYTHONPATH")))
> +                  `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH"))))))))))

The linter says:

  "bash-minimal" should be in 'inputs' when 'wrap-program' is used

> +    (inputs (list gtk+ python python-mpd2 python-pygobject))
> +    (native-inputs (list `(,glib "bin")))
> +    (home-page "https://github.com/SoongNoonien/mpdevil")
> +    (synopsis "Music browser for the MPD")
> +    (description "mpdevil is a music browser for the Music Player Daemon (MPD),
> +which is focused on playing local music without the need of managing playlists.
> +Instead of maintaining a client side database of your music library,
> +mpdevil loads all tags and covers on demand.")
> +    (license license:gpl3+)))

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 57671 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Liliana Marie Prikler" <liliana.prikler <at> gmail.com>,
 <57671 <at> debbugs.gnu.org>
Subject: Re: [bug#57671] [PATCH] gnu: Add mpdevil.
Date: Sat, 10 Sep 2022 10:57:00 +0100

Hey Liliana,

On Thu Sep 8, 2022 at 9:48 AM BST, Liliana Marie Prikler wrote:
> +    (arguments
> +     (list
> +      #:glib-or-gtk? #t

Maybe move these keywords like this:

  (list #:glib-or-gtk? #t
        #:phases
        #~(...))

This generally seems to be the standard.

> +            (lambda* (#:key outputs #:allow-other-keys)
> +              (let ((prog (string-append (assoc-ref outputs "out")
> +                                         "/bin/mpdevil")))

`(assoc-ref outputs "out")' -> `#$output'
`(lambda* (#:key outputs #:allow-other-keys)' -> `(lambda _'

> +    (native-inputs (list `(,glib "bin")))

``(,glib "bin")' -> `(list glib "bin")'

> +    (description "mpdevil is a music browser for the Music Player Daemon (MPD),

This:

  (description
   "...")

seems to be the norm for descriptions.

    -- (

Message #16 received at 57671-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 57671-done <at> debbugs.gnu.org
Subject: Re: [bug#57671] [PATCH] gnu: Add mpdevil.
Date: Sat, 10 Sep 2022 17:25:07 +0200

Am Samstag, dem 10.09.2022 um 10:50 +0100 schrieb Christopher Baines:
> The linter says:
> 
>   "bash-minimal" should be in 'inputs' when 'wrap-program' is used
Fixed and pushed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.