GNU bug report logs - #57674
29.0.50; `backtrace-goto-source' function broken.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57674 in the body.
You can then email your comments to 57674 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michelangelo Rodriguez <michelangelo.rodriguez <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; `backtrace-goto-source' function broken.
Date: Thu, 08 Sep 2022 14:23:13 +0200

In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.34, cairo version 1.16.0) of 2022-09-07 built on mugno
Repository revision: 25813b697cc910ba196ff03a911dbbc0f85c716a
Repository branch: master
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure --with-native-compilation'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES
NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3
THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LANG: it_IT.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  blink-cursor-mode: t
  buffer-read-only: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: linux
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-fns
radix-tree cl-print byte-opt thingatpt debug backtrace find-func
cl-loaddefs comp comp-cstr warnings icons subr-x rx cl-seq cl-macs gv
cl-extra help-mode bytecomp byte-compile cconv cl-lib term/linux rmc
iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq
simple cl-generic indonesian philippine cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite emoji-zwj charscript charprop case-table
epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process
native-compile emacs)

Memory information:
((conses 16 83315 8364)
 (symbols 48 7596 0)
 (strings 32 20814 2188)
 (string-bytes 1 628340)
 (vectors 16 13638)
 (vector-slots 8 285041 11197)
 (floats 8 28 291)
 (intervals 56 296 0)
 (buffers 1000 13))
M-x debug-on-entry <RET> backtrace-goto-source <RET>
M-x backtrace-goto-source <RET>
Select a frame.
Press "s"
press "c" in the new backtrace.
It should appears Source code location not known in the echo area.

Message #8 received at 57674 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michelangelo Rodriguez <michelangelo.rodriguez <at> gmail.com>
Cc: 57674 <at> debbugs.gnu.org
Subject: Re: bug#57674: 29.0.50; `backtrace-goto-source' function broken.
Date: Thu, 08 Sep 2022 15:06:41 +0200

Michelangelo Rodriguez <michelangelo.rodriguez <at> gmail.com> writes:

> M-x debug-on-entry <RET> backtrace-goto-source <RET>
> M-x backtrace-goto-source <RET>
> Select a frame.
> Press "s"
> press "c" in the new backtrace.
> It should appears Source code location not known in the echo area.

I can reproduce this problem (but adding the debug-on-entry to
backtrace-goto-source just makes things more confusing).

The problem seems to be that

 (nth (backtrace-get-index) backtrace-frames)

returns a frame without a :source-available entry here:

(defun backtrace-goto-source ()
  "If its location is known, jump to the source code for the frame at point."
  (interactive)
  (let* ((index (or (backtrace-get-index) (user-error "Not in a stack frame")))
         (frame (nth index backtrace-frames))
         (source-available (plist-get (backtrace-frame-flags frame)
                                      :source-available)))
    (unless (and source-available
                 (run-hook-with-args-until-success
                  'backtrace-goto-source-functions))
      (user-error "Source code location not known"))))

I'm pretty unfamiliar with backtrace.el, but I can't see that slot being
added anywhere there?  edebug does add it, but isn't involved in any way
here.  So it looks like something has gotten lost over the years?

However, `RET' on a symbol finds the sounds just fine, which is probably
why nobody has noticed this problem.  I.e., nobody's using the `s'
command in *Backtrace* buffers.

Message #11 received at 57674 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michelangelo Rodriguez <michelangelo.rodriguez <at> gmail.com>
Cc: 57674 <at> debbugs.gnu.org
Subject: Re: bug#57674: 29.0.50; `backtrace-goto-source' function broken.
Date: Thu, 08 Sep 2022 15:08:50 +0200

The `s' command is introduced in Emacs 27.1 -- and doesn't work there,
so it looks like it's never actually worked?

Message #14 received at 57674 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michelangelo Rodriguez <michelangelo.rodriguez <at> gmail.com>
Cc: 57674 <at> debbugs.gnu.org
Subject: Re: bug#57674: 29.0.50; `backtrace-goto-source' function broken.
Date: Fri, 09 Sep 2022 19:29:55 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> The `s' command is introduced in Emacs 27.1 -- and doesn't work there,
> so it looks like it's never actually worked?

The `s' command is only meaningful when called from edebug, so I've now
rejiggered the code and removed the `s' binding from backtrace-mode-map
in Emacs 29.

Message #19 received at 57674 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michelangelo Rodriguez <michelangelo.rodriguez <at> gmail.com>
Cc: 57674 <at> debbugs.gnu.org
Subject: Re: bug#57674: 29.0.50; `backtrace-goto-source' function broken.
Date: Fri, 09 Sep 2022 22:41:22 +0200

(Please keep the debbugs address in the CCs -- otherwise it won't reach
the bug tracker.)

Michelangelo Rodriguez <michelangelo.rodriguez <at> gmail.com> writes:

>> The `s' command is only meaningful when called from edebug, so I've now
>> rejiggered the code and removed the `s' binding from backtrace-mode-map
>> in Emacs 29.
> I think that also the relative documentation should be removed from
> elisp.

What documentation are you referring to?

Message #22 received at 57674 <at> debbugs.gnu.org (full text, mbox):

From: Michelangelo Rodriguez <michelangelo.rodriguez <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 57674 <at> debbugs.gnu.org
Subject: Re: bug#57674: 29.0.50; `backtrace-goto-source' function broken.
Date: Sat, 10 Sep 2022 00:31:38 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> (Please keep the debbugs address in the CCs -- otherwise it won't reach
> the bug tracker.)
Sorry.
>
> Michelangelo Rodriguez <michelangelo.rodriguez <at> gmail.com> writes:
>
>>> The `s' command is only meaningful when called from edebug, so I've now
>>> rejiggered the code and removed the `s' binding from backtrace-mode-map
>>> in Emacs 29.
>> I think that also the relative documentation should be removed from
>> elisp.
>
> What documentation are you referring to?
Hem... Sorry again, the documentation for s command in the debugger
section of the manual is not anymore in the elisp manual on master,
atleast.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.