Ludovic Courtès <ludo@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 57774) by debbugs.gnu.org; 16 Sep 2022 18:28:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 16 14:28:03 2022
Received: from localhost ([127.0.0.1]:44307 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oZG4I-00074Z-L6
for submit <at> debbugs.gnu.org; Fri, 16 Sep 2022 14:28:03 -0400
Received: from knopi.disroot.org ([178.21.23.139]:45272)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <garekdyszel@HIDDEN>) id 1oZG4F-000748-R2
for 57774 <at> debbugs.gnu.org; Fri, 16 Sep 2022 14:28:00 -0400
Received: from localhost (localhost [127.0.0.1])
by disroot.org (Postfix) with ESMTP id 5858740107;
Fri, 16 Sep 2022 20:27:58 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id X_oqlWXEI9PM; Fri, 16 Sep 2022 20:27:57 +0200 (CEST)
From: Garek Dyszel <garekdyszel@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
t=1663352877; bh=ySV/m58UXW06b3hNdzK2oifN9BHCsiLa0lnpS5wFVv8=;
h=From:To:Subject:In-Reply-To:References:Date;
b=LZkv921AgVs4gmOXV8kMRT1cYWFwCygmuGO3P9FgiYdQlmBcWVtPEKTP181Kk9IZ8
drBFyy3ewsc/MenUt5GU5lXjzJRCFECN2ykmoWd2oGWEbZPFXZ2w2aHv0dQOFPMrVS
3FDoPtbGmU3VGRp3ZGjZdZ1M30TIDefsKETxhWO2RjJ29h53aK3IatFbclHv/Vtbq0
6M9q8km4Kxo5K+hvMUnsM4VGSU471Wm0kxP/RXg+3gxDO4sC74SkmhJr0HP9XZd633
Mu41476+CadwnCuu1xUkSKX6q8nOMwgAUY+TUK/bA088ZxlJUFXLbDULNMbkRAcpce
XglOjaPPgt6cw==
To: "(" <paren@HIDDEN>, 57774 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] Add qucs-s.
In-Reply-To: <CMVWSNPV9K43.1SVD70HZ46NY8@guix-aspire>
References: <87fsgvm12r.fsf@HIDDEN>
<CMVWSNPV9K43.1SVD70HZ46NY8@guix-aspire>
Date: Fri, 16 Sep 2022 14:27:47 -0400
Message-ID: <87tu57uqcc.fsf@HIDDEN>
Mime-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 57774
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi (,
I applied your fixes, but in the process found that qucs-s had already been successfully added before by looking at the package definition for libngspice. This led to the following bug link: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27344#236.
It looks like support was later dropped because qucs-s still depended on Qt4 at the time, mentioned in this thread: https://lists.gnu.org/archive/html/guix-devel/2016-02/msg00596.html.
This suggested it would be a good idea to start from the commit where qucs and qucs-s were removed. Now I'm hacking those old package definitions to work with Qt6. qucs-s 0.0.24 still depends on qt5 (which is already out of date), and I don't want to have to update it right away when this Qt security issue comes up again this year.
I'll send an updated patch when that's done. Sorry for jumping around among existing package sources; I suppose how it worked out this time.
- Garek
At 07:26 2022-09-14 UTC+0100, "(" <paren@HIDDEN> wrote:
> Hey,
>
> On Tue Sep 13, 2022 at 10:11 PM BST, Garek Dyszel wrote:
>> + #:phases #~(modify-phases %standard-phases
>
> To conserve lots of horizontal space, consider moving the ``modify-phases''
> to a new line:
>
>> + #:phases
>> + #~(modify-phases %standard-phases
>
>> + (search-input-file inputs "/bin/ngspice")
>> + [...]
>> + (search-input-file inputs "/bin/octave")
>
> You can just do ``(search-input-file inputs "bin/octave")'', no need for the
> leading slash. Also, wouldn't you want to patch in the paths for Xyce,
> SpiceOpus, and Qucsator, too?
>
>> + (synopsis "GUI for different circuit simulation kernels")
>
> s/different/various/, perhaps?
>
>> +
>> +@itemize
>> +@item Ngspice (recommended)
>> +@item Xyce
>> +@item SpiceOpus
>> +@item Qucsator (non-spice)
>> +@end itemize")
>> + (home-page "https://ra3xdh.github.io/")
>> + (license license:gpl2+)))
>> +
>> (define-public freehdl
>> (package
>> (name "freehdl")
>> --
>> 2.37.2
>
>
> -- (
guix-patches@HIDDEN:bug#57774; Package guix-patches.
Full text available.
Received: (at 57774) by debbugs.gnu.org; 14 Sep 2022 06:26:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 14 02:26:57 2022
Received: from localhost ([127.0.0.1]:53483 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oYLrM-0002jp-SC
for submit <at> debbugs.gnu.org; Wed, 14 Sep 2022 02:26:57 -0400
Received: from knopi.disroot.org ([178.21.23.139]:36294)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <paren@HIDDEN>) id 1oYLrK-0002jg-9z
for 57774 <at> debbugs.gnu.org; Wed, 14 Sep 2022 02:26:54 -0400
Received: from localhost (localhost [127.0.0.1])
by disroot.org (Postfix) with ESMTP id A29E349FCB;
Wed, 14 Sep 2022 08:26:53 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id jKmwMA1CaBn7; Wed, 14 Sep 2022 08:26:52 +0200 (CEST)
Mime-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
t=1663136812; bh=tbjpaXdMKi9ca0Jv0QHHfY+Fs+fKNTC1WGnFVJtq35w=;
h=Date:Subject:From:To:References:In-Reply-To;
b=XBMT6r9glcfjUMXvn+k9/Ps3O92U8AjzTzSz6cIybBHTx7Z5diWnyx9mtj+Hu7w0y
07vwViHdKdjZgktKkgK5v4/V4D3DFcgPBmnJ0fgJGtMrk64cWYMKI2z4PXcKfPO6No
bqObGrUOgp2WCnM4OLs2g6+LhNmpBL4U8KypB4N1PUrOzctw8Lt8oMWGqP87I1/un6
JRn0FW3rZpFkpbL66fbrItNOtSRWOfJn9thuiFh+PwSsIzq6h38hckj0O91RV2AwzN
qFnWkUKReeStm3lG4gYbeK6w7Upbw/49zMclBkoet1sq+OT2pOq08JyEmlWk+psWFk
n9cIaDCd67XZA==
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Wed, 14 Sep 2022 07:26:51 +0100
Message-Id: <CMVWSNPV9K43.1SVD70HZ46NY8@guix-aspire>
Subject: Re: [PATCH v2] Add qucs-s.
From: "(" <paren@HIDDEN>
To: "Garek Dyszel" <garekdyszel@HIDDEN>, <57774 <at> debbugs.gnu.org>
References: <87fsgvm12r.fsf@HIDDEN>
In-Reply-To: <87fsgvm12r.fsf@HIDDEN>
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 57774
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
Hey,
On Tue Sep 13, 2022 at 10:11 PM BST, Garek Dyszel wrote:
> + #:phases #~(modify-phases %standard-phases
To conserve lots of horizontal space, consider moving the ``modify-phases''
to a new line:
> + #:phases
> + #~(modify-phases %standard-phases
> + (search-input-file inputs "/bin/ngspice"=
)
> + [...]
> + (search-input-file inputs "/bin/octave")
You can just do ``(search-input-file inputs "bin/octave")'', no need for th=
e
leading slash. Also, wouldn't you want to patch in the paths for Xyce,
SpiceOpus, and Qucsator, too?
> + (synopsis "GUI for different circuit simulation kernels")
s/different/various/, perhaps?
> +
> +@itemize
> +@item Ngspice (recommended)
> +@item Xyce
> +@item SpiceOpus
> +@item Qucsator (non-spice)
> +@end itemize")
> + (home-page "https://ra3xdh.github.io/")
> + (license license:gpl2+)))
> +
> (define-public freehdl
> (package
> (name "freehdl")
> --=20
> 2.37.2
-- (
guix-patches@HIDDEN:bug#57774; Package guix-patches.
Full text available.
Received: (at 57774) by debbugs.gnu.org; 13 Sep 2022 21:11:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 13 17:11:56 2022
Received: from localhost ([127.0.0.1]:53015 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oYDCG-0002r1-0t
for submit <at> debbugs.gnu.org; Tue, 13 Sep 2022 17:11:56 -0400
Received: from knopi.disroot.org ([178.21.23.139]:39130)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <garekdyszel@HIDDEN>) id 1oYDCD-0002qq-Mf
for 57774 <at> debbugs.gnu.org; Tue, 13 Sep 2022 17:11:54 -0400
Received: from localhost (localhost [127.0.0.1])
by disroot.org (Postfix) with ESMTP id DD3A741A85;
Tue, 13 Sep 2022 23:11:51 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
with UTF8SMTP id 3H7DD9eWxdHX; Tue, 13 Sep 2022 23:11:50 +0200 (CEST)
From: Garek Dyszel <garekdyszel@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
t=1663103509; bh=K8NmuEdO/MCNrj9SylCnyO0qv5vwZDhIJUhvIXZQJNo=;
h=From:To:Cc:Subject:Date;
b=BE/l9F2loKTSEY5bSPMPmwf2BtrH1wstlB2j38WRt0EyaWdMowNxpCo9+XZeRzcF4
ODBJACWR5muNEeu0wiQSqJ/mG1id2/IHQi7vDO87pp1a21hzWgUAl/wRLsz8dAad7X
yJGr7+4WJ+RHeLoQUYLdL+3/ZJgApivUHmEfeTsUyvjTKhmsxn1tRP20RZdwya45Pe
QkKu4tqGqgbRSum8HIzzoqWJWGKuj+jm+ntxj6Vw+Tt6EiiyF7yDknFs/mHj0AMJsJ
BiZ2+wNiz/d+IPHQ5cPpQ+BqP+T1iLGvtt0s0gXtAWacO33K7B08Dp3P+x5eYhFL6/
OLB2AOZ0LEqrA==
To: 57774 <at> debbugs.gnu.org
Subject: [PATCH v2] Add qucs-s.
Date: Tue, 13 Sep 2022 21:11:40 +0000
Message-ID: <87fsgvm12r.fsf@HIDDEN>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 57774
Cc:
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
( and Artyom,
I synthesized my last version of this package with Artyom's version in
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D56768.
Starting over from that version, more or less, automatically fixed the
following issues:
1. (outputs '("out")) removed
2. (propagated-inputs (list ngspice)) removed
3. (arguments `( --> (arguments (list : style changed
Further changes:
1. Overly long description shortened by blending ('s suggestion and Artyom'=
s version.
2. Regexps in the (substitute*) procedure now correctly detect and replace =
the lines where ngspice and octave are referenced in qucs/main.cpp.=20
Let me know what you think.
Thanks,
Garek
* gnu/packages/engineering.scm (qucs-s): New variable.
---
gnu/packages/engineering.scm | 60 ++++++++++++++++++++++++++++++++++++
1 file changed, 60 insertions(+)
diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index a8b9f1e786..e759134ae4 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -36,6 +36,7 @@
;;; Copyright =C2=A9 2022 Artyom V. Poptsov <poptsov.artyom@HIDDEN>
;;; Copyright =C2=A9 2022 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
;;; Copyright =C2=A9 2022 Felix Gruber <felgru@HIDDEN>
+;;; Copyright =C2=A9 2022 Garek Dyszel <garekdyszel@HIDDEN>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -2006,6 +2007,65 @@ (define-public xyce-parallel
,@(alist-delete "trilinos"
(package-inputs xyce-serial))))))
=20
+(define-public qucs-s
+ (package
+ (name "qucs-s")
+ (version "0.0.24")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/ra3xdh/qucs_s")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1lbkaw0grw9w7d37z5dbhaqi8p57cpf9yp071zp6xrairkgimdx8"))))
+ (build-system qt-build-system)
+ (native-inputs (list qttools-5))
+ (inputs (list qtbase-5 qtscript qtsvg-5 ngspice octave))
+ (arguments
+ (list #:tests? #f ;no tests
+ #:phases #~(modify-phases %standard-phases
+ (add-after 'unpack 'patch
+ (lambda* (#:key inputs #:allow-other-keys)
+ (substitute* "qucs/main.cpp"
+ ;; Use the user's configuration files in
+ ;; ~/.config/qucs/qucs_s.conf for the
+ ;; locations of ngspice and octave. If
+ ;; the locations are not given in
+ ;; ~/.config/qucs/qucs_s.conf, use the
+ ;; locations provided by Guix.
+ (("QString ngsp_exe =3D \
+QCoreApplication::applicationDirPath\\(\\) \\+")
+ (string-append
+ "QString ngsp_exe =3D \""
+ (search-input-file inputs "/bin/ngspice")
+ "\";"))
+ (("QDir::separator\\(\\) \\+ \"ngspice\" \\+=
\
+executableSuffix;") "")
+ (("else QucsSettings.OctaveExecutable =3D \"o=
ctave\" \
+\\+ QString\\(executableSuffix\\);")
+ (string-append
+ "else QucsSettings.OctaveExecutable =3D \""
+ (search-input-file inputs "/bin/octave")
+ "\";"))))))))
+ (synopsis "GUI for different circuit simulation kernels")
+ (description
+ "@code{Qucs-S} provides a fork of the Qucs circuit simulator,
+which is used as a graphical user interface for a number of popular
+circuit simulation engines. The package contains libraries for
+schematic capture, visualization and components. The following
+simulation kernels are supported:
+
+@itemize
+@item Ngspice (recommended)
+@item Xyce
+@item SpiceOpus
+@item Qucsator (non-spice)
+@end itemize")
+ (home-page "https://ra3xdh.github.io/")
+ (license license:gpl2+)))
+
(define-public freehdl
(package
(name "freehdl")
--=20
2.37.2
guix-patches@HIDDEN:bug#57774; Package guix-patches.
Full text available.Received: (at 57774) by debbugs.gnu.org; 13 Sep 2022 17:28:26 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 13 13:28:26 2022 Received: from localhost ([127.0.0.1]:52842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oY9hx-0005V9-Sy for submit <at> debbugs.gnu.org; Tue, 13 Sep 2022 13:28:26 -0400 Received: from mail-lj1-f182.google.com ([209.85.208.182]:35829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <poptsov.artyom@HIDDEN>) id 1oY9hu-0005Uv-LP for 57774 <at> debbugs.gnu.org; Tue, 13 Sep 2022 13:28:25 -0400 Received: by mail-lj1-f182.google.com with SMTP id 9so14342649ljr.2 for <57774 <at> debbugs.gnu.org>; Tue, 13 Sep 2022 10:28:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date; bh=GXOUabf33cuexVPb+nSNAxB897/YM5O8EmxzIPYNGEQ=; b=H5Cnd8WhGhGuLJqB3YTm82i7WTrlLRsEb8QxSs0yzY92oCfQSeZ6O7liCGQvqzsznh Wxk+9svopqlGIDitBatRF7gPw/paHZk4lRibdGfkvE/uJM4ZCb877eKezuhUV9p5byKQ aDZpHc1FMVGs00GNTNXgH8FyaRQbX8eCBI7UiIk2++OZskeoFC6LBY+NU0408CBl/aFc dkqLL2WIgMzlLnGgw30vYpisS/BybFAC/CDmNdyRUEwSocqbKr0A7Ub1TirDFtHK/j0m l9qRnunDDqGVzuSZ5rZJ3+9LBA3nXnciJI72ZfQJI6pQ0HbNufUGAmmFAy/1GaA6ohIx QuQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date; bh=GXOUabf33cuexVPb+nSNAxB897/YM5O8EmxzIPYNGEQ=; b=FnFhNu0m0sTrYGy1QhaXApj2er+A103ow5Knr3VNsEX1NPPVFsJvpuNxMPSK9zgo4j xAqwMS+ExsSPsKMWKozkD5ZLoZQyWYVb0WWri28P2DMFiZ/hYQ68SXP6Xek4EB2z1GAW ueSIkXPaJ1OSRn1kv19a2X2g2YxTa2aGn9dRdjmDNDhj4E4bahWZLg4bcR+ZXR3sWiOj QIYzH9rUv5F6oXUyDfGegbtjtlRHP+18yTgN6aaRsFHwU+Gf7e60pUazgGZhzVJYZZnN MKeuj0CiEv0llRvoFYGhFj15BgcDyRH3ZWXFoiQbr9BshSgoce95RxHtT/tsIMp67tim HfFQ== X-Gm-Message-State: ACgBeo01RVNYLdE1NYwyCQZqa63mFquU4EpwYFbTCkymoCZJygskc4TK uW48sQ+62n6PYdxgaflEVpw94zcEQME= X-Google-Smtp-Source: AA6agR538htCmRz8CvRs16n9IiWmAHTiKAVjc4A8UUicGKGhlsO4OVZAqi5Ai2KBELEseSKe4TtmIw== X-Received: by 2002:a2e:3e13:0:b0:26b:e6f1:ce14 with SMTP id l19-20020a2e3e13000000b0026be6f1ce14mr6449536lja.454.1663090095104; Tue, 13 Sep 2022 10:28:15 -0700 (PDT) Received: from elephant ([5.166.205.177]) by smtp.gmail.com with ESMTPSA id w14-20020a05651c118e00b00261ccf566e3sm1803863ljo.65.2022.09.13.10.28.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Sep 2022 10:28:14 -0700 (PDT) From: "Artyom V. Poptsov" <poptsov.artyom@HIDDEN> To: garekdyszel@HIDDEN, 57774 <at> debbugs.gnu.org Subject: [bug#57774] [PATCH] Add qucs-s. Date: Tue, 13 Sep 2022 20:28:11 +0300 Message-ID: <878rmnchg4.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 57774 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hello Garek Dyszel, For the sake of completeness, I've tried to package "qucs-s" already: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D56768 Wasn't finished the process though due to issues and the lack of time, but maybe two incomplete patches could be merged into a working one. Thanks, =2D Artyom =2D-=20 Artyom "avp" Poptsov <poptsov.artyom@HIDDEN> Home page: https://memory-heap.org/~avp/ CADR Hackerspace co-founder: https://cadrspace.ru/ GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFNBAEBCgA3FiEE0MLqwTMQgi2Y3rV86cWi2QiYoC8FAmMgvasZHHBvcHRzb3Yu YXJ0eW9tQGdtYWlsLmNvbQAKCRDpxaLZCJigLyOGB/9LC8uVdCwEdM59WQ46UTef 6iDmHOUNQ9I648tzWNpn0CR6qakkS9M18HPbQrq0P2sMqyXk/oO1wSpQqHpTvBfi lYSHfr3rgNuGzQG6jFexzTRXiS/+4VpSoA2X7WK8q7Feuc00/Ui9bxf2GaVIH1zD n9DfY3delOKJpy6wIIH2ernzBXMj5zZrr9J0eJKfXdGvHmCqOujV8bG9x4WvPtBN y/g14VkO1PZYx8EMqw9ixQ/NbrkfhnbrXK9ZB37FzbFRrRiw505DBmVs4ZQweR7W +NFF7fppaSYsGtCa2sN6g57MAhesGNhMJY39WYVpADPKgdhbW3uBLDpMmN2B09aT =yQFX -----END PGP SIGNATURE----- --=-=-=--
guix-patches@HIDDEN:bug#57774; Package guix-patches.
Full text available.
Received: (at 57774) by debbugs.gnu.org; 13 Sep 2022 16:15:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 13 12:15:27 2022
Received: from localhost ([127.0.0.1]:52751 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oY8ZK-0000dp-Vl
for submit <at> debbugs.gnu.org; Tue, 13 Sep 2022 12:15:27 -0400
Received: from knopi.disroot.org ([178.21.23.139]:43358)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <paren@HIDDEN>) id 1oY8ZI-0000QY-0o
for 57774 <at> debbugs.gnu.org; Tue, 13 Sep 2022 12:15:26 -0400
Received: from localhost (localhost [127.0.0.1])
by disroot.org (Postfix) with ESMTP id 28DEF4A071;
Tue, 13 Sep 2022 18:15:22 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
with UTF8SMTP id bhNV8DNqYIyw; Tue, 13 Sep 2022 18:15:21 +0200 (CEST)
Mime-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
t=1663085557; bh=HtpuksVrrbuYA4D9z02rcT2Iov5TLE42MF2+VEOAmrY=;
h=Date:Subject:From:To:References:In-Reply-To;
b=mLrsFDql9C+gQErGbFoUdM3TCJIijgXTJf/QKHNx58HpPbs7RI1qY6iVcmzJ/0oAu
lMwPVgQuSOwU+pKn2D4iPxghOZu70E26dYwJdZw+It4G2cMVerJQJfXLzcORo8rP3T
Na5ADssg6Okvoh8PXvvImRHuX9F9ehlg4Q/wlMbf+fthzl3ybsXaOBIA9ccOBUeygR
geHN0znykn21dwAt2hbp7avGGkAwF5OFkFieA8Icl96rtLyQEyrUHym9pIZn4+FZ8e
dk3TROZVu+xt3z838FMIX9gw+Ozlz/uiaJWOp2JDs9nWTit0gju15ztCNbchIvrYcA
0anVyXpvpwVWg==
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Tue, 13 Sep 2022 17:12:36 +0100
Message-Id: <CMVEMLCFZYJV.2HHWATU7GOQJV@guix-aspire>
Subject: Re: [bug#57774] [PATCH] Add qucs-s.
From: "(" <paren@HIDDEN>
To: "Garek Dyszel" <garekdyszel@HIDDEN>, <57774 <at> debbugs.gnu.org>
References: <875yhrgtrb.fsf@HIDDEN>
In-Reply-To: <875yhrgtrb.fsf@HIDDEN>
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 57774
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
Hey,
On Tue Sep 13, 2022 at 4:48 PM BST, Garek Dyszel via Guix-patches via wrote=
:
> + (outputs '("out"))
This line is redundant; ``out'' is implicit.
> + (propagated-inputs (list ngspice))
Can you try to avoid propagating this somehow? Propagation is a last-resort
measure, and usually we try to do something like patching invocations of
external commands to refer to the full store path. (Although, looking at
the ``modify-phases'' below, it seems like you already do that, so I guess
you'll only need to move ``ngspice'' to ``inputs''.)
> + (arguments
> + `(;; There exists no "tests" target in the Makefile generated by
Please use the new style ``(list ...)'' instead of ```(...)''.
> + (modify-phases %standard-phases
You'll need to gexp this under the new arguments style: ``#~(modify-phases =
...)''.
> + (with-directory-excursion "etc/xdg/qucs_s"
> + (invoke "touch" "qucs_s.conf")
> + ;; Specify where the ngspice executable is located.
> + (invoke "sed" "-i"
> + (string-append "1iNgspiceExecutable=3D/gnu/store/=
"
> + (assoc-ref inputs "ngspice")
> + "/bin/ngspice") "qucs_s.conf")
> + ;; Set the spice4qucs working directory to
> + ;; ~/.qucs/spice4qucs.
> + ;; (The default is /spice4qucs, which is rather
> + ;; dangerous.)
> + (invoke "sed" "-i" "2iS4Q_workdir=3D~/.qucs/spice4qucs"
> + "qucs_s.conf")))))))
This looks pretty redundant. Try using this instead:
> + (call-with-output-file "etc/xdg/qucs_s/qucs_s.conf"
> + (cute format <>
> + "~
> +NgspiceExecutable=3D~a
> +S4Q_workdir=3D~/.qucs/spice4qucs~%"
> + (search-input-file inputs "bin/ngspice")))
And add this to ``arguments'':
#:modules `((ice-9 format)
(srfi srfi-26)
,@%gnu-build-system-modules)
to import ``format'' and ``cute'', respectively.
> + (description
> + "Qucs-S is a spin-off of the Qucs cross-platform circuit
> +simulator. The \"S\" letter indicates SPICE. The purpose of the Qucs-S
> +subproject is to use free SPICE circuit simulation kernels with the
> +Qucs GUI. It merges the power of SPICE and the simplicity of the Qucs
> +GUI. Qucs intentionally uses its own SPICE incompatible simulation
> +kernel Qucsator. It has advanced RF and AC domain simulation features,
> +but most of the existing industrial SPICE models are incompatible with
> +it. Qucs-S is not a simulator by itself, but it requires to use a
> +simulation backend with it. The schematic document format of Qucs and
> +Qucs-S are fully compatible. Qucs-S can be used with the following
> +simulation kernels:
> +@itemize
> +@item Ngspice is recommended to use. Ngspice is powerful
> +mixed-level/mixed-signal circuit simulator. The most of industrial
> +SPICE models are compatible with Ngspice. It has an excellent
> +performance for time-domain simulation of switching circuits and
> +powerful postprocessor.
> +@item XYCE is a new SPICE-compatible circuit simulator written by
> +Sandia from the scratch. It supports basic SPICE simulation types and
> +has an advanced RF simulation features such as harmonic balance
> +simulation.
> +@item SpiceOpus is developed by the Faculty of Electrical Engineering
> +of the Ljubljana University. It is based on the SPICE-3f5 code.
> +@item Backward compatible with Qucsator.
> +@end itemize")
I think this description would probably be better and far more succint as:
> + (description
> + "This package provides a fork of the Qucs cross-platform circuit
> +simulator, which allows the use of SPICE circuit simulation kernels
> +with the Qucs GUI.")
-- (
guix-patches@HIDDEN:bug#57774; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 13 Sep 2022 15:49:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 13 11:49:02 2022
Received: from localhost ([127.0.0.1]:52538 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oY89l-0006sC-Hv
for submit <at> debbugs.gnu.org; Tue, 13 Sep 2022 11:49:02 -0400
Received: from lists.gnu.org ([209.51.188.17]:55806)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <garekdyszel@HIDDEN>) id 1oY89j-0006rs-8k
for submit <at> debbugs.gnu.org; Tue, 13 Sep 2022 11:48:59 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:37960)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <garekdyszel@HIDDEN>)
id 1oY89j-0007nQ-3V
for guix-patches@HIDDEN; Tue, 13 Sep 2022 11:48:59 -0400
Received: from knopi.disroot.org ([178.21.23.139]:55734)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <garekdyszel@HIDDEN>)
id 1oY89g-0005o7-M1
for guix-patches@HIDDEN; Tue, 13 Sep 2022 11:48:58 -0400
Received: from localhost (localhost [127.0.0.1])
by disroot.org (Postfix) with ESMTP id 88FC240056
for <guix-patches@HIDDEN>; Tue, 13 Sep 2022 17:48:52 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id aDqDolka-o4S for <guix-patches@HIDDEN>;
Tue, 13 Sep 2022 17:48:51 +0200 (CEST)
From: Garek Dyszel <garekdyszel@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
t=1663084131; bh=Ol5CuMYBFWWZwS/TmMc+Y8/T5jV+lnQ/bkNT47mtMug=;
h=From:To:Subject:Date;
b=UuaP8EhE2yORXVyeEPcryEyfE4EMu66vfsiCFUkzZC9yczGHG+fyIRbO9ApZnUVRI
V3SlQ2BvNt1hxMPd24XgP9fU/Jf7YAfN2/tzmvZDnT4BCUIM/bKcNeW25mBfoHRwFK
hZyXdRJP7QR/iZoUD+8lvh5YclwIftjngYviUg67UH/4IYkQf33XpY8EfkIORiKrZa
5sYPbjp3UIoXFMpTWJpg1sa3T1d3N+XP3i7Pr2pndKfBVi9vp+XxMBTriRupZwBTun
uW02MciIVrIElqaAPwumDIaD+rJkV9CS7XlonX6+YMTT6f9w1t3JTF5yKyQ/PDcrGB
fwP96UwqMnWMw==
To: guix-patches@HIDDEN
Subject: [PATCH] Add qucs-s.
Date: Tue, 13 Sep 2022 11:48:40 -0400
Message-ID: <875yhrgtrb.fsf@HIDDEN>
Mime-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=178.21.23.139;
envelope-from=garekdyszel@HIDDEN; helo=knopi.disroot.org
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)
* gnu/packages/engineering.scm (qucs-s): New variable.
---
gnu/packages/engineering.scm | 74 ++++++++++++++++++++++++++++++++++++
1 file changed, 74 insertions(+)
diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index a8b9f1e786..376cb7e8c1 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -2006,6 +2006,80 @@ (define-public xyce-parallel
,@(alist-delete "trilinos"
(package-inputs xyce-serial))))))
+(define-public qucs-s
+ (package
+ (name "qucs-s")
+ (version "0.0.24")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/ra3xdh/qucs_s")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1lbkaw0grw9w7d37z5dbhaqi8p57cpf9yp071zp6xrairkgimdx8"))))
+ (build-system qt-build-system)
+ (outputs '("out"))
+ (inputs (list qtbase-5 qtscript qtsvg-5))
+ (native-inputs (list qttools-5))
+ (propagated-inputs (list ngspice))
+ (arguments
+ `(;; There exists no "tests" target in the Makefile generated by
+ ;; CMake.
+ ;; No other tests provided.
+ #:tests? #f
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'install 'get-ngspice-path
+ (lambda* (#:key inputs #:allow-other-keys)
+ ;; Adjust two lines in the ~/.config/qucs/qucs_s.conf
+ ;; file.
+ (mkdir-p "etc/xdg/qucs_s")
+ (with-directory-excursion "etc/xdg/qucs_s"
+ (invoke "touch" "qucs_s.conf")
+ ;; Specify where the ngspice executable is located.
+ (invoke "sed" "-i"
+ (string-append "1iNgspiceExecutable=/gnu/store/"
+ (assoc-ref inputs "ngspice")
+ "/bin/ngspice") "qucs_s.conf")
+ ;; Set the spice4qucs working directory to
+ ;; ~/.qucs/spice4qucs.
+ ;; (The default is /spice4qucs, which is rather
+ ;; dangerous.)
+ (invoke "sed" "-i" "2iS4Q_workdir=~/.qucs/spice4qucs"
+ "qucs_s.conf")))))))
+
+ (home-page "https://ra3xdh.github.io")
+ (synopsis "QUCS RF circuit simulator with SPICE")
+ (description
+ "Qucs-S is a spin-off of the Qucs cross-platform circuit
+simulator. The \"S\" letter indicates SPICE. The purpose of the Qucs-S
+subproject is to use free SPICE circuit simulation kernels with the
+Qucs GUI. It merges the power of SPICE and the simplicity of the Qucs
+GUI. Qucs intentionally uses its own SPICE incompatible simulation
+kernel Qucsator. It has advanced RF and AC domain simulation features,
+but most of the existing industrial SPICE models are incompatible with
+it. Qucs-S is not a simulator by itself, but it requires to use a
+simulation backend with it. The schematic document format of Qucs and
+Qucs-S are fully compatible. Qucs-S can be used with the following
+simulation kernels:
+@itemize
+@item Ngspice is recommended to use. Ngspice is powerful
+mixed-level/mixed-signal circuit simulator. The most of industrial
+SPICE models are compatible with Ngspice. It has an excellent
+performance for time-domain simulation of switching circuits and
+powerful postprocessor.
+@item XYCE is a new SPICE-compatible circuit simulator written by
+Sandia from the scratch. It supports basic SPICE simulation types and
+has an advanced RF simulation features such as harmonic balance
+simulation.
+@item SpiceOpus is developed by the Faculty of Electrical Engineering
+of the Ljubljana University. It is based on the SPICE-3f5 code.
+@item Backward compatible with Qucsator.
+@end itemize")
+ (license license:gpl2)))
+
(define-public freehdl
(package
(name "freehdl")
--
2.37.2
Garek Dyszel <garekdyszel@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#57774; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.