GNU bug report logs - #57805
[PATCH] gnu: podman: Install shell completions.

Previous Next

Package: guix-patches;

Reported by: Michael Rohleder <mike <at> rohleder.de>

Date: Wed, 14 Sep 2022 15:42:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57805 in the body.
You can then email your comments to 57805 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#57805; Package guix-patches. (Wed, 14 Sep 2022 15:42:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Michael Rohleder <mike <at> rohleder.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 14 Sep 2022 15:42:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Cc: Michael Rohleder <mike <at> rohleder.de>
Subject: [PATCH] gnu: podman: Install shell completions.
Date: Wed, 14 Sep 2022 17:40:57 +0200
* gnu/packages/containers.scm (podman)[arguments]: Add 'install-completions
phase to install shell completions.
---
 gnu/packages/containers.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/containers.scm b/gnu/packages/containers.scm
index 1f962ddfd6..029f0d4ba4 100644
--- a/gnu/packages/containers.scm
+++ b/gnu/packages/containers.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2021 Timmy Douglas <mail <at> timmydouglas.com>
 ;;; Copyright © 2022 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2022 Zhu Zihao <all_but_last <at> 163.com>
+;;; Copyright © 2022 Michael Rohleder <mike <at> rohleder.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -323,7 +324,11 @@ (define-public podman
                 (("/usr/local/libexec/cni")
                  (string-append #$(this-package-input "cni-plugins")
                                 "/bin"))
-                (("/usr/bin/crun") (which "crun"))))))))
+                (("/usr/bin/crun") (which "crun")))))
+          (add-after 'install 'install-completions
+            (lambda _
+              (invoke "make" "install.completions"
+                      (string-append "PREFIX=" #$output)))))))
     (inputs
      (list btrfs-progs
            cni-plugins
-- 
2.37.3





Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Wed, 14 Sep 2022 21:28:02 GMT) Full text and rfc822 format available.

Notification sent to Michael Rohleder <mike <at> rohleder.de>:
bug acknowledged by developer. (Wed, 14 Sep 2022 21:28:02 GMT) Full text and rfc822 format available.

Message #10 received at 57805-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 57805-done <at> debbugs.gnu.org
Subject: Re: bug#57805: [PATCH] gnu: podman: Install shell completions.
Date: Wed, 14 Sep 2022 23:27:13 +0200
Michael Rohleder <mike <at> rohleder.de> skribis:

> * gnu/packages/containers.scm (podman)[arguments]: Add 'install-completions
> phase to install shell completions.

Applied, thanks!




Information forwarded to guix-patches <at> gnu.org:
bug#57805; Package guix-patches. (Wed, 14 Sep 2022 21:37:03 GMT) Full text and rfc822 format available.

Message #13 received at 57805-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 57805-done <at> debbugs.gnu.org
Subject: Re: bug#57805: [PATCH] gnu: podman: Install shell completions.
Date: Wed, 14 Sep 2022 23:36:05 +0200
Michael Rohleder <mike <at> rohleder.de> skribis:

> * gnu/packages/containers.scm (podman)[arguments]: Add 'install-completions
> phase to install shell completions.

Applied, thanks!




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 13 Oct 2022 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 167 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.