GNU bug report logs - #57809
[PATCH] gnome-boxes: Add 'qemu' as propagated-input

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57809 in the body.
You can then email your comments to 57809 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jacob Hrbek <kreyren <at> rixotstudio.cz>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnome-boxes: Add 'qemu' as propagated-input
Date: Wed, 14 Sep 2022 18:17:48 +0000

[Message part 1 (text/plain, inline)]

Fixes:

(gnome-boxes:9304): Boxes-WARNING **: 19:54:29.345: review-page.vala:32: Box setup failed: Failed to create volume: internal error: creation of non-raw file images is not supported without qemu-img.

(gnome-boxes:9304): Boxes-CRITICAL **: 19:54:29.345: boxes_assistant_review_page_populate: assertion 'machine != NULL' failed

Steps to reproduce:
1. Open gnome-boxes on GNU Guix
2. Try to create a box with GNU Guix ISO and expect failure above

[publickey - kreyren@rixotstudio.cz - 1677db82.asc (application/pgp-keys, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #8 received at 57809 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Jacob Hrbek <kreyren <at> rixotstudio.cz>, 57809 <at> debbugs.gnu.org
Subject: Re: [bug#57809] [PATCH] gnome-boxes: Add 'qemu' as propagated-input
Date: Thu, 15 Sep 2022 15:03:21 +0200

[Message part 1 (text/plain, inline)]

On 14-09-2022 20:17, Jacob Hrbek wrote:
> Fixes:
> 
> (gnome-boxes:9304): Boxes-WARNING **: 19:54:29.345: review-page.vala:32: Box setup failed: Failed to create volume: internal error: creation of non-raw file images is not supported without qemu-img.
> 
> (gnome-boxes:9304): Boxes-CRITICAL **: 19:54:29.345: boxes_assistant_review_page_populate: assertion 'machine != NULL' failed
> 
> Steps to reproduce:
> 1. Open gnome-boxes on GNU Guix
> 2. Try to create a box with GNU Guix ISO and expect failure above
> 
> 

Instead of propagation, I recommend doing a substitute* instead, to 
avoid the usual downsides of propagation.  Searching for 'qemu-img' in 
the source code of gnome-boxes (with tar, grep -rF and guix build 
--source), I found:

src/installed-media.vala:        string[] argv = { "qemu-img", 
"convert", "-O", "qcow2", device_file, destination_path };

Could you substitute* "qemu-img" -> (search-input-file inputs 
"bin/qemu-img") and move QEMU from 'propagated-inputs' to 'inputs'.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #11 received at 57809 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Hrbek <kreyren <at> rixotstudio.cz>
To: 57809 <at> debbugs.gnu.org
Cc: Jacob Hrbek <kreyren <at> rixotstudio.cz>
Subject: [PATCH] gnome-boxes: Patch 'qemu-img' path
Date: Sun, 18 Sep 2022 20:43:43 +0000

[Message part 1 (text/plain, inline)]

---
 gnu/packages/gnome.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index d6d22f8eb1..89f5999920 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -12111,6 +12111,7 @@ (define-public polari
     (home-page "https://wiki.gnome.org/Apps/Polari")
     (license license:gpl2+)))

+;; NOTE(Krey): src/util-app.vala might need patched paths
 (define-public gnome-boxes
   (package
     (name "gnome-boxes")
@@ -12133,7 +12134,12 @@ (define-public gnome-boxes
            #:phases #~(modify-phases %standard-phases
                         (add-after 'unpack 'disable-gtk-update-icon-cache
                           (lambda _
-                            (setenv "DESTDIR" "/"))))))
+                            (setenv "DESTDIR" "/")))
+                        (add-before 'configure 'substitute-qemu-dependencies
+                          (lambda _
+
    (substitute* "src/installed-media.vala"
+                                (("qemu-img")
+                                 (search-input-file %build-inputs "/bin/qemu-img"))))))))
     (native-inputs
      (list desktop-file-utils           ;for update-desktop-database
            gettext-minimal
@@ -12141,6 +12147,7 @@ (define-public gnome-boxes
            itstool
            pkg-config
            python
+           qemu-minimal                 ;for qemu-img
            vala))
     (inputs
      (list glib-networking              ;for TLS support
--
2.37.1

[publickey - kreyren@rixotstudio.cz - 1677db82.asc (application/pgp-keys, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #14 received at 57809 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Hrbek <kreyren <at> rixotstudio.cz>
To: 57809 <at> debbugs.gnu.org
Cc: Jacob Hrbek <kreyren <at> rixotstudio.cz>
Subject: [PATCH] gnome-boxes: Patch 'qemu-img' path
Date: Sun, 18 Sep 2022 20:46:35 +0000

[Message part 1 (text/plain, inline)]

---
 gnu/packages/gnome.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index d6d22f8eb1..d9cfa5ebed 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -12133,7 +12133,12 @@ (define-public gnome-boxes
            #:phases #~(modify-phases %standard-phases
                         (add-after 'unpack 'disable-gtk-update-icon-cache
                           (lambda _
-                            (setenv "DESTDIR" "/"))))))
+                            (setenv "DESTDIR" "/")))
+                        (add-before 'configure 'substitute-qemu-dependencies
+                          (lambda _
+                              (substitute* "src/installed-media.vala"
+                                (("qemu-img")
+                                 (search-input-file %build-inputs "/bin/qemu-img"))))))))
     (native-inputs
      (list desktop-file-utils           ;for update-desktop-
database
            gettext-minimal
@@ -12141,6 +12146,7 @@ (define-public gnome-boxes
            itstool
            pkg-config
            python
+           qemu-minimal                 ;for qemu-img
            vala))
     (inputs
      (list glib-networking              ;for TLS support
--
2.37.1

[publickey - kreyren@rixotstudio.cz - 1677db82.asc (application/pgp-keys, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #17 received at 57809 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Hrbek <kreyren <at> rixotstudio.cz>
To: 57809 <at> debbugs.gnu.org
Subject: [PATCH] gnome-boxes: Add 'qemu' as propagated-input
Date: Sun, 18 Sep 2022 20:47:42 +0000

[Message part 1 (text/plain, inline)]

While looking through the code i've noticed a path using /etc/.. so i
added a note about it so two patches one with the note and one without
it

[Message part 2 (text/html, inline)]

[publickey - kreyren@rixotstudio.cz - 1677db82.asc (application/pgp-keys, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #20 received at 57809 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Hrbek <kreyren <at> rixotstudio.cz>
To: 57809 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnome-boxes: Patch 'qemu-img' path
Date: Sun, 18 Sep 2022 21:05:03 +0000

[Message part 1 (text/plain, inline)]

isn't that going to break if the user invokes `guix cg -D` though?

On Ne, zář 18 2022 at 20:43:43 +0000, Jacob Hrbek 
<kreyren <at> rixotstudio.cz> wrote:
> ---
>  gnu/packages/gnome.scm | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index d6d22f8eb1..89f5999920 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -12111,6 +12111,7 @@ (define-public polari
>      (home-page "<https://wiki.gnome.org/Apps/Polari>")
>      (license license:gpl2+)))
> 
> +;; NOTE(Krey): src/util-app.vala might need patched paths
>  (define-public gnome-boxes
>    (package
>      (name "gnome-boxes")
> @@ -12133,7 +12134,12 @@ (define-public gnome-boxes
>             #:phases #~(modify-phases %standard-phases
>                          (add-after 'unpack 
> 'disable-gtk-update-icon-cache
>                            (lambda _
> -                            (setenv "DESTDIR" "/"))))))
> +                            (setenv "DESTDIR" "/")))
> +                        (add-before 'configure 
> 'substitute-qemu-dependencies
> +                          (lambda _
> +                              (substitute* "src/installed-media.vala"
> +                                (("qemu-img")
> +                                 (search-input-file %build-inputs 
> "/bin/qemu-img"))))))))
>      (native-inputs
>       (list desktop-file-utils           ;for update-desktop-database
>             gettext-minimal
> @@ -12141,6 +12147,7 @@ (define-public gnome-boxes
>             itstool
>             pkg-config
>             python
> +           qemu-minimal                 ;for qemu-img
>             vala))
>      (inputs
>       (list glib-networking              ;for TLS support
> --
> 2.37.1
> 

[Message part 2 (text/html, inline)]

[publickey - kreyren@rixotstudio.cz - 1677db82.asc (application/pgp-keys, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #23 received at 57809 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Jacob Hrbek <kreyren <at> rixotstudio.cz>, 57809 <at> debbugs.gnu.org
Subject: Re: [bug#57809] [PATCH] gnome-boxes: Patch 'qemu-img' path
Date: Sun, 18 Sep 2022 23:14:12 +0200

[Message part 1 (text/plain, inline)]

On 18-09-2022 23:05, Jacob Hrbek wrote:
> isn't that going to break if the user invokes `guix cg -D` though?

No, "guix gc" only deletes things that aren't (indirectly) referred to 
by a root (being a garbage collector), and by adding that substitution, 
the compiled gnome-boxes refers to qemu(-minimal).

(Unless the reference is obfuscated, but Vala has a C-like compilation 
model, so I wouldn't expect that.)

> +                              (substitute* "src/installed-media.vala"
> +                                (("qemu-img")
> +                                 (search-input-file %build-inputs "/bin/qemu-img"))))))))

I find (search-input-file inputs "/bin/qemu-img") clearer -- 'inputs' / 
'native-inputs' is sufficiently complicated on its own, no need to bring 
%build-inputs and friends in the equation when it can be avoided.

> +;; NOTE(Krey): src/util-app.vala might need patched paths

(1) the convention is TODO or FIXME, not NOTE
(2) who discovered the potential problem, does not need to be mentioned 
-- there is still "git blame" (which can be used for other things than 
blaming) and "git log" if it turns out to be somehow useful information 
after all (e.g. for attribution).

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #26 received at 57809 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Hrbek <kreyren <at> rixotstudio.cz>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 57809 <at> debbugs.gnu.org
Subject: Re: [bug#57809] [PATCH] gnome-boxes: Patch 'qemu-img' path
Date: Sun, 18 Sep 2022 21:32:29 +0000

[Message part 1 (text/plain, inline)]

On Ne, zář 18 2022 at 23:14:12 +0200, Maxime Devos 
<maximedevos <at> telenet.be> wrote:
> I find (search-input-file inputs "/bin/qemu-img") clearer -- 'inputs' 
> /
> 'native-inputs' is sufficiently complicated on its own, no need to 
> bring
> %build-inputs and friends in the equation when it can be avoided.

That ain't working for me: <https://i.imgur.com/Co4Xsjl.png>

   unbound-variable #f "Unbound variable: ~S" (native-inputs) #f

> (1) the convention is TODO or FIXME, not NOTE

It's not:
- TODO as in "To Do something" or "for something to be done"
- FIXME as in "Low priority thing or quality assurance something that 
needs to be fixed"

More like handing over note to the next guy about possible issue in the 
future and leaving the signature here so that they can just go on chat 
and ask instead of wasting ~3 min on average searching git blame/log 
which gets exponentially more unsustainable to track

At least that's how it works where i work O_o .. personally i find it 
better way than the generic TODO/FIXME

[Message part 2 (text/html, inline)]

[publickey - kreyren@rixotstudio.cz - 1677db82.asc (application/pgp-keys, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #29 received at 57809 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Jacob Hrbek <kreyren <at> rixotstudio.cz>
Cc: 57809 <at> debbugs.gnu.org
Subject: Re: [bug#57809] [PATCH] gnome-boxes: Patch 'qemu-img' path
Date: Sun, 18 Sep 2022 23:50:49 +0200

[Message part 1 (text/plain, inline)]

On 18-09-2022 23:32, Jacob Hrbek wrote:
> On Ne, zář 18 2022 at 23:14:12 +0200, Maxime Devos 
> <maximedevos <at> telenet.be> wrote:
>> I find (search-input-file inputs "/bin/qemu-img") clearer -- 'inputs' 
>> / 'native-inputs' is sufficiently complicated on its own, no need to 
>> bring %build-inputs and friends in the equation when it can be avoided. 
> 
> That ain't working for me: https://i.imgur.com/Co4Xsjl.png 
> <https://i.imgur.com/Co4Xsjl.png>

Quoting the relevant code would be sufficient, no need for image links. 
 Besides, text is more accessible than images of text, text would reach 
a wider audience.

>      unbound-variable #f "Unbound variable: ~S" (native-inputs) #f

(1) 'qemu-minimal' is in the wrong place, it needs to be in 'inputs', 
not 'native-inputs', otherwise it is compiled for the wrong 
architecture. (In both the phase and the inputs/native-inputs field)
(2) 'native-inputs' (or 'inputs'), is unbound.  For information on how 
to use search-input-file, inputs and phases, see the manual, in 
particular (guix)Build Utilities (index entry: search-input-file) and 
its example.

>> (1) the convention is TODO or FIXME, not NOTE  It's not: - TODO as in "To Do something" or "for something to be done" 
> - FIXME as in "Low priority thing or quality assurance something that 
> needs to be fixed"

A missing hardcoded file name can easily be a (usually low-priority) 
bug, so FIXME applies, it's also something to investigate and solve (if 
appropriate), so TODO applies.

> More like handing over note to the next guy about possible issue in the 
> future and leaving the signature here so that they can just go on chat

The required information is already in the "TODO: [stuff about file 
names]", they do not need to go 'on chat', and if they do anyway, 
hardcoding file names is a relatively well-known solution, so I don't 
expect a contact person to be needed.

If that's not sufficient, you can insert an (impersonal) link to the 
Guix issue <https://issues.guix.gnu.org/issue/57809>, which has all the 
relevant information (which is available even when you aren't available 
for chatting, and also when your IRC nick is unknown or if you're gone).

Also, there are no gender restrictions in Guix.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #32 received at 57809 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Hrbek <kreyren <at> rixotstudio.cz>
To: 57809 <at> debbugs.gnu.org
Cc: Jacob Hrbek <kreyren <at> rixotstudio.cz>
Subject: [PATCH] gnome-boxes: Patch 'qemu-img' path
Date: Mon, 19 Sep 2022 04:09:40 +0000

[Message part 1 (text/plain, inline)]

---
 gnu/packages/gnome.scm | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index d6d22f8eb1..ff5cb92907 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -12131,9 +12131,14 @@ (define-public gnome-boxes
                                                     #$output
                                                     "/lib/gnome-boxes"))
            #:phases #~(modify-phases %standard-phases
-                        (add-after 'unpack 'disable-gtk-update-icon-cache
-                          (lambda _
-                            (setenv "DESTDIR" "/"))))))
+                      (add-after 'unpack 'disable-gtk-update-icon-cache
+                        (lambda _
+                          (setenv "DESTDIR" "/")))
+                      (add-before 'configure 'substitute-qemu-dependencies
+                        (lambda* (#:key inputs #:allow-other-keys)
+
                (substitute* "src/installed-media.vala"
+                              (("qemu-img")
+                               (search-input-file inputs "/bin/qemu-img"))))))))
     (native-inputs
      (list desktop-file-utils           ;for update-desktop-database
            gettext-minimal
@@ -12162,6 +12167,7 @@ (define-public gnome-boxes
            sparql-query
            spice-gtk
            tracker
+           qemu-minimal                 ;for qemu-img
            vte
            webkitgtk-with-libsoup2))    ;for webkit2gtk-4.0
     (home-page "https://wiki.gnome.org/Apps/Boxes")
--
2.37.3

[publickey - kreyren@rixotstudio.cz - 1677db82.asc (application/pgp-keys, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #35 received at 57809 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Hrbek <kreyren <at> rixotstudio.cz>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 57809 <at> debbugs.gnu.org
Subject: Re: [bug#57809] [PATCH] gnome-boxes: Patch 'qemu-img' path
Date: Mon, 19 Sep 2022 04:28:26 +0000

[Message part 1 (text/plain, inline)]

>> (2) 'native-inputs' (or 'inputs'), is unbound.  For information on how 

>> to use search-input-file, inputs and phases, see the manual, in particular (guix)Build Utilities (index entry: search-input-file) >> and 

>> its example.

I've been searching through that thing endlessly for almost 5 hours >_> it doesn't help much for that.. I can grep the code to look for usage though which is what I did here ^-^

>> If that's not sufficient, you can insert an (impersonal) link to the 

>> Guix issue

meh, imho takes too much time especially when it's from a newbie like me who needs guidance which adds bunch of useless info to the issue.

>> which has all the 

>> relevant information (which is available even when you aren't available 

>> for chatting, and also when your IRC nick is unknown or if you're gone).

The idea is that people are using chat/client that has chat history and sends notifications so that people can respond quickly or when they are available worst case sending an email..

-- Jacob "Kreyren" Hrbek

------- Original Message -------
On Sunday, September 18th, 2022 at 11:50 PM, Maxime Devos <maximedevos <at> telenet.be> wrote:


> 

> 

> On 18-09-2022 23:32, Jacob Hrbek wrote:
> 

> > On Ne, zář 18 2022 at 23:14:12 +0200, Maxime Devos
> > maximedevos <at> telenet.be wrote:
> > 

> > > I find (search-input-file inputs "/bin/qemu-img") clearer -- 'inputs'
> > > / 'native-inputs' is sufficiently complicated on its own, no need to
> > > bring %build-inputs and friends in the equation when it can be avoided.
> > 

> > That ain't working for me: https://i.imgur.com/Co4Xsjl.png
> > https://i.imgur.com/Co4Xsjl.png
> 

> 

> Quoting the relevant code would be sufficient, no need for image links.
> Besides, text is more accessible than images of text, text would reach
> a wider audience.
> 

> > unbound-variable #f "Unbound variable: ~S" (native-inputs) #f
> 

> 

> (1) 'qemu-minimal' is in the wrong place, it needs to be in 'inputs',
> not 'native-inputs', otherwise it is compiled for the wrong
> architecture. (In both the phase and the inputs/native-inputs field)
> (2) 'native-inputs' (or 'inputs'), is unbound. For information on how
> to use search-input-file, inputs and phases, see the manual, in
> particular (guix)Build Utilities (index entry: search-input-file) and
> its example.
> 

> > > (1) the convention is TODO or FIXME, not NOTE It's not: - TODO as in "To Do something" or "for something to be done"
> > > - FIXME as in "Low priority thing or quality assurance something that
> > > needs to be fixed"
> 

> 

> A missing hardcoded file name can easily be a (usually low-priority)
> bug, so FIXME applies, it's also something to investigate and solve (if
> appropriate), so TODO applies.
> 

> > More like handing over note to the next guy about possible issue in the
> > future and leaving the signature here so that they can just go on chat
> 

> 

> The required information is already in the "TODO: [stuff about file
> names]", they do not need to go 'on chat', and if they do anyway,
> hardcoding file names is a relatively well-known solution, so I don't
> expect a contact person to be needed.
> 

> If that's not sufficient, you can insert an (impersonal) link to the
> Guix issue https://issues.guix.gnu.org/issue/57809, which has all the
> 

> relevant information (which is available even when you aren't available
> for chatting, and also when your IRC nick is unknown or if you're gone).
> 

> Also, there are no gender restrictions in Guix.
> 

> Greetings,
> Maxime.

[publickey - kreyren@rixotstudio.cz - 0x1677DB82.asc (application/pgp-keys, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #38 received at 57809 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Jacob Hrbek <kreyren <at> rixotstudio.cz>
Cc: 57809 <at> debbugs.gnu.org
Subject: Re: [bug#57809] [PATCH] gnome-boxes: Patch 'qemu-img' path
Date: Mon, 19 Sep 2022 15:35:58 +0200

[Message part 1 (text/plain, inline)]

On 19-09-2022 06:28, Jacob Hrbek wrote:
>>> (2) 'native-inputs' (or 'inputs'), is unbound.  For information on how
> 
>>> to use search-input-file, inputs and phases, see the manual, in particular (guix)Build Utilities (index entry: search-input-file) >> and
> 
>>> its example.
> 
> I've been searching through that thing endlessly for almost 5 hours >_> it doesn't help much for that.. I can grep the code to look for usage though which is what I did here ^-^

Here are some proposed methods for finding it, which can be adapted for 
other searches as well.

 * "info guix" followed by 's' 'search-input-file'
   (free-form text search, good for finding examples)
 * "info guix" followed by 'i' 'search-input-file'
   (index entry, works well for procedure names)
 * "info guix" > "Programming Interface" > "Build Utilities", followed
    by some scrolling, then find 'search-input-file' there.
   (using the TOC)

The first two options only take a few seconds.  The latter can be quick 
or long, depending on whether your guess on where it's located is good 
or bad.

And a fourth option, since you seem to like grepping:

 * git grep -F search-input-file doc/
   (in a git checkout of Guix)

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #41 received at 57809 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Jacob Hrbek <kreyren <at> rixotstudio.cz>, 57809 <at> debbugs.gnu.org
Subject: Re: [bug#57809] [PATCH] gnome-boxes: Patch 'qemu-img' path
Date: Mon, 19 Sep 2022 15:41:24 +0200

[Message part 1 (text/plain, inline)]

On 19-09-2022 06:09, Jacob Hrbek wrote:
> +                          (setenv "DESTDIR" "/")))
> +                      (add-before 'configure 'substitute-qemu-dependencies
> +                        (lambda* (#:key inputs #:allow-other-keys)
> +
>                  (substitute* "src/installed-media.vala"
> +                              (("qemu-img")
> +                               (search-input-file inputs "/bin/qemu-img"))))))))

Aside from the indentation (which would IIUC be corrected by "guix 
style", see point (5) of the checklist in "(guix)Submitting Patches")) ...

>       (native-inputs
>        (list desktop-file-utils           ;for update-desktop-database
>              gettext-minimal
> @@ -12162,6 +12167,7 @@ (define-public gnome-boxes
>              sparql-query
>              spice-gtk
>              tracker


> +           qemu-minimal                 ;for qemu-img

... and the non-alphabetical sorting, ...

>              vte
>              webkitgtk-with-libsoup2))    ;for webkit2gtk-4.0

... looks good to me (though to be clear, I did not test the changes), 
though those problems can be addressed by the committer (just a note for 
future submissions).

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #44 received at 57809 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Hrbek <kreyren <at> rixotstudio.cz>
To: 57809 <at> debbugs.gnu.org
Cc: Jacob Hrbek <kreyren <at> rixotstudio.cz>
Subject: [PATCH] gnome-boxes: Fix path for 'qemu-img'
Date: Mon, 19 Sep 2022 21:36:15 +0000

[Message part 1 (text/plain, inline)]

---
 gnu/packages/gnome.scm | 102 ++++++++++++++++++++++-------------------
 1 file changed, 55 insertions(+), 47 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index d6d22f8eb1..65054fc4ac 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -12115,67 +12115,75 @@ (define-public gnome-boxes
   (package
     (name "gnome-boxes")
     (version "42.3")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (string-append "mirror://gnome/sources/gnome-boxes/"
-                           (version-major version) "/"
-                           "gnome-boxes-" version ".tar.xz"))
-       (sha256
-        (base32 "1lv0bdh935qj6wkv3ixg2pcv8yrapj79z02gw4fal3rhz3xggvsn"))))
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://gnome/sources/gnome-boxes/"
+                                  (version-major version)
+                                  "/"
+
             "gnome-boxes-"
+                                  version
+                                  ".tar.xz"))
+              (sha256
+               (base32
+                "1lv0bdh935qj6wkv3ixg2pcv8yrapj79z02gw4fal3rhz3xggvsn"))))
     (build-system meson-build-system)
     (arguments
      (list #:glib-or-gtk? #t
            #:configure-flags #~(list "-Drdp=false"
-                                     (string-append "-Dc_link_args=-Wl,-rpath="
-                                                    #$output
-                                                    "/lib/gnome-boxes"))
+                                     (string-append
+                                      "-Dc_link_args=-Wl,-rpath="
+                                      #$output "/lib/gnome-boxes"))
            #:phases #~(modify-phases %standard-phases
                         (add-after 'unpack 'disable-gtk-update-icon-cache
                           (lambda _
-                            (
setenv "DESTDIR" "/"))))))
-    (native-inputs
-     (list desktop-file-utils           ;for update-desktop-database
-           gettext-minimal
-           `(,glib "bin")               ;for glib-compile-resources
-           itstool
-           pkg-config
-           python
-           vala))
-    (inputs
-     (list glib-networking              ;for TLS support
-           gsettings-desktop-schemas
-           gtk+
-           gtk-vnc
-           gtksourceview
-           json-glib
-           libarchive
-           libgudev
-           libhandy
-           libosinfo
-           libsecret
-           libsoup-minimal-2
-           libusb
-           libvirt
-           libvirt-glib
-           libxml2
-           sparql-query
-           spice-gtk
-           tracker
-           vte
-           webkitgtk-with-libsoup2))    ;for webkit2gtk-4.0
+                            (setenv "DESTDIR" "/")))
+                        (add-before 'configure 'substitut
e-qemu-dependencies
+                          (lambda* (#:key inputs #:allow-other-keys)
+                            (substitute* "src/installed-media.vala"
+                              (("qemu-img")
+                               (search-input-file inputs "/bin/qemu-img"))))))))
+    (native-inputs (list desktop-file-utils ;for update-desktop-database
+                         gettext-minimal
+                         `(,glib "bin") ;for glib-compile-resources
+                         itstool
+                         pkg-config
+                         python
+                         vala))
+    (inputs (list glib-networking ;for TLS support
+                  gsettings-desktop-schemas
+                  gtk+
+                  gtk-vnc
+                  gtksourceview
+                  json-glib
+                  libarchive
+                  libgudev
+                  libhandy
+                  libosinfo
+                  libsecret
+
    libsoup-minimal-2
+                  libusb
+                  libvirt
+                  libvirt-glib
+                  libxml2
+                  qemu-minimal ;for qemu-img
+                  sparql-query
+                  spice-gtk
+                  tracker
+                  vte
+                  webkitgtk-with-libsoup2)) ;for webkit2gtk-4.0
     (home-page "https://wiki.gnome.org/Apps/Boxes")
     (synopsis "View, access, and manage remote and virtual systems")
-    (description "GNOME Boxes is a simple application to view, access, and
+    (description
+     "GNOME Boxes is a simple application to view, access, and
 manage remote and virtual systems.  Note that this application requires the
 @code{libvirt} and @code{virtlog} daemons to run.  Use the command
 @command{info '(guix) Virtualization Services'} to learn how to configure
 these services on the Guix System.")
     (license (list
-              ;; For data/icons/empty-boxes.png.
-
  license:cc-by2.0
-              ;; For all others.
-              license:lgpl2.0+))))
+                   ;; For data/icons/empty-boxes.png.
+                   license:cc-by2.0
+                   ;; For all others.
+                   license:lgpl2.0+))))

 (define-public geary
   (package
--
2.37.3

[publickey - kreyren@rixotstudio.cz - 1677db82.asc (application/pgp-keys, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #47 received at 57809 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Jacob Hrbek <kreyren <at> rixotstudio.cz>, 57809 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnome-boxes: Fix path for 'qemu-img'
Date: Tue, 20 Sep 2022 07:18:59 +0200

Am Montag, dem 19.09.2022 um 21:36 +0000 schrieb Jacob Hrbek:
> ---
>  gnu/packages/gnome.scm | 102 ++++++++++++++++++++++-----------------
> --
Too much noise.  Please separate cosmetic and non-cosmetic changes.

Thanks

Message #50 received at 57809 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Hrbek <kreyren <at> rixotstudio.cz>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 57809 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnome-boxes: Fix path for 'qemu-img'
Date: Tue, 20 Sep 2022 07:55:50 +0000

[Message part 1 (text/plain, inline)]

>> [Krey format the code it looks like trash]

>> [Krey there is too much cosmetic noise it looks like trash]

...

https://issues.guix.gnu.org/57809#9 is the solution

https://issues.guix.gnu.org/57809#13 is the solution + `$ guix style gnome-boxes`

------- Original Message -------
On Tuesday, September 20th, 2022 at 7:18 AM, Liliana Marie Prikler <liliana.prikler <at> gmail.com> wrote:


> Am Montag, dem 19.09.2022 um 21:36 +0000 schrieb Jacob Hrbek:
> 

> > ---
> > gnu/packages/gnome.scm | 102 ++++++++++++++++++++++-----------------
> > --
> 

> Too much noise. Please separate cosmetic and non-cosmetic changes.
> 

> Thanks

[publickey - kreyren@rixotstudio.cz - 0x1677DB82.asc (application/pgp-keys, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #53 received at 57809 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Jacob Hrbek <kreyren <at> rixotstudio.cz>
Cc: 57809 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnome-boxes: Fix path for 'qemu-img'
Date: Tue, 20 Sep 2022 19:12:40 +0200

Am Dienstag, dem 20.09.2022 um 07:55 +0000 schrieb Jacob Hrbek:
> > > [Krey format the code it looks like trash]
> 
> > > [Krey there is too much cosmetic noise it looks like trash]
It is admittedly our fault that we're advertising tools which don't do
their job, but it's not our fault that neither you nor your text editor
know how to match up parentheses with indentation levels.

Message #60 received at 57809-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jacob Hrbek <kreyren <at> rixotstudio.cz>
Cc: 57809-done <at> debbugs.gnu.org
Subject: Re: bug#57809: [PATCH] gnome-boxes: Add 'qemu' as propagated-input
Date: Mon, 26 Sep 2022 23:03:21 +0200

Hi,

Jacob Hrbek <kreyren <at> rixotstudio.cz> skribis:

> ---
>  gnu/packages/gnome.scm | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index d6d22f8eb1..ff5cb92907 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -12131,9 +12131,14 @@ (define-public gnome-boxes
>                                                      #$output
>                                                      "/lib/gnome-boxes"))
>             #:phases #~(modify-phases %standard-phases
> -                        (add-after 'unpack 'disable-gtk-update-icon-cache
> -                          (lambda _
> -                            (setenv "DESTDIR" "/"))))))
> +                      (add-after 'unpack 'disable-gtk-update-icon-cache
> +                        (lambda _
> +                          (setenv "DESTDIR" "/")))
> +                      (add-before 'configure 'substitute-qemu-dependencies
> +                        (lambda* (#:key inputs #:allow-other-keys)
> +
>                 (substitute* "src/installed-media.vala"
> +                              (("qemu-img")
> +                               (search-input-file inputs "/bin/qemu-img"))))))))

Applied with minor tweaks and a commit log, thanks!|

Ludo’.

Message #68 received at 57809 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: Jacob Hrbek <kreyren <at> rixotstudio.cz>, 57809 <at> debbugs.gnu.org
Subject: Re: bug#57809: [PATCH] gnome-boxes: Add 'qemu' as propagated-input
Date: Mon, 26 Sep 2022 23:07:06 +0200

Hey Liliana,

Please let’s not try to find “whose fault it is”.  We’re all trying to
help.

In such a situation, my experience is that it is not only more pleasant
but also more efficient to apply the patch and those remaining tweaks by
yourself so the submitter can see what changes were made and learn from
it.

Thanks in advance,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.