X-Loop: help-debbugs@HIDDEN Subject: bug#57830: [PATCH] testsuite: Remove stray semicolon Resent-From: Marvin Schmidt <marvin.schmidt1987@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-sed@HIDDEN Resent-Date: Thu, 15 Sep 2022 14:37:01 +0000 Resent-Message-ID: <handler.57830.B.16632526054037 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 57830 X-GNU-PR-Package: sed X-GNU-PR-Keywords: patch To: 57830 <at> debbugs.gnu.org Cc: Marvin Schmidt <marv@HIDDEN> X-Debbugs-Original-To: bug-sed@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.16632526054037 (code B ref -1); Thu, 15 Sep 2022 14:37:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Sep 2022 14:36:45 +0000 Received: from localhost ([127.0.0.1]:58823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oYpys-00012y-T5 for submit <at> debbugs.gnu.org; Thu, 15 Sep 2022 10:36:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:51262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <marvin.schmidt1987@HIDDEN>) id 1oYmUQ-0001Hd-1p for submit <at> debbugs.gnu.org; Thu, 15 Sep 2022 06:53:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <marvin.schmidt1987@HIDDEN>) id 1oYmUO-0000xh-7k for bug-sed@HIDDEN; Thu, 15 Sep 2022 06:53:01 -0400 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:45920) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <marvin.schmidt1987@HIDDEN>) id 1oYmUL-0003td-3a for bug-sed@HIDDEN; Thu, 15 Sep 2022 06:52:59 -0400 Received: by mail-ej1-x633.google.com with SMTP id dv25so41131683ejb.12 for <bug-sed@HIDDEN>; Thu, 15 Sep 2022 03:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=XYrKqBuc6u7C8kTpLpOzL+vfaPjpO0/j4goxNBMlBK4=; b=OXbvzjW47/iwevHstvola3CzBpAgw3i2jCObS6TL/kHpmHRv6FuXgc8cMwjAFBs0d+ 3VZ/FgjhDxAS28Pt4uA5bjhzzUYWFNDalgFdADQgjTvWdkT9VI8k47Nerumqj/ZCFdoQ 6U2X3JKEAY9F7FhjSm3MXOIcwtB6lkmZBYHt6NRkIDtIWM4Sf5f1GA8drDs/uYAn7Plw Tm5MDzlCApkEqEs6Ku9xDlb241piobMN0I8PIGpdPwNNDNdNwwRODCz3hoJwy1XM6M+W 7tas9EyF6/YRFcfG2HEv65aT6MzZMg6Y1SEfbls7XB5Gf8IoNg4IN852txdcuqrR5PL4 88Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=XYrKqBuc6u7C8kTpLpOzL+vfaPjpO0/j4goxNBMlBK4=; b=7GZBLmYS12SPwaGvcqppHKB8YoBgA0Wp38iD3ILsJRY5irz8BVY3NkSLObUX5BT6Lo YdasMpnkbgbzMypNddnDejTTM2MEVvX1SzXlQ5jsCnGMvt5QqoseBZp7kfBheJAbOcJ0 vc1pB+qJSCVpsEjnIJOMzUqeUhs72xxbtQ6P0h86rKGCimJNvJ3Q/RsdznMxjM+vHra9 v380EKwhtI47tr4J+wJe8DHS9cLik1YVAgVJMgqY0xmn8/V8kiY15YMfO6f/EFTx3itn QFfJcukDbWg6Wmo+wbCw7+0rHFkQ9dG/palBdnjzdQBxErz4w+xaGEksNg3X0sQBgS55 m+aQ== X-Gm-Message-State: ACgBeo2rb4XfF/hTRQflTR8xWRZr0iVb9SFgC+iF18eVOqpfTowxYLrK im++o/q6/CooZbHCbQn6Z6Jz3OdkzUc= X-Google-Smtp-Source: AA6agR7ZDosWNSCWhFoxyG8VS5T671v3ALkCupQ1kZfNRncgFWzlbXNiHFMVCLfyWA+/THP5AU8eAA== X-Received: by 2002:a17:906:dc8c:b0:74f:25e3:5f81 with SMTP id cs12-20020a170906dc8c00b0074f25e35f81mr27957898ejc.564.1663239173054; Thu, 15 Sep 2022 03:52:53 -0700 (PDT) Received: from pythagoras.local (dynamic-077-006-157-206.77.6.pool.telefonica.de. [77.6.157.206]) by smtp.gmail.com with ESMTPSA id o22-20020aa7c7d6000000b0044e9601e53fsm11414768eds.19.2022.09.15.03.52.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Sep 2022 03:52:52 -0700 (PDT) From: Marvin Schmidt <marvin.schmidt1987@HIDDEN> X-Google-Original-From: Marvin Schmidt <marv@HIDDEN> Date: Thu, 15 Sep 2022 12:52:38 +0200 Message-Id: <20220915105238.923760-1-marv@HIDDEN> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=marvin.schmidt1987@HIDDEN; helo=mail-ej1-x633.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Mailman-Approved-At: Thu, 15 Sep 2022 10:36:40 -0400 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.1 (--) It unintentionally ends the `export` command causing all the following variables not being exported to the test environment I was backporting the alleged fix[1] for the problem that leads to the following failure of the inplace-selinux.sh ``` inplace-selinux.sh: set-up failure: CONFIG_HEADER not defined ``` but the test still failed for me in the same way. Investigating the problem I noticed that some variables from the `TESTS_ENVIRONMENT` weren't present in the test. I then noticed the semicolon in the `built_program=sed;` line and figured that it probably ends the `export` command unintentionally. Looking at the original patch[1] showed that Chris Marusich inserted the ``` CONFIG_HEADER='$(CONFIG_HEADER)' ``` line just above `built_programs=sed;` which explains why it worked for him originally [1] b8f98f7dc363 ("tests: export CONFIG_HEADER to test scripts") [2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36150#16 --- testsuite/local.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuite/local.mk b/testsuite/local.mk index 13e6d004717e..2455af691b86 100644 --- a/testsuite/local.mk +++ b/testsuite/local.mk @@ -160,7 +160,7 @@ TESTS_ENVIRONMENT = \ abs_top_builddir='$(abs_top_builddir)' \ abs_top_srcdir='$(abs_top_srcdir)' \ abs_srcdir='$(abs_srcdir)' \ - built_programs=sed; \ + built_programs=sed \ srcdir='$(srcdir)' \ top_srcdir='$(top_srcdir)' \ CC='$(CC)' \ -- 2.37.3
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Marvin Schmidt <marvin.schmidt1987@HIDDEN> Subject: bug#57830: Acknowledgement ([PATCH] testsuite: Remove stray semicolon) Message-ID: <handler.57830.B.16632526054037.ack <at> debbugs.gnu.org> References: <20220915105238.923760-1-marv@HIDDEN> X-Gnu-PR-Message: ack 57830 X-Gnu-PR-Package: sed X-Gnu-PR-Keywords: patch Reply-To: 57830 <at> debbugs.gnu.org Date: Thu, 15 Sep 2022 14:37:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-sed@HIDDEN If you wish to submit further information on this problem, please send it to 57830 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 57830: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D57830 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.