GNU bug report logs - #57831
[PATCH] testsuite: Remove stray semicolon

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 15 Sep 2022 14:36:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 15 10:36:45 2022
Received: from localhost ([127.0.0.1]:58825 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oYpyu-000134-TM
	for submit <at> debbugs.gnu.org; Thu, 15 Sep 2022 10:36:45 -0400
Received: from lists.gnu.org ([209.51.188.17]:44176)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <marvin.schmidt1987@HIDDEN>) id 1oYoB1-0006De-0l
 for submit <at> debbugs.gnu.org; Thu, 15 Sep 2022 08:41:08 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:50252)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <marvin.schmidt1987@HIDDEN>)
 id 1oYoB0-0005W4-SQ
 for bug-sed@HIDDEN; Thu, 15 Sep 2022 08:41:06 -0400
Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]:33485)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <marvin.schmidt1987@HIDDEN>)
 id 1oYoAz-0003gt-2E
 for bug-sed@HIDDEN; Thu, 15 Sep 2022 08:41:06 -0400
Received: by mail-ej1-x62e.google.com with SMTP id lc7so41929677ejb.0
 for <bug-sed@HIDDEN>; Thu, 15 Sep 2022 05:41:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:from:to:cc:subject:date;
 bh=XYrKqBuc6u7C8kTpLpOzL+vfaPjpO0/j4goxNBMlBK4=;
 b=Mzg2M7gC7E+5V8HXhfQpi/uWe46xIQIG/KGuJfAlCj55T0IqkQSVODBvAwzZ8rbGN8
 kABboa21R6qKvrPz82/q42VN2pPSOyWnYBEFCj+tvJZ51cm3Qvy208wiGaXGbMenKh95
 VARVEQMpIhBJBs9xG9je0gvxUSSMvWQaycy0jiRFMfjvTqhT5uIcH5HU5CWTTV/3TuJq
 59oIsYjwxaX9T461hnM0MDXcAl+FFW80dhxwGti7pUKUDAFVn9xguxaXp9o9MaN1tEHf
 uhUzvI8Hp5F/j1QijYVFgZ43woWKb5aiAbnPergX6087N8md3VLDzgizlFPGi8eXFs5+
 Lqeg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:x-gm-message-state:from:to:cc:subject:date;
 bh=XYrKqBuc6u7C8kTpLpOzL+vfaPjpO0/j4goxNBMlBK4=;
 b=RzskLBADQx3X4K2jWLLsQfDySsunMRQEje7/6dDuBzDf7U6MxIgEgdSdCIFEZ0xLAb
 n4NpWJnQptMDIO7m9XXMIEcwOVgynYVnHONgR7EPhwiOP3Pbz8xRfJH2wV04ISAMd4fZ
 Jg0zQOrcx5UymeP0iEiy0XhRvCVhxCty1uC57D0he1j1ANNhGRU1ynsAwknjQlMLYIor
 Y08IvwLDJ2gmBaBcpfnhRls+3E3Fd50x1wq4iU6emTB4pXZeQsMcWdtle3iUwd/WHYQ/
 cxlyLCD830Q+NI2431qKsL7vK298V6pyA8ZoMGPd3hZK+l8M0Vsw9cZ49xzw3Ln9cNI9
 q+NA==
X-Gm-Message-State: ACgBeo2zke1pIgw9RXOP9wYNT18N6Wer/hht4tjVusGxq0RT0ZA2pe1L
 5WuHWvKIeFwNCSLKl3ZjJHakyatKjoo=
X-Google-Smtp-Source: AA6agR68ct2VxIg5d3VJnd38jGyljhVKmZWLkeX6L+hE7l090KNBCbutOHBJQc0nbWpAdETPfpGSmg==
X-Received: by 2002:a17:907:318b:b0:740:33f2:9e8 with SMTP id
 xe11-20020a170907318b00b0074033f209e8mr28970689ejb.138.1663245663188; 
 Thu, 15 Sep 2022 05:41:03 -0700 (PDT)
Received: from pythagoras.local
 (dynamic-077-006-157-206.77.6.pool.telefonica.de. [77.6.157.206])
 by smtp.gmail.com with ESMTPSA id
 og12-20020a1709071dcc00b0073a644ef803sm9044058ejc.101.2022.09.15.05.41.02
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 15 Sep 2022 05:41:02 -0700 (PDT)
From: Marvin Schmidt <marvin.schmidt1987@HIDDEN>
To: bug-sed@HIDDEN
Subject: [PATCH] testsuite: Remove stray semicolon
Date: Thu, 15 Sep 2022 14:41:00 +0200
Message-Id: <20220915124100.2911375-1-marvin.schmidt1987@HIDDEN>
X-Mailer: git-send-email 2.37.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a00:1450:4864:20::62e;
 envelope-from=marvin.schmidt1987@HIDDEN; helo=mail-ej1-x62e.google.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Thu, 15 Sep 2022 10:36:40 -0400
Cc: Marvin Schmidt <marvin.schmidt1987@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)

It unintentionally ends the `export` command causing all the following
variables not being exported to the test environment

I was backporting the alleged fix[1] for the problem that leads to the
following failure of the inplace-selinux.sh
```
inplace-selinux.sh: set-up failure: CONFIG_HEADER not defined
```
but the test still failed for me in the same way. Investigating the
problem I noticed that some variables from the `TESTS_ENVIRONMENT`
weren't present in the test. I then noticed the semicolon in the
`built_program=sed;` line and figured that it probably ends the `export`
command unintentionally.

Looking at the original patch[1] showed that Chris Marusich inserted the
```
CONFIG_HEADER='$(CONFIG_HEADER)'
```
line just above `built_programs=sed;` which explains why it worked for
him originally

[1] b8f98f7dc363 ("tests: export CONFIG_HEADER to test scripts")
[2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36150#16
---
 testsuite/local.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testsuite/local.mk b/testsuite/local.mk
index 13e6d004717e..2455af691b86 100644
--- a/testsuite/local.mk
+++ b/testsuite/local.mk
@@ -160,7 +160,7 @@ TESTS_ENVIRONMENT =				\
   abs_top_builddir='$(abs_top_builddir)'	\
   abs_top_srcdir='$(abs_top_srcdir)'		\
   abs_srcdir='$(abs_srcdir)'			\
-  built_programs=sed;				\
+  built_programs=sed				\
   srcdir='$(srcdir)'				\
   top_srcdir='$(top_srcdir)'			\
   CC='$(CC)'					\
-- 
2.37.3