GNU bug report logs - #57845
[PATCH] guix: Clarify what CRC is.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57845 in the body.
You can then email your comments to 57845 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: Ludovic Court s <ludo <at> gnu.org>, jgart <jgart <at> dismail.de>
Subject: [PATCH] guix: Clarify what CRC is.
Date: Thu, 15 Sep 2022 20:29:20 -0500

* guix/build-debug-link (Commentary): Clarify that CRC refers to cyclic
redundancy check.
[define-module]: Remove empty line.
---
 guix/build/debug-link.scm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/guix/build/debug-link.scm b/guix/build/debug-link.scm
index 9167737fb3..8fd90d951d 100644
--- a/guix/build/debug-link.scm
+++ b/guix/build/debug-link.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2018 Ludovic Courtès <ludo <at> gnu.org>
+;;; Copyright © 2022 jgart <jgart <at> dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -28,7 +29,6 @@ (define-module (guix build debug-link)
   #:export (debuglink-crc32
             elf-debuglink
             set-debuglink-crc
-
             graft-debug-links))
 
 ;;; Commentary:
@@ -38,10 +38,10 @@ (define-module (guix build debug-link)
 ;;; create separate debug files (info "(gdb) Separate Debug Files").
 ;;;
 ;;; The main facility of this module is 'graft-debug-links', which allows us
-;;; to update the CRC that appears in '.gnu_debuglink' sections when grafting,
-;;; such that separate debug files remain usable after grafting.  Failing to
-;;; do that, GDB would complain about CRC mismatch---see
-;;; <https://bugs.gnu.org/19973>.
+;;; to update the cyclic redundancy check (CRC) that appears in
+;;; '.gnu_debuglink' sections when grafting, such that separate debug files
+;;; remain usable after grafting.  Failing to do that, GDB would complain
+;;; about CRC mismatch---see <https://issues.guix.gnu.org/19973>.
 ;;;
 ;;; Code:
 
-- 
2.37.3

Message #8 received at 57845 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 57845 <at> debbugs.gnu.org
Cc: Ludovic Court s <ludo <at> gnu.org>, jgart <jgart <at> dismail.de>
Subject: [PATCH v2] guix: Clarify what CRC is.
Date: Thu, 15 Sep 2022 20:33:01 -0500

* guix/build-debug-link (Commentary): Clarify that CRC refers to cyclic
redundancy check and fix broken link to issue.
[define-module]: Remove empty line.

Forgot to mention in the commit message that I also fixed the broken
link to the issue.

all best,

jgart
---
 guix/build/debug-link.scm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/guix/build/debug-link.scm b/guix/build/debug-link.scm
index 9167737fb3..8fd90d951d 100644
--- a/guix/build/debug-link.scm
+++ b/guix/build/debug-link.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2018 Ludovic Courtès <ludo <at> gnu.org>
+;;; Copyright © 2022 jgart <jgart <at> dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -28,7 +29,6 @@ (define-module (guix build debug-link)
   #:export (debuglink-crc32
             elf-debuglink
             set-debuglink-crc
-
             graft-debug-links))
 
 ;;; Commentary:
@@ -38,10 +38,10 @@ (define-module (guix build debug-link)
 ;;; create separate debug files (info "(gdb) Separate Debug Files").
 ;;;
 ;;; The main facility of this module is 'graft-debug-links', which allows us
-;;; to update the CRC that appears in '.gnu_debuglink' sections when grafting,
-;;; such that separate debug files remain usable after grafting.  Failing to
-;;; do that, GDB would complain about CRC mismatch---see
-;;; <https://bugs.gnu.org/19973>.
+;;; to update the cyclic redundancy check (CRC) that appears in
+;;; '.gnu_debuglink' sections when grafting, such that separate debug files
+;;; remain usable after grafting.  Failing to do that, GDB would complain
+;;; about CRC mismatch---see <https://issues.guix.gnu.org/19973>.
 ;;;
 ;;; Code:
 
-- 
2.37.3

Message #13 received at 57845-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: jgart <jgart <at> dismail.de>
Cc: 57845-done <at> debbugs.gnu.org
Subject: Re: bug#57845: [PATCH] guix: Clarify what CRC is.
Date: Mon, 26 Sep 2022 23:11:35 +0200

Hi,

jgart <jgart <at> dismail.de> skribis:

> * guix/build-debug-link (Commentary): Clarify that CRC refers to cyclic
> redundancy check and fix broken link to issue.
> [define-module]: Remove empty line.
>
> Forgot to mention in the commit message that I also fixed the broken
> link to the issue.
>
> all best,
>
> jgart

Applied, but without the copyright line (expanding those three letters
is not copyrightable) and without the blank line removal (it’s here on
purpose to separate different levels of the interface).

BTW, the original bug URL is not “broken”: the page is just less
pleasant to the eye.  :-)

Thanks,
Ludo’.

Message #16 received at 57845-done <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 57845-done <at> debbugs.gnu.org
Subject: Re: bug#57845: [PATCH] guix: Clarify what CRC is.
Date: Tue, 27 Sep 2022 11:02:34 -0500

On Mon, 26 Sep 2022 23:11:35 +0200 Ludovic Courtès <ludo <at> gnu.org> wrote:

Thanks! No worries

all best,

jgart

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.