GNU bug report logs - #57846
[PATCH] Update Unicode Support to Unicode Version 15.0.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57846 in the body.
You can then email your comments to 57846 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Update Unicode Support to Unicode Version 15.0.0.
Date: Fri, 16 Sep 2022 07:16:04 +0530

[Message part 1 (text/plain, inline)]

If something is wrong with this patch please tell me.

Thanks.

[Message part 2 (text/html, inline)]

[0001-Update-Unicode-support-to-Unicode-version-15.0.0.patch (text/x-patch, attachment)]

Message #8 received at 57846 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 57846 <at> debbugs.gnu.org
Subject: Re: bug#57846: [PATCH] Update Unicode Support to Unicode Version
 15.0.0.
Date: Fri, 16 Sep 2022 10:18:43 +0300

> From: समीर सिंह Sameer Singh
>  <lumarzeli30 <at> gmail.com>
> Date: Fri, 16 Sep 2022 07:16:04 +0530
> 
> If something is wrong with this patch please tell me.

Thank you for working on this.

> diff --git a/admin/unidata/blocks.awk b/admin/unidata/blocks.awk
> index 1c571feff3..ccfe452ceb 100755
> --- a/admin/unidata/blocks.awk
> +++ b/admin/unidata/blocks.awk
> @@ -118,6 +118,9 @@ function name2alias(name   , w, w2) {
>      else if (name ~ /sutton signwriting/) return "sutton-sign-writing"
>      else if (name ~ /sinhala archaic number/) return "sinhala"
>      else if (name ~ /tangut components/) return "tangut"
> +    else if (name ~ /kawi/) return "kawi"
> +    else if (name ~ /nag mundari/) return "nag-mundari"

Are these two additions really needed?  The first one is just a
literal copy, and the second one is a trivial transformation that's
supposed to be handled by this rule:

    gsub(/ /, "-", name)

Am I missing something?

Other than that, LGTM.

Message #11 received at 57846 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 57846 <at> debbugs.gnu.org
Subject: Re: bug#57846: [PATCH] Update Unicode Support to Unicode Version
 15.0.0.
Date: Fri, 16 Sep 2022 09:37:18 +0200

>>>>> On Fri, 16 Sep 2022 07:16:04 +0530, समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com> said:

    समीर> If something is wrong with this patch please tell me.
    समीर> Thanks.

I looked at it quickly, but havenʼt tested it. The only thing I saw
that Iʼm not sure about is that kaktovik-numeral is not in
`otf-script-alist´, but that may be entirely normal. (and Unicode
added a few spurious newlines in some of the files, but that doesnʼt
really matter)

Thanks for doing this

Robert

-- 

Message #14 received at 57846 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 57846 <at> debbugs.gnu.org
Subject: Re: bug#57846: [PATCH] Update Unicode Support to Unicode Version
 15.0.0.
Date: Fri, 16 Sep 2022 17:35:31 +0530

[Message part 1 (text/plain, inline)]

>
> Are these two additions really needed?  The first one is just a
> literal copy, and the second one is a trivial transformation that's
> supposed to be handled by this rule:
>
>     gsub(/ /, "-", name)
>
> Am I missing something?
>
> Other than that, LGTM.


I have removed them.

Thanks

On Fri, Sep 16, 2022 at 12:48 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh
> >  <lumarzeli30 <at> gmail.com>
> > Date: Fri, 16 Sep 2022 07:16:04 +0530
> >
> > If something is wrong with this patch please tell me.
>
> Thank you for working on this.
>
> > diff --git a/admin/unidata/blocks.awk b/admin/unidata/blocks.awk
> > index 1c571feff3..ccfe452ceb 100755
> > --- a/admin/unidata/blocks.awk
> > +++ b/admin/unidata/blocks.awk
> > @@ -118,6 +118,9 @@ function name2alias(name   , w, w2) {
> >      else if (name ~ /sutton signwriting/) return "sutton-sign-writing"
> >      else if (name ~ /sinhala archaic number/) return "sinhala"
> >      else if (name ~ /tangut components/) return "tangut"
> > +    else if (name ~ /kawi/) return "kawi"
> > +    else if (name ~ /nag mundari/) return "nag-mundari"
>
> Are these two additions really needed?  The first one is just a
> literal copy, and the second one is a trivial transformation that's
> supposed to be handled by this rule:
>
>     gsub(/ /, "-", name)
>
> Am I missing something?
>
> Other than that, LGTM.
>

[Message part 2 (text/html, inline)]

[0001-Update-Unicode-support-to-Unicode-version-15.0.0.patch (text/x-patch, attachment)]

Message #17 received at 57846 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 57846 <at> debbugs.gnu.org
Subject: Re: bug#57846: [PATCH] Update Unicode Support to Unicode Version
 15.0.0.
Date: Fri, 16 Sep 2022 17:37:19 +0530

[Message part 1 (text/plain, inline)]

>
> I looked at it quickly, but havenʼt tested it. The only thing I saw
> that Iʼm not sure about is that kaktovik-numeral is not in
> `otf-script-alist´, but that may be entirely normal. (and Unicode
> added a few spurious newlines in some of the files, but that doesnʼt
> really matter)


It is not mentioned in the microsoft script tags website:
https://docs.microsoft.com/en-us/typography/opentype/otspec191alpha/scripttags_delta

Thanks

On Fri, Sep 16, 2022 at 1:07 PM Robert Pluim <rpluim <at> gmail.com> wrote:

> >>>>> On Fri, 16 Sep 2022 07:16:04 +0530, समीर सिंह Sameer Singh <
> lumarzeli30 <at> gmail.com> said:
>
>     समीर> If something is wrong with this patch please tell me.
>     समीर> Thanks.
>
> I looked at it quickly, but havenʼt tested it. The only thing I saw
> that Iʼm not sure about is that kaktovik-numeral is not in
> `otf-script-alist´, but that may be entirely normal. (and Unicode
> added a few spurious newlines in some of the files, but that doesnʼt
> really matter)
>
> Thanks for doing this
>
> Robert
>
> --
>

[Message part 2 (text/html, inline)]

Message #20 received at 57846 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: rpluim <at> gmail.com, 57846 <at> debbugs.gnu.org
Subject: Re: bug#57846: [PATCH] Update Unicode Support to Unicode Version
 15.0.0.
Date: Fri, 16 Sep 2022 15:15:26 +0300

> Cc: 57846 <at> debbugs.gnu.org
> From: समीर सिंह Sameer Singh
>  <lumarzeli30 <at> gmail.com>
> Date: Fri, 16 Sep 2022 17:37:19 +0530
> 
>  I looked at it quickly, but havenʼt tested it. The only thing I saw
>  that Iʼm not sure about is that kaktovik-numeral is not in
>  `otf-script-alist´, but that may be entirely normal. (and Unicode
>  added a few spurious newlines in some of the files, but that doesnʼt
>  really matter)
> 
> It is not mentioned in the microsoft script tags website:
> https://docs.microsoft.com/en-us/typography/opentype/otspec191alpha/scripttags_delta

Their updates are not in sync with Unicode releases, so it's a small
wonder.

Message #23 received at 57846 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: rpluim <at> gmail.com, 57846 <at> debbugs.gnu.org
Subject: Re: bug#57846: [PATCH] Update Unicode Support to Unicode Version
 15.0.0.
Date: Fri, 16 Sep 2022 17:50:54 +0530

[Message part 1 (text/plain, inline)]

>
> Their updates are not in sync with Unicode releases, so it's a small
> wonder.


kawi and nag mundari are present there, I also could not see other numerals
such as Aegean Numerals, Mayan Numerals etc,
so maybe Numerals are not included there.

On Fri, Sep 16, 2022 at 5:45 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > Cc: 57846 <at> debbugs.gnu.org
> > From: समीर सिंह Sameer Singh
> >  <lumarzeli30 <at> gmail.com>
> > Date: Fri, 16 Sep 2022 17:37:19 +0530
> >
> >  I looked at it quickly, but havenʼt tested it. The only thing I saw
> >  that Iʼm not sure about is that kaktovik-numeral is not in
> >  `otf-script-alist´, but that may be entirely normal. (and Unicode
> >  added a few spurious newlines in some of the files, but that doesnʼt
> >  really matter)
> >
> > It is not mentioned in the microsoft script tags website:
> >
> https://docs.microsoft.com/en-us/typography/opentype/otspec191alpha/scripttags_delta
>
> Their updates are not in sync with Unicode releases, so it's a small
> wonder.
>

[Message part 2 (text/html, inline)]

Message #28 received at 57846-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 57846-done <at> debbugs.gnu.org
Subject: Re: bug#57846: [PATCH] Update Unicode Support to Unicode Version
 15.0.0.
Date: Sat, 17 Sep 2022 09:53:18 +0300

> From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> Date: Fri, 16 Sep 2022 17:35:31 +0530
> Cc: 57846 <at> debbugs.gnu.org
> 
>  Are these two additions really needed?  The first one is just a
>  literal copy, and the second one is a trivial transformation that's
>  supposed to be handled by this rule:
> 
>      gsub(/ /, "-", name)
> 
>  Am I missing something?
> 
>  Other than that, LGTM.
> 
> I have removed them.

Thanks, I installed the changeset.

In the future, please don't forget to mention the bug number in the
commit log message.

Thanks again for doing this.

Message #31 received at 57846-done <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 57846-done <at> debbugs.gnu.org
Subject: Re: bug#57846: [PATCH] Update Unicode Support to Unicode Version
 15.0.0.
Date: Sat, 17 Sep 2022 12:39:57 +0530

[Message part 1 (text/plain, inline)]

>
> Thanks, I installed the changeset.


Great, thanks!

In the future, please don't forget to mention the bug number in the
> commit log message.
>

I forgot about that 😬, will keep in mind for the future.


On Sat, Sep 17, 2022 at 12:23 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> > Date: Fri, 16 Sep 2022 17:35:31 +0530
> > Cc: 57846 <at> debbugs.gnu.org
> >
> >  Are these two additions really needed?  The first one is just a
> >  literal copy, and the second one is a trivial transformation that's
> >  supposed to be handled by this rule:
> >
> >      gsub(/ /, "-", name)
> >
> >  Am I missing something?
> >
> >  Other than that, LGTM.
> >
> > I have removed them.
>
> Thanks, I installed the changeset.
>
> In the future, please don't forget to mention the bug number in the
> commit log message.
>
> Thanks again for doing this.
>

[Message part 2 (text/html, inline)]

Message #34 received at 57846 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: lumarzeli30 <at> gmail.com
Cc: 57846 <at> debbugs.gnu.org
Subject: Re: bug#57846: [PATCH] Update Unicode Support to Unicode Version
 15.0.0.
Date: Sat, 17 Sep 2022 10:24:35 +0300

> Resent-To: bug-gnu-emacs <at> gnu.org
> Cc: 57846-done <at> debbugs.gnu.org
> Date: Sat, 17 Sep 2022 09:53:18 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> Thanks, I installed the changeset.

Btw, you forgot to include src/macuvs.h in the changeset.  It's
sometimes updated by importing new Unicode files, and should be
installed if so.

I've pushed the updated file now.

Message #37 received at 57846 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 57846 <at> debbugs.gnu.org
Subject: Re: bug#57846: [PATCH] Update Unicode Support to Unicode Version
 15.0.0.
Date: Sat, 17 Sep 2022 13:02:13 +0530

[Message part 1 (text/plain, inline)]

>
> Btw, you forgot to include src/macuvs.h in the changeset.  It's
> sometimes updated by importing new Unicode files, and should be
> installed if so.
>

It wasn't committed last year for unicode 14, so I figured it wasn't
necessary, should have asked instead.

Thanks

On Sat, Sep 17, 2022 at 12:54 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > Resent-To: bug-gnu-emacs <at> gnu.org
> > Cc: 57846-done <at> debbugs.gnu.org
> > Date: Sat, 17 Sep 2022 09:53:18 +0300
> > From: Eli Zaretskii <eliz <at> gnu.org>
> >
> > Thanks, I installed the changeset.
>
> Btw, you forgot to include src/macuvs.h in the changeset.  It's
> sometimes updated by importing new Unicode files, and should be
> installed if so.
>
> I've pushed the updated file now.
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.