GNU bug report logs - #57857
[PATCH] gnu: busybox: fix the cross build.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57857 in the body.
You can then email your comments to 57857 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 路辉 <luhux76 <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: busybox: fix the cross build.
Date: Fri, 16 Sep 2022 12:35:04 +0000

[Message part 1 (text/plain, inline)]

[0001-gnu-busybox-fix-the-cross-build.patch (text/x-patch, attachment)]

Message #8 received at 57857 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: 路辉 <luhux76 <at> gmail.com>, 57857 <at> debbugs.gnu.org
Subject: Re: [bug#57857] [PATCH] gnu: busybox: fix the cross build.
Date: Fri, 16 Sep 2022 17:08:33 +0200

[Message part 1 (text/plain, inline)]

On 16-09-2022 14:35, 路辉 wrote:
> 


+             (if tests?
+                 (apply invoke "make"
+                        ;; "V=1"
+                        "SKIP_KNOWN_BUGS=1"
+                        "SKIP_INTERNET_TESTS=1"
+                        "check" make-flags)
+                 #t)))

Can be simplified to

(when tests?
  (apply invoke "make"
          ;; "V=1"
          "SKIP_KNOWN_BUGS=1"
          "SKIP_INTERNET_TESTS=1"
          "check" make-flags))


+     `(#:tests? (if ,(%current-target-system) #f #t)

That's the default, no need to mention it again here.

+       #:make-flags
+       (let ((target ,(%current-target-system)))
+         (if target
+             (list (string-append "CROSS_COMPILE=" target "-"))
+             (list)))

Can be simplified:

#:make-flags
,(let ((target ,(%current-target-system)))
   (if target
       #~(list (string-append "CROSS_COMPILE=" ,target))
       #~'()))

(the #~ makes the phasing more explicit, if you go for that, I recommend 
turning the arguments into (arguments (list #:phases #~(modify-phases 
...) #:make-flags ...)), instead of using ` / , , to remain consistent.)

Greetings,
Maxime

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #11 received at 57857 <at> debbugs.gnu.org (full text, mbox):

From: 路辉 <luhux76 <at> gmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 57857 <at> debbugs.gnu.org
Subject: Re: [bug#57857] [PATCH] gnu: busybox: fix the cross build.
Date: Fri, 16 Sep 2022 15:53:14 +0000

[Message part 1 (text/plain, inline)]

2022-09-16 15:08 GMT, Maxime Devos <maximedevos <at> telenet.be>:
>
>
> On 16-09-2022 14:35, 路辉 wrote:
>>
>
>
> +             (if tests?
> +                 (apply invoke "make"
> +                        ;; "V=1"
> +                        "SKIP_KNOWN_BUGS=1"
> +                        "SKIP_INTERNET_TESTS=1"
> +                        "check" make-flags)
> +                 #t)))
>
> Can be simplified to
>
> (when tests?
>    (apply invoke "make"
>            ;; "V=1"
>            "SKIP_KNOWN_BUGS=1"
>            "SKIP_INTERNET_TESTS=1"
>            "check" make-flags))
>
>
> +     `(#:tests? (if ,(%current-target-system) #f #t)
>
> That's the default, no need to mention it again here.
>
> +       #:make-flags
> +       (let ((target ,(%current-target-system)))
> +         (if target
> +             (list (string-append "CROSS_COMPILE=" target "-"))
> +             (list)))
>
> Can be simplified:
>
> #:make-flags
> ,(let ((target ,(%current-target-system)))
>     (if target
>         #~(list (string-append "CROSS_COMPILE=" ,target))
>         #~'()))
>
> (the #~ makes the phasing more explicit, if you go for that, I recommend
> turning the arguments into (arguments (list #:phases #~(modify-phases
> ...) #:make-flags ...)), instead of using ` / , , to remain consistent.)
>
> Greetings,
> Maxime
>

new patch vvvv

[0001-gnu-busybox-fix-the-cross-build.patch (text/x-patch, attachment)]

Message #14 received at 57857 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: 路辉 <luhux76 <at> gmail.com>
Cc: 57857 <at> debbugs.gnu.org
Subject: Re: [bug#57857] [PATCH] gnu: busybox: fix the cross build.
Date: Sun, 25 Sep 2022 19:55:35 +0200

[Message part 1 (text/plain, inline)]

On 16-09-2022 17:53, 路辉 wrote:
>> Can be simplified:
>>
>> #:make-flags
>> ,(let ((target ,(%current-target-system)))

Oops the , before (%current-target-system) shouldn't be there

>>      (if target
>>          #~(list (string-append "CROSS_COMPILE=" ,target))

OOps, ,target -> #$target

>>          #~'()))
>>
>> (the #~ makes the phasing more explicit, if you go for that, I recommend
>> turning the arguments into (arguments (list #:phases #~(modify-phases
>> ...) #:make-flags ...)), instead of using ` / , , to remain consistent.)
>>
>> Greetings,
>> Maxime
>>
> 
> new patch vvvv

The #:make-flags simplification is missing (it can help with avoiding 
rebuilds (e.g. if a particular architecture needs some different 
#:make-flags than usual), but otherwise looks good.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #19 received at 57857-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: 路辉 <luhux76 <at> gmail.com>
Cc: 57857-done <at> debbugs.gnu.org, Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: bug#57857: [PATCH] gnu: busybox: fix the cross build.
Date: Mon, 26 Sep 2022 23:27:57 +0200

Hi,

路辉 <luhux76 <at> gmail.com> skribis:

> * gnu/packages/busybox.scm (busybox): fix cross build

Applied!  Thank you and thanks Maxime for reviewing.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.