GNU bug report logs - #57864
rust-zstd-sys bundles zstd

Previous Next

To reply to this bug, email your comments to 57864 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: bug-guix <bug-guix <at> gnu.org>
Subject: rust-zstd-sys bundles zstd
Date: Fri, 16 Sep 2022 16:58:19 +0200

[Message part 1 (text/plain, inline)]

X-Debbugs-CC: Arun Isaac <arunisaac <at> systemreboot.net>

^ author of the commit adding the rust-zstd-sys

I noticed that the package 'rust-zstd-sys' bundles a copy of zstd.  This 
is against policy for the reasons documented in the manual.  This 
package was added in commit 4402eb48cdd18aed8072696496362f2e774e973f.

I'll try unbundling it in antioxidant.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #8 received at 57864 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: 57864 <at> debbugs.gnu.org
Cc: arun isaac <arunisaac <at> systemreboot.net>
Subject: Re: rust-zstd-sys bundles zstd
Date: Fri, 16 Sep 2022 18:47:22 +0200

[Message part 1 (text/plain, inline)]

Solved as follows in antioxidant (i.e., enable the 'pkg-config' feature 
and remove the local copy in a snippet).

diff --git a/antioxidant-packages.scm b/antioxidant-packages.scm
index e851bc9..b0296e7 100644
--- a/antioxidant-packages.scm
+++ b/antioxidant-packages.scm
@@ -4708,6 +4708,7 @@ RFC-compliant `EmailAddress` newtype. ")
     ;; rust-num-bigint-dig's zeroize feature requires the "derive"
     ;; feature of rust-zeroize
     ("rust-zeroize" ,#~'("default" "derive"))
+    ("rust-zstd-sys" ,#~'("default" "pkg-config" "non-cargo"))
     ("rust-zip" ,#~'("bzip2" "deflate" "time" "zstd")))) ; avoid 
default "aes-crypto" feature, which requiers an ol

 (define %replacements
@@ -5748,6 +5749,8 @@ RFC-compliant `EmailAddress` newtype. ")
      (("rust-parking-lot" ,(p rust-parking-lot-0.11)))) ; test input
     ("rust-zip" ; new inputs for new version
      (("rust-zstd" ,(p rust-zstd-0.9))))
+    ("rust-zstd-sys"
+     (("zstd:lib" ,(@ (gnu packages compression) zstd) "lib")))
     ("sniffglue" (("rust-bstr" ,(@ (gnu packages crates-io) 
rust-bstr-0.2))))))

 (define %no-parallel-tests?
@@ -6628,6 +6631,14 @@ RFC-compliant `EmailAddress` newtype. ")
               (inherit (package-source pack))
               (modules '((guix build utils)))
               (snippet #~(delete-file-recursively "source"))))
+            ("rust-zstd-sys"
+             ;; Unbundle zstd
+             (origin
+              (inherit (package-source pack))
+              (modules '((guix build utils)))
+              (snippet #~(begin
+                           (delete-file-recursively "zstd")
+                           (delete-file "zstd.h")))))
             ("rust-itoa"
              (origin
               (inherit (package-source pack))

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #11 received at 57864 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Maxime Devos <maximedevos <at> telenet.be>, 57864 <at> debbugs.gnu.org
Subject: Re: bug#57864: rust-zstd-sys bundles zstd
Date: Mon, 26 Sep 2022 00:24:36 +0530

Hi Maxime,

> X-Debbugs-CC: Arun Isaac <arunisaac <at> systemreboot.net>
>
> ^ author of the commit adding the rust-zstd-sys
>
> I noticed that the package 'rust-zstd-sys' bundles a copy of zstd.  This 
> is against policy for the reasons documented in the manual.  This 
> package was added in commit 4402eb48cdd18aed8072696496362f2e774e973f.
>
> I'll try unbundling it in antioxidant.

Sorry for the trouble. Thanks for working on this!

Regards,
Arun

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.