GNU bug report logs - #57870
27.1; vc-tor has no effect

Previous Next

Package: emacs;

Reported by: Sean Whitton <spwhitton <at> spwhitton.name>

Date: Fri, 16 Sep 2022 23:23:01 UTC

Severity: normal

Tags: patch

Found in version 27.1

Done: Sean Whitton <spwhitton <at> spwhitton.name>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57870 in the body.
You can then email your comments to 57870 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#57870; Package emacs. (Fri, 16 Sep 2022 23:23:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Sean Whitton <spwhitton <at> spwhitton.name>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 16 Sep 2022 23:23:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.1; vc-tor has no effect
Date: Fri, 16 Sep 2022 16:22:04 -0700

[Message part 1 (text/plain, inline)]
Hello,

From reading vc-do-command, it looks to me that the vc-tor defcustom has
never actually had any effect on the commands that are run.  The
full-command variable is used only in messages displayed to the user.

If someone else could verify this, I'll push the attached.  This is
blocking my work on #57807.  Thanks.

-- 
Sean Whitton

[0001-vc-do-command-Actually-include-torsocks-in-the-comma.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#57870; Package emacs. (Sat, 17 Sep 2022 14:29:02 GMT) Full text and rfc822 format available.

Message #8 received at 57870 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: 57870 <at> debbugs.gnu.org
Subject: Re: bug#57870: 27.1; vc-tor has no effect
Date: Sat, 17 Sep 2022 14:28:10 +0000

Sean Whitton <spwhitton <at> spwhitton.name> writes:

> Hello,
>
>>From reading vc-do-command, it looks to me that the vc-tor defcustom has
> never actually had any effect on the commands that are run.  The
> full-command variable is used only in messages displayed to the user.
>
> If someone else could verify this, I'll push the attached.  This is
> blocking my work on #57807.  Thanks.

I've just tried it out and it seems to do the right thing.
Added tag(s) patch. Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Sat, 17 Sep 2022 16:38:01 GMT) Full text and rfc822 format available.
Reply sent to Sean Whitton <spwhitton <at> spwhitton.name>:
You have taken responsibility. (Sun, 18 Sep 2022 01:02:02 GMT) Full text and rfc822 format available.
Notification sent to Sean Whitton <spwhitton <at> spwhitton.name>:
bug acknowledged by developer. (Sun, 18 Sep 2022 01:02:02 GMT) Full text and rfc822 format available.

Message #15 received at 57870-done <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Philip Kaludercic <philipk <at> posteo.net>, 57870-done <at> debbugs.gnu.org
Subject: Re: bug#57870: 27.1; vc-tor has no effect
Date: Sat, 17 Sep 2022 18:01:46 -0700

Hello,

On Sat 17 Sep 2022 at 02:28PM GMT, Philip Kaludercic wrote:

> Sean Whitton <spwhitton <at> spwhitton.name> writes:
>
>> Hello,
>>
>>>From reading vc-do-command, it looks to me that the vc-tor defcustom has
>> never actually had any effect on the commands that are run.  The
>> full-command variable is used only in messages displayed to the user.
>>
>> If someone else could verify this, I'll push the attached.  This is
>> blocking my work on #57807.  Thanks.
>
> I've just tried it out and it seems to do the right thing.

Thanks for reviewing!

-- 
Sean Whitton
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 16 Oct 2022 11:24:08 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 192 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.