GNU bug report logs - #57871
[PATCH] ideviceinstaller: new package

Previous Next

Package: guix-patches;

Reported by: Jacob Hrbek <kreyren <at> rixotstudio.cz>

Date: Fri, 16 Sep 2022 23:42:02 UTC

Severity: normal

Tags: patch

Done: Julien Lepiller <julien <at> lepiller.eu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57871 in the body.
You can then email your comments to 57871 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#57871; Package guix-patches. (Fri, 16 Sep 2022 23:42:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jacob Hrbek <kreyren <at> rixotstudio.cz>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 16 Sep 2022 23:42:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jacob Hrbek <kreyren <at> rixotstudio.cz>
To: guix-patches <at> gnu.org
Cc: Jacob Hrbek <kreyren <at> rixotstudio.cz>
Subject: [PATCH] ideviceinstaller: new package
Date: Fri, 16 Sep 2022 23:41:07 +0000
[Message part 1 (text/plain, inline)]
---
 gnu/packages/libusb.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/libusb.scm b/gnu/packages/libusb.scm
index 8a5967f7b4..08206fd87c 100644
--- a/gnu/packages/libusb.scm
+++ b/gnu/packages/libusb.scm
@@ -41,6 +41,7 @@ (define-module (gnu packages libusb)
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system python)
   #:use-module (gnu packages autotools)
+  #:use-module (gnu packages compression)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages java)
@@ -339,6 +340,28 @@ (define-public python-capablerobot-usbhub
 I2C and SPI devices attached to the USB Hub.")
     (license license:expat)))

+(define-public ideviceinstaller
+  (package
+    (name "ideviceinstaller")
+    (version "1.1.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/libimobiledevice/ideviceinstaller/rele
ases/download/" version
+                           "/ideviceinstaller-" version ".tar.bz2"))
+       (sha256
+        (base32 "0qrhdhcxd9x901g2zq3znvrfjhy8hcdp17xkm8aq3y7jjzn87f6y"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     (list pkg-config ; >=0.9.0
+           libimobiledevice ; >=1.3.0
+           libzip ; >=0.10
+           ))
+    (home-page "https://libimobiledevice.org/")
+    (synopsis "CLI Tool to manage apps and app archives on iOS devices")
+    (description "This package provides an interface to manage IPA format files and applications for iOS devices, it's written in C")
+    (license license:gpl2)))
+
 (define-public libplist
   (package
     (name "libplist")
--
2.37.1

[publickey - kreyren@rixotstudio.cz - 1677db82.asc (application/pgp-keys, attachment)]
[signature.asc (application/pgp-signature, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#57871; Package guix-patches. (Fri, 16 Sep 2022 23:47:02 GMT) Full text and rfc822 format available.

Message #8 received at 57871 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Hrbek <kreyren <at> rixotstudio.cz>
To: 57871 <at> debbugs.gnu.org
Subject: Re: bug#57871: Acknowledgement ([PATCH] ideviceinstaller: new package)
Date: Fri, 16 Sep 2022 23:45:45 +0000
[Message part 1 (text/plain, inline)]
heads-up: 
<https://github.com/libimobiledevice/ideviceinstaller/issues/147>

On Pá, zář 16 2022 at 23:42:02 +0000, help-debbugs <at> gnu.org wrote:
> Thank you for filing a new bug report with debbugs.gnu.org.
> 
> This is an automatically generated reply to let you know your message
> has been received.
> 
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
> 
> Your message has been sent to the package maintainer(s):
>  guix-patches <at> gnu.org <mailto:guix-patches <at> gnu.org>
> 
> If you wish to submit further information on this problem, please
> send it to 57871 <at> debbugs.gnu.org <mailto:57871 <at> debbugs.gnu.org>.
> 
> Please do not send mail to help-debbugs <at> gnu.org 
> <mailto:help-debbugs <at> gnu.org> unless you wish
> to report a problem with the Bug-tracking system.
> 
> --
> 57871: <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57871>
> GNU Bug Tracking System
> Contact help-debbugs <at> gnu.org <mailto:help-debbugs <at> gnu.org> with 
> problems

[Message part 2 (text/html, inline)]
[publickey - kreyren@rixotstudio.cz - 1677db82.asc (application/pgp-keys, attachment)]
[signature.asc (application/pgp-signature, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#57871; Package guix-patches. (Fri, 16 Sep 2022 23:48:02 GMT) Full text and rfc822 format available.

Message #11 received at 57871 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Hrbek <kreyren <at> rixotstudio.cz>
To: 57871 <at> debbugs.gnu.org
Subject: Re: bug#57871: Acknowledgement ([PATCH] ideviceinstaller: new package)
Date: Fri, 16 Sep 2022 23:47:37 +0000
[Message part 1 (text/plain, inline)]
build log

On Pá, zář 16 2022 at 23:45:45 +0000, Jacob Hrbek 
<kreyren <at> rixotstudio.cz> wrote:
> heads-up: 
> <https://github.com/libimobiledevice/ideviceinstaller/issues/147>
> 
> On Pá, zář 16 2022 at 23:42:02 +0000, help-debbugs <at> gnu.org wrote:
>> Thank you for filing a new bug report with debbugs.gnu.org.
>> 
>> This is an automatically generated reply to let you know your message
>> has been received.
>> 
>> Your message is being forwarded to the package maintainers and other
>> interested parties for their attention; they will reply in due 
>> course.
>> 
>> Your message has been sent to the package maintainer(s):
>>  guix-patches <at> gnu.org <mailto:guix-patches <at> gnu.org>
>> 
>> If you wish to submit further information on this problem, please
>> send it to 57871 <at> debbugs.gnu.org <mailto:57871 <at> debbugs.gnu.org>.
>> 
>> Please do not send mail to help-debbugs <at> gnu.org 
>> <mailto:help-debbugs <at> gnu.org> unless you wish
>> to report a problem with the Bug-tracking system.
>> 
>> --
>> 57871: <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57871>
>> GNU Bug Tracking System
>> Contact help-debbugs <at> gnu.org <mailto:help-debbugs <at> gnu.org> with 
>> problems

[Message part 2 (text/html, inline)]
[build.log (text/x-log, attachment)]
[publickey - kreyren@rixotstudio.cz - 1677db82.asc (application/pgp-keys, attachment)]
[signature.asc (application/pgp-signature, attachment)]

Reply sent to Julien Lepiller <julien <at> lepiller.eu>:
You have taken responsibility. (Thu, 22 Sep 2022 05:46:01 GMT) Full text and rfc822 format available.

Notification sent to Jacob Hrbek <kreyren <at> rixotstudio.cz>:
bug acknowledged by developer. (Thu, 22 Sep 2022 05:46:02 GMT) Full text and rfc822 format available.

Message #16 received at 57871-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: Jacob Hrbek <kreyren <at> rixotstudio.cz>
Cc: 57871-done <at> debbugs.gnu.org
Subject: Re: [bug#57871] [PATCH] ideviceinstaller: new package
Date: Thu, 22 Sep 2022 07:44:54 +0200
Pushed to master as 04cad8e29ed85be838921c7fa05f7c5bce94b6d1.

I had to change a few things in the final patch:

First of all, please run "guix lint" on your future submissions, so you
can fix some of these issues beforehand.

I changed the source to look directly for the git repository: the
tarballs at github are not always stable, which might break the
package, and a git source is easier to archive in Software Heritage.

I also wrapped a long line in the description, and removed your
comments about versions, since they are not relevant in Guix. This also
fixes an issue about lonely parenthesis. Note that version constraints
like >= 1.2.3 are not relevant in Guix, since packages are not expected
to ever downgrade.

Then, I added the autotools packages (autoconf, automake and libtool)
for the bootstrap phase to run and generate the configure script.

I moved the runtime dependencies (libimobiledevice and other libraries)
to the inputs instead of the native-inputs. There is no difference
between the two for normal compilation, but when cross-compiling, a
software can only link to inputs and propagated-inputs since they are
for the target platform, whereas native-inputs are for the native
platform (the computer performing the build).

Thanks for the patch!




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 20 Oct 2022 11:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 181 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.