GNU bug report logs - #57906
[PATCH] Add face help-key-binding in help-char echo

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefankangas <at> gmail.com>

Date: Sun, 18 Sep 2022 09:41:02 UTC

Severity: minor

Tags: patch

Fixed in version 29.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57906 in the body.
You can then email your comments to 57906 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#57906; Package emacs. (Sun, 18 Sep 2022 09:41:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Stefan Kangas <stefankangas <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 18 Sep 2022 09:41:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add face help-key-binding in help-char echo
Date: Sun, 18 Sep 2022 05:40:43 -0400

[Message part 1 (text/plain, inline)]
Severity: minor

For the sake of consistency, I think we should use the
`help-key-binding' face to the "?" key in the message that shows up when
typing `C-h' and waiting.  Please see the attached patch.

[0001-Add-face-help-key-binding-in-help-char-echo.patch (text/x-diff, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#57906; Package emacs. (Sun, 18 Sep 2022 10:14:02 GMT) Full text and rfc822 format available.

Message #8 received at 57906 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 57906 <at> debbugs.gnu.org
Subject: Re: bug#57906: [PATCH] Add face help-key-binding in help-char echo
Date: Sun, 18 Sep 2022 12:12:57 +0200

Stefan Kangas <stefankangas <at> gmail.com> writes:

> For the sake of consistency, I think we should use the
> `help-key-binding' face to the "?" key in the message that shows up when
> typing `C-h' and waiting.  Please see the attached patch.

Makes sense to me.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#57906; Package emacs. (Wed, 05 Oct 2022 13:41:02 GMT) Full text and rfc822 format available.

Message #11 received at 57906 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 57906 <at> debbugs.gnu.org
Subject: Re: bug#57906: [PATCH] Add face help-key-binding in help-char echo
Date: Wed, 5 Oct 2022 13:40:01 +0000

close 57906 29.1
thanks

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>> For the sake of consistency, I think we should use the
>> `help-key-binding' face to the "?" key in the message that shows up when
>> typing `C-h' and waiting.  Please see the attached patch.
>
> Makes sense to me.

Thanks, pushed (commit 9449e0740c).
bug marked as fixed in version 29.1, send any further explanations to 57906 <at> debbugs.gnu.org and Stefan Kangas <stefankangas <at> gmail.com> Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Wed, 05 Oct 2022 13:41:03 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 03 Nov 2022 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 173 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.