GNU bug report logs - #57913
[PATCH] gnu: Add java-argparse4j.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57913 in the body.
You can then email your comments to 57913 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add java-argparse4j.
Date: Sun, 18 Sep 2022 20:17:30 +0300

[Message part 1 (text/plain, inline)]

Hello,

this patch adds "argparse4j".

[0001-gnu-Add-java-argparse4j.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

Thanks,

- Artyom

References:
1. Java port of Python's famous argparse command-line argument parser.
   <https://github.com/argparse4j/argparse4j>

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 57913 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>, 57913 <at> debbugs.gnu.org
Subject: Re: [bug#57913] [PATCH] gnu: Add java-argparse4j.
Date: Sun, 18 Sep 2022 20:35:15 +0200

[Message part 1 (text/plain, inline)]

This looks good from a distance, but I'm not sure you need maven-enforcer-plugin. Since you're using the ant-build-system, I don't think the plugin has a chance to run?

Le 18 septembre 2022 19:17:30 GMT+02:00, "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> a écrit :
>Hello,
>
>this patch adds "argparse4j".

[Message part 2 (text/html, inline)]

Message #11 received at 57913 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 57913 <at> debbugs.gnu.org
Subject: Re: [bug#57913] [PATCH] gnu: Add java-argparse4j.
Date: Sun, 18 Sep 2022 21:45:16 +0300

[Message part 1 (text/plain, inline)]

Hello Julien,

thank you for the patch review.

> This looks good from a distance, but I'm not sure you need
> maven-enforcer-plugin. Since you're using the ant-build-system, I
> don't think the plugin has a chance to run?

Good catch.  It seems that "java-argparse4j" builds fine w/o
"maven-enforcer-plugin".  I removed this dependency and added
"java-junit" instead as it is required for the tests.

[0001-gnu-Add-java-argparse4j.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

- Artyom

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 57913-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: 57913-done <at> debbugs.gnu.org
Subject: Re: [bug#57913] [PATCH] gnu: Add java-argparse4j.
Date: Mon, 19 Sep 2022 15:52:49 +0200

Le Sun, 18 Sep 2022 21:45:16 +0300,
"Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> a écrit :

> Hello Julien,
> 
> thank you for the patch review.
> 
> > This looks good from a distance, but I'm not sure you need
> > maven-enforcer-plugin. Since you're using the ant-build-system, I
> > don't think the plugin has a chance to run?  
> 
> Good catch.  It seems that "java-argparse4j" builds fine w/o
> "maven-enforcer-plugin".  I removed this dependency and added
> "java-junit" instead as it is required for the tests.

Thanks for the patch, pushed to master as
72fe3c0a35f04a6616c17228953a20861ce9b690.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.