GNU bug report logs - #57944
[PATCH 1/2] gnu: Add gnome-text-editor

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57944 in the body.
You can then email your comments to 57944 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <Sughosha <at> proton.me>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH 1/2] gnu: Add gnome-text-editor
Date: Tue, 20 Sep 2022 04:13:53 +0000

[Message part 1 (text/plain, inline)]

Empty Message

[Message part 2 (text/html, inline)]

[0001-gnu-Add-gnome-text-editor.patch (text/x-patch, attachment)]

[0002-gnu-Add-gnome-console.patch (text/x-patch, attachment)]

Message #8 received at 57944 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Sughosha <Sughosha <at> proton.me>, 57944 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/2] gnu: Add gnome-text-editor
Date: Tue, 20 Sep 2022 07:14:11 +0200

Hi,

Am Dienstag, dem 20.09.2022 um 04:13 +0000 schrieb Sughosha:

> +              (uri (string-append "mirror://gnome/sources/gnome-
> text-editor/"
> +                                  (version-major version)
> +                                  "/"
> +                                  "gnome-text-editor-"
> +                                  version
> +                                  ".tar.xz"))
The format provided by the pretty-printer is, like, a suggestion.

> +    (build-system meson-build-system)
> +    (native-inputs (list pkg-config
You're missing arguments here.  At the very least #:glib-or-gtk? #t

> +     "Text Editor is a simple text editor that focuses on session
> management.
> +It works hard to keep track of changes and state even if you quit
> the
> +application.  You can come back to your work even if you've never
> saved it to a
> +file."
You should probably call it GNOME Text Editor.  The description is
fairly light on advertisments as far as copypasta descriptions go, so I
won't fault you for that here.

> +    (license license:gpl3)))
Should probably be gpl3+.

> +    (synopsis "Simple user-friendly terminal emulator for the GNOME
> desktop")
> +    (description
> +     "Console is supposed to be a simple terminal emulator for the
> average user
> +to carry out simple cli tasks and aims to be a ‘core’ app for
> GNOME/Phosh")
Ehhhhhh... I do want you to cut down on the ads here.

> +    (build-system meson-build-system)
> +    (native-inputs (list desktop-file-utils
Missing arguments.

> +    (home-page "https://gitlab.gnome.org/GNOME/gnome-console")
Dead link is dead.

> +    (license license:gpl3)))
Also probably gpl3+.

Cheers

Message #11 received at 57944 <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <Sughosha <at> proton.me>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 57944 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/2] gnu: Add gnome-text-editor
Date: Tue, 20 Sep 2022 09:12:26 +0000

[Message part 1 (text/plain, inline)]

Thanks for reviewing. I made the changes with the corrections. Here are new patches with the fixes. But one thing I am not sure why gpl3+ was suggested, while in the GitLab repository it is mentioned as GNU GPLv3.

------- Original Message -------
Liliana Marie Prikler <liliana.prikler <at> gmail.com> schrieb am Dienstag, 20. September 2022 um 07:14:


> Hi,
> 
> Am Dienstag, dem 20.09.2022 um 04:13 +0000 schrieb Sughosha:
> 
> > + (uri (string-append "mirror://gnome/sources/gnome-
> > text-editor/"
> > + (version-major version)
> > + "/"
> > + "gnome-text-editor-"
> > + version
> > + ".tar.xz"))
> 
> The format provided by the pretty-printer is, like, a suggestion.
> 
> > + (build-system meson-build-system)
> > + (native-inputs (list pkg-config
> 
> You're missing arguments here. At the very least #:glib-or-gtk? #t
> 
> > + "Text Editor is a simple text editor that focuses on session
> > management.
> > +It works hard to keep track of changes and state even if you quit
> > the
> > +application. You can come back to your work even if you've never
> > saved it to a
> > +file."
> 
> You should probably call it GNOME Text Editor. The description is
> fairly light on advertisments as far as copypasta descriptions go, so I
> won't fault you for that here.
> 
> > + (license license:gpl3)))
> 
> Should probably be gpl3+.
> 
> > + (synopsis "Simple user-friendly terminal emulator for the GNOME
> > desktop")
> > + (description
> > + "Console is supposed to be a simple terminal emulator for the
> > average user
> > +to carry out simple cli tasks and aims to be a ‘core’ app for
> > GNOME/Phosh")
> 
> Ehhhhhh... I do want you to cut down on the ads here.
> 
> > + (build-system meson-build-system)
> > + (native-inputs (list desktop-file-utils
> 
> Missing arguments.
> 
> > + (home-page "https://gitlab.gnome.org/GNOME/gnome-console")
> 
> Dead link is dead.
> 
> > + (license license:gpl3)))
> 
> Also probably gpl3+.
> 
> Cheers

[0001-gnu-Add-gnome-text-editor.patch (text/x-patch, attachment)]

[0002-gnu-Add-gnome-console.patch (text/x-patch, attachment)]

Message #14 received at 57944 <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <Sughosha <at> proton.me>
To: liliana.prikler <at> gmail.com
Cc: 57944 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/2] gnu: Add gnome-text-editor
Date: Tue, 20 Sep 2022 11:21:43 +0000

[Message part 1 (text/plain, inline)]

One more small correction, cmake as native-input was not necessary.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-gnome-text-editor.patch (text/x-diff, attachment)]

[0002-gnu-Add-gnome-console.patch (text/x-diff, attachment)]

Message #19 received at 57944-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Sughosha <Sughosha <at> proton.me>
Cc: 57944-done <at> debbugs.gnu.org
Subject: Re: [PATCH 1/2] gnu: Add gnome-text-editor
Date: Wed, 21 Sep 2022 20:22:18 +0200

Am Dienstag, dem 20.09.2022 um 11:21 +0000 schrieb Sughosha:
> One more small correction, cmake as native-input was not necessary.
You probably saw this already, but I pushed this series with the
nautilus extension to gnome-console.

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.