GNU bug report logs - #57975
[PATCH] gnu: rust-libz-sys-1: Do not remove zlib-ng sources.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57975 in the body.
You can then email your comments to 57975 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: guix-patches <at> gnu.org
Cc: Ricardo Wurmus <rekado <at> elephly.net>
Subject: [PATCH] gnu: rust-libz-sys-1: Do not remove zlib-ng sources.
Date: Wed, 21 Sep 2022 11:35:27 +0200

* gnu/packages/crates-io.scm (rust-libz-sys-1)[source]: Only delete bundled
zlib sources.
---
 gnu/packages/crates-io.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 42a44a2930..f7703f9295 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -32568,9 +32568,9 @@ (define-public rust-libz-sys-1
           "1q25cb8vs113si7q2p0innhi8jk0wpq37hqi2wcc219hcmw43cr3"))
         (modules '((guix build utils)))
         (snippet
-         '(begin (delete-file-recursively "src/zlib")
-                 (delete-file-recursively "src/zlib-ng")
-                 #t))))
+         ;; Do not delete zlib-ng, because we have no native library
+         ;; for it.
+         '(delete-file-recursively "src/zlib"))))
     (build-system cargo-build-system)
     (arguments
      `(#:cargo-inputs
-- 
2.36.1

Message #8 received at 57975 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ricardo Wurmus <rekado <at> elephly.net>, 57975 <at> debbugs.gnu.org
Subject: Re: [bug#57975] [PATCH] gnu: rust-libz-sys-1: Do not remove zlib-ng
 sources.
Date: Wed, 21 Sep 2022 12:15:27 +0200

[Message part 1 (text/plain, inline)]

On 21-09-2022 11:35, Ricardo Wurmus wrote:
> * gnu/packages/crates-io.scm (rust-libz-sys-1)[source]: Only delete bundled
> zlib sources.
> ---
>   gnu/packages/crates-io.scm | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
> index 42a44a2930..f7703f9295 100644
> --- a/gnu/packages/crates-io.scm
> +++ b/gnu/packages/crates-io.scm
> @@ -32568,9 +32568,9 @@ (define-public rust-libz-sys-1
>             "1q25cb8vs113si7q2p0innhi8jk0wpq37hqi2wcc219hcmw43cr3"))
>           (modules '((guix build utils)))
>           (snippet
> -         '(begin (delete-file-recursively "src/zlib")
> -                 (delete-file-recursively "src/zlib-ng")
> -                 #t))))
> +         ;; Do not delete zlib-ng, because we have no native library
> +         ;; for it.
> +         '(delete-file-recursively "src/zlib"))))

According to the README, zlib and zlib-ng are supposed to be compatible, 
so zlib-ng should be removable (as long as dependents don't enable 
zlib-ng, but that can be patched out).

Additionally, using zlib-ng can cause problems if the application also 
links to the regular zlib:

README.md ‘and as long as you don't also dynamically pull in a copy of
stock zlib (which will produce conflicting symbols)’

Proposal: keep removing zlib-ng, and modify the enabled features in 
whatever crate or Rust application asks for zlib-ng.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #11 received at 57975 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 57975 <at> debbugs.gnu.org
Subject: Re: [bug#57975] [PATCH] gnu: rust-libz-sys-1: Do not remove zlib-ng
 sources.
Date: Wed, 21 Sep 2022 12:27:16 +0200

Maxime Devos <maximedevos <at> telenet.be> writes:

> Proposal: keep removing zlib-ng, and modify the enabled features in
> whatever crate or Rust application asks for zlib-ng.

Thanks, I’ll give that a try by patching the target application.

-- 
Ricardo

Message #16 received at 57975-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 57975-done <at> debbugs.gnu.org
Subject: Re: [bug#57975] [PATCH] gnu: rust-libz-sys-1: Do not remove zlib-ng
 sources.
Date: Thu, 22 Sep 2022 00:10:16 +0200

Ricardo Wurmus <rekado <at> elephly.net> writes:

> Maxime Devos <maximedevos <at> telenet.be> writes:
>
>> Proposal: keep removing zlib-ng, and modify the enabled features in
>> whatever crate or Rust application asks for zlib-ng.
>
> Thanks, I’ll give that a try by patching the target application.

Patching the package to not request the zlib-ng feature works, so I
retract this patch.  Thanks again for the hint!

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.