GNU bug report logs - #57977
29.0.50; [PATCH] Make Gnus respect mode-line-buffer-identification-keymap

Previous Next

Package: emacs;

Reported by: Visuwesh <visuweshm <at> gmail.com>

Date: Wed, 21 Sep 2022 12:43:02 UTC

Severity: normal

Tags: patch

Found in version 29.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57977 in the body.
You can then email your comments to 57977 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#57977; Package emacs. (Wed, 21 Sep 2022 12:43:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Visuwesh <visuweshm <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 21 Sep 2022 12:43:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; [PATCH] Make Gnus respect
 mode-line-buffer-identification-keymap
Date: Wed, 21 Sep 2022 18:11:28 +0530
The buffer name in the mode-line has a keymap set which lets you use
button-1 and button-3 to change the buffer in that window.  However,
gnus-mode-line-buffer-identification does not put the keymap.  This
breaks the flow when you're quickly going through the buffers using the
mouse buttons.  I will attach a patch once I get the bug number.

In GNU Emacs 29.0.50 (build 18, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.16.0, Xaw scroll bars) of 2022-09-20 built on astatine
Repository revision: cd2168cd131852279a7d9257c7dff45224c9d6a9
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure --with-sound=alsa --with-x-toolkit=lucid --with-json
 --without-xaw3d --without-gconf --without-libsystemd'
Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LIBOTF LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG
SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM
XINPUT2 XPM LUCID ZLIB
Important settings:
  value of $LC_MONETARY: ta_IN.UTF-8
  value of $LC_NUMERIC: ta_IN.UTF-8
  value of $LANG: en_GB.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Browse Server

Minor modes in effect:
  recentf-mode: t
  shell-dirtrack-mode: t
  eros-mode: t
  pdf-occur-global-minor-mode: t
  minibuffer-depth-indicate-mode: t
  repeat-mode: t
  display-time-mode: t
  display-battery-mode: t
  winner-mode: t
  acme-tag-minor-mode: t
  delete-selection-mode: t
  xterm-mouse-mode: t
  straight-use-package-mode: t
  straight-package-neutering-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  use-hard-newlines: t
  tab-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  undelete-frame-mode: t
  buffer-read-only: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#57977; Package emacs. (Wed, 21 Sep 2022 12:45:02 GMT) Full text and rfc822 format available.

Message #8 received at 57977 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: 57977 <at> debbugs.gnu.org
Subject: 29.0.50; [PATCH] Make Gnus respect
 mode-line-buffer-identification-keymap
Date: Wed, 21 Sep 2022 18:13:54 +0530
[Message part 1 (text/plain, inline)]
Please find attached, thanks.

[0001-Make-Gnus-respect-mode-line-buffer-identification-ke.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#57977; Package emacs. (Wed, 21 Sep 2022 12:51:02 GMT) Full text and rfc822 format available.

Message #11 received at 57977 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: 57977 <at> debbugs.gnu.org
Subject: Re: 29.0.50; [PATCH] Make Gnus respect
 mode-line-buffer-identification-keymap
Date: Wed, 21 Sep 2022 18:20:26 +0530
[Message part 1 (text/plain, inline)]
[புதன் செப்டம்பர் 21, 2022] Visuwesh wrote:

> Please find attached, thanks.

Oops, that patch had a very silly thinko...
[0001-Make-Gnus-respect-mode-line-buffer-identification-ke.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#57977; Package emacs. (Fri, 23 Sep 2022 11:45:02 GMT) Full text and rfc822 format available.

Message #14 received at 57977 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: 57977 <at> debbugs.gnu.org
Subject: Re: 29.0.50; [PATCH] Make Gnus respect
 mode-line-buffer-identification-keymap
Date: Fri, 23 Sep 2022 17:13:45 +0530
[Message part 1 (text/plain, inline)]
[புதன் செப்டம்பர் 21, 2022] Visuwesh wrote:

> [புதன் செப்டம்பர் 21, 2022] Visuwesh wrote:
>
>> Please find attached, thanks.
>
> Oops, that patch had a very silly thinko...

This patch was also wrong.  Submitting a patch when I was tired and
about to sleep was an awful mistake, sorry about the noise.  Attached
patch should be final, hopefully.

[0001-Make-Gnus-respect-mode-line-buffer-identification-ke.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#57977; Package emacs. (Fri, 23 Sep 2022 16:23:01 GMT) Full text and rfc822 format available.

Message #17 received at 57977 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 57977 <at> debbugs.gnu.org
Subject: Re: bug#57977: 29.0.50; [PATCH] Make Gnus respect
 mode-line-buffer-identification-keymap
Date: Fri, 23 Sep 2022 18:22:06 +0200
Visuwesh <visuweshm <at> gmail.com> writes:

> This patch was also wrong.  Submitting a patch when I was tired and
> about to sleep was an awful mistake, sorry about the noise.  Attached
> patch should be final, hopefully.

Thanks; pushed to Emacs 29.




bug marked as fixed in version 29.1, send any further explanations to 57977 <at> debbugs.gnu.org and Visuwesh <visuweshm <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 23 Sep 2022 16:23:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 22 Oct 2022 11:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 179 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.