GNU bug report logs -
#57992
[PATCH] gnu: emacs-use-package: Emit deprecation messages.
Previous Next
Reported by: Hilton Chain <hako <at> ultrarare.space>
Date: Thu, 22 Sep 2022 01:23:01 UTC
Severity: normal
Tags: patch
Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57992 in the body.
You can then email your comments to 57992 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#57992
; Package
guix-patches
.
(Thu, 22 Sep 2022 01:23:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Hilton Chain <hako <at> ultrarare.space>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Thu, 22 Sep 2022 01:23:01 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/patches/emacs-use-package-avoid-positional-arguments.patch: New
file.
* gnu/local.mk (dist_patch_DATA): Add it.
* gnu/packages/emacs-xyz.scm (emacs-use-package)[patches]: Add
emacs-use-package-avoid-positional-arguments.patch.
---
gnu/local.mk | 1 +
gnu/packages/emacs-xyz.scm | 6 ++++-
...e-package-avoid-positional-arguments.patch | 26 +++++++++++++++++++
3 files changed, 32 insertions(+), 1 deletion(-)
create mode 100644 gnu/packages/patches/emacs-use-package-avoid-positional-arguments.patch
diff --git a/gnu/local.mk b/gnu/local.mk
index ef1bae5f3c..731f64b053 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1054,6 +1054,7 @@ dist_patch_DATA = \
%D%/packages/patches/emacs-source-date-epoch.patch \
%D%/packages/patches/emacs-telega-path-placeholder.patch \
%D%/packages/patches/emacs-telega-test-env.patch \
+ %D%/packages/patches/emacs-use-package-avoid-positional-arguments.patch \
%D%/packages/patches/emacs-wordnut-require-adaptive-wrap.patch \
%D%/packages/patches/emacs-yasnippet-fix-tests.patch \
%D%/packages/patches/emacs-kv-fix-tests.patch \
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 32e4c33f16..762d11a776 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -14994,7 +14994,11 @@ (define-public emacs-use-package
(file-name (git-file-name name version))
(sha256
(base32
- "088kl3bml0rs5bkfymgzr15ram9qvy66h1kaisrbkynh0yxvf8g9"))))
+ "088kl3bml0rs5bkfymgzr15ram9qvy66h1kaisrbkynh0yxvf8g9"))
+ (patches
+ (search-patches
+ ;; NOTE: Cherry-picked from upstream commit.
+ "emacs-use-package-avoid-positional-arguments.patch"))))
(build-system emacs-build-system)
(native-inputs
(list texinfo))
diff --git a/gnu/packages/patches/emacs-use-package-avoid-positional-arguments.patch b/gnu/packages/patches/emacs-use-package-avoid-positional-arguments.patch
new file mode 100644
index 0000000000..82b52b0400
--- /dev/null
+++ b/gnu/packages/patches/emacs-use-package-avoid-positional-arguments.patch
@@ -0,0 +1,26 @@
+From cb90d3fa4168d7e1b2f035f4fbb0d5d08db1fbec Mon Sep 17 00:00:00 2001
+From: Jonas Bernoulli <jonas <at> bernoul.li>
+Date: Tue, 18 May 2021 15:44:34 +0200
+Subject: [PATCH] Avoid positional arguments to define-minor-mode
+
+Back in Emacs-21.1, `define-minor-mode' grew keyword arguments to
+replace its old positional arguments. Starting with Emacs-28.1
+a warning will be omitted if positional arguments are still used.
+---
+ bind-key.el | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/bind-key.el b/bind-key.el
+index 1d611c2..9a2ddcd 100644
+--- a/bind-key.el
++++ b/bind-key.el
+@@ -131,7 +131,8 @@
+
+ (define-minor-mode override-global-mode
+ "A minor mode so that keymap settings override other modes."
+- t "")
++ :global t
++ :lighter "")
+
+ ;; the keymaps in `emulation-mode-map-alists' take precedence over
+ ;; `minor-mode-map-alist'
base-commit: 1a1ff7ed8fdaae58aff0e8625399cd7354038ca3
--
2.37.3
Information forwarded
to
guix-patches <at> gnu.org
:
bug#57992
; Package
guix-patches
.
(Fri, 23 Sep 2022 16:30:03 GMT)
Full text and
rfc822 format available.
Message #8 received at 57992 <at> debbugs.gnu.org (full text, mbox):
Emit: to throw or give out; "emit a warning" means "print a warning"
Omit: to leave out; "omit a warning" means "not printing a warning even
though you should".
In these cases, you are proactively working against the warnings, i.e.
preventing them.
Cheers
Information forwarded
to
guix-patches <at> gnu.org
:
bug#57992
; Package
guix-patches
.
(Sat, 24 Sep 2022 17:43:01 GMT)
Full text and
rfc822 format available.
Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):
Hello,
Hilton Chain via Guix-patches via <guix-patches <at> gnu.org> writes:
> * gnu/packages/patches/emacs-use-package-avoid-positional-arguments.patch: New
> file.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/emacs-xyz.scm (emacs-use-package)[patches]: Add
> emacs-use-package-avoid-positional-arguments.patch.
Thank you.
However, unless I'm missing something, I'm not sure we should bother
fixing compilation warnings. This patch can wait next version bump,
can't it?
Regards,
--
Nicolas Goaziou
Information forwarded
to
guix-patches <at> gnu.org
:
bug#57992
; Package
guix-patches
.
(Sat, 24 Sep 2022 17:43:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
guix-patches <at> gnu.org
:
bug#57992
; Package
guix-patches
.
(Sat, 24 Sep 2022 23:43:02 GMT)
Full text and
rfc822 format available.
Message #17 received at 57992 <at> debbugs.gnu.org (full text, mbox):
On Sat, 24 Sep 2022 00:29:16 +0800,
Liliana Marie Prikler wrote:
>
> Emit: to throw or give out; "emit a warning" means "print a warning"
> Omit: to leave out; "omit a warning" means "not printing a warning even
> though you should".
>
> In these cases, you are proactively working against the warnings, i.e.
> preventing them.
>
> Cheers
Oops :P
I'll take care in the future, thank you!
Information forwarded
to
guix-patches <at> gnu.org
:
bug#57992
; Package
guix-patches
.
(Sat, 24 Sep 2022 23:46:02 GMT)
Full text and
rfc822 format available.
Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):
On Sun, 25 Sep 2022 01:42:38 +0800,
Nicolas Goaziou wrote:
> However, unless I'm missing something, I'm not sure we should bother
> fixing compilation warnings. This patch can wait next version bump,
> can't it?
No problem :)
Information forwarded
to
guix-patches <at> gnu.org
:
bug#57992
; Package
guix-patches
.
(Sat, 24 Sep 2022 23:46:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
guix-patches <at> gnu.org
:
bug#57992
; Package
guix-patches
.
(Sun, 25 Sep 2022 12:56:02 GMT)
Full text and
rfc822 format available.
Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):
Hello,
Hilton Chain via Guix-patches via <guix-patches <at> gnu.org> writes:
> On Sun, 25 Sep 2022 01:42:38 +0800,
> Nicolas Goaziou wrote:
>> However, unless I'm missing something, I'm not sure we should bother
>> fixing compilation warnings. This patch can wait next version bump,
>> can't it?
>
> No problem :)
Fair enough. Closing then. Feel free to re-open the issue if you change
your mind.
Regards,
--
Nicolas Goaziou
Reply sent
to
Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
:
You have taken responsibility.
(Sun, 25 Sep 2022 12:56:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Hilton Chain <hako <at> ultrarare.space>
:
bug acknowledged by developer.
(Sun, 25 Sep 2022 12:56:02 GMT)
Full text and
rfc822 format available.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Mon, 24 Oct 2022 11:24:14 GMT)
Full text and
rfc822 format available.
This bug report was last modified 1 year and 190 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.