GNU bug report logs - #57997
[PATCH] gnu: emacs-rime: Emit deprecation warning.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Hilton Chain <hako@HIDDEN>; Keywords: patch; dated Thu, 22 Sep 2022 05:00:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 57997 <at> debbugs.gnu.org:


Received: (at 57997) by debbugs.gnu.org; 23 Sep 2022 16:29:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 23 12:29:26 2022
Received: from localhost ([127.0.0.1]:41600 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oblYM-0000iV-3C
	for submit <at> debbugs.gnu.org; Fri, 23 Sep 2022 12:29:26 -0400
Received: from mail-ej1-f66.google.com ([209.85.218.66]:43934)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <liliana.prikler@HIDDEN>)
 id 1oblYK-0000i2-03; Fri, 23 Sep 2022 12:29:24 -0400
Received: by mail-ej1-f66.google.com with SMTP id lh5so1762102ejb.10;
 Fri, 23 Sep 2022 09:29:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=mime-version:user-agent:content-transfer-encoding:date:cc:to:from
 :subject:message-id:from:to:cc:subject:date;
 bh=bqaCXSeHnLolHAjQ/NPfrsPk5oWqsAEkW2U2PhdWjTU=;
 b=GvElTOqjbmo6BFAhVUQ9DsI8SUrpfbRlb3NVv5ty8QhNphLg2ceB20Tlg4/pyzsQpt
 spqlYnIoz0uRKdPQV3CIlmWdmhAouZwgOMKRl3qZc7O6/x2n3w3dQ/fJPqL0x5pMuxxw
 F5sMxEpcedptG+NQoR9UgkFfN4/C+cKxgFfKKUYhv2g/m5bhk7z3P/EGoSBJIRAL4qHq
 BduWgXM52ogQaR4S1JXy5mHEhTAy5MqXAPU1ou5Z+Li8Hn/42/tPjJh46zH/ONo2QEHp
 1ttF0RQwRIzy9cvCE7rGrQnf1LEIXEnu7LhFuUaQZw/hQ42ORecYsfXKTTrEIgt1zxb0
 Fibg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=mime-version:user-agent:content-transfer-encoding:date:cc:to:from
 :subject:message-id:x-gm-message-state:from:to:cc:subject:date;
 bh=bqaCXSeHnLolHAjQ/NPfrsPk5oWqsAEkW2U2PhdWjTU=;
 b=Jg2hvQodGH5r4PU9hWHSOUKzz1pZvXlW+cm4EGhscXQ7XkNH1Ac2pLQdHR/oEV7VqG
 +lKoDcqdz96pFMmUNA0i4dVPl/nvsDOETbMplyFy0PVJx/udHAOVA5chB/Tlahg4845S
 OgDlfAroik2DZO5c9VPXztn0iszdB4EFfmz2N1cF8mWmlrVRrCE99x7W505LX4L/BhI7
 ZnVRWboSinuZ/K/X2irN8RJ8V3iuImep9TWXe9JKJ1m7uQibYMBwMcynz72FCkdppkVl
 k6+GO7QWRVfG2w9wsUSovU1q4dFLgZDQn+MqaVMY2HhOYxfXGhNl0ZO9mqj2leDNK8ND
 XCfw==
X-Gm-Message-State: ACrzQf29Q6oGyUD+nY3b7lLbTKtoXI2DDAHe5BrgNc8mB26PaKe1oX0w
 MmdAEt1jbaSHiQ0zcXJ4icY=
X-Google-Smtp-Source: AMsMyM4z91ePctQ49vyOhYdyyYkqlao/fVWNjSaaK5mgSP4Uz6wmghGnWtIBQNFp3pjpnlofkAiiPg==
X-Received: by 2002:a17:907:2c78:b0:779:7327:c897 with SMTP id
 ib24-20020a1709072c7800b007797327c897mr7571083ejc.657.1663950557904; 
 Fri, 23 Sep 2022 09:29:17 -0700 (PDT)
Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
 [85.127.52.93]) by smtp.gmail.com with ESMTPSA id
 q27-20020a056402249b00b004542e65337asm5831571eda.51.2022.09.23.09.29.17
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 23 Sep 2022 09:29:17 -0700 (PDT)
Message-ID: <83cfc1b31312f9eec3ca45a70d690db4c2cee3b5.camel@HIDDEN>
Subject: Emit != omit
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Hilton Chain <hako@HIDDEN>
Date: Fri, 23 Sep 2022 18:29:16 +0200
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.0 
MIME-Version: 1.0
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 57997
Cc: 57993 <at> debbugs.gnu.org, 57992 <at> debbugs.gnu.org, 57997 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Emit: to throw or give out; "emit a warning" means "print a warning"
Omit: to leave out; "omit a warning" means "not printing a warning even
though you should".

In these cases, you are proactively working against the warnings, i.e.
preventing them.

Cheers




Information forwarded to guix-patches@HIDDEN:
bug#57997; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 22 Sep 2022 04:59:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 22 00:59:15 2022
Received: from localhost ([127.0.0.1]:35802 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1obEIt-0002k2-1e
	for submit <at> debbugs.gnu.org; Thu, 22 Sep 2022 00:59:15 -0400
Received: from lists.gnu.org ([209.51.188.17]:35268)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <hako@HIDDEN>) id 1obEIr-0002jr-91
 for submit <at> debbugs.gnu.org; Thu, 22 Sep 2022 00:59:13 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:44356)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <hako@HIDDEN>)
 id 1obEIr-00025N-3G
 for guix-patches@HIDDEN; Thu, 22 Sep 2022 00:59:13 -0400
Received: from mail.boiledscript.com ([144.168.59.46]:44646)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <hako@HIDDEN>)
 id 1obEIp-0007ba-Di
 for guix-patches@HIDDEN; Thu, 22 Sep 2022 00:59:12 -0400
Date: Thu, 22 Sep 2022 12:58:38 +0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space;
 s=dkim; t=1663822749;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding;
 bh=KikDlOCX5k7MBLEPym4/e9yG+xIgQsMH/gus0u35h0M=;
 b=SroMQhCja+EDeL8UK9GDALoejyr3ef5CJIm3cuLneG52DKFDv9Vj+kSYtKMYtK+J8K0dOq
 MdOh8h1jweFYwGhmsndh6NNCzu5TZAFwwPoi6qQNa4AMPrx3R3bms4LPbksBjqXLhxVdSW
 Q29Eo2DAXxtRzrZyal2CdPJXvo2B73rVp/G9GrBm5ya5rJKn3sv+0bwkfY2fKT1G3qSEcy
 f/xn5TZJxPhhPW8iPo3gbVXE75iyNWNgZhUWxjHolqsYhGIftWPrr8VVNMs2ShLeK+Nme3
 +U1wkD88cM8ZvJy5LQW25UGEf4H0BK6TVQo2X9EuPn49uNBJ4Ec33udBgshpvQ==
Message-ID: <y76mtasm2dd.wl-hako@HIDDEN>
From: Hilton Chain <hako@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: emacs-rime: Emit deprecation warning.
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8bit
Authentication-Results: mail.boiledscript.com;
 auth=pass smtp.mailfrom=hako@HIDDEN
X-Spamd-Bar: /
Received-SPF: pass client-ip=144.168.59.46; envelope-from=hako@HIDDEN;
 helo=mail.boiledscript.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

* gnu/packages/patches/emacs-rime-update-define-minor-mode-usage.patch: New
file.
* gnu/local.mk (dist_patch_DATA): Add patch.
* gnu/packages/emacs-xyz.scm (emacs-rime)[patches]: Add
emacs-rime-update-define-minor-mode-usage.patch
---
 gnu/local.mk                                  |  1 +
 gnu/packages/emacs-xyz.scm                    |  6 ++-
 ...-rime-update-define-minor-mode-usage.patch | 38 +++++++++++++++++++
 3 files changed, 44 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/patches/emacs-rime-update-define-minor-mode-usage.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index ef1bae5f3c..82e980a272 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1051,6 +1051,7 @@ dist_patch_DATA =						\
   %D%/packages/patches/emacs-libgit-use-system-libgit2.patch    \
   %D%/packages/patches/emacs-lispy-fix-thread-last-test.patch   \
   %D%/packages/patches/emacs-polymode-fix-lexical-variable-error.patch  \
+  %D%/packages/patches/emacs-rime-update-define-minor-mode-usage.patch	\
   %D%/packages/patches/emacs-source-date-epoch.patch		\
   %D%/packages/patches/emacs-telega-path-placeholder.patch	\
   %D%/packages/patches/emacs-telega-test-env.patch		\
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 32e4c33f16..5811fb410a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -29523,7 +29523,11 @@ (define-public emacs-rime
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "0z0iwsqr92g8ykxb51gkawwxwzx0faw0027zgdi7c38ngjqld237"))))
+        (base32 "0z0iwsqr92g8ykxb51gkawwxwzx0faw0027zgdi7c38ngjqld237"))
+       (patches
+        (search-patches
+         ;; NOTE: Cherry-picked from upstream, remove when bumping.
+         "emacs-rime-update-define-minor-mode-usage.patch"))))
     (build-system emacs-build-system)
     (arguments
      '(#:include (cons "\\.so$" %default-include)
diff --git a/gnu/packages/patches/emacs-rime-update-define-minor-mode-usage.patch b/gnu/packages/patches/emacs-rime-update-define-minor-mode-usage.patch
new file mode 100644
index 0000000000..4f905ca0bf
--- /dev/null
+++ b/gnu/packages/patches/emacs-rime-update-define-minor-mode-usage.patch
@@ -0,0 +1,38 @@
+From 5c2ade217134f6f20cd405447af20825e5b44513 Mon Sep 17 00:00:00 2001
+From: tianshu <doglooksgood@HIDDEN>
+Date: Sat, 11 Dec 2021 02:06:35 +0800
+Subject: [PATCH] update define-minor-mode usage
+
+---
+ rime.el | 12 ++++++------
+ 1 file changed, 6 insertions(+), 6 deletions(-)
+
+diff --git a/rime.el b/rime.el
+index 64a4d70..044ab97 100644
+--- a/rime.el
++++ b/rime.el
+@@ -1084,18 +1084,18 @@ Argument NAME ignored."
+   "Mode used in composition.
+ 
+ Should not be enabled manually."
+-  nil
+-  nil
+-  nil
++  :lighter nil
++  :init-value nil
++  :keymap nil
+   (if rime-active-mode
+       (rime-active-mode--init)
+     (rime-active-mode--uninit)))
+ 
+ (define-minor-mode rime-mode
+   "Mode used when input method is activated."
+-  nil
+-  nil
+-  rime-mode-map)
++  :lighter nil
++  :init-value nil
++  :keymap rime-mode-map)
+ 
+ ;;;###autoload
+ (register-input-method "rime" "euc-cn" 'rime-activate rime-title)

base-commit: 33d4992b69bfed2ec6b15b7b842599efb1cb1e31
-- 
2.37.3





Acknowledgement sent to Hilton Chain <hako@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#57997; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 23 Sep 2022 16:30:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.