GNU bug report logs - #57997
[PATCH] gnu: emacs-rime: Emit deprecation warning.

Previous Next

Package: guix-patches;

Reported by: Hilton Chain <hako <at> ultrarare.space>

Date: Thu, 22 Sep 2022 05:00:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57997 in the body.
You can then email your comments to 57997 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#57997; Package guix-patches. (Thu, 22 Sep 2022 05:00:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Hilton Chain <hako <at> ultrarare.space>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 22 Sep 2022 05:00:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-rime: Emit deprecation warning.
Date: Thu, 22 Sep 2022 12:58:38 +0800
* gnu/packages/patches/emacs-rime-update-define-minor-mode-usage.patch: New
file.
* gnu/local.mk (dist_patch_DATA): Add patch.
* gnu/packages/emacs-xyz.scm (emacs-rime)[patches]: Add
emacs-rime-update-define-minor-mode-usage.patch
---
 gnu/local.mk                                  |  1 +
 gnu/packages/emacs-xyz.scm                    |  6 ++-
 ...-rime-update-define-minor-mode-usage.patch | 38 +++++++++++++++++++
 3 files changed, 44 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/patches/emacs-rime-update-define-minor-mode-usage.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index ef1bae5f3c..82e980a272 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1051,6 +1051,7 @@ dist_patch_DATA =						\
   %D%/packages/patches/emacs-libgit-use-system-libgit2.patch    \
   %D%/packages/patches/emacs-lispy-fix-thread-last-test.patch   \
   %D%/packages/patches/emacs-polymode-fix-lexical-variable-error.patch  \
+  %D%/packages/patches/emacs-rime-update-define-minor-mode-usage.patch	\
   %D%/packages/patches/emacs-source-date-epoch.patch		\
   %D%/packages/patches/emacs-telega-path-placeholder.patch	\
   %D%/packages/patches/emacs-telega-test-env.patch		\
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 32e4c33f16..5811fb410a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -29523,7 +29523,11 @@ (define-public emacs-rime
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "0z0iwsqr92g8ykxb51gkawwxwzx0faw0027zgdi7c38ngjqld237"))))
+        (base32 "0z0iwsqr92g8ykxb51gkawwxwzx0faw0027zgdi7c38ngjqld237"))
+       (patches
+        (search-patches
+         ;; NOTE: Cherry-picked from upstream, remove when bumping.
+         "emacs-rime-update-define-minor-mode-usage.patch"))))
     (build-system emacs-build-system)
     (arguments
      '(#:include (cons "\\.so$" %default-include)
diff --git a/gnu/packages/patches/emacs-rime-update-define-minor-mode-usage.patch b/gnu/packages/patches/emacs-rime-update-define-minor-mode-usage.patch
new file mode 100644
index 0000000000..4f905ca0bf
--- /dev/null
+++ b/gnu/packages/patches/emacs-rime-update-define-minor-mode-usage.patch
@@ -0,0 +1,38 @@
+From 5c2ade217134f6f20cd405447af20825e5b44513 Mon Sep 17 00:00:00 2001
+From: tianshu <doglooksgood <at> gmail.com>
+Date: Sat, 11 Dec 2021 02:06:35 +0800
+Subject: [PATCH] update define-minor-mode usage
+
+---
+ rime.el | 12 ++++++------
+ 1 file changed, 6 insertions(+), 6 deletions(-)
+
+diff --git a/rime.el b/rime.el
+index 64a4d70..044ab97 100644
+--- a/rime.el
++++ b/rime.el
+@@ -1084,18 +1084,18 @@ Argument NAME ignored."
+   "Mode used in composition.
+ 
+ Should not be enabled manually."
+-  nil
+-  nil
+-  nil
++  :lighter nil
++  :init-value nil
++  :keymap nil
+   (if rime-active-mode
+       (rime-active-mode--init)
+     (rime-active-mode--uninit)))
+ 
+ (define-minor-mode rime-mode
+   "Mode used when input method is activated."
+-  nil
+-  nil
+-  rime-mode-map)
++  :lighter nil
++  :init-value nil
++  :keymap rime-mode-map)
+ 
+ ;;;###autoload
+ (register-input-method "rime" "euc-cn" 'rime-activate rime-title)

base-commit: 33d4992b69bfed2ec6b15b7b842599efb1cb1e31
-- 
2.37.3





Information forwarded to guix-patches <at> gnu.org:
bug#57997; Package guix-patches. (Fri, 23 Sep 2022 16:30:04 GMT) Full text and rfc822 format available.

Message #8 received at 57997 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: 57993 <at> debbugs.gnu.org, 57992 <at> debbugs.gnu.org, 57997 <at> debbugs.gnu.org
Subject: Emit != omit
Date: Fri, 23 Sep 2022 18:29:16 +0200
Emit: to throw or give out; "emit a warning" means "print a warning"
Omit: to leave out; "omit a warning" means "not printing a warning even
though you should".

In these cases, you are proactively working against the warnings, i.e.
preventing them.

Cheers




Information forwarded to guix-patches <at> gnu.org:
bug#57997; Package guix-patches. (Sat, 24 Sep 2022 23:43:03 GMT) Full text and rfc822 format available.

Message #11 received at 57997 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 57993 <at> debbugs.gnu.org, 57992 <at> debbugs.gnu.org, 57997 <at> debbugs.gnu.org
Subject: Re: Emit != omit
Date: Sun, 25 Sep 2022 07:41:57 +0800
On Sat, 24 Sep 2022 00:29:16 +0800,
Liliana Marie Prikler wrote:
> 
> Emit: to throw or give out; "emit a warning" means "print a warning"
> Omit: to leave out; "omit a warning" means "not printing a warning even
> though you should".
> 
> In these cases, you are proactively working against the warnings, i.e.
> preventing them.
> 
> Cheers

Oops :P
I'll take care in the future, thank you!




Information forwarded to guix-patches <at> gnu.org:
bug#57997; Package guix-patches. (Sun, 25 Sep 2022 12:58:02 GMT) Full text and rfc822 format available.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Hilton Chain via Guix-patches via <guix-patches <at> gnu.org>
Cc: Hilton Chain <hako <at> ultrarare.space>, 57997-close <at> debbugs.gnu.org
Subject: Re: [bug#57997] [PATCH] gnu: emacs-rime: Emit deprecation warning.
Date: Sun, 25 Sep 2022 14:57:08 +0200
Hello,

Hilton Chain via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/patches/emacs-rime-update-define-minor-mode-usage.patch: New
> file.
> * gnu/local.mk (dist_patch_DATA): Add patch.
> * gnu/packages/emacs-xyz.scm (emacs-rime)[patches]: Add
> emacs-rime-update-define-minor-mode-usage.patch

Closing. See bug #57992.

Regards,
-- 
Nicolas Goaziou




Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Sun, 25 Sep 2022 12:58:02 GMT) Full text and rfc822 format available.

Notification sent to Hilton Chain <hako <at> ultrarare.space>:
bug acknowledged by developer. (Sun, 25 Sep 2022 12:58:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 24 Oct 2022 11:24:15 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 156 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.