GNU bug report logs - #58002
29.1: Sokoban: obsoletion warnings in gamegrid

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58002 in the body.
You can then email your comments to 58002 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Emacs Bug Report <bug-gnu-emacs <at> gnu.org>
Cc: Dieter Deyke <dieter.deyke <at> gmail.com>,
 Stefan Kangas <stefankangas <at> gmail.com>
Subject: 29.1: Sokoban: obsoletion warnings in gamegrid
Date: Thu, 22 Sep 2022 12:06:27 +0200

[Message part 1 (text/plain, inline)]

On Emacs master, starting Sokoban (from GNU ELPA) results in several warnings:

> Warning (gamegrid): Using obsolete XEmacs style "glyph"; convert to an Emacs image-spec instead

which apparently is from

> (defvar sokoban-target-options
>   `(((glyph
>       [xpm :data ,sokoban-target-xpm])
[...]

where (after some digging) it seems that the vector needs to be

      ((:type xpm :data ,sokoban-target-xpm :ascent center)))

somewhat non-intuitively, because of the slightly alarming line

> 	   (find-image data)) ;untested!

in gamegrid.el. Suggested patch attached.
Is this all correct and as desired? Does it break anything when using old Emacs versions?

[sokoban-warning.diff (application/octet-stream, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dieter Deyke <dieter.deyke <at> gmail.com>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: Emacs Bug Report <bug-gnu-emacs <at> gnu.org>,
 Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: 29.1: Sokoban: obsoletion warnings in gamegrid
Date: Thu, 22 Sep 2022 14:29:45 +0200

Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:

> On Emacs master, starting Sokoban (from GNU ELPA) results in several warnings:
>
>> Warning (gamegrid): Using obsolete XEmacs style "glyph"; convert to an Emacs image-spec instead
>
> which apparently is from
>
>> (defvar sokoban-target-options
>>   `(((glyph
>>       [xpm :data ,sokoban-target-xpm])
> [...]
>
> where (after some digging) it seems that the vector needs to be
>
>       ((:type xpm :data ,sokoban-target-xpm :ascent center)))
>
> somewhat non-intuitively, because of the slightly alarming line
>
>> 	   (find-image data)) ;untested!
>
> in gamegrid.el. Suggested patch attached.
> Is this all correct and as desired? Does it break anything when using old Emacs versions?

Thanks for your efforts, but that patch does not silence the warnings on
my system. It looks like more is needed, but I do not know how to fix
it.

-- 
Dieter Deyke
mailto:dieter.deyke <at> gmail.com
Get my Gnupg key:
gpg --keyserver keys.gnupg.net --recv-keys B116EA20

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Dieter Deyke <dieter.deyke <at> gmail.com>
Cc: Emacs Bug Report <bug-gnu-emacs <at> gnu.org>,
 Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: 29.1: Sokoban: obsoletion warnings in gamegrid
Date: Thu, 22 Sep 2022 14:39:27 +0200

22 sep. 2022 kl. 14.29 skrev Dieter Deyke <dieter.deyke <at> gmail.com>:

> Thanks for your efforts, but that patch does not silence the warnings on
> my system. It looks like more is needed, but I do not know how to fix
> it.

That's odd. What warnings do you get with the patch applied?
And the usual IT support questions: Are you sure you are running the right file? Did you remember to recompile it?
Are you sure your computer is plugged in?

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dieter Deyke <dieter.deyke <at> gmail.com>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: Emacs Bug Report <bug-gnu-emacs <at> gnu.org>,
 Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: 29.1: Sokoban: obsoletion warnings in gamegrid
Date: Thu, 22 Sep 2022 14:54:26 +0200

Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:

> 22 sep. 2022 kl. 14.29 skrev Dieter Deyke <dieter.deyke <at> gmail.com>:
>
>> Thanks for your efforts, but that patch does not silence the warnings on
>> my system. It looks like more is needed, but I do not know how to fix
>> it.
>
> That's odd. What warnings do you get with the patch applied?
> And the usual IT support questions: Are you sure you are running the
> right file? Did you remember to recompile it?
> Are you sure your computer is plugged in?

Obviously not.  I patched the file, loaded it into an emacs buffer, did
an eval-buffer on it, followed by M-x sokoban. That was not good
enough. So I deleted the .elc file, killed, and re-started emacs, and
now everything is fine, and I stand there as a fool (but I get used to
that).  I do not know, how your patch will affect older emacs versions,
but if I get no negative feedback, I will apply the patch to the repo in
a week.

Thanks again.
-- 
Dieter Deyke
mailto:dieter.deyke <at> gmail.com
Get my Gnupg key:
gpg --keyserver keys.gnupg.net --recv-keys B116EA20

Message #17 received at 58002 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Dieter Deyke <dieter.deyke <at> gmail.com>, 
 Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: 58002 <at> debbugs.gnu.org
Subject: Re: 29.1: Sokoban: obsoletion warnings in gamegrid
Date: Thu, 22 Sep 2022 07:01:31 -0700

Dieter Deyke <dieter.deyke <at> gmail.com> writes:

> I do not know, how your patch will affect older emacs versions, but if
> I get no negative feedback, I will apply the patch to the repo in a
> week.

Thanks for the patch, Mattias.  I was meaning to look into this, but it
seems like you beat me to it.

I've done some minimal testing of the patch on Emacs 27.1 and current
master, and everything seems to work here.

Message #20 received at 58002 <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 58002 <at> debbugs.gnu.org, Dieter Deyke <dieter.deyke <at> gmail.com>
Subject: Re: 29.1: Sokoban: obsoletion warnings in gamegrid
Date: Fri, 23 Sep 2022 10:56:58 +0200

22 sep. 2022 kl. 16.01 skrev Stefan Kangas <stefankangas <at> gmail.com>:

> I was meaning to look into this, but it
> seems like you beat me to it.

We must get our priorities right, it's Sokoban after all!

> I've done some minimal testing of the patch on Emacs 27.1 and current
> master, and everything seems to work here.

Thank you. Let's see how far back in Emacs history Dieter wants to test it.
Oh, and about the

> 	   (find-image data)) ;untested!

in gamegrid-make-glyph, well that path isn't untested any more -- but the Sokoban patch works backwards from that code so it isn't really a proper validation. Then again, the ;untested! line is 20 years old so...

Message #25 received at 58002 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Dieter Deyke <dieter.deyke <at> gmail.com>
Cc: 58002 <at> debbugs.gnu.org,
 Mattias Engdegård <mattias.engdegard <at> gmail.com>
Subject: Re: bug#58002: 29.1: Sokoban: obsoletion warnings in gamegrid
Date: Sat, 12 Nov 2022 13:11:32 -0800

Dieter Deyke <dieter.deyke <at> gmail.com> writes:

> Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:
>
>> 22 sep. 2022 kl. 14.29 skrev Dieter Deyke <dieter.deyke <at> gmail.com>:
>>
>>> Thanks for your efforts, but that patch does not silence the warnings on
>>> my system. It looks like more is needed, but I do not know how to fix
>>> it.
>>
>> That's odd. What warnings do you get with the patch applied?
>> And the usual IT support questions: Are you sure you are running the
>> right file? Did you remember to recompile it?
>> Are you sure your computer is plugged in?
>
> Obviously not.  I patched the file, loaded it into an emacs buffer, did
> an eval-buffer on it, followed by M-x sokoban. That was not good
> enough. So I deleted the .elc file, killed, and re-started emacs, and
> now everything is fine, and I stand there as a fool (but I get used to
> that).  I do not know, how your patch will affect older emacs versions,
> but if I get no negative feedback, I will apply the patch to the repo in
> a week.

Was this patch installed?  Can the bug be closed?  Thanks in advance.

Message #30 received at 58002 <at> debbugs.gnu.org (full text, mbox):

From: Dieter Deyke <dieter.deyke <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 58002 <at> debbugs.gnu.org,
 Mattias Engdegård <mattias.engdegard <at> gmail.com>
Subject: Re: bug#58002: 29.1: Sokoban: obsoletion warnings in gamegrid
Date: Sun, 13 Nov 2022 07:17:41 +0100

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Dieter Deyke <dieter.deyke <at> gmail.com> writes:
>
>> Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:
>>
>>> 22 sep. 2022 kl. 14.29 skrev Dieter Deyke <dieter.deyke <at> gmail.com>:
>>>
>>>> Thanks for your efforts, but that patch does not silence the warnings on
>>>> my system. It looks like more is needed, but I do not know how to fix
>>>> it.
>>>
>>> That's odd. What warnings do you get with the patch applied?
>>> And the usual IT support questions: Are you sure you are running the
>>> right file? Did you remember to recompile it?
>>> Are you sure your computer is plugged in?
>>
>> Obviously not.  I patched the file, loaded it into an emacs buffer, did
>> an eval-buffer on it, followed by M-x sokoban. That was not good
>> enough. So I deleted the .elc file, killed, and re-started emacs, and
>> now everything is fine, and I stand there as a fool (but I get used to
>> that).  I do not know, how your patch will affect older emacs versions,
>> but if I get no negative feedback, I will apply the patch to the repo in
>> a week.
>
> Was this patch installed?  Can the bug be closed?  Thanks in advance.

Yes, the patch was installed, the warnings are gone, everything is fine
now. Please close the bug.

Thank you,
-- 
Dieter Deyke
mailto:dieter.deyke <at> gmail.com
Get my Gnupg key:
gpg --keyserver keys.gnupg.net --recv-keys B116EA20

Message #35 received at 58002-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Dieter Deyke <dieter.deyke <at> gmail.com>
Cc: 58002-done <at> debbugs.gnu.org,
 Mattias Engdegård <mattias.engdegard <at> gmail.com>
Subject: Re: bug#58002: 29.1: Sokoban: obsoletion warnings in gamegrid
Date: Sun, 13 Nov 2022 05:59:01 -0800

Dieter Deyke <dieter.deyke <at> gmail.com> writes:

> Yes, the patch was installed, the warnings are gone, everything is fine
> now. Please close the bug.

Thanks, done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.