GNU bug report logs - #58004
29.0.50; Bounding box of image-crop is unnoticable in certain cases

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58004 in the body.
You can then email your comments to 58004 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Bounding box of image-crop is unnoticable in certain cases
Date: Thu, 22 Sep 2022 19:54:10 +0530

[Message part 1 (text/plain, inline)]

Attached patch is an attempt to make the bounding box of image-crop more
noticeable.
If you're using image-crop in an image that is mostly white, then it is
very hard to notice the bounding box in a light theme.  I looked for a
way to draw a border around the lines in svg but was unable to find
anything so I settled for drawing a rectangle and darkening the inside
of that rectangle.  Alternatively, one can make the rectangle stroke red
since it is probably rare to come across an image that is mostly red.

Before and after can be tested on the attached image named
"vector_addition.png"

[0001-Make-bounding-box-of-image-crop-more-noticeable.patch (text/x-diff, attachment)]

[vector_addition.png (image/png, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: 29.0.50; Bounding box of image-crop is unnoticable in certain
 cases
Date: Fri, 23 Sep 2022 13:04:55 +0530

[Message part 1 (text/plain, inline)]

[வியாழன் செப்டம்பர் 22, 2022] Visuwesh wrote:

> Attached patch is an attempt to make the bounding box of image-crop more
> noticeable.

Revised patch attached.  I decided to make the stroke colour red since
white was not exactly noticeable, and decreased the size of stroke width
since darkening makes the bounding box noticeable enough.

[0001-Make-bounding-box-of-image-crop-more-noticeable.patch (text/x-diff, attachment)]

Message #11 received at 58004 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 58004 <at> debbugs.gnu.org
Subject: Re: bug#58004: 29.0.50; Bounding box of image-crop is unnoticable
 in certain cases
Date: Fri, 23 Sep 2022 18:11:42 +0200

Visuwesh <visuweshm <at> gmail.com> writes:

> Revised patch attached.  I decided to make the stroke colour red since
> white was not exactly noticeable, and decreased the size of stroke width
> since darkening makes the bounding box noticeable enough.

Looks very nice; pushed to Emacs 29.

Message #16 received at 58004 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 58004 <at> debbugs.gnu.org
Subject: Re: bug#58004: 29.0.50; Bounding box of image-crop is unnoticable
 in certain cases
Date: Fri, 23 Sep 2022 21:59:40 +0530

[வெள்ளி செப்டம்பர் 23, 2022] Lars Ingebrigtsen wrote:

> Looks very nice; pushed to Emacs 29.

Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.