GNU bug report logs - #58024
[PATCH] gnu: services: certbot: Add missing activation directory

Previous Next

Package: guix-patches;

Reported by: Mája Tomášek <maya.tomasek <at> disroot.org>

Date: Fri, 23 Sep 2022 12:59:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58024 in the body.
You can then email your comments to 58024 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#58024; Package guix-patches. (Fri, 23 Sep 2022 12:59:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Mája Tomášek <maya.tomasek <at> disroot.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 23 Sep 2022 12:59:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mája Tomášek <maya.tomasek <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: services: certbot: Add missing activation directory
Date: Fri, 23 Sep 2022 12:27:03 +0200
When trying to run certbot, the mcron command fails, as
 /etc/letsencrypt/live is missing. This patch Adds it into the certbot
 activation service.

 ---
 gnu/services/certbot.scm | 2 ++
 1 file changed, 2 insertions(+)

 diff --git a/gnu/services/certbot.scm b/gnu/services/certbot.scm
 index 1c819bef48..7dfdad9874 100644
 --- a/gnu/services/certbot.scm
 +++ b/gnu/services/certbot.scm
 @@ -154,6 +154,7 @@ (define (certbot-renewal-jobs config)
 
 (define (certbot-activation config)
   (let* ((certbot-directory "/var/lib/certbot")
 +         (certbot-cert-directory "/etc/letsencrypt/live")
          (script (in-vicinity certbot-directory "renew-certificates"))
          (message (format #f (G_ "~a may need to be run~%") script)))
     (match config
 @@ -164,6 +165,7 @@ (define (certbot-activation config)
              (use-modules (guix build utils))
              (mkdir-p #$webroot)
              (mkdir-p #$certbot-directory)
 +             (mkdir-p #$certbot-cert-directory)
              (copy-file #$(certbot-command config) #$script)
              (display #$message)))))))
 
 -- 
 2.37.3




Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Thu, 29 Sep 2022 20:57:01 GMT) Full text and rfc822 format available.

Notification sent to Mája Tomášek <maya.tomasek <at> disroot.org>:
bug acknowledged by developer. (Thu, 29 Sep 2022 20:57:02 GMT) Full text and rfc822 format available.

Message #10 received at 58024-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Mája Tomášek <maya.tomasek <at> disroot.org>
Cc: 58024-done <at> debbugs.gnu.org
Subject: Re: bug#58024: [PATCH] gnu: services: certbot: Add missing
 activation directory
Date: Thu, 29 Sep 2022 22:56:15 +0200
Hi,

Mája Tomášek <maya.tomasek <at> disroot.org> skribis:

> When trying to run certbot, the mcron command fails, as
>  /etc/letsencrypt/live is missing. This patch Adds it into the certbot
>  activation service.

I adjusted the commit log to follow our conventions and applied it.

Thanks!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 28 Oct 2022 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 179 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.