GNU bug report logs - #58040
"guix style" puts closing parentheses on the wrong line

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58040 in the body.
You can then email your comments to 58040 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: bug-guix <bug-guix <at> gnu.org>
Subject: "guix style" puts closing parentheses on the wrong line
Date: Sat, 24 Sep 2022 12:18:32 +0200

[Message part 1 (text/plain, inline)]

Hi,

Putting the following definition into a file a.scm (from 
https://issues.guix.gnu.org/57460):

(define (find-latest-release releases)
  (fold (match-lambda*
         (((key . value) result)
          (cond ((even-minor-version? key)
                 (match result
			(#f
			 (cons key value))
			((newest . _)
			 (if (version>? key newest)
                             (cons key value)
                             result))))
                (else
                 result))))
        #f
        releases))

and running "guix style -f a.scm" on it, it becomes

(define (find-latest-release releases)
  (fold (match-lambda* (((key . value) result)
                        (cond
                          ((even-minor-version? key)
                           (match result
                             (#f (cons key value))
                             ((newest . _) (if (version>? key newest)
                                               (cons key value) result))))
                          (else result)))
          ) #f releases)).

In particular, note the ") #f releases" -- IMO ) should be on the 
previous line, after (else result))), to avoid lonely parentheses and to 
align the arguments of 'fold'.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #10 received at 58040-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 58040-done <at> debbugs.gnu.org
Subject: Re: bug#58040: "guix style" puts closing parentheses on the wrong line
Date: Mon, 03 Oct 2022 00:12:40 +0200

Hi,

Maxime Devos <maximedevos <at> telenet.be> skribis:

> and running "guix style -f a.scm" on it, it becomes
>
> (define (find-latest-release releases)
>   (fold (match-lambda* (((key . value) result)
>                         (cond
>                           ((even-minor-version? key)
>                            (match result
>                              (#f (cons key value))
>                              ((newest . _) (if (version>? key newest)
>                                                (cons key value) result))))
>                           (else result)))
>           ) #f releases)).
>
> In particular, note the ") #f releases" -- IMO ) should be on the
> previous line, after (else result))), to avoid lonely parentheses and
> to align the arguments of 'fold'.

Fixed in 4bd75d79e5ad8bb0f6cdcc0d15b9afb25f54afbd: ‘match-lambda*’ had
an incorrect special form declaration.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.