GNU bug report logs - #58055
[PATCH 0/1] Add emacs-orgmd

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58055 in the body.
You can then email your comments to 58055 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Fredrik Salomonsson <plattfot <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Fredrik Salomonsson <plattfot <at> posteo.net>
Subject: [PATCH 0/1] Add emacs-orgmd
Date: Sun, 25 Sep 2022 00:37:50 +0000

An Emacs' Org mode watchlist manager and OMDb API client.

Fredrik Salomonsson (1):
  gnu: Add emacs-orgmdb.

 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)


base-commit: fc07082fe3d750c85282c4aa57d01a36ebe9296b
-- 
2.37.3

Message #8 received at 58055 <at> debbugs.gnu.org (full text, mbox):

From: Fredrik Salomonsson <plattfot <at> posteo.net>
To: 58055 <at> debbugs.gnu.org
Cc: Fredrik Salomonsson <plattfot <at> posteo.net>
Subject: [PATCH 1/1] gnu: Add emacs-orgmdb.
Date: Sun, 25 Sep 2022 00:49:57 +0000

* gnu/packages/emacs-xyz.scm (emacs-orgmdb): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0e3e0be3b8..5572564b6d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -6010,6 +6010,32 @@ (define-public emacs-org-now
 their original location with another.")
       (license license:gpl3+))))
 
+(define-public emacs-orgmdb
+  (package
+   (name "emacs-orgmdb")
+   (version "0.5")
+   (source
+    (origin
+     (method git-fetch)
+     (uri (git-reference
+           (url "https://github.com/isamert/orgmdb.el")
+           (commit "66c13abdb84e0f0a31bae6cfda27478771d58d8e")))
+     (sha256
+      (base32
+       "1hvxha0ih9jhvwj07l6jnpf2vzhgvb6ii73g49c8saxld61l0frf"))
+     (file-name (git-file-name name version))))
+   (build-system emacs-build-system)
+   (propagated-inputs
+    (list
+     emacs-s
+     emacs-dash
+     emacs-org))
+   (home-page "https://github.com/isamert/orgmdb.el")
+   (synopsis "An Emacs' Org mode watchlist manager and OMDb API client")
+   (description "This package adds tools for managing your watchlist in Emacs' Org
+mode and some functions for interacting with the OMDb API.")
+   (license license:gpl3+)))
+
 (define-public emacs-rich-minority
   (package
     (name "emacs-rich-minority")
-- 
2.37.3

Message #13 received at 58055-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Fredrik Salomonsson <plattfot <at> posteo.net>
Cc: 58055-done <at> debbugs.gnu.org
Subject: Re: [bug#58055] [PATCH 1/1] gnu: Add emacs-orgmdb.
Date: Sun, 25 Sep 2022 15:18:59 +0200

Hello,

Fredrik Salomonsson <plattfot <at> posteo.net> writes:

> * gnu/packages/emacs-xyz.scm (emacs-orgmdb): New variable.

Thank you. I applied the patch with the following changes:

> +   (propagated-inputs
> +    (list
> +     emacs-s
> +     emacs-dash
> +     emacs-org))

I reordered inputs alphabetically.

> +   (home-page "https://github.com/isamert/orgmdb.el")
> +   (synopsis "An Emacs' Org mode watchlist manager and OMDb API client")

I removed the article "An".

Regards,
-- 
Nicolas Goaziou

Message #16 received at 58055 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Fredrik Salomonsson <plattfot <at> posteo.net>, 58055 <at> debbugs.gnu.org
Subject: Re: [bug#58055] [PATCH 0/1] Add emacs-orgmd
Date: Sun, 25 Sep 2022 19:40:14 +0200

[Message part 1 (text/plain, inline)]

On 25-09-2022 02:37, Fredrik Salomonsson wrote:
> An Emacs' Org mode watchlist manager and OMDb API client.
> 
> Fredrik Salomonsson (1):
>    gnu: Add emacs-orgmdb.
> 
>   gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
>   1 file changed, 26 insertions(+)
> 
> 
> base-commit: fc07082fe3d750c85282c4aa57d01a36ebe9296b

Have you tested this in a pure environment?  Going by 
<https://github.com/isamert/orgmdb.el/blob/66c13abdb84e0f0a31bae6cfda27478771d58d8e/orgmdb.el#L663>, 
it requires 'fd' to work, but 'fd is not mentioned in the propagated 
inputs and neither is it mentioned in the 'inputs' + appropriate 
substitute*.

I recommend the latter, and in the future having a quick look at the 
source code to see if it invokes some software (Emacs additions are 
usually short).

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #19 received at 58055-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: Fredrik Salomonsson <plattfot <at> posteo.net>, 58055-done <at> debbugs.gnu.org
Subject: Re: [bug#58055] [PATCH 0/1] Add emacs-orgmd
Date: Sun, 25 Sep 2022 21:10:28 +0200

Hello,

Maxime Devos <maximedevos <at> telenet.be> writes:

> On 25-09-2022 02:37, Fredrik Salomonsson wrote:
>> An Emacs' Org mode watchlist manager and OMDb API client.
>> Fredrik Salomonsson (1):
>>    gnu: Add emacs-orgmdb.
>>   gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
>>   1 file changed, 26 insertions(+)
>> base-commit: fc07082fe3d750c85282c4aa57d01a36ebe9296b
>
> Have you tested this in a pure environment?  Going by
> <https://github.com/isamert/orgmdb.el/blob/66c13abdb84e0f0a31bae6cfda27478771d58d8e/orgmdb.el#L663>,
> it requires 'fd' to work, but 'fd is not mentioned in the propagated
> inputs and neither is it mentioned in the 'inputs' + appropriate
> substitute*.
>
> I recommend the latter, and in the future having a quick look at the
> source code to see if it invokes some software (Emacs additions are
> usually short).

Fixed in 31593237f6aa82ce29e0ecf1911e64713e21ddcb. Thanks for the heads up.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.