GNU bug report logs - #58078
[PATCH 0/2] Fix two emacs packages with native compilation.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58078 in the body.
You can then email your comments to 58078 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH 0/2] Fix two emacs packages with native compilation.
Date: Sun, 25 Sep 2022 16:25:56 +0000

Hi,

I noticed that emacs-pdf-tools was failing if trying to native compile at build with --with-input=emacs-minimal=emacs as noted in the recent native compilation news. The error was just an exit status of 255, but I diagnosed by running the given compilation command in emacs to find the problem. The culprit is missing the phase that adds the install directory to the native load path (where emacs will try to write the compiled files) for this package as it manually pulls in the emacs build phases. Simply adding this missing phase (new with native compilation) fixes the problem.

While I was at it, I checked for any other packages with a similar problem, with a quick search through emacs-xyz. I found only emacs-libgit and fixed it similarly. I may have missed others or in other modules, but pdf-tools was the only one so far from my emacs packages.

I checked that both packages build normally and with native compilation, and checked that those that depend on emacs-libgit built fine too.

Thanks!
John

Message #8 received at 58078 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: 58078 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: emacs-pdf-tools: Fix build with native compilation.
Date: Sun, 25 Sep 2022 16:28:39 +0000

[Message part 1 (text/plain, inline)]

Empty Message

[0001-gnu-emacs-pdf-tools-Fix-build-with-native-compilatio.patch (text/x-patch, attachment)]

Message #11 received at 58078 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: 58078 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: emacs-libgit: Fix build with native compilation.
Date: Sun, 25 Sep 2022 16:29:27 +0000

[Message part 1 (text/plain, inline)]

Empty Message

[0002-gnu-emacs-libgit-Fix-build-with-native-compilation.patch (text/x-patch, attachment)]

Message #16 received at 58078-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: John Kehayias <john.kehayias <at> protonmail.com>, 58078-done <at> debbugs.gnu.org
Subject: Re: [PATCH 2/2] gnu: emacs-libgit: Fix build with native compilation.
Date: Sun, 25 Sep 2022 19:30:19 +0200

Pushed both to master.

Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.