GNU bug report logs - #58098
Improve composition rules for Gumrukhi

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58098 in the body.
You can then email your comments to 58098 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Improve composition rules for Gumrukhi
Date: Tue, 27 Sep 2022 00:13:07 +0530

[Message part 1 (text/plain, inline)]

Hi
In this patch I have added support for Gurmukhi Addak, Yakash, Udaat etc to
improve its composition rules.
I have also added the word "Gurmukhi" to the doc-string of punjabi-itrans
and punjabi-inscript so that they could be more easily found.

Finally I have also added support for chess symbols.

Please review the patch, it will be attached in the next mail.
Thanks.

[Message part 2 (text/html, inline)]

Message #8 received at 58098 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: 58098 <at> debbugs.gnu.org
Subject: Re: Improve composition rules for Gumrukhi
Date: Tue, 27 Sep 2022 00:17:49 +0530

[Message part 1 (text/plain, inline)]

On Tue, Sep 27, 2022 at 12:13 AM समीर सिंह Sameer Singh <
lumarzeli30 <at> gmail.com> wrote:

> Hi
> In this patch I have added support for Gurmukhi Addak, Yakash, Udaat etc
> to improve its composition rules.
> I have also added the word "Gurmukhi" to the doc-string of punjabi-itrans
> and punjabi-inscript so that they could be more easily found.
>
> Finally I have also added support for chess symbols.
>
> Please review the patch, it will be attached in the next mail.
> Thanks.
>

[Message part 2 (text/html, inline)]

[0001-Improve-Gurmukhi-composition-rules-Bug-58098.patch (text/x-patch, attachment)]

Message #11 received at 58098 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: 58098 <at> debbugs.gnu.org
Subject: Re: Improve composition rules for Gumrukhi
Date: Tue, 27 Sep 2022 01:30:31 +0530

[Message part 1 (text/plain, inline)]

Looks like I was wrong about adding "Gurmukhi" to the doc-strings in the
input method, they do not show up and will also not improve
searchability even if they were there, so here is the revised patch without
it.

On Tue, Sep 27, 2022 at 12:17 AM समीर सिंह Sameer Singh <
lumarzeli30 <at> gmail.com> wrote:

>
>
> On Tue, Sep 27, 2022 at 12:13 AM समीर सिंह Sameer Singh <
> lumarzeli30 <at> gmail.com> wrote:
>
>> Hi
>> In this patch I have added support for Gurmukhi Addak, Yakash, Udaat etc
>> to improve its composition rules.
>> I have also added the word "Gurmukhi" to the doc-string of punjabi-itrans
>> and punjabi-inscript so that they could be more easily found.
>>
>> Finally I have also added support for chess symbols.
>>
>> Please review the patch, it will be attached in the next mail.
>> Thanks.
>>
>

[Message part 2 (text/html, inline)]

[0001-Improve-Gurmukhi-composition-rules-Bug-58098.patch (text/x-patch, attachment)]

Message #14 received at 58098 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58098 <at> debbugs.gnu.org
Subject: Re: bug#58098: Improve composition rules for Gumrukhi
Date: Tue, 27 Sep 2022 16:12:57 +0300

> From: समीर सिंह Sameer Singh
>  <lumarzeli30 <at> gmail.com>
> Date: Tue, 27 Sep 2022 01:30:31 +0530
> 
> --- a/lisp/international/fontset.el
> +++ b/lisp/international/fontset.el
> @@ -300,7 +300,8 @@ font-encoding-charset-alist
>  	(ottoman-siyaq-number #x1ed01)
>  	(mahjong-tile #x1F000)
>  	(domino-tile #x1F030)
> -        (emoji #x1F300 #x1F600)))
> +        (emoji #x1F300 #x1F600)
> +        (chess-symbol #x1FA00 #x1FA67)))

I don't understand this part: why should we require #x1FA67?  Did you
perhaps mean this:

      (chess-symbol . [#x1FA00 #x1FA67])

> @@ -836,7 +837,8 @@ setup-default-fontset
>                      tai-tham
>  		    mahjong-tile
>  		    domino-tile
> -                    emoji))
> +                    emoji
> +                    chess-symbol))

We already have the setup for chess-symbol, below this line where you
are making changes.  Is it not enough for some reason?

Message #17 received at 58098 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58098 <at> debbugs.gnu.org
Subject: Re: bug#58098: Improve composition rules for Gumrukhi
Date: Tue, 27 Sep 2022 19:22:09 +0530

[Message part 1 (text/plain, inline)]

>
> I don't understand this part: why should we require #x1FA67?  Did you
> perhaps mean this:
>
>       (chess-symbol . [#x1FA00 #x1FA67])


Isn't the script-representative-chars used to improve font selection by
requesting more characters?
So does the specific character requested have any effect? because I chose
it randomly.

We already have the setup for chess-symbol, below this line where you
> are making changes.  Is it not enough for some reason?
>

Prior to this patch the chess symbol block was not rendered on my machine
despite having its font (Noto Sans Symbols2)

On Tue, Sep 27, 2022 at 6:43 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh
> >  <lumarzeli30 <at> gmail.com>
> > Date: Tue, 27 Sep 2022 01:30:31 +0530
> >
> > --- a/lisp/international/fontset.el
> > +++ b/lisp/international/fontset.el
> > @@ -300,7 +300,8 @@ font-encoding-charset-alist
> >       (ottoman-siyaq-number #x1ed01)
> >       (mahjong-tile #x1F000)
> >       (domino-tile #x1F030)
> > -        (emoji #x1F300 #x1F600)))
> > +        (emoji #x1F300 #x1F600)
> > +        (chess-symbol #x1FA00 #x1FA67)))
>
> I don't understand this part: why should we require #x1FA67?  Did you
> perhaps mean this:
>
>       (chess-symbol . [#x1FA00 #x1FA67])
>
> > @@ -836,7 +837,8 @@ setup-default-fontset
> >                      tai-tham
> >                   mahjong-tile
> >                   domino-tile
> > -                    emoji))
> > +                    emoji
> > +                    chess-symbol))
>
> We already have the setup for chess-symbol, below this line where you
> are making changes.  Is it not enough for some reason?
>

[Message part 2 (text/html, inline)]

Message #20 received at 58098 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58098 <at> debbugs.gnu.org
Subject: Re: bug#58098: Improve composition rules for Gumrukhi
Date: Tue, 27 Sep 2022 17:08:12 +0300

> From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> Date: Tue, 27 Sep 2022 19:22:09 +0530
> Cc: 58098 <at> debbugs.gnu.org
> 
>  I don't understand this part: why should we require #x1FA67?  Did you
>  perhaps mean this:
> 
>        (chess-symbol . [#x1FA00 #x1FA67])
> 
> Isn't the script-representative-chars used to improve font selection by requesting more characters?
> So does the specific character requested have any effect? because I chose it randomly.

The form

       (chess-symbol #x1FA00 #x1FA67)

requires that _both_ #x1FA00 and #x1FA67 be supported by a font, for
it to be eligible to display chess-symbols.  By contrast, the form

       (chess-symbol . [#x1FA00 #x1FA67])

requires that _either_ of the two characters is supported.  So my
question is: do we really want _both_ of the characters supported by a
font, and if not, do we really want Emacs to reject such a font?

Did you look at what #x1FA67 looks like?  It is not a "traditional"
chess symbol.  And neither are the characters that are its neighbors.

>  We already have the setup for chess-symbol, below this line where you
>  are making changes.  Is it not enough for some reason?
> 
> Prior to this patch the chess symbol block was not rendered on my machine despite having its font (Noto
> Sans Symbols2) 

You don't have Symbola installed?

Message #23 received at 58098 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58098 <at> debbugs.gnu.org
Subject: Re: bug#58098: Improve composition rules for Gumrukhi
Date: Tue, 27 Sep 2022 20:54:22 +0530

[Message part 1 (text/plain, inline)]

The form
>
>        (chess-symbol #x1FA00 #x1FA67)
>
> requires that _both_ #x1FA00 and #x1FA67 be supported by a font, for
> it to be eligible to display chess-symbols.  By contrast, the form
>
>        (chess-symbol . [#x1FA00 #x1FA67])
>
> requires that _either_ of the two characters is supported.  So my
> question is: do we really want _both_ of the characters supported by a
> font, and if not, do we really want Emacs to reject such a font?
>

I have updated the patch accordingly and replaced (chess-symbol #x1FA00
#x1FA67) with  (chess-symbol . [#x1FA00 #x1FA67])

> You don't have Symbola installed?

I have the Symbola font installed via the gdouros-symbola-fonts package on
my Fedora37 system, but it does not seem to support
the chess-symbols block as verified by hb-view.
Its description in the fedora wiki also does not mention the chess-symbols
block:

> Symbola covers the following scripts and symbols supported by The Unicode
> Standard 5.2: Basic Latin, Latin-1 Supplement, Latin Extended-A, IPA
> Extensions, Spacing Modifier Letters, Greek and Coptic, Cyrillic, Cyrillic
> Supplementary, General Punctuation, Superscripts and Subscripts, Combining
> Diacritical Marks for Symbols, Letterlike Symbols, Number Forms, Arrows,
> Mathematical Operators, Miscellaneous Technical, Control Pictures, Optical
> Character Recognition, Box Drawing, Block Elements, Geometric Shapes,
> Miscellaneous Symbols, Dingbats, Miscellaneous Mathematical Symbols-A,
> Supplemental Arrows-A, Supplemental Arrows-B, Miscellaneous Mathematical
> Symbols-B, Supplemental Mathematical Operators, Miscellaneous Symbols and
> Arrows, Supplemental Punctuation, CJK Symbols and Punctuation, Yijing
> Hexagram Symbols, Vertical Forms, Combining Half Marks, CJK Compatibility
> Forms, Specials, Tai Xuan Jing Symbols, Counting Rod Numerals, Mathematical
> Alphanumeric Symbols, Mahjong Tile Symbols, Domino Tile Symbols.
>

On Tue, Sep 27, 2022 at 7:38 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> > Date: Tue, 27 Sep 2022 19:22:09 +0530
> > Cc: 58098 <at> debbugs.gnu.org
> >
> >  I don't understand this part: why should we require #x1FA67?  Did you
> >  perhaps mean this:
> >
> >        (chess-symbol . [#x1FA00 #x1FA67])
> >
> > Isn't the script-representative-chars used to improve font selection by
> requesting more characters?
> > So does the specific character requested have any effect? because I
> chose it randomly.
>
> The form
>
>        (chess-symbol #x1FA00 #x1FA67)
>
> requires that _both_ #x1FA00 and #x1FA67 be supported by a font, for
> it to be eligible to display chess-symbols.  By contrast, the form
>
>        (chess-symbol . [#x1FA00 #x1FA67])
>
> requires that _either_ of the two characters is supported.  So my
> question is: do we really want _both_ of the characters supported by a
> font, and if not, do we really want Emacs to reject such a font?
>
> Did you look at what #x1FA67 looks like?  It is not a "traditional"
> chess symbol.  And neither are the characters that are its neighbors.
>
> >  We already have the setup for chess-symbol, below this line where you
> >  are making changes.  Is it not enough for some reason?
> >
> > Prior to this patch the chess symbol block was not rendered on my
> machine despite having its font (Noto
> > Sans Symbols2)
>
> You don't have Symbola installed?
>

[Message part 2 (text/html, inline)]

[0001-Improve-Gurmukhi-composition-rules-Bug-58098.patch (text/x-patch, attachment)]

Message #28 received at 58098-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58098-done <at> debbugs.gnu.org
Subject: Re: bug#58098: Improve composition rules for Gumrukhi
Date: Wed, 28 Sep 2022 15:39:12 +0300

> From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> Date: Tue, 27 Sep 2022 20:54:22 +0530
> Cc: 58098 <at> debbugs.gnu.org
> 
>  The form
> 
>         (chess-symbol #x1FA00 #x1FA67)
> 
>  requires that _both_ #x1FA00 and #x1FA67 be supported by a font, for
>  it to be eligible to display chess-symbols.  By contrast, the form
> 
>         (chess-symbol . [#x1FA00 #x1FA67])
> 
>  requires that _either_ of the two characters is supported.  So my
>  question is: do we really want _both_ of the characters supported by a
>  font, and if not, do we really want Emacs to reject such a font?
> 
>  I have updated the patch accordingly and replaced (chess-symbol #x1FA00 #x1FA67) with 
>  (chess-symbol . [#x1FA00 #x1FA67])
> 
>  > You don't have Symbola installed?
> 
>  I have the Symbola font installed via the gdouros-symbola-fonts package on my Fedora37 system, but
>  it does not seem to support
>  the chess-symbols block as verified by hb-view.
>  Its description in the fedora wiki also does not mention the chess-symbols block:
> 
>  Symbola covers the following scripts and symbols supported by The Unicode Standard 5.2:
>  Basic Latin, Latin-1 Supplement, Latin Extended-A, IPA Extensions, Spacing Modifier Letters,
>  Greek and Coptic, Cyrillic, Cyrillic Supplementary, General Punctuation, Superscripts and
>  Subscripts, Combining Diacritical Marks for Symbols, Letterlike Symbols, Number Forms,
>  Arrows, Mathematical Operators, Miscellaneous Technical, Control Pictures, Optical Character
>  Recognition, Box Drawing, Block Elements, Geometric Shapes, Miscellaneous Symbols,
>  Dingbats, Miscellaneous Mathematical Symbols-A, Supplemental Arrows-A, Supplemental
>  Arrows-B, Miscellaneous Mathematical Symbols-B, Supplemental Mathematical Operators,
>  Miscellaneous Symbols and Arrows, Supplemental Punctuation, CJK Symbols and Punctuation,
>  Yijing Hexagram Symbols, Vertical Forms, Combining Half Marks, CJK Compatibility Forms,
>  Specials, Tai Xuan Jing Symbols, Counting Rod Numerals, Mathematical Alphanumeric
>  Symbols, Mahjong Tile Symbols, Domino Tile Symbols. 

OK, I installed this on master.

Message #31 received at 58098-done <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58098-done <at> debbugs.gnu.org
Subject: Re: bug#58098: Improve composition rules for Gumrukhi
Date: Wed, 28 Sep 2022 18:27:26 +0530

[Message part 1 (text/plain, inline)]

Thanks!

On Wed, Sep 28, 2022 at 6:09 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> > Date: Tue, 27 Sep 2022 20:54:22 +0530
> > Cc: 58098 <at> debbugs.gnu.org
> >
> >  The form
> >
> >         (chess-symbol #x1FA00 #x1FA67)
> >
> >  requires that _both_ #x1FA00 and #x1FA67 be supported by a font, for
> >  it to be eligible to display chess-symbols.  By contrast, the form
> >
> >         (chess-symbol . [#x1FA00 #x1FA67])
> >
> >  requires that _either_ of the two characters is supported.  So my
> >  question is: do we really want _both_ of the characters supported by a
> >  font, and if not, do we really want Emacs to reject such a font?
> >
> >  I have updated the patch accordingly and replaced (chess-symbol #x1FA00
> #x1FA67) with
> >  (chess-symbol . [#x1FA00 #x1FA67])
> >
> >  > You don't have Symbola installed?
> >
> >  I have the Symbola font installed via the gdouros-symbola-fonts package
> on my Fedora37 system, but
> >  it does not seem to support
> >  the chess-symbols block as verified by hb-view.
> >  Its description in the fedora wiki also does not mention the
> chess-symbols block:
> >
> >  Symbola covers the following scripts and symbols supported by The
> Unicode Standard 5.2:
> >  Basic Latin, Latin-1 Supplement, Latin Extended-A, IPA Extensions,
> Spacing Modifier Letters,
> >  Greek and Coptic, Cyrillic, Cyrillic Supplementary, General
> Punctuation, Superscripts and
> >  Subscripts, Combining Diacritical Marks for Symbols, Letterlike
> Symbols, Number Forms,
> >  Arrows, Mathematical Operators, Miscellaneous Technical, Control
> Pictures, Optical Character
> >  Recognition, Box Drawing, Block Elements, Geometric Shapes,
> Miscellaneous Symbols,
> >  Dingbats, Miscellaneous Mathematical Symbols-A, Supplemental Arrows-A,
> Supplemental
> >  Arrows-B, Miscellaneous Mathematical Symbols-B, Supplemental
> Mathematical Operators,
> >  Miscellaneous Symbols and Arrows, Supplemental Punctuation, CJK Symbols
> and Punctuation,
> >  Yijing Hexagram Symbols, Vertical Forms, Combining Half Marks, CJK
> Compatibility Forms,
> >  Specials, Tai Xuan Jing Symbols, Counting Rod Numerals, Mathematical
> Alphanumeric
> >  Symbols, Mahjong Tile Symbols, Domino Tile Symbols.
>
> OK, I installed this on master.
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.