GNU bug report logs - #58111
[PATCH] Add support for the Adlam script

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58111 in the body.
You can then email your comments to 58111 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add support for the Adlam script
Date: Tue, 27 Sep 2022 16:49:18 +0530

[Message part 1 (text/plain, inline)]

Adlam script is added to Emacs this time.

Please review the patch (which will be attached in the next mail)
Thanks

[Message part 2 (text/html, inline)]

Message #8 received at 58111 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: 58111 <at> debbugs.gnu.org
Subject: Re: [PATCH] Add support for the Adlam script
Date: Tue, 27 Sep 2022 16:52:22 +0530

[Message part 1 (text/plain, inline)]

On Tue, Sep 27, 2022 at 4:49 PM समीर सिंह Sameer Singh <
lumarzeli30 <at> gmail.com> wrote:

> Adlam script is added to Emacs this time.
>
> Please review the patch (which will be attached in the next mail)
> Thanks
>

[Message part 2 (text/html, inline)]

[0001-Add-support-for-the-Adlam-script-bug-58111.patch (text/x-patch, attachment)]

Message #11 received at 58111 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58111 <at> debbugs.gnu.org
Subject: Re: bug#58111: [PATCH] Add support for the Adlam script
Date: Tue, 27 Sep 2022 15:05:45 +0200

>>>>> On Tue, 27 Sep 2022 16:52:22 +0530, समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com> said:


    समीर> * lisp/language/misc-lang.el ("Adlam"): New language environment.
    समीर> Add composition rules for Adlam. Add sample text and input method.

Two spaces after full stop.

    समीर> @@ -1229,10 +1229,9 @@ to edit such sequences by allowing point to "enter" the sequence.
    समीर>  *** Support for many old scripts and writing systems.
    समीर>  Emacs now supports and has language-environments and input methods for
    समीर>  several dozens of old scripts that were used in the past for various
    समीर> -languages in South and South-East Asia.  For each such script Emacs
    समीर> -now has font-selection and character composition rules, a language
    समीर> -environment, and an input method.  The newly-added scripts and the
    समीर> -corresponding language environments are:
    समीर> +languages.  For each such script Emacs now has font-selection and character
    समीर> +composition rules, a language environment, and an input method.  The newly-added
    समीर> +scripts and the corresponding language environments are:

I think this text should be re-wrapped ('M-q')

    समीर> +(quail-define-package
    समीर> + "adlam" "Adlam" "𞤀" t "Adlam input method.
    समीर> +
    समीर> + `\\=`' is used to switch levels instead of Alt-Gr.

Are the `' necessary around the "\\=" ?

The rest looks good to a limited Latin-1 person such as myself :-)

Thanks for doing this.

Robert
-- 

Message #14 received at 58111 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58111 <at> debbugs.gnu.org
Subject: Re: bug#58111: [PATCH] Add support for the Adlam script
Date: Tue, 27 Sep 2022 16:15:34 +0300

> From: समीर सिंह Sameer Singh
>  <lumarzeli30 <at> gmail.com>
> Date: Tue, 27 Sep 2022 16:52:22 +0530
> 
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -1229,10 +1229,9 @@ to edit such sequences by allowing point to "enter" the sequence.
>  *** Support for many old scripts and writing systems.
>  Emacs now supports and has language-environments and input methods for
>  several dozens of old scripts that were used in the past for various
> -languages in South and South-East Asia.  For each such script Emacs
> -now has font-selection and character composition rules, a language
> -environment, and an input method.  The newly-added scripts and the
> -corresponding language environments are:
> +languages.  For each such script Emacs now has font-selection and character
> +composition rules, a language environment, and an input method.  The newly-added
> +scripts and the corresponding language environments are:

The new text needs to be re-filled.

> +;; Adlam composition rules
> +(set-char-table-range
> + composition-function-table
> + '(#x1E900 . #x1E95F)
> + (list (vector
> +        "[\x1E900-\x1E95F]+"
> +        1 'font-shape-gstring)))

This doesn't look right: why 1 and not 0?

Message #17 received at 58111 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 58111 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#58111: [PATCH] Add support for the Adlam script
Date: Tue, 27 Sep 2022 21:12:30 +0530

[Message part 1 (text/plain, inline)]

>
> I think this text should be re-wrapped ('M-q')


Will do, thanks

Are the `' necessary around the "\\=" ?
>

Not really, but there is also no harm letting them be there. They are also
in the other input methods which I have added.
See in indian.el, philippine.el, indonesian.el etc
This was copied from the brahmi input method written by Eli.

On Tue, Sep 27, 2022 at 6:35 PM Robert Pluim <rpluim <at> gmail.com> wrote:

> >>>>> On Tue, 27 Sep 2022 16:52:22 +0530, समीर सिंह Sameer Singh <
> lumarzeli30 <at> gmail.com> said:
>
>
>     समीर> * lisp/language/misc-lang.el ("Adlam"): New language environment.
>     समीर> Add composition rules for Adlam. Add sample text and input
> method.
>
> Two spaces after full stop.
>
>     समीर> @@ -1229,10 +1229,9 @@ to edit such sequences by allowing point
> to "enter" the sequence.
>     समीर>  *** Support for many old scripts and writing systems.
>     समीर>  Emacs now supports and has language-environments and input
> methods for
>     समीर>  several dozens of old scripts that were used in the past for
> various
>     समीर> -languages in South and South-East Asia.  For each such script
> Emacs
>     समीर> -now has font-selection and character composition rules, a
> language
>     समीर> -environment, and an input method.  The newly-added scripts and
> the
>     समीर> -corresponding language environments are:
>     समीर> +languages.  For each such script Emacs now has font-selection
> and character
>     समीर> +composition rules, a language environment, and an input
> method.  The newly-added
>     समीर> +scripts and the corresponding language environments are:
>
> I think this text should be re-wrapped ('M-q')
>
>     समीर> +(quail-define-package
>     समीर> + "adlam" "Adlam" "𞤀" t "Adlam input method.
>     समीर> +
>     समीर> + `\\=`' is used to switch levels instead of Alt-Gr.
>
> Are the `' necessary around the "\\=" ?
>
> The rest looks good to a limited Latin-1 person such as myself :-)
>
> Thanks for doing this.
>
> Robert
> --
>

[Message part 2 (text/html, inline)]

Message #20 received at 58111 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58111 <at> debbugs.gnu.org
Subject: Re: bug#58111: [PATCH] Add support for the Adlam script
Date: Tue, 27 Sep 2022 21:23:40 +0530

[Message part 1 (text/plain, inline)]

>
> This doesn't look right: why 1 and not 0?


I copied this from my hanifi-rohingya composition rules, where I do not
remember
why I added 0 instead of 1. Even though they were working as intended I
have replaced it with 0
there just to be safe.

On Tue, Sep 27, 2022 at 6:46 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh
> >  <lumarzeli30 <at> gmail.com>
> > Date: Tue, 27 Sep 2022 16:52:22 +0530
> >
> > --- a/etc/NEWS
> > +++ b/etc/NEWS
> > @@ -1229,10 +1229,9 @@ to edit such sequences by allowing point to
> "enter" the sequence.
> >  *** Support for many old scripts and writing systems.
> >  Emacs now supports and has language-environments and input methods for
> >  several dozens of old scripts that were used in the past for various
> > -languages in South and South-East Asia.  For each such script Emacs
> > -now has font-selection and character composition rules, a language
> > -environment, and an input method.  The newly-added scripts and the
> > -corresponding language environments are:
> > +languages.  For each such script Emacs now has font-selection and
> character
> > +composition rules, a language environment, and an input method.  The
> newly-added
> > +scripts and the corresponding language environments are:
>
> The new text needs to be re-filled.
>
> > +;; Adlam composition rules
> > +(set-char-table-range
> > + composition-function-table
> > + '(#x1E900 . #x1E95F)
> > + (list (vector
> > +        "[\x1E900-\x1E95F]+"
> > +        1 'font-shape-gstring)))
>
> This doesn't look right: why 1 and not 0?
>

[Message part 2 (text/html, inline)]

[0001-Add-support-for-the-Adlam-script-bug-58111.patch (text/x-patch, attachment)]

Message #23 received at 58111 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58111 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#58111: [PATCH] Add support for the Adlam script
Date: Tue, 27 Sep 2022 18:10:45 +0200

>>>>> On Tue, 27 Sep 2022 21:12:30 +0530, समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com> said:

    समीर> Are the `' necessary around the "\\=" ?
    >> 

    समीर> Not really, but there is also no harm letting them be there. They are also
    समीर> in the other input methods which I have added.
    समीर> See in indian.el, philippine.el, indonesian.el etc
    समीर> This was copied from the brahmi input method written by Eli.

Youʼre right, I misread the quoting, it does help to make backquote
stand out.

Robert
-- 

Message #26 received at 58111 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58111 <at> debbugs.gnu.org
Subject: Re: bug#58111: [PATCH] Add support for the Adlam script
Date: Tue, 27 Sep 2022 19:36:23 +0300

> From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> Date: Tue, 27 Sep 2022 21:23:40 +0530
> Cc: 58111 <at> debbugs.gnu.org
> 
>  This doesn't look right: why 1 and not 0?
> 
> I copied this from my hanifi-rohingya composition rules, where I do not remember
> why I added 0 instead of 1. Even though they were working as intended I have replaced it with 0
> there just to be safe. 

In hanifi-rohingya, the codepoints that triggered composition were
between #x10D1D and #x10D27, whereas the regexp was
"[\x10D00-\x10D27]+", which matches many more characters.  With 1 as
the 2nd element of the rule vector, this means the sequence of
characters U+10D00 U+10D00 will not cause composition, but the
sequence U+10D00 U+10D1D will.  By contrast, in Adlam case, the
characters that trigger composition and the regexp are identical, so I
see no reason to trigger the composition only on the second character
of a sequence.

I see that you have now changed the hanifi-rohingya as well, but I'm
not sure that does what you want.  Please consider the effect I
described above, and decide whether you want 0 or 1 there.

Message #29 received at 58111 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58111 <at> debbugs.gnu.org
Subject: Re: bug#58111: [PATCH] Add support for the Adlam script
Date: Wed, 28 Sep 2022 11:55:10 +0530

[Message part 1 (text/plain, inline)]

>
> I see that you have now changed the hanifi-rohingya as well, but I'm
> not sure that does what you want.  Please consider the effect I
> described above, and decide whether you want 0 or 1 there.


You are right, adding 0 there results in incorrect composition, I have now
reverted my change.
Thanks

On Tue, Sep 27, 2022 at 10:06 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> > Date: Tue, 27 Sep 2022 21:23:40 +0530
> > Cc: 58111 <at> debbugs.gnu.org
> >
> >  This doesn't look right: why 1 and not 0?
> >
> > I copied this from my hanifi-rohingya composition rules, where I do not
> remember
> > why I added 0 instead of 1. Even though they were working as intended I
> have replaced it with 0
> > there just to be safe.
>
> In hanifi-rohingya, the codepoints that triggered composition were
> between #x10D1D and #x10D27, whereas the regexp was
> "[\x10D00-\x10D27]+", which matches many more characters.  With 1 as
> the 2nd element of the rule vector, this means the sequence of
> characters U+10D00 U+10D00 will not cause composition, but the
> sequence U+10D00 U+10D1D will.  By contrast, in Adlam case, the
> characters that trigger composition and the regexp are identical, so I
> see no reason to trigger the composition only on the second character
> of a sequence.
>
> I see that you have now changed the hanifi-rohingya as well, but I'm
> not sure that does what you want.  Please consider the effect I
> described above, and decide whether you want 0 or 1 there.
>

[Message part 2 (text/html, inline)]

[0001-Add-support-for-the-Adlam-script-bug-58111.patch (text/x-patch, attachment)]

Message #34 received at 58111-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58111-done <at> debbugs.gnu.org
Subject: Re: bug#58111: [PATCH] Add support for the Adlam script
Date: Wed, 28 Sep 2022 15:44:53 +0300

> From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> Date: Wed, 28 Sep 2022 11:55:10 +0530
> Cc: 58111 <at> debbugs.gnu.org
> 
>  I see that you have now changed the hanifi-rohingya as well, but I'm
>  not sure that does what you want.  Please consider the effect I
>  described above, and decide whether you want 0 or 1 there.
> 
> You are right, adding 0 there results in incorrect composition, I have now reverted my change.

Thanks, installed.

Message #37 received at 58111-done <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58111-done <at> debbugs.gnu.org
Subject: Re: bug#58111: [PATCH] Add support for the Adlam script
Date: Wed, 28 Sep 2022 18:26:54 +0530

[Message part 1 (text/plain, inline)]

Thanks!

On Wed, Sep 28, 2022 at 6:15 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
> > Date: Wed, 28 Sep 2022 11:55:10 +0530
> > Cc: 58111 <at> debbugs.gnu.org
> >
> >  I see that you have now changed the hanifi-rohingya as well, but I'm
> >  not sure that does what you want.  Please consider the effect I
> >  described above, and decide whether you want 0 or 1 there.
> >
> > You are right, adding 0 there results in incorrect composition, I have
> now reverted my change.
>
> Thanks, installed.
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.