GNU logs - #58141, boring messages

Message sent to joaotavora@HIDDEN, bug-gnu-emacs@HIDDEN:

Subject: bug#58141: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic
Resent-From: Augusto Stoffel <arstoffel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: joaotavora@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 28 Sep 2022 11:40:01 +0000
Resent-Message-ID: <handler.58141.B.16643651802997 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 58141 <at> debbugs.gnu.org
Cc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
From: Augusto Stoffel <arstoffel@HIDDEN>
Date: Wed, 28 Sep 2022 13:39:25 +0200
Message-ID: <87pmffd8ya.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2a00:1450:4864:20::633;
 envelope-from=arstoffel@HIDDEN; helo=mail-ej1-x633.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--=-=-=
Content-Type: text/plain

Or at least I really dislike the default value, which looks like this:


--=-=-=
Content-Type: image/png
Content-Disposition: inline;
 filename="Screenshot from 2022-09-28 13-16-40.png"
Content-Transfer-Encoding: base64

iVBORw0KGgoAAAANSUhEUgAAAOgAAABxCAYAAADfwO/zAAAABHNCSVQICAgIfAhkiAAAABl0RVh0
U29mdHdhcmUAZ25vbWUtc2NyZWVuc2hvdO8Dvz4AAAAmdEVYdENyZWF0aW9uIFRpbWUAV2VkIDI4
IFNlcCAyMDIyIDEzOjE2OjQwGIWqJgAAFyxJREFUeJzt3Xtc1HW+x/HXcB10BhC5CCoIooh4TcVM
vCtp5WWpzNo0xHbXTrbnbOvJstpF28pa21qOtmfTo5amhq4X0pIGSwglDDEWQUUEAcEAuQwDDDDA
nD/AsTEQBhn55XyfjwePB/P7/eb7/cCDN7/f93f5jkyv1+u5hUajuXWREUdHR6qqqtpdr1Qqb/t+
QRA6x6qnCxAEoX0ioIIgYSKggiBhIqCCIGEioIIgYSKggiBhIqCCIGEioIIgYSKggiBhIqCCIGEi
oIIgYSKggiBhIqCCIGEioIIgYSKggiBhdz2g7w98nz3z99xRG6WZpfzvmP9lvfV61snWsU62jtzj
uV1uLzMTxowBa2uQyVq+jh9ve1u9Xs/vfvc7AgMDyc/PNyyvrq5mzpw5zJkzh9ra2i7XIgg/ZdPT
BXRFwhsJ1FXU8cSBJwzLPEZ5dLm9N96Aigo4cODmslGj2t52zZo1qFQqvv/+e/r27WtYrlAoOHr0
KA8++CCPP/44R48e7XI9gnDDLzKgVVersHe0J2BhQLe0d/UqODrCwoW33y4lJYWoqCji4+ONwnmD
nZ0dn376KaNHj2bXrl08/fTT3VKfYLnEGNQEr7/+Oo899hgTJ05sdxsvLy9efPFF1q5dSxuzyQiC
Scy6B82IzuDbt76lqqAKn6k+zP373Da305ZrUb2kIvfrXOqr6uk/oT+zN8zGY/TNw9YtE7ZQlFJk
9L51snWG75fFLcN3lm+na5swAVJSjJfJZDe/j4uDWbNuvi4pKUGlUvHtt9922PZvfvMbIiMjiY+P
Z/r06W1uU1lZyfTp01Gr1Rw4cICxY8d2unbBcpgtoJe/usz+JftxH+HOtD9Po66yjq9Wf4WuVme0
na5Wx5YJWwAIeTkEubOc1K2pbJm4hRUnV+A5zhOA0I2h1FXWARD3Shy6Gh3zouYZ2jF1DLpxI1RW
tnz/yitQUwNRUTfX3zoGjY2NxcrKiuDg4A7bdnV1JSAggCNHjrQb0OzsbNLS0gA4c+aMCKjQJrMF
9OS7J+nt1puIxAjsHe0BqKuo468efzXaLulvSWiuaVh1YRVO3k4ABIYF8mHQh6jWqFgWtwwAn2k+
hvec2niKOuu6OxqDTpt28/uNG1vO4N5uDHrlyhV8fX2xtrbuVPtDhgzhypUr7a4fP34827dvR61W
s2TJkk5WLVgaswX0Wuo1fGf6GsIJIO8jp7d7b6Ptco/n4h7kjl1vO7RlWsPyAZMGkBGdgb5Zj8xK
Rk8rLCzE0dGx09s7Ojpy4cKF224THh5+h1UJ9zqzBLSxrpG6ijrslfY/WyeTGYetIqcCdb6ad13f
bbOtmuIaFJ4Kc5RpEhcXF+rr6zu9fX19PS4uLmasSLAEZgmojdwGO6Ud9ZqO/6AV/RQ4+TixPGG5
OUrpNt7e3uTmdv5miJycHO677z4zViRYArNdZvEY5UF+Yj4NmgbDsnp1PTUlNUbbeYd4cy31GppC
49ns03enc/38dXOVZ7LJkydTXV3dqZDqdDouXLjA5MmTb7vdrl272Lx5MzU1NbfdTrBcZhuDhqwJ
Yc+CPWyfup1xvx1HXWUdP6b9iJ3Czmi7Ka9OIX13OttCthH8QjAOfRy4En+FtE/SmPvBXFwDXQEo
Tium6mrLx01oy7U0VDdw6eillh/CwQbfmZ2/xAKQltZygwJAeTlUV8ONm38cHGDmTOPtR44cyciR
I9m6dStvvvnmbdvet28fjY2NLFq0qN1tUlJSWLp0KQByuZwVK1aYVL9gGWTm/GyW9N3pJG5IpOpq
FT5TfJgXNY9tIdvoN6YfT37+pGH7mpIa4tbEkZeQh+aaBhd/Fyb9YRJjlo8xbHN4+WF+2PFDm/05
D3LmP3P/8/Y/6S2WL4cdO9peN2gQtLWj3LlzJ3/4wx/IzMzE3d29zffqdDomTJhAaGgo777b9rga
oKKigunTp1NVVSWugwrtMmtA70Vz5szB2tqaL7/88mcnvABWr17NgQMHOHfuHL169eqBCoV7ibjV
z0R79+6lpKSEZ555Bp3O+KaLt99+m7179/LFF1+IcArdQuxBu0CtVpOSkkJQUBD9+vUDWh43S05O
ZtiwYfTv37+HKxTuFSKggiBh4hBXECRMBFQQJEwEVBAkTARUECRMBFQQJEwEVBAkTARUECRMBFTi
vvzySyIjI4mMjCQxMfGu9VtYWEhkZCTXr1+nrq6OyMhIzp8/3+X2vvvuOyIjI6mrq+vGKqXbb3fp
ckAdHR2NZhi49bVw52JjY0lOTu6RG+lLSkqwsbHBxcWFkpISANzc3O56HZZO7EElSqVSkZSUxLx5
8247zae5lJSU4OrqipWVFSUlJVhbW3d5hgi9Xk95eXk3VyjdfrvTL3Li6u5w8OBB0tPTCQ8Px9vb
G2iZpuQf//gHDg4OPPvss52eIKy7NTU1UVRUxNy5c5k4cSI//vjjXem3sbGRq60PyV69ehUPj5aZ
EktKSlAoFOTn52NlZWX4fXUkMzOT6Ohoo2UbNmwwfG9nZ8fatWsNr7VaLSqVitzcXOrr6/Hy8mL2
7NmG+51vKCgoID4+nmvXrtHU1ISHhwcBAQHcf//9WFlZmdyvlFlsQB966CHy8/M5ePAgzz33HHZ2
dsTGxlJbW8vSpUtNDmdWVhbNzc3trvfz88POzq7d9T9lbW3N0qVLsbK6uwc4VVVV7PjJQ7LDhg0D
oLi4GLVazY4dO5DL5bz88sudam/gwIGGGQvT09PJyMjg0UcfxdbWFsDo59PpdHz00UcAhISEIJfL
SU1NZevWrURERODl5QW0PEe7c+dOPD09mTFjBnK5nKKiIuLj42lqamLKlCkm9St1FhtQe3t7wsLC
2L59O7GxsQwbNozU1FQWLVrU5sc6dGT//v00NDS0u/73v/+9SYeIPfFH5OLiQmRkJNXV1WzcuNHw
UHpJSQmhoaE88MADJrWnVCoNIS8qapl0fMiQIcjl8p9tm5SURHV1NatWrcLJqXX61cBANm/eTFxc
HMuWtUy/mpeXR0NDA3PmzGHAgAEAjBgxgokTJxrOgZjSr9RZbECh5T/8tGnT+Oabb8jIyGDEiBGM
GTOm4ze24ZdyyNQZxcXFAHh4eKDRaNBqtYbDXXPJycnBzc0NW1tbo0+HGzhwIBkZGej1emQymeFE
VWxsLMHBwbi5ueHm5mYI9b3GogMKcP/995OYmEhdXR0hISE9XU6P2rFjh2GybblcjqOjI9nZ2UDL
dC8AixcvZvjw4d3ed0VFBWq1ut1pYqqrq1EqlfTv35/HH3+cM2fOcOjQIZqamrC3t8ff35/Q0NB7
LqgWH1CVSoWNjQ22trYcPXqU5cuXd+nw8q233urWQ9ye8OCDD6LVaklISDCMp2+cIAoLCwMw255U
oVDg7OzM8uUdT78aFBREUFAQjY2NlJeXk5eXR2xsLFqt1nAofK/ockBvfWD7dg9wS9XFixdJSUlh
0aJF2Nvb89lnn5GQkNDu56ncTlhY2G1PEikUPT/5dkc8PVs+B0elUhnGdyUlJXh4eODn52fWvr29
vTlz5gxVVVVG19PT09Pp16+f4dC2vLwctVqNr68vNjY2uLu74+7uTlZWFtevS2ea1u7S5YDe+CXe
COatr6VOo9Fw+PBhhg4dahh3jhkzhoSEBPz8/Dp9KeGGGyclukthYaFhLKhWqw3LUlNTgZaPObz1
8kN30Ov1XL9+3TDpdnFxMT4+Ph28q2M3ZtnIzs42nM22srLC398fgKlTp5Kens62bduYOHEicrmc
vLw80tLSmDt3riGgKSkpJCUlMXr0aHx8fJDL5RQUFHD58mUmTZpkcr9SZ5F7UL1ez6FDhwBYsGCB
Yfm8efO4cuUKBw4cYOXKlT161i8jI4NTp04ZLTt//rzhdruZM2eaJaCVlZXodDrc3d0NYZ0wYcId
tztq1CguXLjAwYMHaWpqAoyvRzo4OPDcc8+hUqk4ffo01dXVuLi4sGDBAqM7qUJDQ/Hy8uLcuXPE
x8dTW1uLs7Mzs2bNajOgHfUrdWJOIkGQsF/OFVtBsEAioIIgYSKggiBhIqCCIGEioIIgYSKggiBh
IqCCIGEioIIgYSKggiBhIqCCIGEioBKWmJjInDlz6Nu3Lx4eHjz00EOcPXv2rvRdmZbG54MHU335
MjqNhs8HD+bHr77qcns5O3bw+eDB6Dq4jbS79VS/3UUEVKKOHz/OjBkzKCws5IUXXiA8PJzTp08z
efJksrKyzN6/5tIlrOzs6D1oEJrW/hS/kCdA7iUW/8C2VK1du5Y+ffpw6tQpnJ2dAXjkkUeYOnUq
mzZtIioqyqz9V2VlofD3R2ZtjebiRaxsbendxcfO9M3N1LTO1HA39VS/3ckiA9pQoyF6xUwGT3+E
SSv/bLTu8okYEv/nNR7esBvXISN6qEKIi4sjLy/PEE6ASZMmIZPJyMnJMUufzfX1VPzwAwAVqak4
BgQALWG1d3OjPCUFmY0NLuPGdaq9a8eOkfL880bLjv1kziebXr2Yl55ueK2rrCTznXe4npREo0aD
86hRBL70Eo6BgUZtVJw9S1ZUFJXnzqFvbEQZEEC/WbPwi4hAZm1tcr9SZpEBteutxHviTK6cjCV4
xctY29ob1l0+EYPTAD+Tw3nkyBHD84ZtmT17Nr179+50e0qlkhEjjGvIzc1Fr9czePBgk2rrLG1x
Maeeesrwul9oKACaixfRFhVx6qmnsHV0ZG4nx8F9xo5lwj//CUDh4cMUffEF973/Pta9egEg+8nU
Mk1aLQmLFgHgv3Iltkol+dHRfBsWRsi+fTi1/i5qCwpIWrYM5xEjGPbii9golajPnSNr0yaaGxsZ
8txzJvUrefo2VFVV3fYLuO36X4KitCT9jrCR+tyTxwzLqkuv6T9+dLQ+/dB2k9tTKBR6oN2v7Ozs
O6q3ublZv3jxYr2VlZU+IyPjjtrqSF1pqT7Gz09ffOKEXq/X67+87z599pYtd9Tm+ffe08f4+ekb
2vn7yNq0SX90+HB9bWGhYVlzY6P++KxZ+lNPP21Ylv+vf+lj/Pz05WfPGr2/tqhI39zUZHK/UvcL
+lfSvfqNDKa3qyeXv4kxLMtJOAIyGDztEZPb02g06PX6dr/udK+3evVqoqOjeeedd8wyq95PVV24
AIBjQAB1xcXoKisNh7vmUnryJMohQ7Du1YuGykoaKivRaTS4jB1LRWoq+tb5npStJ6oy/vIXCmNi
qDp/nubGRhw8PX9Ze8ZOsshDXACZzAr/GQv594Et1FVVIHfsQ078UfrfNwUHZ9eeLs+gubmZF154
gQ8//JD169ezevVqs/V16qmnKEtOBsBWqUTerx+lCQkAfBceDsD4zZvxnDu32/uuLShAW1REbDvj
2/rr15G7u+M8ahTjoqLI/+wzfnjpJZp1OmwUCtynTmX4K6/g0DoD/b3CYgMK4D9zIWn7/0neqa9w
GzaGyquXGfPk8x2/sQ1KpZLq6up212dnZ5u8F62treXJJ5/k2LFjbN++nfDWkJhL0KuvolOrydq0
CX3reLrq4kXsXV257/33AVCaaU9q7+aGQ//+TN67t8NtvR5+GK+HH6a5vp6avDzKTp8m48030anV
3P/JJ2apr6dYdEAV7v3pN3w8Od9+QXVpEfZKZwaOn9altnbu3Hnbk0SmTvBVWlrK/Pnzyc7ORqVS
MXXq1C7VZQqnoCAAMjdsoE/rWU9NVhaOw4bhauLHPpjKZfx48vbsoa64GPlP5t4tjInBafhwwzXY
mvx8tIWFuE6ahJW9PcqhQ1EOHUrx119Tbaaz2z3JogMK4D9rEYn/8xrqwlz8pj6MlY1tl9pZ1HoG
srssWLCA06dP88c//tFoNr8bFi9eTJ8+fbq1T2i5dlidk4P34sVAyx60b3DwHbcrb/2cl9KEhJtn
U62tcW/9xzP0P/6DwpgYTi5ejO+yZdg6OVGWnEzBwYOMeP11Q0Dzdu/m8tatDAwLo29wMDZKJRWp
qZQmJuIXEWFyv1Jn8bP6NdbXEb1iJjptNfM3RuPi273z23bVkCFDDB+70JZz584R1LrH6061BQUc
nz6dyXv30mfcOL4cOZIRf/oT3k88cUftNtbUkPL885R99x3NOh3w8+uR9WVlnH/nHcpOn6a+tJTe
Pj74RUQw8LHHjNoqOnqUws8/R52ZSUNFBb0GDGBgWJjhOqip/UqZxQcU4MhLS9A3NTH/vX09XYog
GLn3zkubqOpaPmWXM/Gf2b2HqILQHSx2DFp+5SK1ZcXkJamwVzjhN/Xhni5JEH7GYgN6/sgusr85
TC8XNyY/vx57pXPHbxKEu0yMQQVBwix+DCoIUiYCKggSJgIqCBImAioIEiYCKggSJgIqCBImAtrN
kv+ezDrZOurV9T1dinAPEAEVBAkTAe1G+mY9ZZfKeroM4R5isXcSfTrvU7KP3Xyca/H+xei0OuLX
x1NxuYIpa6cw440ZAGjLtaheUpH7dS71VfX0n9Cf2Rtm4zG65cHi8/86T/Rj0e32Zaew4xXNKwCo
/lvFqY2neK3uNaztbz4a9bbybYY/NpyF2xeaVF/y35M59l/H+G3Kb/nmT9+Ql5CHwlNByJoQxq4Y
a9LvpLKyEk9PT5YuXcpHH31ktO7jjz8mPDyc5ORkgrvh+VChcyz2Xtxpf5rG+JXjKTlXwtevfU3Z
pTLObjvLoGmDGLZwGAMnDwRAV6tjy4QtAIS8HILcWU7q1lS2TNzCipMr8BznyYBJA1hyaAkA//70
32TuyyTs0zDsetsBILOWma2+G06sO4H7CHcCFgSQujWVmGdjcB7kjO8s30736ezszK9+9Suio6OJ
iopCLpcb1n3yyScEBgaKcN5lFhvQAZMGACB3bvkjvBx7mZU/rMS2l/GMCkl/S0JzTcOqC6tw8nYC
IDAskA+DPkS1RsWyuGUovZQELGyZq6copQiAoQ8Pxd7Jnq7qbH03BK8KZnDoYEN97/V/j4zoDJMC
ChAREcGePXuIiYlhceusCgUFBZw4cYINGzZ09ccRukiMQVsFPRHU5h9/7vFc3IPcsetth7ZMi7ZM
S726ngGTBlBwqgB9889GCHe1vhtcBrsYvu/l1gvHAY5UXqk0uZ+ZM2fi7e3Nxx9/bFi2a9cuZDIZ
S5cuNbk94c5Y7B70Vr3d2p71vSKnAnW+mndd321zfU1xDQpPhTlLA9qvrz029jZd+udhZWVFeHg4
b731FqWlpbi5ubFr1y7mzZtn8sRnwp0TAe2Aop8CJx8nlics754GW4ejTQ1NRieJpCQ8PJw33niD
ffv2MXnyZDIzM1m/fn1Pl2WRxCFuB7xDvLmWeg1NofGZ7fTd6Vw/f93k9m6MY3/84UfDsrqKOnRa
3Z0V2o18fX2ZNm0au3fvZvfu3fTt25f58+f3dFkWyWL3oIWnC6ktraU4vRhoObljI7dBZiXDf97N
z8Gc8uoU0nensy1kG8EvBOPQx4Er8VdI+ySNuR/MxTXQeBb6G4e72ceysVPcPIvrP7elzYD5Aaj+
W8XBZw7ywOoHaKhuoDitGCsb4/+Vna3PXCIiInjmmWe4cOECv/71r7GzszN7n8LPWWxAT/z5hNF1
xsQNiQDYyG14VfuqYbmDiwMr01YStyaO7zd/j+aaBhd/Fxb+30LGLB/zs3ZHLx3NxcMXObjsIE0N
LRNZ//Q6qJOPE0sOLUG1RsXxtccZNH0QszfM5mLMxS7VZy6PPvooq1atoqysjOXLu+nwXjCZxd6o
IHRs/PjxNDY28kPrZ4YKd58YgwptunTpEmfOnBF7zx5msYe4QtvS0tK4evUq+/fvx8XFhaeffrqn
S7JoIqCCkQ8++IAdO3bg5eXFtm3b6Nu3b0+XZNHEGFQQJEyMQQVBwkRABUHCREAFQcJEQAVBwkRA
BUHCREAFQcJEQAVBwkRABUHCREAFQcJEQAVBwv4fplcC0bsKO1kAAAAASUVORK5CYII=
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


When I first saw this face appearing, I had no idea what was going on.
That this is a Flymake warning is unexpected, since there's nothing
squiggly about it.  Moreover, it overrides all other font-locking, which
presumably still has meaningful information.  Finally, I think it's hard
to be sure the result is readable in all custom themes, even all
reasonable ones.

In general, I would argue that =E2=80=9Ccreative=E2=80=9D decorations shoul=
d be left off
by default.  So concretely in this case my suggestion would be to let
eglot-diagnostic-*-face inherit from one of the good old Flymake faces.

--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Augusto Stoffel <arstoffel@HIDDEN>
Subject: bug#58141: Acknowledgement ([Eglot] Default eglot-diagnostic-tag-unnecessary-face
 is problematic)
Message-ID: <handler.58141.B.16643651802997.ack <at> debbugs.gnu.org>
References: <87pmffd8ya.fsf@HIDDEN>
X-Gnu-PR-Message: ack 58141
X-Gnu-PR-Package: emacs
Reply-To: 58141 <at> debbugs.gnu.org
Date: Wed, 28 Sep 2022 11:40:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 58141 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
58141: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D58141
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#58141: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic
Resent-From: Augusto Stoffel <arstoffel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 08 Oct 2022 11:16:02 +0000
Resent-Message-ID: <handler.58141.B58141.166522771320667 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 58141 <at> debbugs.gnu.org
Cc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
From: Augusto Stoffel <arstoffel@HIDDEN>
In-Reply-To: <87pmffd8ya.fsf@HIDDEN> (Augusto Stoffel's message of "Wed, 28
 Sep 2022 13:39:25 +0200")
References: <87pmffd8ya.fsf@HIDDEN>
Date: Sat, 08 Oct 2022 13:15:03 +0200
Message-ID: <87zge67eiw.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Wed, 28 Sep 2022 at 13:39, Augusto Stoffel wrote:

> Finally, I think it's hard to be sure the result is readable in all
> custom themes, even all reasonable ones.

I initially wrote this as an abstract argument, but let me point out
that in the Modus Operandi theme (which is eminently reasonable), the
shadow face and font-lock-comment-face are equal.  So it's hard to
distinguish commented-out code from (presumably) unnecessary code.

Here's a concrete suggestion: when a language server diagnostic says
some code is "unnecessary", then apply _both_
eglot-diagnostic-tag-unnecessary-face and the usual Flymake face, with
that order of priority.  If the user so wishes, they can use
eglot-diagnostic-tag-unnecessary-face to override any attribute of the
flymake-* faces.  But, by default, the eglot-diagnostic-tag-* faces are
best kept empty.

Last modified: Sat, 8 Oct 2022 11:30:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.