GNU bug report logs - #58156
[PATCH] gnu: Add emacs-circadian.

Previous Next

Package: guix-patches;

Reported by: kiasoc5 <kiasoc5 <at> disroot.org>

Date: Thu, 29 Sep 2022 04:24:01 UTC

Severity: normal

Tags: moreinfo, patch

Done: kiasoc5 <kiasoc5 <at> disroot.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58156 in the body.
You can then email your comments to 58156 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#58156; Package guix-patches. (Thu, 29 Sep 2022 04:24:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to kiasoc5 <kiasoc5 <at> disroot.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 29 Sep 2022 04:24:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: kiasoc5 <kiasoc5 <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: kiasoc5 <kiasoc5 <at> disroot.org>
Subject: [PATCH] gnu: Add emacs-circadian.
Date: Thu, 29 Sep 2022 00:22:02 -0400
* gnu/packages/emacs-xyz.scm (emacs-circadian): New variable.
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c5d49c2925..c8bd2e9aa0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -19526,6 +19526,28 @@ (define-public emacs-ts
 timestamps by providing a @code{ts} struct.")
     (license license:gpl3+)))
 
+(define-public emacs-circadian
+  (package
+    (name "emacs-circadian")
+    (version "0.3.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://stable.melpa.org/packages/circadian-"
+                           version ".el"))
+       (sha256
+        (base32
+         "1pypy9bhg4lmmjjj0yqvlqs478i84x3awgzzjzdmrj1jlqbbvdj7"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/guidoschmidt/circadian.el")
+    (synopsis "Theme-switching for Emacs based on daytime")
+    (description "emacs-circadian tries to help reduce eye strain that
+may arise from the difference of the display brightness and surrounding
+light by automatically switching between light and dark themes.  It is
+inspired by color temperature shifting tools and brightness adaption
+software.")
+    (license license:expat)))
+
 (define-public emacs-peg
   (package
     (name "emacs-peg")

base-commit: 45eac6cdf5c8d9d7b0c564b105c790d2d2007799
-- 
2.37.3





Information forwarded to guix-patches <at> gnu.org:
bug#58156; Package guix-patches. (Thu, 29 Sep 2022 09:49:01 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: kiasoc5 via Guix-patches via <guix-patches <at> gnu.org>
Cc: kiasoc5 <kiasoc5 <at> disroot.org>, 58156 <at> debbugs.gnu.org
Subject: Re: [bug#58156] [PATCH] gnu: Add emacs-circadian.
Date: Thu, 29 Sep 2022 11:48:49 +0200
Hello,

kiasoc5 via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-circadian): New variable.

Thank you.

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://stable.melpa.org/packages/circadian-"
> +                           version ".el"))

Tarballs from Stable MELPA are not considered stable (!). Could you use
GitHub as upstream?

> +       (sha256
> +        (base32
> +         "1pypy9bhg4lmmjjj0yqvlqs478i84x3awgzzjzdmrj1jlqbbvdj7"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/guidoschmidt/circadian.el")
> +    (synopsis "Theme-switching for Emacs based on daytime")
> +    (description "emacs-circadian tries to help reduce eye strain that

Circadian reduces eye strain…

or

Circadian may reduce…

In any case the project is named Circadian, "emacs-circadian" being the
name of the Guix variable bound to the package.

> +may arise from the difference of the display brightness and surrounding
> +light by automatically switching between light and dark themes.  It is
> +inspired by color temperature shifting tools and brightness adaption
> +software.")
> +    (license license:expat)))

Licensing is ambiguous. The LICENSE file is expat, but the sole ".el"
file is explicitly GPL3+. So I guess this would be (list gpl3+ expat).

Could you also activate tests for this package? See for example
"emacs-go-mode" for an example. You will need to add emacs-el-mock
and emacs-ert-runner to the list of native inputs.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#58156; Package guix-patches. (Thu, 29 Sep 2022 09:49:02 GMT) Full text and rfc822 format available.

Added tag(s) moreinfo. Request was from Maxim Cournoyer <maxim.cournoyer <at> gmail.com> to control <at> debbugs.gnu.org. (Sat, 08 Oct 2022 04:37:02 GMT) Full text and rfc822 format available.

bug closed, send any further explanations to 58156 <at> debbugs.gnu.org and kiasoc5 <kiasoc5 <at> disroot.org> Request was from kiasoc5 <kiasoc5 <at> disroot.org> to control <at> debbugs.gnu.org. (Wed, 09 Nov 2022 07:53:01 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 07 Dec 2022 12:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 112 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.