GNU bug report logs - #58236
[PATCH] gnu: genie: Add genie.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58236 in the body.
You can then email your comments to 58236 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "J. Sims" <jtsims <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: genie: Add genie.
Date: Sat, 01 Oct 2022 22:15:44 +0000

Hello,

This is a patch to add the GENie project generator to Guix. It's a fork of Premake 4.4 that some other projects, notably the Scopes programming language, use.

I'm submitting it independently instead of as part of a patch series with Scopes because I've already packaged it then accidentally deleted that package twice before. Scopes has some rough edges around packaging in a Guix-friendly way and I don't suspect I will have its package ready very soon. All of this together means I'd like to avoid repeating my previous mistakes and go ahead and get it into Guix.

Thanks,
Juli

--------------------------BEGIN-PATCH------------------------------

* gnu/packages/build-tools.scm (genie): Add genie.
---
 gnu/packages/build-tools.scm | 44 ++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/build-tools.scm b/gnu/packages/build-tools.scm
index 84a62d0fd6..55bec5f817 100644
--- a/gnu/packages/build-tools.scm
+++ b/gnu/packages/build-tools.scm
@@ -14,6 +14,7 @@
 ;;; Copyright © 2020 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2021 qblade <qblade <at> protonmail.com>
 ;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2022 Juliana Sims <jtsims <at> protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -763,3 +764,46 @@ (define-public build
 @item Extensible language/compiler framework.
 @end itemize")
     (license license:gpl2+)))
+
+(define-public genie
+  (let ((commit "b139103697bbb62db895e4cc7bfe202bcff4ff25")
+        (ver "1167"))
+    (package
+      (name "genie")
+      (version ver)
+      (home-page "https://github.com/bkaradzic/genie")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url home-page)
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "16plshzkyjjzpfcxnwjskrs7i4gg0qn92h2k0rbfl4a79fgmwvwv"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (delete 'configure)
+           (replace 'install
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let ((out (assoc-ref outputs "out")))
+                 (install-file "bin/linux/genie"
+                               (string-append out "/bin"))))))
+         #:parallel-build? #t
+         #:tests? #f)) ;; tests have not been updated since Premake fork
+      (synopsis "Project generator tool")
+      (description "GENie (pronounced as Jenny) is project generator tool. It
+automagically generates project from Lua script, making applying the same
+settings for multiple projects easy.
+
+Supported project generators:
+@itemize
+@item GNU Makefile
+@item JSON Compilation Database
+@item Ninja (experimental)
+@item Visual Studio 2010, 2012, 2013, 2015, 2017, 2019
+@item XCode
+@end itemize")
+      (license license:bsd-3))))

base-commit: 461b1e490935e720999e78dc29656ae3c9ea2ea3
-- 
2.37.3

Message #8 received at 58236 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
To: "J. Sims" <jtsims <at> protonmail.com>, 58236 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: genie: Add genie.
Date: Mon, 03 Oct 2022 08:45:17 +0200

Am Samstag, dem 01.10.2022 um 22:15 +0000 schrieb J. Sims:
> Hello,
> 
> This is a patch to add the GENie project generator to Guix. It's a
> fork of Premake 4.4 that some other projects, notably the Scopes
> programming language, use.
> 
> I'm submitting it independently instead of as part of a patch series
> with Scopes because I've already packaged it then accidentally
> deleted that package twice before. Scopes has some rough edges around
> packaging in a Guix-friendly way and I don't suspect I will have its
> package ready very soon. All of this together means I'd like to avoid
> repeating my previous mistakes and go ahead and get it into Guix.
> 
> Thanks,
> Juli
> 
> --------------------------BEGIN-PATCH------------------------------
> 
> * gnu/packages/build-tools.scm (genie): Add genie.
> ---
Usually, adding comments after this line is preferred.

>  gnu/packages/build-tools.scm | 44
> ++++++++++++++++++++++++++++++++++++
>  1 file changed, 44 insertions(+)
> 
> diff --git a/gnu/packages/build-tools.scm b/gnu/packages/build-
> tools.scm
> index 84a62d0fd6..55bec5f817 100644
> --- a/gnu/packages/build-tools.scm
> +++ b/gnu/packages/build-tools.scm
> @@ -14,6 +14,7 @@
>  ;;; Copyright © 2020 Efraim Flashner <efraim <at> flashner.co.il>
>  ;;; Copyright © 2021 qblade <qblade <at> protonmail.com>
>  ;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> +;;; Copyright © 2022 Juliana Sims <jtsims <at> protonmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -763,3 +764,46 @@ (define-public build
>  @item Extensible language/compiler framework.
>  @end itemize")
>      (license license:gpl2+)))
> +
> +(define-public genie
> +  (let ((commit "b139103697bbb62db895e4cc7bfe202bcff4ff25")
> +        (ver "1167"))
> +    (package
> +      (name "genie")
> +      (version ver)
Use git-version.

> +      (home-page "https://github.com/bkaradzic/genie")
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url home-page)
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> "16plshzkyjjzpfcxnwjskrs7i4gg0qn92h2k0rbfl4a79fgmwvwv"))))
> +      (build-system gnu-build-system)
> +      (arguments
> +       `(#:phases
Prefer lists of G-Expressions.
> +         (modify-phases %standard-phases
> +           (delete 'configure)
> +           (replace 'install
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (let ((out (assoc-ref outputs "out")))
> +                 (install-file "bin/linux/genie"
> +                               (string-append out "/bin"))))))
> +         #:parallel-build? #t
I don't think this one's needed.  If however it is necessary, look
towards webkit for how to hack in -j2.
> +         #:tests? #f)) ;; tests have not been updated since Premake
> fork
That sounds bad.  Do they all fail or are some of them salvagable?
> +      (synopsis "Project generator tool")
> +      (description "GENie (pronounced as Jenny) is project generator
> tool. It
I think we can do without pronunciation guides.
> +automagically generates project from Lua script, making applying the
> same
> +settings for multiple projects easy.
> +
> +Supported project generators:
> +@itemize
> +@item GNU Makefile
> +@item JSON Compilation Database
> +@item Ninja (experimental)
> +@item Visual Studio 2010, 2012, 2013, 2015, 2017, 2019
> +@item XCode
> +@end itemize")
Make sure your description consists of complete sentences.
> +      (license license:bsd-3))))
> 
> base-commit: 461b1e490935e720999e78dc29656ae3c9ea2ea3

Cheers

Message #11 received at 58236 <at> debbugs.gnu.org (full text, mbox):

From: "J. Sims" <jtsims <at> protonmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Cc: 58236 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: genie: Add genie.
Date: Tue, 04 Oct 2022 19:37:05 +0000

[Message part 1 (text/plain, inline)]

On Monday, October 3rd, 2022 at 01:45, Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at> wrote:


> Am Samstag, dem 01.10.2022 um 22:15 +0000 schrieb J. Sims:
> 
> > Hello,
> > 
> > This is a patch to add the GENie project generator to Guix. It's a
> > fork of Premake 4.4 that some other projects, notably the Scopes
> > programming language, use.
> > 
> > I'm submitting it independently instead of as part of a patch series
> > with Scopes because I've already packaged it then accidentally
> > deleted that package twice before. Scopes has some rough edges around
> > packaging in a Guix-friendly way and I don't suspect I will have its
> > package ready very soon. All of this together means I'd like to avoid
> > repeating my previous mistakes and go ahead and get it into Guix.
> > 
> > Thanks,
> > Juli
> > 
> > --------------------------BEGIN-PATCH------------------------------
> > 
> > * gnu/packages/build-tools.scm (genie): Add genie.
> > ---
> 
> Usually, adding comments after this line is preferred.
> 
> > gnu/packages/build-tools.scm | 44
> > ++++++++++++++++++++++++++++++++++++
> > 1 file changed, 44 insertions(+)
> > 
> > diff --git a/gnu/packages/build-tools.scm b/gnu/packages/build-
> > tools.scm
> > index 84a62d0fd6..55bec5f817 100644
> > --- a/gnu/packages/build-tools.scm
> > +++ b/gnu/packages/build-tools.scm
> > @@ -14,6 +14,7 @@
> > ;;; Copyright © 2020 Efraim Flashner efraim <at> flashner.co.il
> > ;;; Copyright © 2021 qblade qblade <at> protonmail.com
> > ;;; Copyright © 2021 Maxim Cournoyer maxim.cournoyer <at> gmail.com
> > +;;; Copyright © 2022 Juliana Sims jtsims <at> protonmail.com
> > ;;;
> > ;;; This file is part of GNU Guix.
> > ;;;
> > @@ -763,3 +764,46 @@ (define-public build
> > @item Extensible language/compiler framework.
> > @end itemize")
> > (license license:gpl2+)))
> > +
> > +(define-public genie
> > + (let ((commit "b139103697bbb62db895e4cc7bfe202bcff4ff25")
> > + (ver "1167"))
> > + (package
> > + (name "genie")
> > + (version ver)
> 
> Use git-version.
> 
> > + (home-page "https://github.com/bkaradzic/genie")
> > + (source
> > + (origin
> > + (method git-fetch)
> > + (uri (git-reference
> > + (url home-page)
> > + (commit commit)))
> > + (file-name (git-file-name name version))
> > + (sha256
> > + (base32
> > "16plshzkyjjzpfcxnwjskrs7i4gg0qn92h2k0rbfl4a79fgmwvwv"))))
> > + (build-system gnu-build-system)
> > + (arguments
> > + `(#:phases
> 
> Prefer lists of G-Expressions.
> 
> > + (modify-phases %standard-phases
> > + (delete 'configure)
> > + (replace 'install
> > + (lambda* (#:key outputs #:allow-other-keys)
> > + (let ((out (assoc-ref outputs "out")))
> > + (install-file "bin/linux/genie"
> > + (string-append out "/bin"))))))
> > + #:parallel-build? #t
> 
> I don't think this one's needed. If however it is necessary, look
> towards webkit for how to hack in -j2.
> 
> > + #:tests? #f)) ;; tests have not been updated since Premake
> > fork
> 
> That sounds bad. Do they all fail or are some of them salvagable?
> 
> > + (synopsis "Project generator tool")
> > + (description "GENie (pronounced as Jenny) is project generator
> > tool. It
> 
> I think we can do without pronunciation guides.
> 
> > +automagically generates project from Lua script, making applying the
> > same
> > +settings for multiple projects easy.
> > +
> > +Supported project generators:
> > +@itemize
> > +@item GNU Makefile
> > +@item JSON Compilation Database
> > +@item Ninja (experimental)
> > +@item Visual Studio 2010, 2012, 2013, 2015, 2017, 2019
> > +@item XCode
> > +@end itemize")
> 
> Make sure your description consists of complete sentences.
> 
> > + (license license:bsd-3))))
> > 
> > base-commit: 461b1e490935e720999e78dc29656ae3c9ea2ea3
> 
> 
> Cheers

Thanks for the feedback (and the kick in the pants I needed to finally get my hands dirty with gexps)! I've incorporated all of your comments. I'd like to note, though, that the tests are apparently entirely manual. I asked the developer how tests should be run and the response was essentially, "compile the project and use it." For what it's worth, I have indeed compiled and used this project in the past, so it should work fine.

-Juli

[0001-gnu-genie-Add-genie.patch (text/x-patch, attachment)]

Message #14 received at 58236 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
To: "J. Sims" <jtsims <at> protonmail.com>
Cc: 58236 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: genie: Add genie.
Date: Wed, 05 Oct 2022 12:34:05 +0200

Am Dienstag, dem 04.10.2022 um 19:37 +0000 schrieb J. Sims:

> (define-public genie
> +  (let ((commit "b139103697bbb62db895e4cc7bfe202bcff4ff25")
> +        (version "1167")
> +        (revision "0"))
Do not let-bind version.
> +    (package
> +      (name "genie")
> +      (version (git-version version revision commit))
> +      (home-page "https://github.com/bkaradzic/genie")
home-page comes before synopsis and description...
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url home-page)
> +                      (commit commit)))
Don't pull it up so that you can "save" the url argument.  Type url out
explicitly.
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                 
> "16plshzkyjjzpfcxnwjskrs7i4gg0qn92h2k0rbfl4a79fgmwvwv"))))
> +      (build-system gnu-build-system)
> +      (arguments
> +       (list #:phases #~(modify-phases %standard-phases
> +                          (delete 'configure)
> +                          (replace 'install
> +                            (lambda _
> +                              (install-file "bin/linux/genie"
> +                                            (string-append #$output
> "/bin")))))
Prefer saving horizontal space over vertical space.
> +             #:tests? #f)) ;only manual tests
When it comes to software testing, there is no sequence of instructions
that only a human can carry out.  Tests either exist or they don't and
in the case of GENie there at least formally exists a directory for
them.
> +      (synopsis "Project generator tool")
Note that tool is superfluous here.
> +      (description
> +       "GENie is project generator tool. It generates projects from
> +Lua scripts, making applying the same settings for multiple projects
> easy. It
I'd simply write "GENie generates projects from Lua scripts, making it
easy to apply the same settings to multiple projects."
> +supports generating projects using GNU Makefiles; JSON Compilation
> Database;
> +Visual Studio 2010, 2012, 2013, 2015, 2017, and 2019; XCode; and
> experimentally
> +supports Ninja.")
We're not going to use proprietary software on our FSDG-compliant
system, so it's only Makefiles, JSON compilation databases and
experimental Ninja.
> +      (license license:bsd-3))))

Cheers

Message #17 received at 58236 <at> debbugs.gnu.org (full text, mbox):

From: "J. Sims" <jtsims <at> protonmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>,
 "58236 <at> debbugs.gnu.org" <58236 <at> debbugs.gnu.org>
Subject: Re: [PATCH] gnu: genie: Add genie.
Date: Thu, 06 Oct 2022 01:06:37 +0000

[Message part 1 (text/plain, inline)]

On Wednesday, October 5th, 2022 at 05:34, Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at> wrote:


> Am Dienstag, dem 04.10.2022 um 19:37 +0000 schrieb J. Sims:
> 
> > (define-public genie
> > + (let ((commit "b139103697bbb62db895e4cc7bfe202bcff4ff25")
> > + (version "1167")
> > + (revision "0"))
> 
> Do not let-bind version.
> 
> > + (package
> > + (name "genie")
> > + (version (git-version version revision commit))
> > + (home-page "https://github.com/bkaradzic/genie")
> 
> home-page comes before synopsis and description...
> 
> > + (source (origin
> > + (method git-fetch)
> > + (uri (git-reference
> > + (url home-page)
> > + (commit commit)))
> 
> Don't pull it up so that you can "save" the url argument. Type url out
> explicitly.
> 
> > + (file-name (git-file-name name version))
> > + (sha256
> > + (base32
> > +
> > "16plshzkyjjzpfcxnwjskrs7i4gg0qn92h2k0rbfl4a79fgmwvwv"))))
> > + (build-system gnu-build-system)
> > + (arguments
> > + (list #:phases #~(modify-phases %standard-phases
> > + (delete 'configure)
> > + (replace 'install
> > + (lambda _
> > + (install-file "bin/linux/genie"
> > + (string-append #$output
> > "/bin")))))
> 
> Prefer saving horizontal space over vertical space.
> 
> > + #:tests? #f)) ;only manual tests
> 
> When it comes to software testing, there is no sequence of instructions
> that only a human can carry out. Tests either exist or they don't and
> in the case of GENie there at least formally exists a directory for
> them.
> 
> > + (synopsis "Project generator tool")
> 
> Note that tool is superfluous here.
> 
> > + (description
> > + "GENie is project generator tool. It generates projects from
> > +Lua scripts, making applying the same settings for multiple projects
> > easy. It
> 
> I'd simply write "GENie generates projects from Lua scripts, making it
> easy to apply the same settings to multiple projects."
> 
> > +supports generating projects using GNU Makefiles; JSON Compilation
> > Database;
> > +Visual Studio 2010, 2012, 2013, 2015, 2017, and 2019; XCode; and
> > experimentally
> > +supports Ninja.")
> 
> We're not going to use proprietary software on our FSDG-compliant
> system, so it's only Makefiles, JSON compilation databases and
> experimental Ninja.
> 
> > + (license license:bsd-3))))
> 
> 
> Cheers

This patch should incorporate all above comments.

If there are further questions about tests: https://github.com/bkaradzic/GENie/issues/545#issuecomment-1267152313

-Juli

[0001-gnu-genie-Add-genie.patch (text/x-patch, attachment)]

Message #20 received at 58236 <at> debbugs.gnu.org (full text, mbox):

From: "J. Sims" <jtsims <at> protonmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>,
 "58236 <at> debbugs.gnu.org" <58236 <at> debbugs.gnu.org>
Subject: Re: [PATCH] gnu: genie: Add genie.
Date: Thu, 06 Oct 2022 01:12:55 +0000

[Message part 1 (text/plain, inline)]

On Wednesday, October 5th, 2022 at 20:06, J. Sims <jtsims <at> protonmail.com> wrote:


> On Wednesday, October 5th, 2022 at 05:34, Liliana Marie Prikler liliana.prikler <at> ist.tugraz.at wrote:
> 
> 
> 
> > Am Dienstag, dem 04.10.2022 um 19:37 +0000 schrieb J. Sims:
> > 
> > > (define-public genie
> > > + (let ((commit "b139103697bbb62db895e4cc7bfe202bcff4ff25")
> > > + (version "1167")
> > > + (revision "0"))
> > 
> > Do not let-bind version.
> > 
> > > + (package
> > > + (name "genie")
> > > + (version (git-version version revision commit))
> > > + (home-page "https://github.com/bkaradzic/genie")
> > 
> > home-page comes before synopsis and description...
> > 
> > > + (source (origin
> > > + (method git-fetch)
> > > + (uri (git-reference
> > > + (url home-page)
> > > + (commit commit)))
> > 
> > Don't pull it up so that you can "save" the url argument. Type url out
> > explicitly.
> > 
> > > + (file-name (git-file-name name version))
> > > + (sha256
> > > + (base32
> > > +
> > > "16plshzkyjjzpfcxnwjskrs7i4gg0qn92h2k0rbfl4a79fgmwvwv"))))
> > > + (build-system gnu-build-system)
> > > + (arguments
> > > + (list #:phases #~(modify-phases %standard-phases
> > > + (delete 'configure)
> > > + (replace 'install
> > > + (lambda _
> > > + (install-file "bin/linux/genie"
> > > + (string-append #$output
> > > "/bin")))))
> > 
> > Prefer saving horizontal space over vertical space.
> > 
> > > + #:tests? #f)) ;only manual tests
> > 
> > When it comes to software testing, there is no sequence of instructions
> > that only a human can carry out. Tests either exist or they don't and
> > in the case of GENie there at least formally exists a directory for
> > them.
> > 
> > > + (synopsis "Project generator tool")
> > 
> > Note that tool is superfluous here.
> > 
> > > + (description
> > > + "GENie is project generator tool. It generates projects from
> > > +Lua scripts, making applying the same settings for multiple projects
> > > easy. It
> > 
> > I'd simply write "GENie generates projects from Lua scripts, making it
> > easy to apply the same settings to multiple projects."
> > 
> > > +supports generating projects using GNU Makefiles; JSON Compilation
> > > Database;
> > > +Visual Studio 2010, 2012, 2013, 2015, 2017, and 2019; XCode; and
> > > experimentally
> > > +supports Ninja.")
> > 
> > We're not going to use proprietary software on our FSDG-compliant
> > system, so it's only Makefiles, JSON compilation databases and
> > experimental Ninja.
> > 
> > > + (license license:bsd-3))))
> > 
> > Cheers
> 
> 
> This patch should incorporate all above comments.
> 
> If there are further questions about tests: https://github.com/bkaradzic/GENie/issues/545#issuecomment-1267152313
> 
> -Juli

Apologies, I forgot to configure my git settings on a new computer; please use this version of the patch instead, which has a correct email.

[0001-gnu-genie-Add-genie.patch (text/x-patch, attachment)]

Message #25 received at 58236-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "J. Sims" <jtsims <at> protonmail.com>
Cc: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>,
 "58236 <at> debbugs.gnu.org" <58236-done <at> debbugs.gnu.org>
Subject: Re: bug#58236: [PATCH] gnu: genie: Add genie.
Date: Sun, 09 Oct 2022 22:20:52 +0200

Hi,

"J. Sims" <jtsims <at> protonmail.com> skribis:

> From 7a1d86dbe8b07964661160d5b86e9cd92790cf1e Mon Sep 17 00:00:00 2001
> From: "J. Sims" <jtsims <at> protonmail.com>
> Date: Wed, 5 Oct 2022 19:37:11 -0500
> Subject: [PATCH] gnu: genie: Add genie.
>
> * gnu/packages/build-tools.scm (genie): Add genie.

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.