GNU bug report logs - #58257
[PATCH] gnu: Add go-webring.

Previous Next

Package: guix-patches;

Reported by: jgart <jgart <at> dismail.de>

Date: Sun, 2 Oct 2022 19:56:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58257 in the body.
You can then email your comments to 58257 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#58257; Package guix-patches. (Sun, 02 Oct 2022 19:56:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to jgart <jgart <at> dismail.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 02 Oct 2022 19:56:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: Add go-webring.
Date: Sun,  2 Oct 2022 14:55:45 -0500
* gnu/packages/web.scm (go-webring): New variable.
---
 gnu/packages/web.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 3262dbbb10..bc2b1a1950 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -58,6 +58,7 @@
 ;;; Copyright © 2022 cage <cage-dev <at> twistfold.it>
 ;;; Copyright © 2022 Pradana Aumars <paumars <at> courrier.dev>
 ;;; Copyright © 2022 Petr Hodina <phodina <at> protonmail.com>
+;;; Copyright © 2022 jgart <jgart <at> dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -8184,6 +8185,32 @@ (define-public quark
       ;; to account for "vendor names".
       (properties '((lint-hidden-cve . ("CVE-2019-15520")))))))
 
+(define-public go-webring
+  (let ((commit "6786a27b0c57df75323217453369c83a4d9f4dea")
+        (revision "0"))
+    (package
+      (name "go-webring")
+      (version (git-version "20220426" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://git.sr.ht/~amolith/go-webring")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1xra0mapdmda8n0z6zsgcqppdzvxc47p0fahsdyig5qmpk89ar8l"))))
+      (build-system go-build-system)
+      (arguments
+       (list #:import-path "git.sr.ht/~amolith/go-webring"))
+      (propagated-inputs (list go-github-com-spf13-pflag))
+      (home-page "https://git.sr.ht/~amolith/go-webring")
+      (synopsis "Simple webring implementation")
+      (description
+"@code{go--webring} provides a simple webring implementation as used by
+the Fediring.")
+      (license (list license:cc0 license:bsd-2)))))
+
 (define-public archivebox
   (package
     (name "archivebox")
-- 
2.37.3





Information forwarded to guix-patches <at> gnu.org:
bug#58257; Package guix-patches. (Tue, 04 Oct 2022 18:14:02 GMT) Full text and rfc822 format available.

Message #8 received at 58257 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "jgart" <jgart <at> dismail.de>, <58257 <at> debbugs.gnu.org>
Subject: Re: [bug#58257] [PATCH] gnu: Add go-webring.
Date: Tue, 04 Oct 2022 19:12:59 +0100
Hey jgart,

On Sun Oct 2, 2022 at 8:55 PM BST, jgart via Guix-patches via wrote:
> +      (build-system go-build-system)
> +      (arguments
> +       (list #:import-path "git.sr.ht/~amolith/go-webring"))

Since this is a program, not a library, shouldn't you use
``#:install-source? #f''?

> +      (propagated-inputs (list go-github-com-spf13-pflag))

You don't need to propagate the inputs of a program.

> +      (synopsis "Simple webring implementation")

How about something like,

  Webring generator for blogs

> +      (description
> +"@code{go--webring} provides a simple webring implementation as used by
> +the Fediring.")

Maybe,

> +      (description
> +       "This package provides a program for generating \"webring\" in
> +Gemtext or HTML format for blogs from a template.")

    -- (




Information forwarded to guix-patches <at> gnu.org:
bug#58257; Package guix-patches. (Tue, 04 Oct 2022 22:04:01 GMT) Full text and rfc822 format available.

Message #11 received at 58257 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 58257 <at> debbugs.gnu.org
Cc: "\(" <paren <at> disroot.org>, jgart <jgart <at> dismail.de>
Subject: [PATCH v2] gnu: Add go-webring.
Date: Tue,  4 Oct 2022 17:00:47 -0500
* gnu/packages/web.scm (go-webring): New variable.

Hi paren,

Thanks for the review. I changed everything but the blog stuff because
go-webring is not necessarily used in the context of a blog. A webring
can stand on it's own without being associated with a blog. A webring
can associate websites that are not blogs or Guix channels ;()

Here's v2

all best,

jgart
---
 gnu/packages/web.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 3262dbbb10..967d4328b5 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -58,6 +58,7 @@
 ;;; Copyright © 2022 cage <cage-dev <at> twistfold.it>
 ;;; Copyright © 2022 Pradana Aumars <paumars <at> courrier.dev>
 ;;; Copyright © 2022 Petr Hodina <phodina <at> protonmail.com>
+;;; Copyright © 2022 jgart <jgart <at> dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -8184,6 +8185,33 @@ (define-public quark
       ;; to account for "vendor names".
       (properties '((lint-hidden-cve . ("CVE-2019-15520")))))))
 
+(define-public go-webring
+  (let ((commit "6786a27b0c57df75323217453369c83a4d9f4dea")
+        (revision "0"))
+    (package
+      (name "go-webring")
+      (version (git-version "20220426" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://git.sr.ht/~amolith/go-webring")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1xra0mapdmda8n0z6zsgcqppdzvxc47p0fahsdyig5qmpk89ar8l"))))
+      (build-system go-build-system)
+      (arguments
+       (list #:import-path "git.sr.ht/~amolith/go-webring"
+             #:install-source? #f))
+      (inputs (list go-github-com-spf13-pflag))
+      (home-page "https://git.sr.ht/~amolith/go-webring")
+      (synopsis "Simple webring implementation")
+      (description
+"@code{go--webring} provides a simple webring implementation as used by
+the Fediring.")
+      (license (list license:cc0 license:bsd-2)))))
+
 (define-public archivebox
   (package
     (name "archivebox")
-- 
2.37.3





Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Sun, 09 Oct 2022 20:26:02 GMT) Full text and rfc822 format available.

Notification sent to jgart <jgart <at> dismail.de>:
bug acknowledged by developer. (Sun, 09 Oct 2022 20:26:02 GMT) Full text and rfc822 format available.

Message #16 received at 58257-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: jgart <jgart <at> dismail.de>
Cc: 58257-done <at> debbugs.gnu.org, "\(" <paren <at> disroot.org>
Subject: Re: bug#58257: [PATCH] gnu: Add go-webring.
Date: Sun, 09 Oct 2022 22:25:03 +0200
Hi,

jgart <jgart <at> dismail.de> skribis:

> * gnu/packages/web.scm (go-webring): New variable.

Applied, thanks!

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#58257; Package guix-patches. (Sun, 09 Oct 2022 20:30:02 GMT) Full text and rfc822 format available.

Message #19 received at 58257-done <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 58257-done <at> debbugs.gnu.org, "\(" <paren <at> disroot.org>
Subject: Re: bug#58257: [PATCH] gnu: Add go-webring.
Date: Sun, 9 Oct 2022 15:29:15 -0500
On Sun, 09 Oct 2022 22:25:03 +0200 Ludovic Courtès <ludo <at> gnu.org> wrote:
> Applied, thanks!

THNX! <3





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 07 Nov 2022 12:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 142 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.