GNU bug report logs - #58263
[PATCH 1/2] gnu: Add emacs-meme.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58263 in the body.
You can then email your comments to 58263 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH 1/2] gnu: Add emacs-meme.
Date: Sun, 2 Oct 2022 20:09:27 -0500

Make memes with emacs!

Message #8 received at 58263 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 58263 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH 1/2] gnu: Add emacs-imgur-el.
Date: Sun,  2 Oct 2022 20:30:28 -0500

* gnu/packages/emacs-xyz.scm (emacs-imgur-el): New variable.
---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 9ba87652f3..5049824bce 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -552,6 +552,29 @@ (define-public emacs-telephone-line
 configuration language which makes it trivial to write your own themes.")
       (license license:gpl3+))))
 
+(define-public emacs-imgur-el
+  (let ((commit "e179f5e3411d8eb3773e436e391e432c52e8b911")
+        (revision "0"))
+    (package
+      (name "emacs-imgur-el")
+      (version (git-version "20220125" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/larsmagne/imgur.el")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1hkfwz5278vd3cap95656n2a5a4qkd66r7gzlg4zjq2f45f9b9bx"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/larsmagne/imgur.el")
+      (synopsis "Simple library for uploading pictures to imgur")
+      (description
+"@code{emacs-imgur-el} is a simple library for uploading pictures to imgur.")
+      (license license:gpl2+))))
+
 (define-public emacs-terminal-here
   (package
     (name "emacs-terminal-here")
-- 
2.37.3

Message #11 received at 58263 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 58263 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH 2/2] gnu: Add emacs-meme.
Date: Sun,  2 Oct 2022 20:30:29 -0500

* gnu/packages/emacs-xyz.scm (emacs-meme): New variable.
---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5049824bce..72a9e52043 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -552,6 +552,30 @@ (define-public emacs-telephone-line
 configuration language which makes it trivial to write your own themes.")
       (license license:gpl3+))))
 
+(define-public emacs-meme
+  (let ((commit "0a0ca8f6babaca3fea94f308f8d58f5186eba920")
+        (revision "0"))
+    (package
+      (name "emacs-meme")
+      (version (git-version "20220125" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/larsmagne/meme")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0c30qx0dmd9hym7m2kvjw39vq6b8n51hwhdks48sb7hsb069l039"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+        (list emacs-imgur-el))
+      (home-page "https://github.com/larsmagne/meme")
+      (synopsis "Emacs meme generator")
+      (description "@code{emacs-meme} provides a meme generator for Emacs.")
+      (license license:gpl2+))))
+
 (define-public emacs-imgur-el
   (let ((commit "e179f5e3411d8eb3773e436e391e432c52e8b911")
         (revision "0"))
-- 
2.37.3

Message #14 received at 58263 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
To: jgart <jgart <at> dismail.de>, 58263 <at> debbugs.gnu.org
Subject: Re: [PATCH 2/2] gnu: Add emacs-meme.
Date: Mon, 03 Oct 2022 09:06:30 +0200

Am Sonntag, dem 02.10.2022 um 20:30 -0500 schrieb jgart:
> * gnu/packages/emacs-xyz.scm (emacs-meme): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 5049824bce..72a9e52043 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -552,6 +552,30 @@ (define-public emacs-telephone-line
>  configuration language which makes it trivial to write your own
> themes.")
>        (license license:gpl3+))))
>  
> +(define-public emacs-meme
> +  (let ((commit "0a0ca8f6babaca3fea94f308f8d58f5186eba920")
> +        (revision "0"))
> +    (package
> +      (name "emacs-meme")
> +      (version (git-version "20220125" revision commit))
We don't do melpa versions.  Since this one seems to be missing any
version info whatsoever, use "0".
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri
> +          (git-reference
> +           (url "https://github.com/larsmagne/meme")
> +           (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> "0c30qx0dmd9hym7m2kvjw39vq6b8n51hwhdks48sb7hsb069l039"))))
> +      (build-system emacs-build-system)
> +      (propagated-inputs
> +        (list emacs-imgur-el))
> +      (home-page "https://github.com/larsmagne/meme")
> +      (synopsis "Emacs meme generator")
> +      (description "@code{emacs-meme} provides a meme generator for
> Emacs.")
> +      (license license:gpl2+))))
Note that this package asks you to install non-free fonts.  In general,
the customizability of both this and imgur.el is too low to really call
it an emacs package imho (and the way emacs-meme handles fonts is not
up to par with what emacs faces can do).  I spare you a full code
review, but rest assured that both packages should undergo some more
revisions before distro packaging.

Cheers

Message #21 received at 58263-done <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: 58263-done <at> debbugs.gnu.org
Date: Tue, 18 Jun 2024 06:22:46 +0000

Closing this ticket. 

Feel free to reopen if anyone is interested in investigating it further.

all best,

jgart

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.