GNU logs - #58312, boring messages

Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#58312: Improve =?UTF-8?Q?=E2=80=9CInvalid?= face =?UTF-8?Q?attribute=E2=80=9D?= error message
Resent-From: Felix Dietrich <felix.dietrich@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 05 Oct 2022 18:43:02 +0000
Resent-Message-ID: <handler.58312.B.1664995359317 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 58312
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: 58312 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.1664995359317
          (code B ref -1); Wed, 05 Oct 2022 18:43:02 +0000
Received: (at submit) by debbugs.gnu.org; 5 Oct 2022 18:42:39 +0000
Received: from localhost ([127.0.0.1]:58058 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1og9Lr-000053-EX
	for submit <at> debbugs.gnu.org; Wed, 05 Oct 2022 14:42:39 -0400
Received: from lists.gnu.org ([209.51.188.17]:49214)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <felix.dietrich@HIDDEN>) id 1og9Lo-00004r-OT
 for submit <at> debbugs.gnu.org; Wed, 05 Oct 2022 14:42:38 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:35044)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <felix.dietrich@HIDDEN>)
 id 1og9Lo-0001gn-GG
 for bug-gnu-emacs@HIDDEN; Wed, 05 Oct 2022 14:42:36 -0400
Received: from mout.kundenserver.de ([212.227.17.10]:37675)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <felix.dietrich@HIDDEN>)
 id 1og9Lj-00044n-D8
 for bug-gnu-emacs@HIDDEN; Wed, 05 Oct 2022 14:42:35 -0400
Received: from localhost ([77.11.160.112]) by mrelayeu.kundenserver.de
 (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id
 1MFK8N-1oQVES16wT-00FlNz for <bug-gnu-emacs@HIDDEN>; Wed, 05 Oct 2022
 20:42:29 +0200
From: Felix Dietrich <felix.dietrich@HIDDEN>
Date: Wed, 05 Oct 2022 20:42:28 +0200
Message-ID: <87czb6p0x7.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:OEJNBZmpb3fwRaN2qglFRwD0hBb8FWQp3JhruYzTMHIzpRZPodv
 PL7H5Az2sKtBpL5DZ1ROcIjapl7P4uDHo9Nhl9WOYrLapt1OoZS+S943F/uGbW0ytujlh/o
 rvX2EResRJhtT79UBd1efqed+tdsIkdyx2sFcHPopAMQJhmUvaiBJzRJU/59JRo4ZZXglcr
 8xvkaBbWERityYPDVJJKg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:tDnoc/wlsnI=:cKahZYqJ0rBu/jWGVsEh//
 ZQs95nascWSZn/2iOjxEOf5ckacIH/Tdk1/jWGJnSZKbSdTdCjeu5U97rdyOU/UmmWEq/iksn
 eqYWZGxE3s5QMVgK8q6yHsJgFqzUZPHcPuAvHInQGAkkz1o/iBoJXhqGFlQ654UMaoT4LfsD+
 P8UQmNvNUMnUxPXsdUmqO4ZgFpjmEDHF5nUqhziB2mJk5904yuHnhAQqi5jgNXiup5Uouw1+q
 PV8hGceZQOlqoWEGVG9VcUVKMOeJI0d2Vgx/gJnaLJmLoFUcYEf17Y8K9H5fmWnQdVqFPVOyP
 ajBfj/g0RemHc2RdGdeCsNrpfURMM59+NglCzupxl5H9hLHAK9++uurxIMoPtckIbW+ZdtXem
 +lA+YYOWIN0DYgoK9g9Z0xn7J+Sepc8zYik0DsKiOARh8QuvqGJY1Svw/VfhcEcVRsJWmTY6K
 j1tFoLjInL0CqYZfFBZyC2Mqz4uB18cca8n/3/yQVKrEjptvJVQk5QQyNH3rcNgaGfiI9gJw1
 ELmcaGPn61alTsTpXbLbdsxKifxvqVCFDnnuUh6BzFyaZj2qyIajgZisBzokYTSEnuNX6bVGr
 Ol6SJh+VD6loc6VBGx5lVI94bhvN0SB3WBwu4+2WfTFxPPcYy0aqaQUtWI1u+6EHnY0Md8Pch
 YOznpD4jHDoWTZUbUSudNyCUHTLoWgQpL21IXEB4spk/NefT9m4luzDFJKhUWAAzH7NhPdAGF
 59ILEWmXo/TSBKb309NI+DNQrm1SFXkmKEIex1MN7FZPaDqM3h1eaZ58XxtFPWbW8PkkhlaBS
 B2r6vBd6FLFXo1A82P3ZF43zXgGJQ==
Received-SPF: none client-ip=212.227.17.10;
 envelope-from=felix.dietrich@HIDDEN; helo=mout.kundenserver.de
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001,
 SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Package: emacs
Severity: wishlist

Could the log message =E2=80=9CInvalid face attribute=E2=80=9D created by
=E2=80=9Cxfaces.c:merge_face_ref=E2=80=9D be extended to also include the b=
uffer or
other identifying information about its origin?  This request is
motivated by a recent issue posted to the help-gnu-emacs list [1].

When Emacs encounters an anonymous face with an invalid face attribute
value in a buffer, it will write a log entry to the =E2=80=9C*Messages*=E2=
=80=9D buffer.
This message takes the form =E2=80=9CInvalid face attribute ATTRIBUTE VALUE=
=E2=80=9D and
lacks any information that would allow easy identification of the
invalid face=CA=BCs place of origin.  The log entry is induced by the
function =E2=80=9Cxfaces.c:merge_face_ref=E2=80=9D.  This function takes as=
 its first
argument a =E2=80=9Cstruct window=E2=80=9D which could potentially be used =
to retrieve
the causing buffer using its =E2=80=9Ccontents=E2=80=9D member (note, thoug=
h, that it
may be NULL).

Here is a snippet that will cause the =E2=80=9CInvalid face attribute=E2=80=
=9D message
to be written to the =E2=80=9C*Messages*=E2=80=9D buffer when evaluated:

#+begin_src emacs-lisp
  (let ((buf (generate-new-buffer "*test*"))
        (s (propertize "Hello World" 'face '(:foreground nil))))
    (with-current-buffer buf
      (insert s))
    (display-buffer buf))
#+end_src

#+begin_example
#<window 54 on *test*<2>>Invalid face attribute :foreground nil
Invalid face attribute :foreground nil
#+end_example

Two things I noticed exploring the issue:

1. the value I use in the above example for the :foreground attribute
nil is handled specially in =E2=80=9Cxfaces.c:internal-set-lisp-face-attrib=
ute=E2=80=9D
(accompanied by a comment stating =E2=80=9CCompatibility with 20.x.=E2=80=
=9D): it is
changed to =E2=80=98unspecified=E2=80=99, but in =E2=80=9Cxfaces.c:merge_fa=
ce_ref=E2=80=9D nil is
considered an error;

2. there is a newline missing between the log entries for the result of
the evaluation and the error entries in the =E2=80=9C*Messages*=E2=80=9D bu=
ffer.  This
is bug #58311 <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D58311>.


Footnotes:
[1]  From: Eric S Fraga
     Subject: how to track down "invalid face attribute" errors?
     Date: Sun, 25 Sep 2022 13:03:03 +0100
     Message-ID: <87k05rr79k.fsf@HIDDEN>

     <https://lists.gnu.org/archive/html/help-gnu-emacs/2022-09/msg00415.ht=
ml>

--=20
Felix Dietrich

Message sent:


Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Felix Dietrich <felix.dietrich@HIDDEN>
Subject: bug#58312: Acknowledgement (Improve =?UTF-8?Q?=E2=80=9CInvalid?=
 face =?UTF-8?Q?attribute=E2=80=9D?= error message)
Message-ID: <handler.58312.B.1664995359317.ack <at> debbugs.gnu.org>
References: <87czb6p0x7.fsf@HIDDEN>
X-Gnu-PR-Message: ack 58312
X-Gnu-PR-Package: emacs
Reply-To: 58312 <at> debbugs.gnu.org
Date: Wed, 05 Oct 2022 18:43:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 58312 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
58312: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D58312
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#58312: Improve =?UTF-8?Q?=E2=80=9CInvalid?= face =?UTF-8?Q?attribute=E2=80=9D?= error message
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 06 Oct 2022 12:45:02 +0000
Resent-Message-ID: <handler.58312.B58312.16650602896016 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 58312
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Felix Dietrich <felix.dietrich@HIDDEN>
Cc: 58312 <at> debbugs.gnu.org
Received: via spool by 58312-submit <at> debbugs.gnu.org id=B58312.16650602896016
          (code B ref 58312); Thu, 06 Oct 2022 12:45:02 +0000
Received: (at 58312) by debbugs.gnu.org; 6 Oct 2022 12:44:49 +0000
Received: from localhost ([127.0.0.1]:59326 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ogQF7-0001Yx-Gd
	for submit <at> debbugs.gnu.org; Thu, 06 Oct 2022 08:44:49 -0400
Received: from quimby.gnus.org ([95.216.78.240]:41228)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1ogQF5-0001Yj-Op
 for 58312 <at> debbugs.gnu.org; Thu, 06 Oct 2022 08:44:48 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID
 :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=a4MadW5D9uQOHfn9KvDm3zcg7yVuFTkwrAv6V2ZlgV8=; b=Y8OJy2EddjIGan9+giT99CWZ63
 B/zibPqa6FFydbbU7F6d93wa65jrj9Qc9BUigVcxfIU+7WcnZ9hH/921gM7gHseF6uZQvwxiQhhoM
 fNwQf57FGdOnRbNhr0Tb36MCBdELoKiiVVoEzlW0SWlLPqISvotl4GhChMrZROVNWG0E=;
Received: from [84.212.220.105] (helo=downe)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1ogQEx-0002uW-S4; Thu, 06 Oct 2022 14:44:41 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
In-Reply-To: <87czb6p0x7.fsf@HIDDEN> (Felix Dietrich's message of
 "Wed, 05 Oct 2022 20:42:28 +0200")
References: <87czb6p0x7.fsf@HIDDEN>
X-Now-Playing: Alan Vega's _Collision Drive_: "Viet vet"
Date: Thu, 06 Oct 2022 14:44:39 +0200
Message-ID: <87pmf5xgso.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 
 Content preview:  Felix Dietrich <felix.dietrich@HIDDEN> writes: >
   Could the log message =?UTF-8?Q?=E2=80=9CInvalid?= face =?UTF-8?Q?attribute=E2=80=9D?= created by > =?UTF-8?Q?=E2=80=9Cxfaces.c:merge=5Fface=5Fref=E2=80=9D?=
    be extended to also include the buffer or > other identifying information
    about its origin? 
 
 Content analysis details:   (-2.9 points, 5.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
                             [score: 0.0000]
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Felix Dietrich <felix.dietrich@HIDDEN> writes:

> Could the log message =E2=80=9CInvalid face attribute=E2=80=9D created by
> =E2=80=9Cxfaces.c:merge_face_ref=E2=80=9D be extended to also include the=
 buffer or
> other identifying information about its origin?

Perhaps include the window name?  That would be less ambiguous than the
buffer name.

Message received at control <at> debbugs.gnu.org:


Received: (at control) by debbugs.gnu.org; 6 Oct 2022 12:44:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 06 08:44:54 2022
Received: from localhost ([127.0.0.1]:59329 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ogQFB-0001ZD-Q3
	for submit <at> debbugs.gnu.org; Thu, 06 Oct 2022 08:44:53 -0400
Received: from quimby.gnus.org ([95.216.78.240]:41242)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1ogQFA-0001Yp-UG
 for control <at> debbugs.gnu.org; Thu, 06 Oct 2022 08:44:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc:
 MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=Aci1qX2hbozWFUbTekwRCpyUNzwMW3V+y/zwkEXr/wg=; b=FDEhzxBRxqDciaC4caeaLVns2d
 2f8FqRkpEmRpzmLVoLKheEO63AeSiu27RLmpyPNg2iEbnISpC/p7et+0zgREh8fR3Me6c3ZsmMNSs
 MU7wKPs/1zLSnvNFwEAhd/jmhGoTvc/43K6YALJ4baqyw1tO/sEwgrViTR7w5ekrSdyc=;
Received: from [84.212.220.105] (helo=downe)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1ogQF3-0002ue-8W
 for control <at> debbugs.gnu.org; Thu, 06 Oct 2022 14:44:47 +0200
Date: Thu, 06 Oct 2022 14:44:44 +0200
Message-Id: <87o7upxgsj.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: control message for bug #58312
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  tags 58312 + moreinfo quit 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

tags 58312 + moreinfo
quit

Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#58312: Improve =?UTF-8?Q?=E2=80=9CInvalid?= face =?UTF-8?Q?attribute=E2=80=9D?= error message
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 10 Jan 2024 10:52:02 +0000
Resent-Message-ID: <handler.58312.B58312.170488386218875 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 58312
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: moreinfo
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: Felix Dietrich <felix.dietrich@HIDDEN>, Po Lu <luangruo@HIDDEN>, eliz@HIDDEN, 58312 <at> debbugs.gnu.org
Received: via spool by 58312-submit <at> debbugs.gnu.org id=B58312.170488386218875
          (code B ref 58312); Wed, 10 Jan 2024 10:52:02 +0000
Received: (at 58312) by debbugs.gnu.org; 10 Jan 2024 10:51:02 +0000
Received: from localhost ([127.0.0.1]:42054 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rNWAo-0004uN-6H
	for submit <at> debbugs.gnu.org; Wed, 10 Jan 2024 05:51:02 -0500
Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:50476)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1rNWAm-0004tp-8O
 for 58312 <at> debbugs.gnu.org; Wed, 10 Jan 2024 05:51:00 -0500
Received: by mail-ed1-x52b.google.com with SMTP id
 4fb4d7f45d1cf-55569b59f81so4877183a12.1
 for <58312 <at> debbugs.gnu.org>; Wed, 10 Jan 2024 02:50:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1704883847; x=1705488647; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=DTHReiVa3UkTPPUApci8QOAMmNluEjsVQ3fixS8XYKo=;
 b=hvwOUXZMg378SX0dWuoybh4A+bERkXrH51XNlSq3Pni9Cw05STb58QElPp99OOn8as
 3iGidcLnZvZHIIk4/V2R5mhtGaZsuKIJIplewGyZUfoNdPmibV03eVEyyWjFcb0/GI+H
 6LS3MPJEy7L4Dta7QcBfdfiXHkRtIYDaMTRmYFi85rWq9+/EiNXmhxfuBaTg26hZEeDX
 ejlPQwl4AQCu4e/ev69ugXA9A6Uiou3XKoNu/5lK+cXEIXlYevEYKoBXnfsYNeL2GJCq
 u0QjK10EV2Po3TLVtfNxAgp+JSJH8i2CuglXBDxnXIFPS+okzksWeOvWChUnSk6pGY4Q
 MMMg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1704883847; x=1705488647;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:x-gm-message-state:from:to
 :cc:subject:date:message-id:reply-to;
 bh=DTHReiVa3UkTPPUApci8QOAMmNluEjsVQ3fixS8XYKo=;
 b=PfLZLJ6lc9B7g0QOizWUAJ58o9n9WuqVIkDnKGToG8j+CW/fdxTE0CkPuRTLhQ82pc
 Ygt1igTigo19TNQAhEU5AMyJZPUpq+381q7jSEiW1KpyJRmboL417kmdIakdTb6XTb82
 cgCcLHS6UclQAABfc/HOo1lffn12vJDk6T0kxlBfCJ204zNILMzrxjUDdq2osnmzGeUs
 A+PBBGQFL3/H6+RuCMQoPCzsHYLghxqviqleaSgmtsDfgT0uZfVM81FKJhpNCmaUmpnY
 VKBlLYIvUuNw4sYhYnvM9wtZ24OPQO7dpevasbeltlDCgZVYcz50lUih24c5z5jSg14P
 elHw==
X-Gm-Message-State: AOJu0Yx2K9Ir4qiAfEtXy5C6aCU2o4tc8Yabib3pyNyGjiAk59bY/y7n
 K6TgJw2251gCota/qz07QgN1Zu/HxEtRgQ2DG3k=
X-Google-Smtp-Source: AGHT+IHZwzD2MWB55bP5wiCtbE9pQMI4GY+gNhYls44MZcIsdMSH6qifQGxgZ3ahe6BSeZ7JmRt2l0ZSTqki2wP3k38=
X-Received: by 2002:a50:8a9e:0:b0:556:95bb:8112 with SMTP id
 j30-20020a508a9e000000b0055695bb8112mr354458edj.19.1704883847007; Wed, 10 Jan
 2024 02:50:47 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Wed, 10 Jan 2024 02:50:46 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87pmf5xgso.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Thu,
 06 Oct 2022 14:44:39 +0200")
References: <87czb6p0x7.fsf@HIDDEN> <87pmf5xgso.fsf@HIDDEN>
MIME-Version: 1.0
Date: Wed, 10 Jan 2024 02:50:46 -0800
Message-ID: <CADwFkmkc+0RRb8ZR6PD_dSYwCu6oG_wCiZXZzYoEujyq=HB=xw@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Lars Ingebrigtsen <larsi@HIDDEN> writes:

> Felix Dietrich <felix.dietrich@HIDDEN> writes:
>
>> Could the log message =E2=80=9CInvalid face attribute=E2=80=9D created b=
y
>> =E2=80=9Cxfaces.c:merge_face_ref=E2=80=9D be extended to also include th=
e buffer or
>> other identifying information about its origin?
>
> Perhaps include the window name?  That would be less ambiguous than the
> buffer name.

That makes sense to me.  Eli or Po Lu, WDYT about this change?

Message received at control <at> debbugs.gnu.org:


Received: (at control) by debbugs.gnu.org; 10 Jan 2024 10:51:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 10 05:51:16 2024
Received: from localhost ([127.0.0.1]:42057 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rNWB2-0004uq-FR
	for submit <at> debbugs.gnu.org; Wed, 10 Jan 2024 05:51:16 -0500
Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:44247)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1rNWB1-0004ud-68
 for control <at> debbugs.gnu.org; Wed, 10 Jan 2024 05:51:15 -0500
Received: by mail-ed1-x52a.google.com with SMTP id
 4fb4d7f45d1cf-55783b7b47aso3893397a12.0
 for <control <at> debbugs.gnu.org>; Wed, 10 Jan 2024 02:51:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1704883862; x=1705488662; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=ScM53nLVidS0uRfTXf2neGAPO54IHQNFVeKLeMcHi3s=;
 b=QoeZ0JdX4UAlzMroGU9H4fDp/qqSUap92TkRZL3KfWFQpLHEcz8zobzXug+NFyqkkY
 0hFDUyVYTeBs+SVHyV8nxHWjGx2OKufSZ5BCPYhdx8C/YZqLADQwidzJ3op61goFBJ/f
 sh45sIk/aFVWGmI26JnloJvJQefX/QSp6aMDlT8jYWjgtpy4XBWK2cwegPRnXEHzZtEF
 kGgtpX17OOrVlBxN2gCvXpUTFs/X71/pAIgAzUmR+pcqickHw0VlN6ajb84eGKU0Wqnl
 yGKsrFh4k4Pef+KiFHc5w7n+y6DEsbiqa39ZXSISXI9tHLwDrsxPY+GeirszFlxK+ePC
 y6QQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1704883862; x=1705488662;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=ScM53nLVidS0uRfTXf2neGAPO54IHQNFVeKLeMcHi3s=;
 b=g1kMknA0cTPH3VMl0LLuW66EX1cJCacRJq//7bzFx/N680Cy15JeYSCHrcLndRKJwj
 ENJYw/OHwKnQVTM/QjyUz3jHJ7yMwTX3/HuHo72YpJUIrvh4rveQ6/78m07YmSIAvXtT
 lxuH94I0FgE/1aK3e7mAzRANxIbPW16oQYUc0BH7pSXT10dWAbeTUcXzSo2kiv3898Wn
 SUXcXSksj/SDA8qMwXdBdLigIaYRZrCuEC8j0902fboufZcz85/Pi7VuaowmNeBJxJlc
 L3lZRF7Z8D3BgNAOc6aUYURr9jzybpUW866cwK8o6VzcRHl+XwE4zzRPbb+QJAW7dKro
 6UrA==
X-Gm-Message-State: AOJu0YwjqqY7X5stYXy5abOUNVDSd3KDEX8VaiuomEcOtfXJ2GFVFCMw
 nhfIY80PcTICpSxYX8/fnLEEoy9W9pEHRydeJsxj8Vy6RFU=
X-Google-Smtp-Source: AGHT+IEyATVHzXTkASKOAYJxOvKsDhiCoJeghNP5SSNRa05PeqApbyqTxnEWOZzHNa9LspboynA91FQtLTssoymJFh4=
X-Received: by 2002:a50:cd10:0:b0:558:1540:d33a with SMTP id
 z16-20020a50cd10000000b005581540d33amr340154edi.17.1704883862117; Wed, 10 Jan
 2024 02:51:02 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Wed, 10 Jan 2024 02:51:01 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Wed, 10 Jan 2024 02:51:01 -0800
Message-ID: <CADwFkmkq_p5g5u3ZXMyKmQWmy4v0A2zt5NDJEmG9fXsByN2f9A@HIDDEN>
Subject: control message for bug #58312
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 58312 - moreinfo
quit

Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#58312: Improve =?UTF-8?Q?=E2=80=9CInvalid?= face =?UTF-8?Q?attribute=E2=80=9D?= error message
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 10 Jan 2024 13:48:02 +0000
Resent-Message-ID: <handler.58312.B58312.170489446211463 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 58312
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: felix.dietrich@HIDDEN, luangruo@HIDDEN, larsi@HIDDEN, 58312 <at> debbugs.gnu.org
Received: via spool by 58312-submit <at> debbugs.gnu.org id=B58312.170489446211463
          (code B ref 58312); Wed, 10 Jan 2024 13:48:02 +0000
Received: (at 58312) by debbugs.gnu.org; 10 Jan 2024 13:47:42 +0000
Received: from localhost ([127.0.0.1]:39222 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rNYvl-0002yc-SP
	for submit <at> debbugs.gnu.org; Wed, 10 Jan 2024 08:47:42 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:54278)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rNYvh-0002ww-ND
 for 58312 <at> debbugs.gnu.org; Wed, 10 Jan 2024 08:47:41 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rNYmi-0007iD-Oe; Wed, 10 Jan 2024 08:38:20 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=4CweE6fYErviUqekyC6OMON5mpZrVqTP2OXILhmtH58=; b=CYAhjPn0atORvmeNEUUD
 g+NogoI1UM3MBb6+wd7NEfPABRhEhRGQdtSdgPDffw4RsmAJ1/z9kXGc4nSIIL+8W0kAxe6N1EBnI
 M2M42QNr8ys1DAY0w+Ft4vqZ/n7i8DD475pC9fAOg1NyHbubNW/BTooPoPBWcU/YMJ6U9BAY69cdj
 KzTILO95YDNsu4YWEVP3rWg/dzMYSYsXJeqG6lO7ZdBraO6+wk7qQFMspDoT/ok7Tqob3df6/ojes
 ds+a1Bip7b6G6gPX8kzzx3Fp8LjWV5Xs9cRDIT6MKLtU36wxmNBdWyUYRAnbcCl51VuuU3Q6gB5DY
 ZQfdPijbh5dklA==;
Date: Wed, 10 Jan 2024 15:38:00 +0200
Message-Id: <834jflnwav.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CADwFkmkc+0RRb8ZR6PD_dSYwCu6oG_wCiZXZzYoEujyq=HB=xw@HIDDEN>
 (message from Stefan Kangas on Wed, 10 Jan 2024 02:50:46 -0800)
References: <87czb6p0x7.fsf@HIDDEN> <87pmf5xgso.fsf@HIDDEN>
 <CADwFkmkc+0RRb8ZR6PD_dSYwCu6oG_wCiZXZzYoEujyq=HB=xw@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Kangas <stefankangas@HIDDEN>
> Date: Wed, 10 Jan 2024 02:50:46 -0800
> Cc: Felix Dietrich <felix.dietrich@HIDDEN>, 58312 <at> debbugs.gnu.org, eliz@HIDDEN, 
> 	Po Lu <luangruo@HIDDEN>
> 
> Lars Ingebrigtsen <larsi@HIDDEN> writes:
> 
> > Felix Dietrich <felix.dietrich@HIDDEN> writes:
> >
> >> Could the log message “Invalid face attribute” created by
> >> “xfaces.c:merge_face_ref” be extended to also include the buffer or
> >> other identifying information about its origin?
> >
> > Perhaps include the window name?  That would be less ambiguous than the
> > buffer name.
> 
> That makes sense to me.  Eli or Po Lu, WDYT about this change?

Patches welcome, but please take into account the fact that the window
is not always known there: merge_face_ref can be called with its first
argument NULL.
Last modified: Sat, 20 Jan 2024 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.