GNU bug report logs - #58319
29.0.50; Not logical compilation warnings

Previous Next

Package: emacs;

Reported by: "Jean Louis" <bugs <at> rcdrun.com>

Date: Wed, 5 Oct 2022 20:34:04 UTC

Severity: normal

Tags: notabug

Found in version 29.0.50

Done: Mattias Engdegård <mattias.engdegard <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58319 in the body.
You can then email your comments to 58319 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#58319; Package emacs. (Wed, 05 Oct 2022 20:34:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Jean Louis" <bugs <at> rcdrun.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 05 Oct 2022 20:34:04 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Jean Louis" <bugs <at> rcdrun.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Not logical compilation warnings
Date: Wed, 05 Oct 2022 21:25:00 +0300
I am testing new function M-x emacs-lisp-native-compile-and-load
and I can see some new warnings that I have not seen before.

These warnings are not enlightening neither helpful.

It is not clear what the sign + after number means. It is unclear if it
means "5 and more" or "more than five". That sign is not helpful.

To me it looks same 5+ and 5-10, as both mean to me that it is 5 and
more arguments. But maybe author wants to say what it should mean.

In rcd-db-report:
rcd-cf.el:365:8: Warning: function rcd-db-report used to take 5+ arguments,
    now takes 5-10

In cf-address-add:
rcd-cf.el:956:8: Warning: function cf-address-add used to take 0+ arguments,
    now takes 0-10

In cf-people-relations-add:
rcd-cf.el:3351:8: Warning: function cf-people-relations-add used to take 0+
    arguments, now takes 0-19



In GNU Emacs 29.0.50 (build 3, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.17.6, Xaw3d scroll bars) of 2022-10-05 built on
 protected.rcdrun.com
Repository revision: 9449e0740cd97bbcdbaeb4713dc2dd51e65994fd
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Parabola GNU/Linux-libre

Configured using:
 'configure --with-x-toolkit=lucid --with-native-compilation'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS WEBP X11 XAW3D XDBE XIM XINPUT2 XPM LUCID ZLIB

Important settings:
  value of $LC_ALL: en_US.UTF-8
  value of $LANG: de_DE.UTF-8
  value of $XMODIFIERS: @im=exwm-xim
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
comp comp-cstr warnings icons subr-x rx cl-seq cl-macs gv cl-extra
help-mode bytecomp byte-compile cconv cl-lib sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip eldoc
paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode
mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
faces cus-face macroexp files window text-properties overlay sha1 md5
base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo x-toolkit
xinput2 x multi-tty make-network-process native-compile emacs)

Memory information:
((conses 16 79594 8370)
 (symbols 48 7181 0)
 (strings 32 20866 1702)
 (string-bytes 1 622658)
 (vectors 16 16150)
 (vector-slots 8 279952 10661)
 (floats 8 29 30)
 (intervals 56 277 0)
 (buffers 1000 13))

-- 
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58319; Package emacs. (Thu, 06 Oct 2022 05:34:02 GMT) Full text and rfc822 format available.

Message #8 received at 58319 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Jean Louis" <bugs <at> rcdrun.com>
Cc: 58319 <at> debbugs.gnu.org
Subject: Re: bug#58319: 29.0.50; Not logical compilation warnings
Date: Thu, 06 Oct 2022 08:33:15 +0300
> From: "Jean Louis" <bugs <at> rcdrun.com>
> Date: Wed, 05 Oct 2022 21:25:00 +0300
> 
> 
> I am testing new function M-x emacs-lisp-native-compile-and-load
> and I can see some new warnings that I have not seen before.

The aspects of the warnings you are asking about have nothing to do
with native-compilation, the warnings are emitted by the byte
compiler.

> These warnings are not enlightening neither helpful.

Maybe you need to get used to what they say, that's all.

> It is not clear what the sign + after number means. It is unclear if it
> means "5 and more" or "more than five". That sign is not helpful.

It means 5 or more.  Usually, it means the function's signature has 5
mandatory arguments and then something like "&rest args".

> To me it looks same 5+ and 5-10, as both mean to me that it is 5 and
> more arguments. But maybe author wants to say what it should mean.

Emacs can only say "5-10" when the function uses &optional, because
only in that case it is possible to know how many more can follow.

I think this format of warnings exists since about forever.




Added tag(s) notabug. Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 06 Oct 2022 07:12:01 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58319; Package emacs. (Thu, 06 Oct 2022 10:18:01 GMT) Full text and rfc822 format available.

Message #13 received at 58319 <at> debbugs.gnu.org (full text, mbox):

From: Jean Louis <bugs <at> gnu.support>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58319 <at> debbugs.gnu.org
Subject: Re: bug#58319: 29.0.50; Not logical compilation warnings
Date: Thu, 6 Oct 2022 13:06:46 +0300
* Eli Zaretskii <eliz <at> gnu.org> [2022-10-06 08:35]:
> > From: "Jean Louis" <bugs <at> rcdrun.com>
> > Date: Wed, 05 Oct 2022 21:25:00 +0300
> > 
> > 
> > I am testing new function M-x emacs-lisp-native-compile-and-load
> > and I can see some new warnings that I have not seen before.
> 
> The aspects of the warnings you are asking about have nothing to do
> with native-compilation, the warnings are emitted by the byte
> compiler.

Thanks, I get understanding.

> > These warnings are not enlightening neither helpful.
> 
> Maybe you need to get used to what they say, that's all.

Of course I can get used to less meaningful expression, but I protest
against such.

> > It is not clear what the sign + after number means. It is unclear if it
> > means "5 and more" or "more than five". That sign is not helpful.
> 
> It means 5 or more.  Usually, it means the function's signature has 5
> mandatory arguments and then something like "&rest args".

> > To me it looks same 5+ and 5-10, as both mean to me that it is 5 and
> > more arguments. But maybe author wants to say what it should mean.
> 
> Emacs can only say "5-10" when the function uses &optional, because
> only in that case it is possible to know how many more can follow.
> 
> I think this format of warnings exists since about forever.

That means when it says "5-10" that it is limited to 10, and "5+"
means it is not limited to how many arguments it can take.

That meaning is not clearly expressed, it is something only insiders
know.

--
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58319; Package emacs. (Thu, 06 Oct 2022 10:55:01 GMT) Full text and rfc822 format available.

Message #16 received at 58319 <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: 58319 <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>, Stefan Monnier <monnier <at> iro.umontreal.ca>,
 Jean Louis <bugs <at> rcdrun.com>
Subject: bug#58319: 29.0.50; Not logical compilation warnings
Date: Thu, 6 Oct 2022 12:54:29 +0200
[Message part 1 (text/plain, inline)]
The warnings not being "logical" is of course nonsense, but I actually agree that '5+' is a tad on the obscure side. This is a human-facing message and we can be nicer: either '5 or more' or 'at least 5' would be clearer.

'5-10' is not quite as problematic. 'from 5 to 10' would probably do, and 'between 5 and 10' is better but also worse since it could be misinterpreted as the set {6..9} unless we append ' inclusive'. No strong opinion here.

As a special case, '5-6' is always better written as '5 or 6'.

I've looked through the various contexts where the messages appear and the patch below (which keeps 'X-Y') should be an improvement in all cases. Anyone strongly against?

[arity-warning-message.diff (application/octet-stream, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58319; Package emacs. (Thu, 06 Oct 2022 12:23:01 GMT) Full text and rfc822 format available.

Message #19 received at 58319 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Jean Louis <bugs <at> rcdrun.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>, 58319 <at> debbugs.gnu.org
Subject: Re: bug#58319: 29.0.50; Not logical compilation warnings
Date: Thu, 06 Oct 2022 14:22:33 +0200
Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:

> I've looked through the various contexts where the messages appear and
> the patch below (which keeps 'X-Y') should be an improvement in all
> cases. Anyone strongly against?

I think your change looks like an improvement -- it clarifies without
making the warnings substantially longer.




Reply sent to Mattias Engdegård <mattias.engdegard <at> gmail.com>:
You have taken responsibility. (Fri, 07 Oct 2022 12:08:01 GMT) Full text and rfc822 format available.

Notification sent to "Jean Louis" <bugs <at> rcdrun.com>:
bug acknowledged by developer. (Fri, 07 Oct 2022 12:08:02 GMT) Full text and rfc822 format available.

Message #24 received at 58319-done <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 58319-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#58319: 29.0.50; Not logical compilation warnings
Date: Fri, 7 Oct 2022 14:07:13 +0200
6 okt. 2022 kl. 14.22 skrev Lars Ingebrigtsen <larsi <at> gnus.org>:

> I think your change looks like an improvement -- it clarifies without
> making the warnings substantially longer.

Thank you, pushed to master.
(Of course '3-5' should really be '3–5' but who knows what terminal trouble that would cause.)





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58319; Package emacs. (Fri, 07 Oct 2022 13:08:02 GMT) Full text and rfc822 format available.

Message #27 received at 58319 <at> debbugs.gnu.org (full text, mbox):

From: Jean Louis <bugs <at> gnu.support>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Stefan Monnier <monnier <at> iro.umontreal.ca>,
 58319 <at> debbugs.gnu.org
Subject: Re: bug#58319: 29.0.50; Not logical compilation warnings
Date: Fri, 7 Oct 2022 13:58:37 +0300
* Mattias Engdegård <mattias.engdegard <at> gmail.com> [2022-10-06 13:56]:
> The warnings not being "logical" is of course nonsense, but I
> actually agree that '5+' is a tad on the obscure side. This is a
> human-facing message and we can be nicer: either '5 or more' or 'at
> least 5' would be clearer.

Good.

But it should be something like:

- 5 or more without limit
- 5 to maximum 10

--
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58319; Package emacs. (Fri, 07 Oct 2022 13:08:02 GMT) Full text and rfc822 format available.

Message #30 received at 58319 <at> debbugs.gnu.org (full text, mbox):

From: Jean Louis <bugs <at> gnu.support>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Mattias Engdegård <mattias.engdegard <at> gmail.com>,
 58319 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#58319: 29.0.50; Not logical compilation warnings
Date: Fri, 7 Oct 2022 14:00:02 +0300
* Lars Ingebrigtsen <larsi <at> gnus.org> [2022-10-06 16:06]:
> Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:
> 
> > I've looked through the various contexts where the messages appear and
> > the patch below (which keeps 'X-Y') should be an improvement in all
> > cases. Anyone strongly against?
> 
> I think your change looks like an improvement -- it clarifies without
> making the warnings substantially longer.

Cutting the meaning for purpose of making warnings shorter is
detrimental.

Warnings are for human and they are not stored anywhere. You waste no
hard disk space.

--
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 05 Nov 2022 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 145 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.