GNU logs - #58381, boring messages


Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#58381] yubikey-agent
Resent-From: Nicolas Graves <ngraves@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 08 Oct 2022 16:37:01 +0000
Resent-Message-ID: <handler.58381.B.166524701632006 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 58381
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: 58381 <at> debbugs.gnu.org
X-Debbugs-Original-To: guix-patches@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.166524701632006
          (code B ref -1); Sat, 08 Oct 2022 16:37:01 +0000
Received: (at submit) by debbugs.gnu.org; 8 Oct 2022 16:36:56 +0000
Received: from localhost ([127.0.0.1]:41320 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ohCoq-0008K9-E5
	for submit <at> debbugs.gnu.org; Sat, 08 Oct 2022 12:36:56 -0400
Received: from lists.gnu.org ([209.51.188.17]:52856)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ngraves@HIDDEN>) id 1ohCol-0008Jx-2x
 for submit <at> debbugs.gnu.org; Sat, 08 Oct 2022 12:36:55 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:44556)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ngraves@HIDDEN>)
 id 1ohCok-0000pa-S0
 for guix-patches@HIDDEN; Sat, 08 Oct 2022 12:36:50 -0400
Received: from 5.mo576.mail-out.ovh.net ([46.105.43.105]:46389)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ngraves@HIDDEN>)
 id 1ohCoh-0003mI-FO
 for guix-patches@HIDDEN; Sat, 08 Oct 2022 12:36:50 -0400
Received: from player763.ha.ovh.net (unknown [10.110.171.136])
 by mo576.mail-out.ovh.net (Postfix) with ESMTP id 8219923B3F
 for <guix-patches@HIDDEN>; Sat,  8 Oct 2022 16:36:35 +0000 (UTC)
Received: from ngraves.fr (met42-h01-213-44-161-47.dsl.sta.abo.bbox.fr
 [213.44.161.47]) (Authenticated sender: ngraves@HIDDEN)
 by player763.ha.ovh.net (Postfix) with ESMTPSA id DD6992F7F7F43
 for <guix-patches@HIDDEN>; Sat,  8 Oct 2022 16:36:34 +0000 (UTC)
Authentication-Results: garm.ovh; auth=pass
 (GARM-95G001ea10d02a-0698-4698-bf70-99a376d63b6e,
 5F6F42330A353EE9EB4E9625E491D0CA375D2A9D) smtp.auth=ngraves@HIDDEN
X-OVh-ClientIp: 213.44.161.47
From: Nicolas Graves <ngraves@HIDDEN>
Date: Sat, 08 Oct 2022 18:36:34 +0200
Message-ID: <87r0zil1bh.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Ovh-Tracer-Id: 12038966232622883578
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: 0
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeiledguddtudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvufffkfggtgesthdtredttddttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeeujeelieeljeffhfelteejtdeljeehveduffelvefgudefkeehgfdvvdevgeevfeenucfkpheptddrtddrtddrtddpvddufedrgeegrdduiedurdegjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepphhlrgihvghrjeeifedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehnghhrrghvvghssehnghhrrghvvghsrdhfrhdpnhgspghrtghpthhtohepuddprhgtphhtthhopehguhhigidqphgrthgthhgvshesghhnuhdrohhrghdpoffvtefjohhsthepmhhoheejie
Received-SPF: pass client-ip=46.105.43.105; envelope-from=ngraves@HIDDEN;
 helo=5.mo576.mail-out.ovh.net
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)


Small go package series to add yubikey-agent.

-- 
Best regards,
Nicolas Graves




Message sent:


Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Nicolas Graves <ngraves@HIDDEN>
Subject: bug#58381: Acknowledgement (yubikey-agent)
Message-ID: <handler.58381.B.166524701632006.ack <at> debbugs.gnu.org>
References: <87r0zil1bh.fsf@HIDDEN>
X-Gnu-PR-Message: ack 58381
X-Gnu-PR-Package: guix-patches
Reply-To: 58381 <at> debbugs.gnu.org
Date: Sat, 08 Oct 2022 16:37:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 58381 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
58381: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D58381
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems


Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#58381] [PATCH 1/3] gnu: Add go-github-com-go-piv-piv-go.
References: <87r0zil1bh.fsf@HIDDEN>
In-Reply-To: <87r0zil1bh.fsf@HIDDEN>
Resent-From: Nicolas Graves <ngraves@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 08 Oct 2022 16:40:01 +0000
Resent-Message-ID: <handler.58381.B58381.166524718732357 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 58381
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: 58381 <at> debbugs.gnu.org
Cc: ngraves@HIDDEN
Received: via spool by 58381-submit <at> debbugs.gnu.org id=B58381.166524718732357
          (code B ref 58381); Sat, 08 Oct 2022 16:40:01 +0000
Received: (at 58381) by debbugs.gnu.org; 8 Oct 2022 16:39:47 +0000
Received: from localhost ([127.0.0.1]:41330 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ohCra-0008Pk-D7
	for submit <at> debbugs.gnu.org; Sat, 08 Oct 2022 12:39:47 -0400
Received: from 13.mo561.mail-out.ovh.net ([188.165.33.202]:43923)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ngraves@HIDDEN>) id 1ohCrV-0008PX-SP
 for 58381 <at> debbugs.gnu.org; Sat, 08 Oct 2022 12:39:44 -0400
Received: from player761.ha.ovh.net (unknown [10.110.171.54])
 by mo561.mail-out.ovh.net (Postfix) with ESMTP id 23DBD24087
 for <58381 <at> debbugs.gnu.org>; Sat,  8 Oct 2022 16:39:39 +0000 (UTC)
Received: from ngraves.fr (met42-h01-213-44-161-47.dsl.sta.abo.bbox.fr
 [213.44.161.47]) (Authenticated sender: ngraves@HIDDEN)
 by player761.ha.ovh.net (Postfix) with ESMTPSA id 143B22F7D76B5;
 Sat,  8 Oct 2022 16:39:37 +0000 (UTC)
Authentication-Results: garm.ovh; auth=pass
 (GARM-107S00127e56177-59d9-4685-86f8-d50fbd3bb50a,
 5F6F42330A353EE9EB4E9625E491D0CA375D2A9D) smtp.auth=ngraves@HIDDEN
X-OVh-ClientIp: 213.44.161.47
From: Nicolas Graves <ngraves@HIDDEN>
Date: Sat,  8 Oct 2022 18:39:30 +0200
Message-Id: <20221008163932.15808-1-ngraves@HIDDEN>
X-Mailer: git-send-email 2.38.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Ovh-Tracer-Id: 12090757626111451874
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: 0
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeiledguddtvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepueeiheeftdegveefgeduieehieelteekveegjeejuddtfeetheelgedvheeltddunecuffhomhgrihhnpehprghnnhgvthhrrghtrdgtohhmpdhgihhthhhusgdrtghomhenucfkpheptddrtddrtddrtddpvddufedrgeegrdduiedurdegjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepphhlrgihvghrjeeiuddrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehnghhrrghvvghssehnghhrrghvvghsrdhfrhdpnhgspghrtghpthhtohepuddprhgtphhtthhopeehkeefkeduseguvggssghughhsrdhgnhhurdhorhhgpdfovfetjfhoshhtpehmohehiedu
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/security-token.scm (go-github-com-go-piv-piv-go): New variable.
---
 gnu/packages/security-token.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 447a7a582d..3dc619ed4f 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -17,6 +17,7 @@
 ;;; Copyright © 2022 John Kehayias <john.kehayias@HIDDEN>
 ;;; Copyright © 2022 Petr Hodina <phodina@HIDDEN>
 ;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
+;;; Copyright © 2022 Nicolas Graves <ngraves@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -44,6 +45,7 @@ (define-module (gnu packages security-token)
   #:use-module (guix build-system cargo)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system go)
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system python)
   #:use-module (gnu packages autotools)
@@ -967,3 +969,30 @@ (define-public cardpeek
 It also has limited support for Mifare Classic compatible cards (Thalys card)")
     (license license:gpl3+)
     (home-page "http://pannetrat.com/Cardpeek")))
+
+(define-public go-github-com-go-piv-piv-go
+  (package
+    (name "go-github-com-go-piv-piv-go")
+    (version "1.10.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/go-piv/piv-go")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1j2szvvwgd0ysbap42rap4f60pj4smmmrxjlx0y131l3ki6v6gdm"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/go-piv/piv-go/piv"
+       #:unpack-path "github.com/go-piv/piv-go"
+       #:tests? #f))
+    (native-inputs (list pkg-config))
+    (propagated-inputs (list pcsc-lite))
+    (home-page "https://github.com/go-piv/piv-go")
+    (synopsis "A Go YubiKey PIV implementation")
+    (description "YubiKeys implement the PIV specification for managing smart
+card certificates. This package provides a simpler alternative to GPG for
+managing asymmetric keys on a YubiKey.")
+    (license license:asl2.0)))
-- 
2.38.0





Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#58381] [PATCH 2/3] gnu: Add go-github-com-twpayne-go-pinentry-minimal.
Resent-From: Nicolas Graves <ngraves@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 08 Oct 2022 16:40:02 +0000
Resent-Message-ID: <handler.58381.B58381.166524718932369 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 58381
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: 58381 <at> debbugs.gnu.org
Cc: ngraves@HIDDEN
Received: via spool by 58381-submit <at> debbugs.gnu.org id=B58381.166524718932369
          (code B ref 58381); Sat, 08 Oct 2022 16:40:02 +0000
Received: (at 58381) by debbugs.gnu.org; 8 Oct 2022 16:39:49 +0000
Received: from localhost ([127.0.0.1]:41332 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ohCrd-0008Q1-1m
	for submit <at> debbugs.gnu.org; Sat, 08 Oct 2022 12:39:49 -0400
Received: from 14.mo584.mail-out.ovh.net ([46.105.40.29]:56917)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ngraves@HIDDEN>) id 1ohCrZ-0008Ph-P1
 for 58381 <at> debbugs.gnu.org; Sat, 08 Oct 2022 12:39:46 -0400
Received: from player739.ha.ovh.net (unknown [10.109.143.232])
 by mo584.mail-out.ovh.net (Postfix) with ESMTP id 3AA0E21C4F
 for <58381 <at> debbugs.gnu.org>; Sat,  8 Oct 2022 16:39:43 +0000 (UTC)
Received: from ngraves.fr (met42-h01-213-44-161-47.dsl.sta.abo.bbox.fr
 [213.44.161.47]) (Authenticated sender: ngraves@HIDDEN)
 by player739.ha.ovh.net (Postfix) with ESMTPSA id 61A272B6F599C;
 Sat,  8 Oct 2022 16:39:42 +0000 (UTC)
Authentication-Results: garm.ovh; auth=pass
 (GARM-105G00656adb0cc-17f1-435a-90ab-80cc2a8862e5,
 5F6F42330A353EE9EB4E9625E491D0CA375D2A9D) smtp.auth=ngraves@HIDDEN
X-OVh-ClientIp: 213.44.161.47
From: Nicolas Graves <ngraves@HIDDEN>
Date: Sat,  8 Oct 2022 18:39:31 +0200
Message-Id: <20221008163932.15808-2-ngraves@HIDDEN>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221008163932.15808-1-ngraves@HIDDEN>
References: <20221008163932.15808-1-ngraves@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Ovh-Tracer-Id: 12091883527128146658
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: 0
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeiledguddtvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpedvheelieffheetvdelhfffffejfefgudfhteekveehieetudeiudfgkeeutdehjeenucffohhmrghinhepghhithhhuhgsrdgtohhmnecukfhppedtrddtrddtrddtpddvudefrdeggedrudeiuddrgeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrhejfeelrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepheekfeekudesuggvsggsuhhgshdrghhnuhdrohhrghdpoffvtefjohhsthepmhhoheekge
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/security-token.scm (go-github-com-twpayne-go-pinentry-minimal): New variable.
---
 gnu/packages/security-token.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 3dc619ed4f..af7325ee79 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -996,3 +996,28 @@ (define-public go-github-com-go-piv-piv-go
 card certificates. This package provides a simpler alternative to GPG for
 managing asymmetric keys on a YubiKey.")
     (license license:asl2.0)))
+
+(define-public go-github-com-twpayne-go-pinentry-minimal
+  (package
+    (name "go-github-com-twpayne-go-pinentry-minimal")
+    (version "0.0.0-20220113210447-2a5dc4396c2a")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/twpayne/go-pinentry-minimal")
+             (commit (go-version->git-ref version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1rzy0r8bf6qhfvymsg36db07pgrv10kn0yanc12ph73mg9rw2qgz"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/twpayne/go-pinentry-minimal/pinentry"
+       #:unpack-path "github.com/twpayne/go-pinentry-minimal"))
+    (home-page "https://github.com/twpayne/go-pinentry-minimal")
+    (synopsis "Pinentry client")
+    (description
+     "This package provides a minimal client to GnuPG's pinentry,
+which only depends on Go's standard library.  It is a fork of
+@url{https://github.com/twpayne/go-pinentry}.")
+    (license license:expat)))
-- 
2.38.0





Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#58381] [PATCH 3/3] gnu: Add yubikey-agent.
Resent-From: Nicolas Graves <ngraves@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 08 Oct 2022 16:40:02 +0000
Resent-Message-ID: <handler.58381.B58381.166524719132385 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 58381
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: 58381 <at> debbugs.gnu.org
Cc: ngraves@HIDDEN
Received: via spool by 58381-submit <at> debbugs.gnu.org id=B58381.166524719132385
          (code B ref 58381); Sat, 08 Oct 2022 16:40:02 +0000
Received: (at 58381) by debbugs.gnu.org; 8 Oct 2022 16:39:51 +0000
Received: from localhost ([127.0.0.1]:41335 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ohCrf-0008QG-CC
	for submit <at> debbugs.gnu.org; Sat, 08 Oct 2022 12:39:51 -0400
Received: from 7.mo560.mail-out.ovh.net ([188.165.48.182]:56069)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ngraves@HIDDEN>) id 1ohCrd-0008Pz-9Z
 for 58381 <at> debbugs.gnu.org; Sat, 08 Oct 2022 12:39:50 -0400
Received: from player728.ha.ovh.net (unknown [10.109.146.173])
 by mo560.mail-out.ovh.net (Postfix) with ESMTP id 9B3A023C35
 for <58381 <at> debbugs.gnu.org>; Sat,  8 Oct 2022 16:39:47 +0000 (UTC)
Received: from ngraves.fr (met42-h01-213-44-161-47.dsl.sta.abo.bbox.fr
 [213.44.161.47]) (Authenticated sender: ngraves@HIDDEN)
 by player728.ha.ovh.net (Postfix) with ESMTPSA id ED5F32F68899C;
 Sat,  8 Oct 2022 16:39:45 +0000 (UTC)
Authentication-Results: garm.ovh; auth=pass
 (GARM-96R001f08b3068-46fa-4563-a7d4-5769e30c34e3,
 5F6F42330A353EE9EB4E9625E491D0CA375D2A9D) smtp.auth=ngraves@HIDDEN
X-OVh-ClientIp: 213.44.161.47
From: Nicolas Graves <ngraves@HIDDEN>
Date: Sat,  8 Oct 2022 18:39:32 +0200
Message-Id: <20221008163932.15808-3-ngraves@HIDDEN>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221008163932.15808-1-ngraves@HIDDEN>
References: <20221008163932.15808-1-ngraves@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Ovh-Tracer-Id: 12093009425799373538
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: 0
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeiledguddtvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeehleefjeeutddvkefgveeuueelieeiteethfejudfhkeegfeegvdeggfektdeileenucffohhmrghinhepghhithhhuhgsrdgtohhmpdhfihhlihhpphhordhiohenucfkpheptddrtddrtddrtddpvddufedrgeegrdduiedurdegjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepphhlrgihvghrjedvkedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehnghhrrghvvghssehnghhrrghvvghsrdhfrhdpnhgspghrtghpthhtohepuddprhgtphhtthhopeehkeefkeduseguvggssghughhsrdhgnhhurdhorhhgpdfovfetjfhoshhtpehmohehiedt
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/security-token.scm (yubikey-agent): New variable.
---
 gnu/packages/security-token.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index af7325ee79..306d0b86e6 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -62,6 +62,7 @@ (define-module (gnu packages security-token)
   #:use-module (gnu packages graphviz)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages gnupg)
+  #:use-module (gnu packages golang)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages libusb)
   #:use-module (gnu packages linux)
@@ -1021,3 +1022,34 @@ (define-public go-github-com-twpayne-go-pinentry-minimal
 which only depends on Go's standard library.  It is a fork of
 @url{https://github.com/twpayne/go-pinentry}.")
     (license license:expat)))
+
+(define-public yubikey-agent
+  (let* ((commit "6d9db9c29100daacbe83e74653c79c94acc5958d")
+         (revision "1"))
+    (package
+      (name "yubikey-agent")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/FiloSottile/yubikey-agent")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "06y2qjq0m365sdl6inxzfnqyd346i5sgfis5crw2zmgsl1q5kdws"))))
+      (build-system go-build-system)
+      (arguments
+       '(#:import-path "filippo.io/yubikey-agent"))
+      (propagated-inputs
+       (list go-golang-org-x-term
+             go-golang-org-x-sys
+             go-golang-org-x-crypto
+             go-github-com-twpayne-go-pinentry-minimal
+             go-github-com-go-piv-piv-go
+             pcsc-lite))
+      (native-inputs (list pkg-config))
+      (home-page "https://filippo.io/yubikey-agent")
+      (synopsis "yubikey-agent")
+      (description "yubikey-agent is a seamless ssh-agent for YubiKeys.")
+      (license license:bsd-3))))
-- 
2.38.0





Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#58381] [PATCH 1/3] gnu: Add go-github-com-go-piv-piv-go.
Resent-From: Christopher Baines <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 11 Oct 2022 10:51:02 +0000
Resent-Message-ID: <handler.58381.B.166548541418674 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 58381
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: Nicolas Graves <ngraves@HIDDEN>
Cc: 58381 <at> debbugs.gnu.org
X-Debbugs-Original-Cc: 58381 <at> debbugs.gnu.org, guix-patches@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.166548541418674
          (code B ref -1); Tue, 11 Oct 2022 10:51:02 +0000
Received: (at submit) by debbugs.gnu.org; 11 Oct 2022 10:50:14 +0000
Received: from localhost ([127.0.0.1]:51121 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oiCpy-0004r7-CN
	for submit <at> debbugs.gnu.org; Tue, 11 Oct 2022 06:50:14 -0400
Received: from lists.gnu.org ([209.51.188.17]:49882)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1oiCpx-0004qz-CP
 for submit <at> debbugs.gnu.org; Tue, 11 Oct 2022 06:50:13 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:43280)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1oiCpl-0003au-Lc
 for guix-patches@HIDDEN; Tue, 11 Oct 2022 06:50:08 -0400
Received: from mira.cbaines.net ([212.71.252.8]:36752)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mail@HIDDEN>) id 1oiCpj-0000gG-34
 for guix-patches@HIDDEN; Tue, 11 Oct 2022 06:50:00 -0400
Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:fc93:27fb:8412:c8b7])
 by mira.cbaines.net (Postfix) with ESMTPSA id AEEC627BBE9;
 Tue, 11 Oct 2022 11:49:57 +0100 (BST)
Received: from felis (localhost [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id 202dae13;
 Tue, 11 Oct 2022 10:49:57 +0000 (UTC)
References: <87r0zil1bh.fsf@HIDDEN>
 <20221008163932.15808-1-ngraves@HIDDEN>
User-agent: mu4e 1.8.9; emacs 28.1
From: Christopher Baines <mail@HIDDEN>
Date: Tue, 11 Oct 2022 11:48:43 +0100
In-reply-to: <20221008163932.15808-1-ngraves@HIDDEN>
Message-ID: <87pmeyab3i.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@HIDDEN;
 helo=mira.cbaines.net
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Nicolas Graves via Guix-patches via <guix-patches@HIDDEN> writes:

> * gnu/packages/security-token.scm (go-github-com-go-piv-piv-go): New vari=
able.
> ---
>  gnu/packages/security-token.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)

Hi Nicolas,

These patches look pretty good to me, just some things to check with
propagated-inputs though.

> diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-toke=
n.scm
> index 447a7a582d..3dc619ed4f 100644
> --- a/gnu/packages/security-token.scm
> +++ b/gnu/packages/security-token.scm
> @@ -17,6 +17,7 @@
>  ;;; Copyright =C2=A9 2022 John Kehayias <john.kehayias@HIDDEN>
>  ;;; Copyright =C2=A9 2022 Petr Hodina <phodina@HIDDEN>
>  ;;; Copyright =C2=A9 2022 Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.=
org>
> +;;; Copyright =C2=A9 2022 Nicolas Graves <ngraves@HIDDEN>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -44,6 +45,7 @@ (define-module (gnu packages security-token)
>    #:use-module (guix build-system cargo)
>    #:use-module (guix build-system cmake)
>    #:use-module (guix build-system gnu)
> +  #:use-module (guix build-system go)
>    #:use-module (guix build-system glib-or-gtk)
>    #:use-module (guix build-system python)
>    #:use-module (gnu packages autotools)
> @@ -967,3 +969,30 @@ (define-public cardpeek
>  It also has limited support for Mifare Classic compatible cards (Thalys =
card)")
>      (license license:gpl3+)
>      (home-page "http://pannetrat.com/Cardpeek")))
> +
> +(define-public go-github-com-go-piv-piv-go
> +  (package
> +    (name "go-github-com-go-piv-piv-go")
> +    (version "1.10.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/go-piv/piv-go")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "1j2szvvwgd0ysbap42rap4f60pj4smmmrxjlx0y131l3ki6v6gdm"))=
))
> +    (build-system go-build-system)
> +    (arguments
> +     '(#:import-path "github.com/go-piv/piv-go/piv"
> +       #:unpack-path "github.com/go-piv/piv-go"
> +       #:tests? #f))
> +    (native-inputs (list pkg-config))
> +    (propagated-inputs (list pcsc-lite))

What relation does pcsc-lite have to this package, and why does it need
to be propagated?

If this can be avoid, that would be good. Otherwise it would be good to
mention why the propagation is needed in a comment.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNFSlFfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XfYFg/+P0CYkrsWuE6xqm1WTl0jLculxpSCQZM/
vRNiycXl9IXf4xz2OFrswi4d6yqdYQt2Fi1SOoLIOz1nkq60P6ARdd0W5BADfbi6
3BOV7IW2fDDtufuhfYxZC5ThskTlGwvJ6aoN8dPY2D+CroK4Vlb4Xzq6JbxxGqnk
1QpNklCmyoF09H803roHuaskM2cSpY0nTJhuEJImr0egvURPBccXNenTHjjMXYnu
650MqtyzFFSzts1rS1jL6pGivtE1IEeQNKUg2hJ8vPW7sU9uBI+jiwR2yh+9qtp4
RhmGYxNia3a7k3FpuXnBZUcTLIPPK5btSvqxVqpuR2LFIF8X1oz8QgmuQAku00mL
XhXYfSm/dQaw0MEHNXksG0kMDUZ1lRaI3jGHUBKq9Ii9Q/BMvDhj5T382KELzEXy
CVcAURMOmmxie53TbQJ1BRXb6eyO7j/qM9ZsldxDp/ewLxEJfdRbtHbGi2oxkT8e
mmsUvTqA3QdWVzoA7M/zk5BQcMUfuLAqw4PfiQwutQvCnFWGiV/vf8gY2UPF/XId
vA/hwy1pI4zFH9xcabZu8OnXrn73ub1XH/FwmjFJDVmexN7gJfPpzQzjQ/hhdV2d
VTSU2oX/mLeX3PGI/5zYgw6c/ksvA9pRpXO8DiJbz5dQJDHk9HQSbBBRp3fgvZFl
DNky5FWM5fo=
=cMKP
-----END PGP SIGNATURE-----
--=-=-=--




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#58381] [PATCH 1/3] gnu: Add go-github-com-go-piv-piv-go.
Resent-From: Christopher Baines <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 11 Oct 2022 10:51:02 +0000
Resent-Message-ID: <handler.58381.B58381.166548540318646 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 58381
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: Nicolas Graves <ngraves@HIDDEN>
Cc: 58381 <at> debbugs.gnu.org
X-Debbugs-Original-Cc: 58381 <at> debbugs.gnu.org, guix-patches@HIDDEN
Received: via spool by 58381-submit <at> debbugs.gnu.org id=B58381.166548540318646
          (code B ref 58381); Tue, 11 Oct 2022 10:51:02 +0000
Received: (at 58381) by debbugs.gnu.org; 11 Oct 2022 10:50:03 +0000
Received: from localhost ([127.0.0.1]:51118 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oiCpm-0004qd-My
	for submit <at> debbugs.gnu.org; Tue, 11 Oct 2022 06:50:03 -0400
Received: from mira.cbaines.net ([212.71.252.8]:41538)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1oiCpj-0004q9-5U
 for 58381 <at> debbugs.gnu.org; Tue, 11 Oct 2022 06:50:01 -0400
Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:fc93:27fb:8412:c8b7])
 by mira.cbaines.net (Postfix) with ESMTPSA id AEEC627BBE9;
 Tue, 11 Oct 2022 11:49:57 +0100 (BST)
Received: from felis (localhost [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id 202dae13;
 Tue, 11 Oct 2022 10:49:57 +0000 (UTC)
References: <87r0zil1bh.fsf@HIDDEN>
 <20221008163932.15808-1-ngraves@HIDDEN>
User-agent: mu4e 1.8.9; emacs 28.1
From: Christopher Baines <mail@HIDDEN>
Date: Tue, 11 Oct 2022 11:48:43 +0100
In-reply-to: <20221008163932.15808-1-ngraves@HIDDEN>
Message-ID: <87pmeyab3i.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Nicolas Graves via Guix-patches via <guix-patches@HIDDEN> writes:

> * gnu/packages/security-token.scm (go-github-com-go-piv-piv-go): New vari=
able.
> ---
>  gnu/packages/security-token.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)

Hi Nicolas,

These patches look pretty good to me, just some things to check with
propagated-inputs though.

> diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-toke=
n.scm
> index 447a7a582d..3dc619ed4f 100644
> --- a/gnu/packages/security-token.scm
> +++ b/gnu/packages/security-token.scm
> @@ -17,6 +17,7 @@
>  ;;; Copyright =C2=A9 2022 John Kehayias <john.kehayias@HIDDEN>
>  ;;; Copyright =C2=A9 2022 Petr Hodina <phodina@HIDDEN>
>  ;;; Copyright =C2=A9 2022 Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.=
org>
> +;;; Copyright =C2=A9 2022 Nicolas Graves <ngraves@HIDDEN>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -44,6 +45,7 @@ (define-module (gnu packages security-token)
>    #:use-module (guix build-system cargo)
>    #:use-module (guix build-system cmake)
>    #:use-module (guix build-system gnu)
> +  #:use-module (guix build-system go)
>    #:use-module (guix build-system glib-or-gtk)
>    #:use-module (guix build-system python)
>    #:use-module (gnu packages autotools)
> @@ -967,3 +969,30 @@ (define-public cardpeek
>  It also has limited support for Mifare Classic compatible cards (Thalys =
card)")
>      (license license:gpl3+)
>      (home-page "http://pannetrat.com/Cardpeek")))
> +
> +(define-public go-github-com-go-piv-piv-go
> +  (package
> +    (name "go-github-com-go-piv-piv-go")
> +    (version "1.10.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/go-piv/piv-go")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "1j2szvvwgd0ysbap42rap4f60pj4smmmrxjlx0y131l3ki6v6gdm"))=
))
> +    (build-system go-build-system)
> +    (arguments
> +     '(#:import-path "github.com/go-piv/piv-go/piv"
> +       #:unpack-path "github.com/go-piv/piv-go"
> +       #:tests? #f))
> +    (native-inputs (list pkg-config))
> +    (propagated-inputs (list pcsc-lite))

What relation does pcsc-lite have to this package, and why does it need
to be propagated?

If this can be avoid, that would be good. Otherwise it would be good to
mention why the propagation is needed in a comment.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNFSlFfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XfYFg/+P0CYkrsWuE6xqm1WTl0jLculxpSCQZM/
vRNiycXl9IXf4xz2OFrswi4d6yqdYQt2Fi1SOoLIOz1nkq60P6ARdd0W5BADfbi6
3BOV7IW2fDDtufuhfYxZC5ThskTlGwvJ6aoN8dPY2D+CroK4Vlb4Xzq6JbxxGqnk
1QpNklCmyoF09H803roHuaskM2cSpY0nTJhuEJImr0egvURPBccXNenTHjjMXYnu
650MqtyzFFSzts1rS1jL6pGivtE1IEeQNKUg2hJ8vPW7sU9uBI+jiwR2yh+9qtp4
RhmGYxNia3a7k3FpuXnBZUcTLIPPK5btSvqxVqpuR2LFIF8X1oz8QgmuQAku00mL
XhXYfSm/dQaw0MEHNXksG0kMDUZ1lRaI3jGHUBKq9Ii9Q/BMvDhj5T382KELzEXy
CVcAURMOmmxie53TbQJ1BRXb6eyO7j/qM9ZsldxDp/ewLxEJfdRbtHbGi2oxkT8e
mmsUvTqA3QdWVzoA7M/zk5BQcMUfuLAqw4PfiQwutQvCnFWGiV/vf8gY2UPF/XId
vA/hwy1pI4zFH9xcabZu8OnXrn73ub1XH/FwmjFJDVmexN7gJfPpzQzjQ/hhdV2d
VTSU2oX/mLeX3PGI/5zYgw6c/ksvA9pRpXO8DiJbz5dQJDHk9HQSbBBRp3fgvZFl
DNky5FWM5fo=
=cMKP
-----END PGP SIGNATURE-----
--=-=-=--




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#58381] [PATCH 3/3] gnu: Add yubikey-agent.
Resent-From: Christopher Baines <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 11 Oct 2022 10:52:02 +0000
Resent-Message-ID: <handler.58381.B58381.166548549218826 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 58381
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: Nicolas Graves <ngraves@HIDDEN>
Cc: 58381 <at> debbugs.gnu.org
Received: via spool by 58381-submit <at> debbugs.gnu.org id=B58381.166548549218826
          (code B ref 58381); Tue, 11 Oct 2022 10:52:02 +0000
Received: (at 58381) by debbugs.gnu.org; 11 Oct 2022 10:51:32 +0000
Received: from localhost ([127.0.0.1]:51126 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oiCrD-0004tZ-U2
	for submit <at> debbugs.gnu.org; Tue, 11 Oct 2022 06:51:32 -0400
Received: from mira.cbaines.net ([212.71.252.8]:41540)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1oiCrB-0004tQ-Vz
 for 58381 <at> debbugs.gnu.org; Tue, 11 Oct 2022 06:51:31 -0400
Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:fc93:27fb:8412:c8b7])
 by mira.cbaines.net (Postfix) with ESMTPSA id 5F71627BBE9;
 Tue, 11 Oct 2022 11:51:28 +0100 (BST)
Received: from felis (localhost [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id 5a4aae02;
 Tue, 11 Oct 2022 10:51:27 +0000 (UTC)
References: <20221008163932.15808-1-ngraves@HIDDEN>
 <20221008163932.15808-3-ngraves@HIDDEN>
User-agent: mu4e 1.8.9; emacs 28.1
From: Christopher Baines <mail@HIDDEN>
Date: Tue, 11 Oct 2022 11:50:01 +0100
In-reply-to: <20221008163932.15808-3-ngraves@HIDDEN>
Message-ID: <87lepmab0w.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain


Nicolas Graves via Guix-patches via <guix-patches@HIDDEN> writes:

> +      (propagated-inputs
> +       (list go-golang-org-x-term
> +             go-golang-org-x-sys
> +             go-golang-org-x-crypto
> +             go-github-com-twpayne-go-pinentry-minimal
> +             go-github-com-go-piv-piv-go
> +             pcsc-lite))

Similar comment here regarding the propagated inputs.

This looks excessive, I'm guessing yubikey-agent includes binaries, so
why are these go things required in the profile at runtime?

Thanks,

Chris

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNFSq9fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XdB/g//bj0QhPg2gR/RU8hD6f6IayDMOcaMU1Kl
SLyrcpoRR3nRvSuNHvWx4JttaszoEWNBr/z6FcH0zaPxTOICOp5dZnVclSG03TSs
rSmLW1svyiyOtukHiOmHjU7VKKp8Tr7vmFzpn8BCJNOni3q/Sw1hyvDcArv1P95k
oUi4Hci3ve5vrxl3E+GsZ8yG0gXVBtrAq1uVCWfRdEcJlaYx2+aYoACI0EN92yXB
DrDWRfGS5MaUgL8Khdf8n46JZEmrZWt8uW4VG1sWi6hF7irqlwNIl1HEmxvThF+a
FPpQAlKXjfrPaIMk6De3D7rfCjXUzmNnk5ah9cr6ET7U6WVSYSNzbfxoJ4gRMNyQ
kimkdWIcRAm2xZoGtpC9pU92SXM2vNO1YvxHlJWo+lapi7XD42z71pf4J+8Tdeni
QPv/YuANq+B6lIy/sQh6NaAN5oe9gK8fMqT0SIWfZU5aNWFRjkEKQ+tSkqDLB/YL
l/NtPDhYR42x0Vt1jU9MSPXAsmsvsvLUvp0IK5YgNEp4wJZuq6zcq20pRHIrUJYM
+2gHKSTMT0cgys4+eU4H5S1RL4Bqr8qj/s3+YgKhWHtZBX/M2Yg688uRLM7JH6v4
gyEuQ+YZ4+voz3e9Cl/KbGToZj9Mt8bIlGAanqFBYtw5K+1sO4Opful3emoAXItm
0N/K/6f4GV0=
=mgeA
-----END PGP SIGNATURE-----
--=-=-=--




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#58381] [PATCH 1/3] gnu: Add go-github-com-go-piv-piv-go.
Resent-From: Nicolas Graves <ngraves@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 11 Oct 2022 12:19:02 +0000
Resent-Message-ID: <handler.58381.B58381.16654907273554 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 58381
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: Christopher Baines <mail@HIDDEN>
Cc: 58381 <at> debbugs.gnu.org
X-Debbugs-Original-Cc: 58381 <at> debbugs.gnu.org, guix-patches@HIDDEN
Received: via spool by 58381-submit <at> debbugs.gnu.org id=B58381.16654907273554
          (code B ref 58381); Tue, 11 Oct 2022 12:19:02 +0000
Received: (at 58381) by debbugs.gnu.org; 11 Oct 2022 12:18:47 +0000
Received: from localhost ([127.0.0.1]:51308 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oiEDe-0000vG-Ls
	for submit <at> debbugs.gnu.org; Tue, 11 Oct 2022 08:18:47 -0400
Received: from 7.mo583.mail-out.ovh.net ([178.32.124.100]:56191)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ngraves@HIDDEN>) id 1oiEDb-0000v6-Nx
 for 58381 <at> debbugs.gnu.org; Tue, 11 Oct 2022 08:18:45 -0400
Received: from player778.ha.ovh.net (unknown [10.110.103.132])
 by mo583.mail-out.ovh.net (Postfix) with ESMTP id 909B624FAC
 for <58381 <at> debbugs.gnu.org>; Tue, 11 Oct 2022 12:18:41 +0000 (UTC)
Received: from ngraves.fr (met42-h01-213-44-161-47.dsl.sta.abo.bbox.fr
 [213.44.161.47]) (Authenticated sender: ngraves@HIDDEN)
 by player778.ha.ovh.net (Postfix) with ESMTPSA id 683052F81772C;
 Tue, 11 Oct 2022 12:18:36 +0000 (UTC)
Authentication-Results: garm.ovh; auth=pass
 (GARM-95G00189153e19-21c0-46e0-b342-b38f27628ea8,
 CAD2B4A3459146A86F0B95563822EA9C8829CA61) smtp.auth=ngraves@HIDDEN
X-OVh-ClientIp: 213.44.161.47
From: Nicolas Graves <ngraves@HIDDEN>
In-Reply-To: <87pmeyab3i.fsf@HIDDEN>
References: <87r0zil1bh.fsf@HIDDEN>
 <20221008163932.15808-1-ngraves@HIDDEN> <87pmeyab3i.fsf@HIDDEN>
Date: Tue, 11 Oct 2022 14:18:30 +0200
Message-ID: <878rlmwo2x.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Ovh-Tracer-Id: 6854478634336772858
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: 0
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejiedggeeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufgjfhffkfggtgesthdtredttddttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeektedtleefheekieehjeelhfejgfdvieeikeekfeejteeutdehgeffjeelvdekkeenucffohhmrghinhepghhnuhdrohhrghdprghrtghhlhhinhhugidrohhrghenucfkphepuddvjedrtddrtddruddpvddufedrgeegrdduiedurdegjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqpdhnsggprhgtphhtthhopedupdhrtghpthhtohepheekfeekudesuggvsggsuhhgshdrghhnuhdrohhrghdpoffvtefjohhsthepmhhoheekfedpmhhouggvpehsmhhtphhouhht
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 2022-10-11 11:48, Christopher Baines wrote:

> What relation does pcsc-lite have to this package, and why does it need
> to be propagated?
>
> If this can be avoid, that would be good. Otherwise it would be good to
> mention why the propagation is needed in a comment.

For piv-go, in their README:

To build on Linux, piv-go requires PCSC lite. To install on Debian-based distros, run:
sudo apt-get install libpcsclite-dev

==> So probably no need to propagate here.

----

For yubikey-agent:

The package relies on pcscd (daemon) to run on linux, which is already
available in guix. Maybe it's better to say that in the README ? Instead
of the package, what it needs is actually the service.

I've also written some tested lines for a yubikey-agent
configuration/feature (as done in the RDE project) shepherd service,
although as it is really tiny, I didn't know if I should've contributed
this.

It looks like that, and did work (it also depends on the acceptance of
the patch https://issues.guix.gnu.org/52900 in this case):

(define* (feature-yubikey-agent
          #:key
          (yubikey-agent yubikey-agent))
  "Configure Yubikey-Agent."
  (ensure-pred file-like? yubikey-agent)

  (define (get-system-services _)
    (list
     (service pcscd-service-type)
     (udev-rules-service
      'yubikey
      (file->udev-rule
       "70-u2f.rules"
       (file-append libfido2 "/udev/rules.d/70-u2f.rules")))))

  ;; (define (get-home-services config)
  ;;   (list
  ;;    ;; MAYBE: It should be installed system-wide?
  ;;    (simple-service
  ;;     'yubikey-agent-add-yubikey-agent-package
  ;;     home-profile-service-type
  ;;     (list yubikey-agent))
  ;;    (simple-service
  ;;    'start-yubikey-agent-at-startup
  ;;    home-shepherd-service-type
  ;;    (list (shepherd-service
  ;;           (documentation "Run the yubikey-agent.")
  ;;           (provision '(yubikey-agent))
  ;;           (requirement '())
  ;;           (start #~(make-forkexec-constructor
  ;;                     (list (string-append
  ;;                            #$yubikey-agent "/bin/yubikey-agent")
  ;;                            "-l" "/tmp/yubikey-agent.sock")))
  ;;           (stop #~(make-kill-destructor)))))))

  (feature
   (name 'yubikey-agent)
   (values `((yubikey-agent . ,yubikey-agent)))
   (system-services-getter get-system-services)
   ;; (home-services-getter get-home-services)
   ))


I'm not sure what would be the guideline here regarding doing or
avoiding propagations. WDYT? (I'm sending a V2 once I have a clearer
idea of what makes sense).

---

From the package README:

On Arch, use [the `yubikey-agent` package](https://aur.archlinux.org/packages/yubikey-agent/) from the AUR.

```
git clone https://aur.archlinux.org/yubikey-agent.git
cd yubikey-agent && makepkg -si

systemctl daemon-reload --user
sudo systemctl enable --now pcscd.socket
systemctl --user enable --now yubikey-agent

export SSH_AUTH_SOCK="${XDG_RUNTIME_DIR}/yubikey-agent/yubikey-agent.sock"
```
-- 
Best regards,
Nicolas Graves




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#58381] [PATCH 1/3] gnu: Add go-github-com-go-piv-piv-go.
Resent-From: Nicolas Graves <ngraves@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 11 Oct 2022 12:20:01 +0000
Resent-Message-ID: <handler.58381.B.16654907433608 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 58381
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: Christopher Baines <mail@HIDDEN>
Cc: 58381 <at> debbugs.gnu.org
X-Debbugs-Original-Cc: 58381 <at> debbugs.gnu.org, guix-patches@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.16654907433608
          (code B ref -1); Tue, 11 Oct 2022 12:20:01 +0000
Received: (at submit) by debbugs.gnu.org; 11 Oct 2022 12:19:03 +0000
Received: from localhost ([127.0.0.1]:51312 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oiEDv-0000w7-3M
	for submit <at> debbugs.gnu.org; Tue, 11 Oct 2022 08:19:03 -0400
Received: from lists.gnu.org ([209.51.188.17]:51804)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ngraves@HIDDEN>) id 1oiEDt-0000vc-Dp
 for submit <at> debbugs.gnu.org; Tue, 11 Oct 2022 08:19:02 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:35810)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ngraves@HIDDEN>)
 id 1oiEDt-0001C0-20
 for guix-patches@HIDDEN; Tue, 11 Oct 2022 08:19:01 -0400
Received: from 16.mo583.mail-out.ovh.net ([87.98.174.144]:49687)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ngraves@HIDDEN>)
 id 1oiEDl-0006Jg-7K
 for guix-patches@HIDDEN; Tue, 11 Oct 2022 08:19:00 -0400
Received: from player778.ha.ovh.net (unknown [10.110.208.44])
 by mo583.mail-out.ovh.net (Postfix) with ESMTP id 5F6A124F9C
 for <guix-patches@HIDDEN>; Tue, 11 Oct 2022 12:18:41 +0000 (UTC)
Received: from ngraves.fr (met42-h01-213-44-161-47.dsl.sta.abo.bbox.fr
 [213.44.161.47]) (Authenticated sender: ngraves@HIDDEN)
 by player778.ha.ovh.net (Postfix) with ESMTPSA id 683052F81772C;
 Tue, 11 Oct 2022 12:18:36 +0000 (UTC)
Authentication-Results: garm.ovh; auth=pass
 (GARM-95G00189153e19-21c0-46e0-b342-b38f27628ea8,
 CAD2B4A3459146A86F0B95563822EA9C8829CA61) smtp.auth=ngraves@HIDDEN
X-OVh-ClientIp: 213.44.161.47
From: Nicolas Graves <ngraves@HIDDEN>
In-Reply-To: <87pmeyab3i.fsf@HIDDEN>
References: <87r0zil1bh.fsf@HIDDEN>
 <20221008163932.15808-1-ngraves@HIDDEN> <87pmeyab3i.fsf@HIDDEN>
Date: Tue, 11 Oct 2022 14:18:30 +0200
Message-ID: <878rlmwo2x.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Ovh-Tracer-Id: 6854478634336772858
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: 0
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejiedggeeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufgjfhffkfggtgesthdtredttddttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeektedtleefheekieehjeelhfejgfdvieeikeekfeejteeutdehgeffjeelvdekkeenucffohhmrghinhepghhnuhdrohhrghdprghrtghhlhhinhhugidrohhrghenucfkphepuddvjedrtddrtddruddpvddufedrgeegrdduiedurdegjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqpdhnsggprhgtphhtthhopedupdhrtghpthhtohepghhuihigqdhprghttghhvghssehgnhhurdhorhhgpdfovfetjfhoshhtpehmohehkeefpdhmohguvgepshhmthhpohhuth
Received-SPF: pass client-ip=87.98.174.144; envelope-from=ngraves@HIDDEN;
 helo=16.mo583.mail-out.ovh.net
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001,
 RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

On 2022-10-11 11:48, Christopher Baines wrote:

> What relation does pcsc-lite have to this package, and why does it need
> to be propagated?
>
> If this can be avoid, that would be good. Otherwise it would be good to
> mention why the propagation is needed in a comment.

For piv-go, in their README:

To build on Linux, piv-go requires PCSC lite. To install on Debian-based distros, run:
sudo apt-get install libpcsclite-dev

==> So probably no need to propagate here.

----

For yubikey-agent:

The package relies on pcscd (daemon) to run on linux, which is already
available in guix. Maybe it's better to say that in the README ? Instead
of the package, what it needs is actually the service.

I've also written some tested lines for a yubikey-agent
configuration/feature (as done in the RDE project) shepherd service,
although as it is really tiny, I didn't know if I should've contributed
this.

It looks like that, and did work (it also depends on the acceptance of
the patch https://issues.guix.gnu.org/52900 in this case):

(define* (feature-yubikey-agent
          #:key
          (yubikey-agent yubikey-agent))
  "Configure Yubikey-Agent."
  (ensure-pred file-like? yubikey-agent)

  (define (get-system-services _)
    (list
     (service pcscd-service-type)
     (udev-rules-service
      'yubikey
      (file->udev-rule
       "70-u2f.rules"
       (file-append libfido2 "/udev/rules.d/70-u2f.rules")))))

  ;; (define (get-home-services config)
  ;;   (list
  ;;    ;; MAYBE: It should be installed system-wide?
  ;;    (simple-service
  ;;     'yubikey-agent-add-yubikey-agent-package
  ;;     home-profile-service-type
  ;;     (list yubikey-agent))
  ;;    (simple-service
  ;;    'start-yubikey-agent-at-startup
  ;;    home-shepherd-service-type
  ;;    (list (shepherd-service
  ;;           (documentation "Run the yubikey-agent.")
  ;;           (provision '(yubikey-agent))
  ;;           (requirement '())
  ;;           (start #~(make-forkexec-constructor
  ;;                     (list (string-append
  ;;                            #$yubikey-agent "/bin/yubikey-agent")
  ;;                            "-l" "/tmp/yubikey-agent.sock")))
  ;;           (stop #~(make-kill-destructor)))))))

  (feature
   (name 'yubikey-agent)
   (values `((yubikey-agent . ,yubikey-agent)))
   (system-services-getter get-system-services)
   ;; (home-services-getter get-home-services)
   ))


I'm not sure what would be the guideline here regarding doing or
avoiding propagations. WDYT? (I'm sending a V2 once I have a clearer
idea of what makes sense).

---

From the package README:

On Arch, use [the `yubikey-agent` package](https://aur.archlinux.org/packages/yubikey-agent/) from the AUR.

```
git clone https://aur.archlinux.org/yubikey-agent.git
cd yubikey-agent && makepkg -si

systemctl daemon-reload --user
sudo systemctl enable --now pcscd.socket
systemctl --user enable --now yubikey-agent

export SSH_AUTH_SOCK="${XDG_RUNTIME_DIR}/yubikey-agent/yubikey-agent.sock"
```
-- 
Best regards,
Nicolas Graves




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#58381] [PATCH 1/3] gnu: Add go-github-com-go-piv-piv-go.
Resent-From: Christopher Baines <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 13 Oct 2022 11:03:01 +0000
Resent-Message-ID: <handler.58381.B58381.166565895927158 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 58381
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: Nicolas Graves <ngraves@HIDDEN>
Cc: 58381 <at> debbugs.gnu.org
Received: via spool by 58381-submit <at> debbugs.gnu.org id=B58381.166565895927158
          (code B ref 58381); Thu, 13 Oct 2022 11:03:01 +0000
Received: (at 58381) by debbugs.gnu.org; 13 Oct 2022 11:02:39 +0000
Received: from localhost ([127.0.0.1]:59718 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oivz4-00073y-Pl
	for submit <at> debbugs.gnu.org; Thu, 13 Oct 2022 07:02:39 -0400
Received: from mira.cbaines.net ([212.71.252.8]:41564)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1oivz1-00073j-8a
 for 58381 <at> debbugs.gnu.org; Thu, 13 Oct 2022 07:02:37 -0400
Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:fc93:27fb:8412:c8b7])
 by mira.cbaines.net (Postfix) with ESMTPSA id F287027BBE9;
 Thu, 13 Oct 2022 12:02:33 +0100 (BST)
Received: from felis (localhost [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id d86f6a58;
 Thu, 13 Oct 2022 11:02:33 +0000 (UTC)
References: <87r0zil1bh.fsf@HIDDEN>
 <20221008163932.15808-1-ngraves@HIDDEN> <87pmeyab3i.fsf@HIDDEN>
 <878rlmwo2x.fsf@HIDDEN>
User-agent: mu4e 1.8.9; emacs 28.1
From: Christopher Baines <mail@HIDDEN>
Date: Thu, 13 Oct 2022 11:58:31 +0100
In-reply-to: <878rlmwo2x.fsf@HIDDEN>
Message-ID: <875ygo7zqw.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain


Nicolas Graves <ngraves@HIDDEN> writes:

> On 2022-10-11 11:48, Christopher Baines wrote:
>
>> What relation does pcsc-lite have to this package, and why does it need
>> to be propagated?
>>
>> If this can be avoid, that would be good. Otherwise it would be good to
>> mention why the propagation is needed in a comment.
>
> For piv-go, in their README:
>
> To build on Linux, piv-go requires PCSC lite. To install on Debian-based distros, run:
> sudo apt-get install libpcsclite-dev
>
> ==> So probably no need to propagate here.
>
> ----
>
> For yubikey-agent:
>
> The package relies on pcscd (daemon) to run on linux, which is already
> available in guix. Maybe it's better to say that in the README ? Instead
> of the package, what it needs is actually the service.
>
> I've also written some tested lines for a yubikey-agent
> configuration/feature (as done in the RDE project) shepherd service,
> although as it is really tiny, I didn't know if I should've contributed
> this.
>
> It looks like that, and did work (it also depends on the acceptance of
> the patch https://issues.guix.gnu.org/52900 in this case):
>
> (define* (feature-yubikey-agent
>           #:key
>           (yubikey-agent yubikey-agent))
>   "Configure Yubikey-Agent."
>   (ensure-pred file-like? yubikey-agent)
>
>   (define (get-system-services _)
>     (list
>      (service pcscd-service-type)
>      (udev-rules-service
>       'yubikey
>       (file->udev-rule
>        "70-u2f.rules"
>        (file-append libfido2 "/udev/rules.d/70-u2f.rules")))))
>
>   ;; (define (get-home-services config)
>   ;;   (list
>   ;;    ;; MAYBE: It should be installed system-wide?
>   ;;    (simple-service
>   ;;     'yubikey-agent-add-yubikey-agent-package
>   ;;     home-profile-service-type
>   ;;     (list yubikey-agent))
>   ;;    (simple-service
>   ;;    'start-yubikey-agent-at-startup
>   ;;    home-shepherd-service-type
>   ;;    (list (shepherd-service
>   ;;           (documentation "Run the yubikey-agent.")
>   ;;           (provision '(yubikey-agent))
>   ;;           (requirement '())
>   ;;           (start #~(make-forkexec-constructor
>   ;;                     (list (string-append
>   ;;                            #$yubikey-agent "/bin/yubikey-agent")
>   ;;                            "-l" "/tmp/yubikey-agent.sock")))
>   ;;           (stop #~(make-kill-destructor)))))))
>
>   (feature
>    (name 'yubikey-agent)
>    (values `((yubikey-agent . ,yubikey-agent)))
>    (system-services-getter get-system-services)
>    ;; (home-services-getter get-home-services)
>    ))
>
>
> I'm not sure what would be the guideline here regarding doing or
> avoiding propagations. WDYT? (I'm sending a V2 once I have a clearer
> idea of what makes sense).

I'd try avoiding all the propagated inputs and then tackle the issue of
getting the service working separately.

Thanks,

Chris

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNH8EdfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9Xcpvg//Tj7H9Ll1ouz0bXBAsI8mWMzXMZpZQcE4
yD+jX1EznF+nF4eDSAjyrI0Caf+L9I5WicpWERfuBTFZAQ73bUHJPxwOczf4/ULu
ycbqpE4VITap5IDqPHSf9P34qkc1GBtJTUPX3Q/z9ACbLxgzvJY3K3Eg45trXm/d
CG3KHnxM3meFWd1D4zSnisUoBk80gJnFT4iLyl5vdJ018CawzWPhPL4gOfKzPwPD
OWeLoITtfcYR7OqU2jM4wQoWaSTZp0x441Upt9jWxedtd9Yd+R40b5hMXIIv7dsp
b93ys0pW4RxpOnWtN0kHAH7ro5zJleyMGCfYpjW7bcmd0EIY+S9B6PB245sH+p/g
2ANg9i2rPM2hRHMeotYCOtw+Gg70zqRGvzHlCky2arm18UrAuH14tJmknSCCd5RH
KODVtW1Rgm0d3mdI67RNGMokhflO5Lfp/NySOCfCHrPz48d932BF0xWqmRSBnuTA
ZTAPbx6yhB8bTtXulb5fGnswGq76QzuKvEX44+m9PU1dBW128bd96lkxPVv8yXQA
na38stuFyf74emQr9NOZDdN9Clm2Tn9b+2QNHGrv2VqebcbGEWG0U+OupwfPCcCJ
FoR/MufQCht6FIGyeY7URCcT1lHh0BwFypsRzYgtnAqmX45gQSN4viPt0r+PWbz5
iRGCdm2KsYg=
=YbN1
-----END PGP SIGNATURE-----
--=-=-=--




Message received at control <at> debbugs.gnu.org:


Received: (at control) by debbugs.gnu.org; 18 Oct 2022 12:41:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 18 08:41:59 2022
Received: from localhost ([127.0.0.1]:51479 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oklux-0000m2-Fv
	for submit <at> debbugs.gnu.org; Tue, 18 Oct 2022 08:41:59 -0400
Received: from eggs.gnu.org ([209.51.188.92]:41556)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1okluv-0000lq-Hs
 for control <at> debbugs.gnu.org; Tue, 18 Oct 2022 08:41:57 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:33942)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1okluq-0003vQ-8U
 for control <at> debbugs.gnu.org; Tue, 18 Oct 2022 08:41:52 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to:
 references; bh=ANbdLYZ9XBn1ptvc1Ve7M7MwV6wHO8DHkaz5wlqBuR8=; b=mU14VB0gVQdNnm
 ZXNUu4Hzz2Z+NU24X4SGLyYS/Qw+iCazvrziJDXykCLGqPTivxqakEoOoWbm/YU9tx4syoSavaY9+
 SSQlT+T6BLDiLy1d/qCFx6wf9fdeigL/P6PZxwE5VFu1aU3Bhz/vYTtLSqweefRzK7C3QB6ihQ7ae
 9jq278XQvVdDGzCr4yZV6FIqOqxji19Wfl2ryoNLQDvxKilCwApiJNEXoiUsh969nLsJasfHl65/i
 ONmoBAm9Sukh3+3YwB2913+NR3ahm2LIvTbSXymGKN3x9rQJQM0Kd4xyoP0yQKmVXe6fRwxPPXu2U
 5pKep0PMP1Xk4W+XZNYQ==;
Received: from [193.50.110.209] (port=51756 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1okluo-00021E-FI
 for control <at> debbugs.gnu.org; Tue, 18 Oct 2022 08:41:51 -0400
Date: Tue, 18 Oct 2022 14:41:49 +0200
Message-Id: <87lepdnw1e.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
Subject: control message for bug #58381
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

tags 58381 + moreinfo
quit






Last modified: Tue, 18 Oct 2022 12:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.