GNU bug report logs - #58406
29.0.50; Bars refactoring?

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: wishlist; Reported by: Manuel Giraud <manuel@HIDDEN>; dated Mon, 10 Oct 2022 07:39:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
Severity set to 'wishlist' from 'normal' Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 58406 <at> debbugs.gnu.org:


Received: (at 58406) by debbugs.gnu.org; 11 Oct 2022 00:33:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 10 20:33:00 2022
Received: from localhost ([127.0.0.1]:50301 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oi3Cd-0005OX-Sr
	for submit <at> debbugs.gnu.org; Mon, 10 Oct 2022 20:33:00 -0400
Received: from sonic306-22.consmr.mail.ne1.yahoo.com ([66.163.189.84]:33864)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <luangruo@HIDDEN>) id 1oi3Cb-0005OJ-KF
 for 58406 <at> debbugs.gnu.org; Mon, 10 Oct 2022 20:32:58 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1665448370; bh=cY2hXLOvqd8CPbCKjvMLH8Gv1jE0jkau08qMr9L1D3w=;
 h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To;
 b=o5Hq8HwR4oprzNmFxqqRqzovDopMxQFa+JCpWK10vUbDF7/NFZt95K7lY02CFMYyV8tY3hiY7ixfivUdzyyEMpMf3+8Rw26zj0EXU8HnaOUBM7zab2zy/YNl4Xt6pZs9lxKksokMci5UoKjVv7mAn1jXDq8FnoUCtEkey4ej+wiE2au83yEU9YjfWLzkoxA3ENHlY7qRQNzkkeDnG7EAsJDGFXqvRcVKJgVWVglLUaTdkhRbgelAtxETt1rIOOyQL+j+VvsHR1FHf8/ZfBUbZFbo2pDBY0zblG5r7CVO/CEK8cry5jFo/Z1peanAc8McTKdMvYzEtOndP2gYu2kfAQ==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1665448370; bh=eBHB/IW2viavfCgbUQCoEYec9QHwVaokAnNXPbWBnxU=;
 h=X-Sonic-MF:From:To:Subject:Date:From:Subject;
 b=bQdgrbWo5AMTcV9lW9WELY92ZVGCuHEIG5BP+OS9NdvPPmHnDob6kIFC8OnlkZTVH12vEtMLkuX9kmSJTzKMyGV3d98tHJlOOYYdowCNtkSuuV5JAyJGJNX4kNEf7974MJrXTz3aSduuS1g27PmAy2hlSBhn4vzdDO959aGHXHcw17kdvUEhGk8fiXf3T5yCAgWYdeCeVUrZ8IPmYLP0tw7Bdv1PeY+Saski/aPI5OW64N4PVaSoqWrp3Qh7x7dFpVH3XFKJ6Er4AWjOodGBMPFrMP1mZzAnFsvjLlUuIXNnqZ3Oo+lJd2JOC5TuxrzsdCUdo8b7XqP/CTe1rr0jnA==
X-YMail-OSG: sPj3S4wVM1kjAjqQYEhTf9uj81de4lI.1uM5e6PiMlRI14Z2VeW_1ab0U_AUpjv
 zRTf8fHRUdl6znur5tfMD2NXQ7g_c0n.c6uGIzDLUl8hPCBxUuZvzmkWHl5XA8H06pVlX.WeEsrN
 YX63sTcJkJkKLNNrPFVHhMNuf6U5GzvpPEF9muXHfIdOGCHRxJFHuLFUh2P5PC5xY3dil8nx8wzf
 LtkWYa5CF2oEX66WHqzyHshTtFEkLat6Q0ktqlGq3sm3xpp1YtalyB.916DPAguuawSV.DumaQdJ
 6X8ErNAqQ2_lCgTrDy9FYqW6WZWEkPEiON3GCh6FIusMLqZgL1KTs8RNSsV3mKhWH8xh958sOwJk
 1vKjO9dde4csXmdJau3tS8yMLUc0OHXNpkQRQPysMhDkx46dr.zjTg9UEuPNe57bQHw6Ui.UCy9W
 QoBGJt6NSew_DGUkVyaFe6KBtYVXrKVGgKIY4N24HGKksO2r7m7BCXZlgOMCP7tPruxShEyD4FFo
 CLOTwYjdRxlxUS2cycqzzSGvfwzaCkQsDJGo02gP.bWYETQhK2Xbyak6Xv34s_rT6IuVY976X1r9
 CavIhglrILAT6TC.aOWdyt_0g7a7Sqn4OpTCqQzGqT8E0yfvWKDTdl97y0KaDKxSRTdf757q8PVp
 euwJspTKenbHemycw7_4Ma0pzco9ypDEs6CwlbxZrdLSmexTNQ03SLOZe422WSZKOC9VwOvZIUSZ
 YQiDRW3zuF9cewZ3cbQlidqu9KkxlxOq4xL57eWqXtUlW0x6WLeu8HQu2B.CyTCtcPDNy4.rFkxW
 9iBohU0vCdtrqPN07vkhTtOvvzv3nP_me.tsBtEbiygJNT_TlpMWljTQQxw4_n3KJvp3p4q1Ivk5
 X6sNvtEzVWjSCHNpQS.aFTai.jvyQwUCA3E48EJCTpK_ILTNsNgfIPlKiBdyn3nT1EPbZkjNZiSb
 w0SJsCjB6WPAQ9dyG661lLMLwFglqcVwd6vEYAMj_ktQJiIhJrtGCFIuL2rxWvyNJcAnpssnE4SR
 2AEFF71FVFB.v7RbvAIFL4J8ITGzWl6PDqfcO9UdFR8grqYWkqSXoIsDNCHWbbscbp3NgPGmKzaZ
 ry.UraYrKmJyfkn7Mw5fgR0WhmpX7BTxVA_iY9r2xfTQbP6npinWZJCz.Fj_W8UJe52TVD_.D3KK
 9kiiUXC0uD_opVYW1.nIssWK36H7QxxeWDTP29OB1ykX7HebPWw_0p6VP_eVBnEvEGRoooK4IfAY
 ZAmED3P2kosSkg1uswnBR14jTesNSyu.uar.M_glTT1eFM0LxxglEHhgBbmnUAlXRfEN.A5q7FvH
 fFNbMi2g1I9JO3yU3bSX3ybPAMPwLWepW1L0yTnKqBCnFs6vPMeXg5ORgYxYiAUs8E8f2NY1NtGF
 lMChtsxi3WN_SoLzeKFBQV3t1uW7kw_Sdeo8PxgzwOFHo8W5FszjMvbdnclTVsYhtfwSJ_3IGbch
 NSF4KdBq1hqMSzv_efIdZnCEyfirfCsW0ztO9mzhOzD74YeEd4j56bc3N7.T.AWfbEWe2NH2psgS
 bT6opn.fFdARiD8YxUGfvetv3SxZkz520JnXTQ_b15kiw60H5XDddCgo.0CyAoL0QSK2br2iTxZQ
 oS5dqwh6yN3BTQMeptf.fZJV61oL5xwPQdh9D2VXXdpQS.sXRPuMZoOJvocfp2wiXfy2U6NcwEMW
 wz2xngvnnKa6B7P71CmG8coz3M3kuxa68HeQElFmGRwQ3wZMf671UaMsSxNG22xpRr87NmPE8JZ.
 YfgSW7BKpbDqfsGeaclQrFF0ctcAydfztKdCS8XzxF8ov.7EaqYWb..9P1BBxmowl7bBCTtwbjSD
 MLtqzhdWH8e8R7wrtagH3bgnQ_ynQe0tQS6ceDLEDlux_0mZUjxmZhKgLIF4lRTVa3zdZbIlZejR
 4nEj9IMBmHp.sxF.XQEFpqct54nZC31O.ye7B51fOf5BuDqo1NfXCbmkLRxdCBoFsIXNPiElddJR
 RkOYzTrt60rAknKwQ7o0DAwe9r.l2LvHCnJmf6tZN0pJ3qLkB6wvigRlBIbIduFwHk3hEpaPY2gU
 xMPdZHpQrYlFUzjL.1nVOmTKAvRwORJ_qBwU_IkWBYicxDkWQzMU2zWC8bWUWSb12nCpVftfpo_4
 b.3W_dGAZGrWMB4mrImjFU1XImr.aqn2bz5YF9M1FdRjdfZfTWK.hv_MjIeZr._hwoJH_4meq6eC
 pBcdZ34tqPJLjg2dJ6fhwMsKeXPUlCYom0BZ9qHQIT0oOwQd09DqvnpA_AlwYeOIy29oA4MoDaH0
 -
X-Sonic-MF: <luangruo@HIDDEN>
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic306.consmr.mail.ne1.yahoo.com with HTTP; Tue, 11 Oct 2022 00:32:50 +0000
Received: by hermes--production-sg3-785466d859-8rptm (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 41f2957f8149ac710fef01fed54d6166; 
 Tue, 11 Oct 2022 00:32:45 +0000 (UTC)
From: Po Lu <luangruo@HIDDEN>
To: Manuel Giraud <manuel@HIDDEN>
Subject: Re: bug#58406: 29.0.50; Bars refactoring?
References: <87a6641648.fsf@HIDDEN> <87bkqkm777.fsf@HIDDEN>
 <87tu4cyszl.fsf@HIDDEN> <8735bwm57n.fsf@HIDDEN>
 <87wn9798ww.fsf@HIDDEN> <87h70blrt4.fsf@HIDDEN>
 <87mta392fr.fsf@HIDDEN>
Date: Tue, 11 Oct 2022 08:32:41 +0800
In-Reply-To: <87mta392fr.fsf@HIDDEN> (Manuel Giraud's message of "Mon,
 10 Oct 2022 16:30:00 +0200")
Message-ID: <87sfjvjj2u.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Mailer: WebService/1.1.20740
 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo
Content-Length: 663
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 58406
Cc: 58406 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

Manuel Giraud <manuel@HIDDEN> writes:

>       - what most other programs do is to highlight the menu bar entry
>         when clicked (and then stay that way while the menu is opened).
>         So even with this case, we'd have to have a way of highlighting
>         a menu bar entry.

That would not be mouse highlight anymore, and relying on mouse
highlight to implement that means you'd have to fix the expose
processing to respect it, in which case I'm not even sure expose
processing works at all in the oldXMenu.

Besides, the menu usually covers the bar item in the no toolkit build,
so I'm fairly certain people won't get to see the highlight.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#58406; Package emacs. Full text available.

Message received at 58406 <at> debbugs.gnu.org:


Received: (at 58406) by debbugs.gnu.org; 10 Oct 2022 16:08:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 10 12:08:43 2022
Received: from localhost ([127.0.0.1]:49624 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ohvKc-0000oi-Vu
	for submit <at> debbugs.gnu.org; Mon, 10 Oct 2022 12:08:43 -0400
Received: from eggs.gnu.org ([209.51.188.92]:59742)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1ohvKb-0000oT-KR
 for 58406 <at> debbugs.gnu.org; Mon, 10 Oct 2022 12:08:42 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:32812)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1ohvKU-0005ev-81; Mon, 10 Oct 2022 12:08:35 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=pwh9bwR3tRRmsXZDEO9jMPhklMCrvME/9oUyyQM5+D4=; b=E/vupPSB0YV5qviG9O6t
 0EUZk8azpDGVyQRMxJhx54GktEzlLa93VsL+OCIeGndxT8cpoGv/5HqlrHvxzQ6aqyxKF8ZCR4lBI
 9Xpok+bUH66CeucrKK859kS8BRLAW6iI84xVRv28dc/EsWAc41IjmnCS+W/E2g69bdeOu/nWYZdzz
 XG8lHx2Xe0OlN2aJsSe9vNsCym1jIyUPc6zYZbBGc2k3h6dpnhk2SECoHo/3L1NF7MBirtzkStd7e
 UTvMR1G+lJ935OV1galOMw73vsK3wmfmjOi/lYmVVeKLLFUsee8Ye2P3zQIdP3q2LQjgOawZyiSFJ
 5aUB/Xfxr97p+Q==;
Received: from [87.69.77.57] (port=3427 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1ohvKT-0006PU-NN; Mon, 10 Oct 2022 12:08:34 -0400
Date: Mon, 10 Oct 2022 19:08:41 +0300
Message-Id: <837d17hd9y.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Manuel Giraud <manuel@HIDDEN>
In-Reply-To: <87mta392fr.fsf@HIDDEN> (message from Manuel Giraud on Mon, 
 10 Oct 2022 16:30:00 +0200)
Subject: Re: bug#58406: 29.0.50; Bars refactoring?
References: <87a6641648.fsf@HIDDEN> <87bkqkm777.fsf@HIDDEN>
 <87tu4cyszl.fsf@HIDDEN> <8735bwm57n.fsf@HIDDEN>
 <87wn9798ww.fsf@HIDDEN> <87h70blrt4.fsf@HIDDEN>
 <87mta392fr.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: 58406
Cc: luangruo@HIDDEN, 58406 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

> Cc: 58406 <at> debbugs.gnu.org
> From: Manuel Giraud <manuel@HIDDEN>
> Date: Mon, 10 Oct 2022 16:30:00 +0200
> 
> I understand that all of this takes place in the "--with-x-toolkit=no"
> land and that it might not be the most used setup but maybe it could be
> a place to test some moderately "wild" ideas 😊

The same code is used by menus on TTY frames and by the MSDOS build,
FWIW.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#58406; Package emacs. Full text available.

Message received at 58406 <at> debbugs.gnu.org:


Received: (at 58406) by debbugs.gnu.org; 10 Oct 2022 14:30:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 10 10:30:05 2022
Received: from localhost ([127.0.0.1]:49520 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ohtnA-0006eo-RO
	for submit <at> debbugs.gnu.org; Mon, 10 Oct 2022 10:30:05 -0400
Received: from ledu-giraud.fr ([51.159.28.247]:48898)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <manuel@HIDDEN>) id 1ohtn9-0006eK-0B
 for 58406 <at> debbugs.gnu.org; Mon, 10 Oct 2022 10:30:04 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=kX/JcAIhmnyyLvbe
 O6N8NK99ynp88SeVh3lD3yH3MAY=;
 h=date:references:in-reply-to:subject:
 cc:to:from; d=ledu-giraud.fr; b=RPqkYA+kuVPvMUYrea2cuGVJIvcaOOyJ7cWeuW
 bmc9665ts5CBCBbJQ9ofAi0/gjUcw8MwGwp6vdtKtuv6oPTGlx3b+B8nSqaJurgBlTnUWl
 KXCcNWP9bXCd+2uB41TZpvou7v2uGstldnd4G5Pp5TyA3b1Jt3jQ4OBHwVUYwIJGwXOiCT
 cVGev8Du1QViECpeEk5kBkdgwNeUfhJm8fPZUjmisjyputKrGuavvCssuoucNiq3vdz+7Q
 Oaslab2Ygqvkbn78S02EuuBfV6rLBANVMvpes4Xcqsoevt5Jxqacx8lww17KseOe/cJPUM
 ONRVydMZnUnnxrlX6TMM3dLQ==
Received: from elite.giraud (<unknown> [10.1.1.1])
 by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 81c16bd2
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Mon, 10 Oct 2022 16:30:01 +0200 (CEST)
From: Manuel Giraud <manuel@HIDDEN>
To: Po Lu <luangruo@HIDDEN>
Subject: Re: bug#58406: 29.0.50; Bars refactoring?
In-Reply-To: <87h70blrt4.fsf@HIDDEN> (Po Lu's message of "Mon, 10 Oct 2022
 21:41:11 +0800")
References: <87a6641648.fsf@HIDDEN> <87bkqkm777.fsf@HIDDEN>
 <87tu4cyszl.fsf@HIDDEN> <8735bwm57n.fsf@HIDDEN>
 <87wn9798ww.fsf@HIDDEN> <87h70blrt4.fsf@HIDDEN>
Date: Mon, 10 Oct 2022 16:30:00 +0200
Message-ID: <87mta392fr.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 3.3 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Po Lu <luangruo@HIDDEN> writes: [...] > No, I meant that
 no other program has highlightable menu items in their > menu bars. 
 Content analysis details:   (3.3 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 2.6 RCVD_IN_SBL            RBL: Received via a relay in Spamhaus SBL
 [51.159.28.247 listed in zen.spamhaus.org]
 0.1 URIBL_SBL_A Contains URL's A record listed in the Spamhaus SBL
 blocklist [URIs: ledu-giraud.fr]
 0.6 URIBL_SBL Contains an URL's NS IP listed in the Spamhaus SBL
 blocklist [URIs: ledu-giraud.fr]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
X-Debbugs-Envelope-To: 58406
Cc: 58406 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.3 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Po Lu <luangruo@HIDDEN> writes: [...] > No, I meant that
    no other program has highlightable menu items in their > menu bars. 
 
 Content analysis details:   (2.3 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  2.6 RCVD_IN_SBL            RBL: Received via a relay in Spamhaus SBL
                             [51.159.28.247 listed in zen.spamhaus.org]
  0.1 URIBL_SBL_A            Contains URL's A record listed in the Spamhaus SBL
                             blocklist
                             [URIs: ledu-giraud.fr]
  0.6 URIBL_SBL              Contains an URL's NS IP listed in the Spamhaus SBL
                             blocklist
                             [URIs: ledu-giraud.fr]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

Po Lu <luangruo@HIDDEN> writes:

[...]

> No, I meant that no other program has highlightable menu items in their
> menu bars.

Ok, I see what you mean.  I've two remarks:

      - maybe, at a minimum, we could have a visual clue that we are on
        the menu bar by the mean of mouse cursor change.  Mine stays
        what it was: an arrow or a vertical insert bar.

      - what most other programs do is to highlight the menu bar entry
        when clicked (and then stay that way while the menu is opened).
        So even with this case, we'd have to have a way of highlighting
        a menu bar entry.

I understand that all of this takes place in the "--with-x-toolkit=3Dno"
land and that it might not be the most used setup but maybe it could be
a place to test some moderately "wild" ideas =F0=9F=98=8A
--=20
Manuel Giraud




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#58406; Package emacs. Full text available.

Message received at 58406 <at> debbugs.gnu.org:


Received: (at 58406) by debbugs.gnu.org; 10 Oct 2022 13:42:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 10 09:42:56 2022
Received: from localhost ([127.0.0.1]:46425 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oht3Y-0004dP-Gq
	for submit <at> debbugs.gnu.org; Mon, 10 Oct 2022 09:42:56 -0400
Received: from sonic309-20.consmr.mail.ne1.yahoo.com ([66.163.184.146]:43264)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <luangruo@HIDDEN>) id 1oht3X-0004dD-FY
 for 58406 <at> debbugs.gnu.org; Mon, 10 Oct 2022 09:42:55 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1665409370; bh=jRqFuuPyGJ9O45qCG0WeuwtGROkllnzaf9Fn+5J6D3U=;
 h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To;
 b=lANLIMyy8XB66NDzochGaEaU7l0l39uDegsWbNGJifOM8cRUUaQ0UieZ/fEH62OSPMRROQY2ol/uBaVl5y0zGP0fyqVII7+R0IlOL94zlKgxXg8Y4vqxsGJxXb1c3fCFAnL+gZYO4tGJ+ujOO3oXI4mA9oijmIvhORXsWA4OMnwVZkv31+0Ptic/S+5LZKFkhYgb4e58UZuOB8+4Z3hVtJWlF9OmlBWXG+EchA0TngJsctHaCdprYXzKGET/89H1OqGVHzOH2y0AjL4IoVuxpJ6sjIlrEcOClzKIoWTVK3gT9R+L1kPq8+2mUY+Uj0ol8OPLs9Jp95s6q7O6Suuk9Q==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1665409370; bh=h9OWBIt5z6qtusEUfq84h/VZD+W7f/6KQPqkKpsFRiK=;
 h=X-Sonic-MF:From:To:Subject:Date:From:Subject;
 b=qI1C9GvnxfOYOzb1WIM+wGKVFWJsdD3gF3D7XJ8xGiyYxfrvMTnPDyFWUQoHM/kihEhIjxBFTBqZcMZcCR11PlAs8LQBqm6NO4tIRmVR+8IfdGFhRUH3riQR1sNOBNrq2jG5/mDlT26oXOi5WhO9cMBxuEbQH/oBHQG9/L8ZZqV1gakGHpmX5Q77N9NrSjzx+FUORlr3+14BQ5qf5WO5onSnr4oWT6WTk/BUN9zbFvv8fOS6omwJ1grTxqbxOZ7yZl6hSfPEvsTGXiN5Mqoes1u7pzXp0f1R8Xx3QPNCRfsSSx44z1RvzSJ7v0edctg8P/Gd9xoTtAoYN/xkobZpYQ==
X-YMail-OSG: CT1TfZoVM1ngRIHlcVOdyUTmM3gG4895K7D3IN9izEjlk18Ni09zHNPsM4KPZ_j
 6kBd1NlCSVeKS8zpnTPkGmM0Vl1ugb7WZNvsVL9nQ2L9ikcSjeIwm_TLNeQWi0x05.gsySMdkEFc
 UHTo0WaQouu1vMpP_.DaqU6MyPlg.e_w9uAu_z2LNmdbAE4.Wr8H5TKmzE5dD3oGsjnVqk3izIPt
 eS21RGOhHZPBQPGzasFk2eqWciFUuNkQonZnkUKwFduE_106hTRzrPyvSWroxpLOrKmYHq6heGxh
 QQSXnVVzBLh.JLuf5WFtc36Dbgb2ZPrlrIEBK6a.s50wI1Y8_hkuEC0HDxH6eOrFiXc3fFiSpRfc
 OYvivDDEaKL0BTvVagljGlc9z7LpSPiEvU5oJQDZRjDKBcGm_1JjeUweidYSc4rilBw37GNQiWO7
 vbee5yDM2gKbYnJpd19QPGfSh2jTIt6.LRsH8vunut4V9kdAsDR.Uy7yELl_nBzqUcJaNdm38ZnQ
 9JpEAdijJ5Qqp4.6et0ypfB2fdAY.XDvI1iBKOj9248.8D9GsrMV9I3eOvZrFOMX4EbKKfFlFist
 4DX71QHsq9wYFHXetPCfzcTyqg41PPn9_JZOoCjqw8BfIolMekPYiaIcPuXEHlKZHhSo6ndWRNY.
 Q_v3BS5PZJF0Y2Q2X2dqrwEjp7uXBXOmjnYnlzsvnXjumrTN_FxaXfx4nMZniwHTKQNjwMjBLxUd
 FYm1s5HkTzdVRyoXxHSakoe4WETBAJHQ4Wsnin7Pmr1f88_IRknUDV5o4inns05XoCNrUO_N8XqS
 XkM1jmEO.2PaGSoUgiE8zkS70Fd5U5EAHhs0KI17FGP.nwdEaNW3OcFVG4xI6KFuFxjUzamldymp
 jFITg95Hqetk.z2aPfpmc3qbL9uetpr3A0ZT8z0nLr5mh1E9HBDIAwUrtBMQcn09CYwJ0znZJGjb
 8dLQ5RhxYMH6vdy_gHdBzRXu.baWyeTr.ico9o7jD2GqK8JT5sca7A6I4j6OPE773DpNsajt3Pgv
 ShtcZoMv7qg03AMxMsy4cGvPmZHzXexabpg9S3r5tOEKN0.GtazMwhlzTYGfAOuS6beVaMIiQwRn
 H7KqAnMUjgka1c7X_0mB3c5TsxwBTUCsn2skKq97jl_ingxVTFE0FNIahxCWFtyeS1losWmsrCj1
 XiY02ixSwzeSF2YPt3_sC5gSuZnwOWXYHbLdEMbxglbVxntxhYE7UhKdzDjOIoa6ggl_mfz3ep_J
 q4r1E4fE17q4DpUmJGsiZlcvy3rLJblOUqyVX.x60Q0UulD0zVItgVllspX9B0jyC.Ftd13kTYkz
 QxNQ7_7omCjDOsULa0q7M4TS37ogy.6AVQzbnsh6PF4wcqiKt7RK6e35U1F.LPGOdM.DqZoY5BPh
 V1mQVZJhi3gC7T3G1E2Hp0j9TMveVcFkWoTqbt_Sjk1PpCbIsvMPmoZ2Js3pckDu4x85SP1MRMdJ
 6WQ.Dt_XQDrL0i14xAuNKB4V8uSD_5NM10FWDhreZKBYCvh4KA6LBO.m49D_MQOyCGu.QJx5pCFg
 PgfQajDdgcQnel02my5FV3.X5J7cX976xNWenQVt0UCRWXsOubTl7SWQSzRkKXA55d_KByBiEnVF
 0GsdnjZwpHlY0JIAqRtBoTGdzwDFyfxMlliQe7EL_7G2BsiFVrVtK9UHTyFF2a87aeESq3ni0s9T
 MxUG6elYFahKDywBA2Fg7SFfMR6H3IEwPvkL5zSODCOvULV6ZJI4jDVwTEmOXzdRrmIT8_dU.A7N
 qvNodJ633GcCk.d8ZiSdtbPjeI1V2cKacyEYEn36Q_mAgt1WI_U6NzuJi3ickwhYDGv61DaKVcou
 SwEwbCC5lQxOuj5dTQLRD5ApgvMM9DtAgodTUIBzkrQWkTAE_J33BhO1MHQkSaijdUPuoEFR9xWh
 T1k.SWpmptxY8plTiRdoaqu_Xj25HcJiMTsyY9pK_WVlrWVgOoYzwVZHP6MS_f.viAcZ11D4rfrY
 oSyy9USiv3.nzBskVla0Y0rV8oDqvekZsyTUxZG3BIgctovJna38LrzrvZhbjdwvXZKusvVAWia8
 6Lmwwq78i0Sw3Cm.JpmmkAGbaZV.XbT4lHkicSAZaOcwySngKvVXJqD2udKFchF0c.gg.w8cxoyY
 hS_1ex4iT7eXgoqo2_lszAeWKNw9oR8TXoODpzipycOoWs9kQartLYC2wj1fEwE9MCaJ7XPPpZO1
 0_iaCLsl3ngHMaDurBuevUKHDREBjkT5UO8dS8Utn75PfTFp8niOtSWjl.28Y8y2r2WvMkPNWiRk
 -
X-Sonic-MF: <luangruo@HIDDEN>
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic309.consmr.mail.ne1.yahoo.com with HTTP; Mon, 10 Oct 2022 13:42:50 +0000
Received: by hermes--production-sg3-7794f55d99-qc4c6 (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 2cf44de6421c49289f3f601d542937b0; 
 Mon, 10 Oct 2022 13:42:42 +0000 (UTC)
From: Po Lu <luangruo@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#58406: 29.0.50; Bars refactoring?
References: <87a6641648.fsf@HIDDEN> <87bkqkm777.fsf@HIDDEN>
 <87tu4cyszl.fsf@HIDDEN> <8735bwm57n.fsf@HIDDEN>
 <83pmf0gihb.fsf@HIDDEN> <87y1tokn8r.fsf@HIDDEN>
 <83ilkrhqfd.fsf@HIDDEN>
Date: Mon, 10 Oct 2022 21:42:37 +0800
In-Reply-To: <83ilkrhqfd.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 10 Oct
 2022 14:24:38 +0300")
Message-ID: <87czazlrqq.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Mailer: WebService/1.1.20702
 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo
Content-Length: 400
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 58406
Cc: 58406 <at> debbugs.gnu.org, manuel@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

> I just tried that, and saw nothing suspicious.  What should I watch
> for? what do you see in that case?

Moving the mouse back onto the tab bar button will lead to it not being
highlighted as expected, until you click on the tab bar.

But as I said, that was fixed.  Messing with the *bar code has a very
real potential to introduce similar nasty bugs again.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#58406; Package emacs. Full text available.

Message received at 58406 <at> debbugs.gnu.org:


Received: (at 58406) by debbugs.gnu.org; 10 Oct 2022 13:41:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 10 09:41:29 2022
Received: from localhost ([127.0.0.1]:46420 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oht28-0004bG-Uw
	for submit <at> debbugs.gnu.org; Mon, 10 Oct 2022 09:41:29 -0400
Received: from sonic309-20.consmr.mail.ne1.yahoo.com ([66.163.184.146]:34270)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <luangruo@HIDDEN>) id 1oht26-0004b0-82
 for 58406 <at> debbugs.gnu.org; Mon, 10 Oct 2022 09:41:27 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1665409280; bh=YjhJjcR+/cVL7VFJcXoDTvTCXpKnifYgMNrXiWZMJGU=;
 h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To;
 b=Wqgv4fs9NcJYmFFd6hRV18pDVr4y03V5HRxrwMSfHWpsm35LXaAdV6DpWx370kI0MVKE8iURZ2AlbjAVUxCzQw8TuZ1SaJahZv1Iap49F+M1VkGNPIhsYgB/78MrDIEh8LCCby5sJiSye8aB9KtNt+q51w4Ws1hkPUjnquqmCW/CIUTJDMINh2B8DqVms8EYQ3zKTckhUynMSUQ/1bslszTxkGOnsVb2RzJpyFI9ia8ZRF20wDvRlT6msbgQtM6h2gSEHrIU91Efo7iOO+N+yTVSgct1zdEs0dSeQglqh9DPwQG0pQfgrmztliZhiXHWx6ERkMraNe5qlK9FCgVW7w==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1665409280; bh=qwKjdfXZXoxOkX3lVRmFbgVHn+BdpodBbHDEeCuntK2=;
 h=X-Sonic-MF:From:To:Subject:Date:From:Subject;
 b=bnC7r25Z/8wOKb2Cz63pLldPqh0rf8CUYcNKpSPqrN5dc7ePocD5kevVA+xgu2uiXfs5K1QdWIpSVmOEcHLt6JCVmxGwkFJLpYpq1XNaA2ISUIkesLBYphqazqmEXCJloe6d9v4ESHadvp7IGlVHAA8SNGQiRqcCD350Voas5GkLHds2qYh3joRP28c01nbyuMf+bcso0yiIwt/yaxtExhMuOPbaFysh0ksri6t+HinMnIxS43J/t+gnrLdutEHxSLmeBF87D3DdrEeX6FBRFsFEUAHpDAGP5XtkLxgPj5+kTtdW2K9dAVIS9Mg9ue8mCfFIPMWu+58I1TOoHJBvTw==
X-YMail-OSG: 279Qt6sVM1krHAkLTnRpgIdq8s0iRVDBSpIVGoz3SLFdzC3CEj009nqpn1tmBZr
 sp1_IYKtbHAnknFX5BTLid1IEUADHvYD1eYFXwNeqFbpf9BvtF6EZUOJzT6Wj7tKBw2AwEPRLOad
 6n0CO2OYB_muCM.g06aE8zV4WiJBs2wxKSDZ2D3xv4UIuFIbRP5HzkeyDQp5HYUmu71O7ReSobf_
 7k4.HeYi1NsnBoRvw27JqCgzWNfA1Q.11aCS_UsxzvpJIGQXEADZkLdDEWPFoFpQqsjY_KmqHAN3
 I3niPvhFIQfPk8OjG3l1jtJzxJvGtvvpC.LAfP9GJuvMyxpbF8LGHDh.DLjHNJjo5WZlzbE8dr5L
 bh9NkVY1P2tpjJ2RmTkTd4hWACzjmv9bxpVYfUH7tisY_e8K.hO653Nj9JqHpaiQH5k2ey5ATdDF
 Do4eAMsiDlnu5BWWsV52hMgArG2klm7pKEzQb4kS542praZy63B3d2oUoGSpJroqm8zJUMMB_z2T
 _bNCvMbWPC_KcdApaJ44A6FT3oCvpizmalf7gUeRBtPX_mW9Qn51fwOS_bTSj6eprNpk09tI1hWn
 Bmq2Ho2e10jz9HYnjncGb1yPcrmTWvtZUsxpKxIrdD8gyP3XyVvzJsGCodpTm9y4pK3ETcf2P5s3
 kJdjt1cL3rCgfJAJn_Nl4yzNND88VyCGZQL1oie8709dzLzOB_fAFLDO9u7GYLcOw3.k.ugPuSTg
 1gXtaFtqMx0whD0g_LWufU__v_wVRXqpTtq76G.3Jj5UXN2S9uQm3ilVqxGKK7bJU9rYCxFFa_1P
 Y2HfTwdKYZVdrrge5msNcwpl.61YHYPKrEQ.mPP3xp._DMXaJIug4RtMDEV55xlGRx98OUsLxJ4S
 Jfd0QlShdWW_69kE2xTcMvbtpn1Y8eI68Q7rj2nS4ow5jMpLdf38A1nYidFMB1RpfACk3NimhcS.
 TM2Vl2peMCFu1komYTqbiJASJPjZImyVMyATAuaVwAqmAzhDqT5Q1ZZUm4nCeY1XPeH8cNLBW4gn
 igNYh5Lj2xntjfizzm9s2b6fnBf3dZR5BqJ4W1J7dnqvL90MHac3l_vBcoB_Znv2jUC2EMJZmASr
 .xzSUbQlkz7La.p_qxqFbxTTGXJ5ZMagq94VHcAm0AmV.yaQK2OQMgbpqbLbqQy0b6_8eaFoNrof
 phS_9mc_wJ3X9VOjkLOCysQ33nXoSEZ79WeoxUYq6aebROGM79PU5vSugy8aHDj_pU1Io_pSbbL.
 Nz1Q39GJ8EaDl4FEPTEIuS2Uh3zHhzHJ0ZIhE7kHzYuDsRvVPxhEMa0LY4_3jgXFfR0Me5_AQMJN
 pz8DsWTCK_YSMPmOsvliBOCMCW4fwy307YMPDkY9JNKHk8ObrG1yl0SIR091FMAsolNBvTDPn1gM
 ZfnLvbRHyKZfYPKb5IzT1OKBIAcSwtaLRopfsiVnzekIA2fOUcsjqxEAE0nmuHsItMFkXPYKeEqX
 HjeBxdvEOgR1yY5Aw6TkPCFCXl.WvZBwCGs0n8JaP_uC4HPS8VItmhCOosCJKsowPQaqDl7_fnfx
 qmWhs6PPe4r5GILS9TlUTGOWwIWIj.44_PYDSnpLOCb12m855ryZiMQdllB8FSU0XDks.88OhmTD
 s6TsayOH_rQV3EGvEBwBUCSD03vhMHrbRtiK5lG_2F0jixIkZZveVIYo060tVmSTPytiwnzZcgmZ
 _s7uTb29IZ71nkS8T3lo2MAuHuFYKUUT8Mr3QKiX1UQC5ZyMIFHW75hr74Nr741Lx7kAw.nNLA6l
 7Z5dZfc_.yvaaP.n6ijMzo9dUTOGqmjyPv1Ni1cooAbP5Np.hBjVw69VV4WPNMKdAH5xT0J1IsJu
 _SSn3J0.jqUqu7vDu.fGx2ItU_X4JT.3eYBKuupf3oRGdNGuybUAwAt2wNfx2Zcg.Z20ShCW5fGh
 rfDa6yPNglikcogzSgWbWnveXdCpzWk__2zQp9bPNBXHyNAOSv3ar6KF0v7uGdKk3aO_w8LEXibG
 Jv9Uz8t14NYksaZns17ZDD53lJQR7K7t8_mnCbHJJRHMoQF8Jk8sPUCOiD.8aX5uBsQAR5gkeFmb
 NKb9edULKvwb7dqneolc0_RWCeHjeDBw06mb.fZgeCe7OupLcuWAkEE6HzQUtPjgkVFEmQKvuN2K
 XrO9hE2s6IFfqQgpP5Vz5QoQuqnuX51QpAm4MZFQ8aPr4P0GXussh.O3LuEAF1K8w7L6WxCiCcFE
 LgvW207cNTPpar5fvBYh21fpCuuCD5aQpA1F0LlxGh7A1YEsDXglgW1UObTYbXyhcPSLIdIPbTNt
 uFsIh0w8-
X-Sonic-MF: <luangruo@HIDDEN>
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic309.consmr.mail.ne1.yahoo.com with HTTP; Mon, 10 Oct 2022 13:41:20 +0000
Received: by hermes--production-sg3-7794f55d99-lnmnm (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 0574b0d41fc72d91fad41a27b2245d3d; 
 Mon, 10 Oct 2022 13:41:17 +0000 (UTC)
From: Po Lu <luangruo@HIDDEN>
To: Manuel Giraud <manuel@HIDDEN>
Subject: Re: bug#58406: 29.0.50; Bars refactoring?
References: <87a6641648.fsf@HIDDEN> <87bkqkm777.fsf@HIDDEN>
 <87tu4cyszl.fsf@HIDDEN> <8735bwm57n.fsf@HIDDEN>
 <87wn9798ww.fsf@HIDDEN>
Date: Mon, 10 Oct 2022 21:41:11 +0800
In-Reply-To: <87wn9798ww.fsf@HIDDEN> (Manuel Giraud's message of "Mon,
 10 Oct 2022 14:10:07 +0200")
Message-ID: <87h70blrt4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Mailer: WebService/1.1.20702
 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo
Content-Length: 1383
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 58406
Cc: 58406 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

Manuel Giraud <manuel@HIDDEN> writes:

> I find it useful to have some visual feed back that some text is
> clickable (the mode-line is a good example of this IMO).  What do you
> mean by "no program does that anymore"?  Do you that this is done by the
> widget library?

No, I meant that no other program has highlightable menu items in their
menu bars.

>>> I understand that it is too close to Emacs 29.  Do you think the menu
>>> bar could be made to mimic some feature of the tool bar (like tab bar
>>> did)?  Or do you think it would add to the cargo cult?
>>
>> I'd rather not touch any of the *bar code before Emacs 29 is cut.  Most
>> people do not use the bars, leading to many latent bugs.  Examples:
>> mouse face not being cleared when tooltips are enabled and the mouse
>> moves outside the frame, last_tool_bar_item not being cleared in the
>> same case, and last_tab_bar_item not being cleared, leading to mouse
>> highlight not working after the mouse is released outside a frame.
>>
>> These bugs are particularly nasty because they only happen in rare
>> situations, but can completely ruin the visual appearance of a frame
>> when they do.
>
> Ok, maybe I could look into them as an exercise on xdisp.c

The bugs previously mentioned were fixed, I'm just afraid that trying to
merge the tool bar and tab bar code will introduce more similar, nasty,
bugs.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#58406; Package emacs. Full text available.

Message received at 58406 <at> debbugs.gnu.org:


Received: (at 58406) by debbugs.gnu.org; 10 Oct 2022 12:10:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 10 08:10:27 2022
Received: from localhost ([127.0.0.1]:46334 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ohrbo-0002ML-Lf
	for submit <at> debbugs.gnu.org; Mon, 10 Oct 2022 08:10:27 -0400
Received: from ledu-giraud.fr ([51.159.28.247]:34792)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <manuel@HIDDEN>) id 1ohrbl-0002MA-Ta
 for 58406 <at> debbugs.gnu.org; Mon, 10 Oct 2022 08:10:11 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=+ac8fBFCYids44Bx
 dyC4GnFXZOVNnJQaoIe+GiCvU7o=;
 h=date:references:in-reply-to:subject:
 cc:to:from; d=ledu-giraud.fr; b=Og3E7q7bqKo9FeuOvErXAU2VKQZ/6fctI6ncqU
 O9MT2vMjgx2UbYgf9KXpGfQ7GnuRTB+yLawiNM9hTWItByi7CeVEKxHL5jTSHhcKiscY5Q
 W2Gk03mllqlWZ9n8mnBUzY3nP1Yi8zdC0uaUJj5B4/7mPdlu8iQP7S7KLOpiTKARjLdlx8
 RaIiPRao27SynCDQBhuq5x4DZwrPnbA2qSIFn5IBYo60F3Lj0/y3y8Dbv4NhkOfh2CALfq
 RVxdTZp+5cyeu68vH5rZVXIBSNAGywAt+xfQLBfg0wk7TIHFxp741pk5GA7ul7olJ5oqnZ
 P4xqK01TW1GyZX6doqA7g8Dg==
Received: from elite.giraud (<unknown> [10.1.1.1])
 by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 58d8a0d8
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Mon, 10 Oct 2022 14:10:08 +0200 (CEST)
From: Manuel Giraud <manuel@HIDDEN>
To: Po Lu <luangruo@HIDDEN>
Subject: Re: bug#58406: 29.0.50; Bars refactoring?
In-Reply-To: <8735bwm57n.fsf@HIDDEN> (Po Lu's message of "Mon, 10 Oct 2022
 16:51:40 +0800")
References: <87a6641648.fsf@HIDDEN> <87bkqkm777.fsf@HIDDEN>
 <87tu4cyszl.fsf@HIDDEN> <8735bwm57n.fsf@HIDDEN>
Date: Mon, 10 Oct 2022 14:10:07 +0200
Message-ID: <87wn9798ww.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 3.3 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: Po Lu <luangruo@HIDDEN> writes: > Manuel Giraud
 <manuel@HIDDEN>
 writes: > >> mouse over highlight: like the relief on tool bar button or,
 even >> better, with highlight face like on the modeline. > > I'm afraid
 I don't see t [...] 
 Content analysis details:   (3.3 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 2.6 RCVD_IN_SBL            RBL: Received via a relay in Spamhaus SBL
 [51.159.28.247 listed in zen.spamhaus.org]
 0.1 URIBL_SBL_A Contains URL's A record listed in the Spamhaus SBL
 blocklist [URIs: ledu-giraud.fr]
 0.6 URIBL_SBL Contains an URL's NS IP listed in the Spamhaus SBL
 blocklist [URIs: ledu-giraud.fr]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
X-Debbugs-Envelope-To: 58406
Cc: 58406 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Po Lu <luangruo@HIDDEN> writes:

> Manuel Giraud <manuel@HIDDEN> writes:
>
>> mouse over highlight: like the relief on tool bar button or, even
>> better, with highlight face like on the modeline.
>
> I'm afraid I don't see the utility of that in a menu bar, since it
> doesn't consist of "buttons" in the sense that the tool bar or tab bar
> do, and no program does that anymore.

I find it useful to have some visual feed back that some text is
clickable (the mode-line is a good example of this IMO).  What do you
mean by "no program does that anymore"?  Do you that this is done by the
widget library?

>> I understand that it is too close to Emacs 29.  Do you think the menu
>> bar could be made to mimic some feature of the tool bar (like tab bar
>> did)?  Or do you think it would add to the cargo cult?
>
> I'd rather not touch any of the *bar code before Emacs 29 is cut.  Most
> people do not use the bars, leading to many latent bugs.  Examples:
> mouse face not being cleared when tooltips are enabled and the mouse
> moves outside the frame, last_tool_bar_item not being cleared in the
> same case, and last_tab_bar_item not being cleared, leading to mouse
> highlight not working after the mouse is released outside a frame.
>
> These bugs are particularly nasty because they only happen in rare
> situations, but can completely ruin the visual appearance of a frame
> when they do.

Ok, maybe I could look into them as an exercise on xdisp.c
-- 
Manuel Giraud




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#58406; Package emacs. Full text available.

Message received at 58406 <at> debbugs.gnu.org:


Received: (at 58406) by debbugs.gnu.org; 10 Oct 2022 11:58:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 10 07:58:45 2022
Received: from localhost ([127.0.0.1]:46319 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ohrQj-00023o-Ab
	for submit <at> debbugs.gnu.org; Mon, 10 Oct 2022 07:58:45 -0400
Received: from ledu-giraud.fr ([51.159.28.247]:26488)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <manuel@HIDDEN>) id 1ohrQg-00023f-Li
 for 58406 <at> debbugs.gnu.org; Mon, 10 Oct 2022 07:58:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=3brJWWZMLgwZ8Svm
 v3zbgSaXMshh7tDTlyewyrysC/8=;
 h=date:references:in-reply-to:subject:
 cc:to:from; d=ledu-giraud.fr; b=UGnBJ6WhyJX5hWGQDeyXPUT5aFWRjwjvrRo5mc
 hJxwGhH1D/NQMK9h0QDT1DKAREgdxgVqEPEMWEzigGgS7MstJdyZ/PXMVqEOAxVLdYR708
 Bay7/Q2VmKkgmo4s8qtm0ilVFEh651euiMYMS1VqvRt9pspwoWRUEnDUiawVQuJRmPQ0xw
 FAx58aAwBh5fomlssVYmjpviqUWJU7AVTc+4qQu1EYxvj73KZTAFlUE+6ORrsb1nr2ak3S
 FwYySfT+Hujf38hPEY6987L3vs3SEUh1reTCqMK5tYbgsqWrneYNoSj9iNvvEyeD18IYiE
 SvoMZ6aphvkpdhAUQK34vPRw==
Received: from elite.giraud (<unknown> [10.1.1.1])
 by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 9246b2b9
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Mon, 10 Oct 2022 13:58:41 +0200 (CEST)
From: Manuel Giraud <manuel@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#58406: 29.0.50; Bars refactoring?
In-Reply-To: <83y1togj84.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 10 Oct
 2022 11:45:31 +0300")
References: <87a6641648.fsf@HIDDEN> <83y1togj84.fsf@HIDDEN>
Date: Mon, 10 Oct 2022 13:58:40 +0200
Message-ID: <871qrfao0f.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 3.3 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Eli Zaretskii <eliz@HIDDEN> writes: [...] > The approach
 is OK, and welcome. But let's please wait with this > refactoring until after
 the emacs-29 branch is cut. OK? 
 Content analysis details:   (3.3 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 2.6 RCVD_IN_SBL            RBL: Received via a relay in Spamhaus SBL
 [51.159.28.247 listed in zen.spamhaus.org]
 0.1 URIBL_SBL_A Contains URL's A record listed in the Spamhaus SBL
 blocklist [URIs: ledu-giraud.fr]
 0.6 URIBL_SBL Contains an URL's NS IP listed in the Spamhaus SBL
 blocklist [URIs: ledu-giraud.fr]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
X-Debbugs-Envelope-To: 58406
Cc: 58406 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.3 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Eli Zaretskii <eliz@HIDDEN> writes: [...] > The approach
   is OK, and welcome. But let's please wait with this > refactoring until after
    the emacs-29 branch is cut. OK? 
 
 Content analysis details:   (2.3 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  2.6 RCVD_IN_SBL            RBL: Received via a relay in Spamhaus SBL
                             [51.159.28.247 listed in zen.spamhaus.org]
  0.1 URIBL_SBL_A            Contains URL's A record listed in the Spamhaus SBL
                             blocklist
                             [URIs: ledu-giraud.fr]
  0.6 URIBL_SBL              Contains an URL's NS IP listed in the Spamhaus SBL
                             blocklist
                             [URIs: ledu-giraud.fr]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

Eli Zaretskii <eliz@HIDDEN> writes:

[...]

> The approach is OK, and welcome.  But let's please wait with this
> refactoring until after the emacs-29 branch is cut.  OK?

Yes.  Po Lu made that point clear too.

[...]

> The "F->tool_bar_items" part of the comment is outdated.
>
> Also, our style is to leave two spaces between sentences in comments
> and documentation.

[...]

> Likewise here: outdated reference to tool_bar_items.


Yes.  Sorry to have wasted your time: this patch is far from clean (and
it shows in comment and the like).  It was really just to show my
direction.

>> +  /* Is mouse on the highlighted item?  */
>> +  if (bar =3D=3D TAB_BAR)
>> +    return *prop_idx =3D=3D f->last_tab_bar_item ? 0 : 1;
>> +  else if (EQ (window, hlinfo->mouse_face_window)
>> +      && *vpos >=3D hlinfo->mouse_face_beg_row
>> +      && *vpos <=3D hlinfo->mouse_face_end_row
>> +      && (*vpos > hlinfo->mouse_face_beg_row
>> +	  || *hpos >=3D hlinfo->mouse_face_beg_col)
>> +      && (*vpos < hlinfo->mouse_face_end_row
>> +	  || *hpos < hlinfo->mouse_face_end_col
>> +	  || hlinfo->mouse_face_past_end))
>> +    return 0;
>
> The "else if" clause should only be used for the tool bar, not for the
> menu bar, AFAIU.

I don't know yet =F0=9F=98=85

>> @@ -15485,6 +15451,7 @@ handle_tool_bar_click_with_device (struct frame =
*f, int x, int y, bool down_p,
>>    Mouse_HLInfo *hlinfo =3D MOUSE_HL_INFO (f);
>>    struct window *w =3D XWINDOW (f->tool_bar_window);
>>    int hpos, vpos, prop_idx;
>> +  bool close_p;
>
> The value of this is ignored here, so it is better to call this
> variable 'ignored' or 'dummy' or something to that effect.

Yes it is a good idea.  I'll try to remember that next time.
--=20
Manuel Giraud




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#58406; Package emacs. Full text available.

Message received at 58406 <at> debbugs.gnu.org:


Received: (at 58406) by debbugs.gnu.org; 10 Oct 2022 11:24:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 10 07:24:48 2022
Received: from localhost ([127.0.0.1]:46293 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ohqtr-0007Ty-OA
	for submit <at> debbugs.gnu.org; Mon, 10 Oct 2022 07:24:47 -0400
Received: from eggs.gnu.org ([209.51.188.92]:45416)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1ohqtq-0007Tj-C1
 for 58406 <at> debbugs.gnu.org; Mon, 10 Oct 2022 07:24:46 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:58560)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1ohqth-0007aq-Cv; Mon, 10 Oct 2022 07:24:39 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=5kWW8KBa/oFtuDfxssFFWyGbhDtSjlBNnIVavBvI7dA=; b=lt85cmGmTyLF
 pfgBX/Qi+qV30Cc3RXZ7C2039TC1+WJa5buGBvNQyIVlsI0TtawG6jGG2Z0yTZySK5+WwdVR+g1Mz
 4SHZsTBFaEOLgBv/u6GIpP79R2le13AgkDyhNXgYIRJXtTBfD67V5UG4trzjB/YSLQbHfwSHhtqZb
 4xyJpNw7akkHvuDASuaEaZW+lbYwBmK/b2PY7y1feiMf4Y5nnvrw1B3Zsy7zEvHZpSCotMnYTJVV/
 OjrtvjeVxymTskTkOB9qazRk2v4N3ReOxRshorby/gkZmKBhlZRcC0e847asjYQvbWlPovtymliCx
 MQIAbv7QILuay+HEZ23l1g==;
Received: from [87.69.77.57] (port=1597 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1ohqtf-0000Ys-As; Mon, 10 Oct 2022 07:24:36 -0400
Date: Mon, 10 Oct 2022 14:24:38 +0300
Message-Id: <83ilkrhqfd.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Po Lu <luangruo@HIDDEN>
In-Reply-To: <87y1tokn8r.fsf@HIDDEN> (message from Po Lu on Mon, 10 Oct
 2022 18:05:08 +0800)
Subject: Re: bug#58406: 29.0.50; Bars refactoring?
References: <87a6641648.fsf@HIDDEN> <87bkqkm777.fsf@HIDDEN>
 <87tu4cyszl.fsf@HIDDEN> <8735bwm57n.fsf@HIDDEN>
 <83pmf0gihb.fsf@HIDDEN> <87y1tokn8r.fsf@HIDDEN>
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: 58406
Cc: 58406 <at> debbugs.gnu.org, manuel@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

> From: Po Lu <luangruo@HIDDEN>
> Cc: manuel@HIDDEN,  58406 <at> debbugs.gnu.org
> Date: Mon, 10 Oct 2022 18:05:08 +0800
> 
> Eli Zaretskii <eliz@HIDDEN> writes:
> 
> >> Cc: 58406 <at> debbugs.gnu.org
> >> Date: Mon, 10 Oct 2022 16:51:40 +0800
> >> From:  Po Lu via "Bug reports for GNU Emacs,
> >>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> >> 
> >> Most people do not use the bars, leading to many latent bugs.
> >> Examples: mouse face not being cleared when tooltips are enabled and
> >> the mouse moves outside the frame, last_tool_bar_item not being
> >> cleared in the same case, and last_tab_bar_item not being cleared,
> >> leading to mouse highlight not working after the mouse is released
> >> outside a frame.
> >
> > I do use the bars, and I don't think I see any of the above problems.
> > How would one notice them?
> 
> One of the problems (which was fixed earlier this summer) could be
> reproduced by holding Alt-TAB (or waiting for a focus to steal the
> focus) with the mouse held down on a tab or tool bar button.

I just tried that, and saw nothing suspicious.  What should I watch
for? what do you see in that case?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#58406; Package emacs. Full text available.

Message received at 58406 <at> debbugs.gnu.org:


Received: (at 58406) by debbugs.gnu.org; 10 Oct 2022 10:05:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 10 06:05:26 2022
Received: from localhost ([127.0.0.1]:46166 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ohpf4-0005Hd-G2
	for submit <at> debbugs.gnu.org; Mon, 10 Oct 2022 06:05:26 -0400
Received: from sonic313-56.consmr.mail.ne1.yahoo.com ([66.163.185.31]:42233)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <luangruo@HIDDEN>) id 1ohpf1-0005HN-Gu
 for 58406 <at> debbugs.gnu.org; Mon, 10 Oct 2022 06:05:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1665396318; bh=tMcy9rTIIv/5T7UOVixy9Qi+kePQCcs69DcnIv8eg1c=;
 h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To;
 b=hVNjKH3Iex0/LhEUIHyBz3hkQp4NV8annHDn9EDxY4gKJ7Nh9W0Sa6uVs0ousNBqFJfzStC/P4v+dx2YaeHkOHTK0FqIG9s5t1UnQxX0ef56DFZDNbMtmh5k2o8n+N03TjkdrzxTFRQQuZDDtnYaKscygLFuWf9P8HPg+upw6oFyr1LmBFXzYglrPQ5or8hznea6UDdgq7qiSubU3kjWZA80dVbxJjWV5AGMq2GVM/+an1pWgCWs0ZqT5WOvTvKPTCUs85JuGevCvTMVldAKDURdI/M+IvgKX388eBW2NwTd1Wx59GYxUyqKIHIOxPAuyTaOWiHYu4Gdp4mFPTdFIQ==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1665396318; bh=cgdRGet8bn0tlyvpdnKYLoQiFETTnVnYeVW0KLL2u2L=;
 h=X-Sonic-MF:From:To:Subject:Date:From:Subject;
 b=GXCKEW8kP/PZ77pcZDUzXPag0svQYA8i5j+6Je/gfDK73Ht05cAOqQvxv5lybCLJU5Css4h3sJ20oTmeMj+bB/S3pwx0F7u82dJ09IXG3boMEhiHXmkNVewbuFdgCeqqbnyYZjH4bf+s+lTKn9meJ95gZuK2gUQs2cKRBe+Wlv6e+2B3Bf552gwfB2FGh+/Hq1q5EmOjhmoDD0ClmGpR69UT0F6mFLqeFgmt9fP2+cazJj2st+Ptr75HhKn9qAkzIdxMZCF2x4URiqgkKpYzEbVY1+j0voqtSVROyd3qW/caPN2UlFB3kqJ5R0mt89OeAQ54HPvVV4Sb4JgPNcdHNw==
X-YMail-OSG: 7L90IxMVM1mCd_Cobovk79.vz0MTV.1YRLxx4ATj1493SJ4hT9XCdBXA1PQtZKG
 PZL61FeVQVNowk6Z2ANWis0N0Tn0NQqAAdXQvvfV5DaeD0nvKAWGJh3dBN881e0UEBJbOi2ol1O7
 ksf02bnPIbOcQmeEE6tOz55zyW5SFiDC46._a1O.iSvQBZuLIeFXVD4.TPnxtbAFqI5EwiVg3HHg
 CGrylGjjng2JmhfuTPXwmu5LoPcIgfHioQDLt._.E_7Hhph1_xJyRcUFc57x11R87mYX2_0lCgl7
 H3MrfFfVBqH9tRhefoLUK5zjuihYYLC9PJVf3UztMANJcSzzoHk.06sMd3PhCHneYuVyBze38cPU
 l5TubxmYVDq3nG1FML91r4ICvFIkGUaUKEfwwj6_tGyknigbyZ5pxUMcVLL3kAvPJDLNe6tr_aqX
 nW258Xmzq5vPDFpBpsNdGgl9CZBeDTYwuQPh6brMNAHYvknxqc8atd9xdk2g1JQchTtUMpw.Ic_l
 XIUAHuLfucs_c0eT7KMgIiBt9uGsrfLsUFrKsuJL8Qgu0SjwjpuYBZw0413TklY9OA4NOu4qEfm6
 lG3cGuhE4EZqsBVAIhb_eSuFRMSvE68xGgnvDln2xKgm8sWk56sED6TXLF4C9ncrDLjr1osfpRsX
 xZG0H7R1jonLIDE_xDxX3j8kG6TvXxxA5DiFnnMuXkkR6IjPjpPGKCzzrEJqfOGqktj9xw.Zk6qK
 bprWrG_StHOYE6So1vHqKjoI62wg_7StRPWTuOVHxUpELO3w_lGnlsPvDwSVqTgInmbKRd6EutDJ
 bmh.n3u57krsnQgw62IJxXvecZcWaIDYR3YvyAFb_77w1GGCvOVW0QUMrHSK3Ryo00U7wfh.HDOE
 89xcgERdatAwVPDoCJ4De064j2d_3HAR1SwKMxDyBjoUSxbW98b660ci_QZvv8GwWWsKoMAHQh4Y
 2yug77M3pE6r2AbBsrdNE9Y0IiMNSIjY4ReWBGSO8WSw4YQ.QwyLHwfSO7j6w_IF_z5G9KYM5pbo
 8dwTj8TeKBkDoW5xv4ImjoMsgL3fOHUxbeO8I.CZgAfrQjXrcux.q.NA1yt3W0TaReMm_jOlANFA
 7CPd0sM0g9b2yzGF_kcGKAh8On0BPEpiBP.7M_c4rXQ9xa0UxzMKTsz1j.gfwq4GUonTtZNL.sdK
 LwJj9yO3idxarT76r5qudAfWaPwtp8FlaCnmt04SYLWib6tR4ZaV8_jdRPqmzAkOOAc1bvX_sQor
 405CR_rJN7syzjI9PKBaJ2ntFw5JGJkcGt7AH4xlP.xSWO.w0wWlg288l9qIqskTVOcy93kVHVj1
 tTA5UqdYqzOwge5ITdk56TB9FDhnaDT.J57mexXkdRQ2G9ueZXwk.LYyVcDuaIeYfaB1X35uQXIs
 7Ys2JKQIG3BMg_dz0PUDi2Jl85lG77VI_OnjezlfpDe0LVMuBc5Ummw.YJqykqwVvARSQE8QNJfc
 1BdaFp7uPxpLDxiyEazg0IKYbK24P7GM5rlRRUSWttdHX..3.GdHF61WUgLpj22fszOdjV9X7PaN
 nOg5p9PXy1sBeph23wKbRmzGdi3kY46pdDNRfv6s45.oWT7vPmo4dUiZy7uW32gar509uhnIS.X7
 8SEu.k65JOBTq9znSCi2XUUt8R7_t2W.0DLnii7f40tRep3wlCqvUdwosMSmT0UqgemFse5frFoz
 5d2x1BREnW_BO0Ry2jVVZqhsY733DLHje1apccmNEI60.kHjoXB8ETKzgPBJMffKuLf_YzQZLJNc
 nhN_L8JCr3nUecyk45XmboPh1To4n7ixiZBF9oWdq6RcEfxAx0EVYFEtkdr9ATfbLml3gu_B8u36
 YKVdg3hca3aavtCk6v7ujTCwZpXJ0REeYTNB8Aaqww8fFV4o2UEEFEG0oc1xZR4XvuvnlPq0aMyH
 IaQAGAJyss9_ImLaYV0fWT8B0ysvLuQDXrjBNvG.8C9wk5NxfayV5qCrTVUPcRM6h5NYrOsXeLvx
 _gMye0F5K2iuiqwt6gap3RlMfIoKAxxrYEWMqm7BleiYjsMWPsHVPONSYilvABpUrOgzF31RdNz0
 d7r.Y6akNoZvAunw2w9SGU4NPEb3q1zHrhyWHF5i764dUvIe9XEsXQm4SrwC7I7YjKvoy7nE5tMN
 MzjIutQxOjDe1IVwMhCLw3IEbSDqyGSZpEfPJW8R6.F3bZW486WkC4yhSkgCq6jiLM52MgfGz3dD
 haMRSKNyWLni5c_TzfW_fKjbyZfiMT8_Mh8voWzIGSpckQecL33P3U72oANWf0bhJs.mV1lJA2il
 e
X-Sonic-MF: <luangruo@HIDDEN>
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic313.consmr.mail.ne1.yahoo.com with HTTP; Mon, 10 Oct 2022 10:05:18 +0000
Received: by hermes--production-sg3-7794f55d99-gf86m (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 6c86c0d2a84671eed610954959823d4e; 
 Mon, 10 Oct 2022 10:05:12 +0000 (UTC)
From: Po Lu <luangruo@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#58406: 29.0.50; Bars refactoring?
References: <87a6641648.fsf@HIDDEN> <87bkqkm777.fsf@HIDDEN>
 <87tu4cyszl.fsf@HIDDEN> <8735bwm57n.fsf@HIDDEN>
 <83pmf0gihb.fsf@HIDDEN>
Date: Mon, 10 Oct 2022 18:05:08 +0800
In-Reply-To: <83pmf0gihb.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 10 Oct
 2022 12:01:36 +0300")
Message-ID: <87y1tokn8r.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Mailer: WebService/1.1.20702
 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo
Content-Length: 889
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 58406
Cc: 58406 <at> debbugs.gnu.org, manuel@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

>> Cc: 58406 <at> debbugs.gnu.org
>> Date: Mon, 10 Oct 2022 16:51:40 +0800
>> From:  Po Lu via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>> 
>> Most people do not use the bars, leading to many latent bugs.
>> Examples: mouse face not being cleared when tooltips are enabled and
>> the mouse moves outside the frame, last_tool_bar_item not being
>> cleared in the same case, and last_tab_bar_item not being cleared,
>> leading to mouse highlight not working after the mouse is released
>> outside a frame.
>
> I do use the bars, and I don't think I see any of the above problems.
> How would one notice them?

One of the problems (which was fixed earlier this summer) could be
reproduced by holding Alt-TAB (or waiting for a focus to steal the
focus) with the mouse held down on a tab or tool bar button.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#58406; Package emacs. Full text available.

Message received at 58406 <at> debbugs.gnu.org:


Received: (at 58406) by debbugs.gnu.org; 10 Oct 2022 09:01:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 10 05:01:43 2022
Received: from localhost ([127.0.0.1]:46017 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ohofP-0001SC-6h
	for submit <at> debbugs.gnu.org; Mon, 10 Oct 2022 05:01:43 -0400
Received: from eggs.gnu.org ([209.51.188.92]:33150)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1ohofH-0001Re-Nq
 for 58406 <at> debbugs.gnu.org; Mon, 10 Oct 2022 05:01:42 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:55682)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1ohofC-0007kv-Hq; Mon, 10 Oct 2022 05:01:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=ZhWtucHh1tjsAtoumAQVPVrxf2rMf3N0si5po9ScgTk=; b=sOYZlARbt2U5
 Q6aXBiZaxUY4h2uXqq7N5dX7OrxZ4nvW5xLVh+yhvbYhg+ei0rls9ro+qfri6o83CJYJlOmSXUDlN
 y0hxNLkDyqQ4LA+Qha77rE++PGpRu6gLLwJNIcKXmzzburjxA2qjq9WZasG6tZgAZ8Th/3kHjgkBu
 NFMvAg3W0qXYkhZyFhvm6OUlGSvSaxuhHCupbSNejd80f/ouaKdWjNeuvMNkb4R+rLVYG4v+l+po4
 axLGuMwkhw5AhwVllwix+cRNXUS43YjCpml1dfa0BpXs3HrhyS+f4ztjBiSoHnD/4QrPg6qZL4lDs
 d8kISa6+gJYcUgClqQZHMA==;
Received: from [87.69.77.57] (port=4535 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1ohofB-0000FP-Im; Mon, 10 Oct 2022 05:01:30 -0400
Date: Mon, 10 Oct 2022 12:01:36 +0300
Message-Id: <83pmf0gihb.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Po Lu <luangruo@HIDDEN>
In-Reply-To: <8735bwm57n.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN)
Subject: Re: bug#58406: 29.0.50; Bars refactoring?
References: <87a6641648.fsf@HIDDEN> <87bkqkm777.fsf@HIDDEN>
 <87tu4cyszl.fsf@HIDDEN> <8735bwm57n.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 58406
Cc: 58406 <at> debbugs.gnu.org, manuel@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 58406 <at> debbugs.gnu.org
> Date: Mon, 10 Oct 2022 16:51:40 +0800
> From:  Po Lu via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> 
> Most people do not use the bars, leading to many latent bugs.
> Examples: mouse face not being cleared when tooltips are enabled and
> the mouse moves outside the frame, last_tool_bar_item not being
> cleared in the same case, and last_tab_bar_item not being cleared,
> leading to mouse highlight not working after the mouse is released
> outside a frame.

I do use the bars, and I don't think I see any of the above problems.
How would one notice them?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#58406; Package emacs. Full text available.

Message received at 58406 <at> debbugs.gnu.org:


Received: (at 58406) by debbugs.gnu.org; 10 Oct 2022 08:58:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 10 04:58:40 2022
Received: from localhost ([127.0.0.1]:45994 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ohocS-0001KF-Lm
	for submit <at> debbugs.gnu.org; Mon, 10 Oct 2022 04:58:40 -0400
Received: from eggs.gnu.org ([209.51.188.92]:34360)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1ohocQ-0001K3-RA
 for 58406 <at> debbugs.gnu.org; Mon, 10 Oct 2022 04:58:39 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:53472)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1ohocL-0007Dl-1R; Mon, 10 Oct 2022 04:58:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=DJl4Ot44fiDWL6e2T1Pfq4R7R2dCXLbE/+ENvM4voFU=; b=CNfbNJMxfjkg
 cBzrTWkNs9Ol6DZ/IADfhIyoM8IXbm7AOL9UnMF9s3kkw3oC3+FXhDdulLf1KKN5O5VGO5mtrung7
 38CxGBtDTvRncEJ3TwxPj7RkZKR2/Zv+DU3w5Z2vrMeaJQMJuDEpkVNJDi89p1/SmO//drIZntY2x
 u/It7YNAbcSqo866BgRbV6DAepXBJgT5kBpy0ugoAwsczszJjWF4/ua++TBNMVXINu1PMlqZ0LhI7
 6X07/MgGFtTbRmZwUHwWWF84cQir76O4IDUc1NE4sVfbMW0xlA/Wz7lySkIvBcODx8b0mNNqJfCvK
 PvVZuQ3NiQZz+Rl/P4LpCQ==;
Received: from [87.69.77.57] (port=4336 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1ohoc6-0000CJ-Rh; Mon, 10 Oct 2022 04:58:32 -0400
Date: Mon, 10 Oct 2022 11:58:24 +0300
Message-Id: <83r0zggimn.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Manuel Giraud <manuel@HIDDEN>
In-Reply-To: <87tu4cyszl.fsf@HIDDEN> (message from Manuel Giraud on Mon, 
 10 Oct 2022 10:37:18 +0200)
Subject: Re: bug#58406: 29.0.50; Bars refactoring?
References: <87a6641648.fsf@HIDDEN> <87bkqkm777.fsf@HIDDEN>
 <87tu4cyszl.fsf@HIDDEN>
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: 58406
Cc: luangruo@HIDDEN, 58406 <at> debbugs.gnu.org, manuel@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

> Cc: 58406 <at> debbugs.gnu.org, Manuel Giraud <manuel@HIDDEN>
> From: Manuel Giraud <manuel@HIDDEN>
> Date: Mon, 10 Oct 2022 10:37:18 +0200
> 
> > Why ENUM_BF?
> 
> A mistake.  I thought it was the way to use enum types in emacs.

Only for bitfields in a struct.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#58406; Package emacs. Full text available.

Message received at 58406 <at> debbugs.gnu.org:


Received: (at 58406) by debbugs.gnu.org; 10 Oct 2022 08:52:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 10 04:52:01 2022
Received: from localhost ([127.0.0.1]:45947 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ohoW0-000197-SV
	for submit <at> debbugs.gnu.org; Mon, 10 Oct 2022 04:52:01 -0400
Received: from sonic309-20.consmr.mail.ne1.yahoo.com ([66.163.184.146]:41301)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <luangruo@HIDDEN>) id 1ohoVx-00018s-Qq
 for 58406 <at> debbugs.gnu.org; Mon, 10 Oct 2022 04:51:58 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1665391911; bh=a1LBcg5Rm4qKQ3fIj/YwXyrS5LE18rKUPvpkQFiksdA=;
 h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To;
 b=iHcnvwtYVfF/Wvo7puo7gn/mid6OgG805gZslW2P1ylHwKX0lAxPY/1WvqaX2uXeJtFjrqsG6v2HY533jQh+mc4X/vmf8Jl4bv9Eb5w2H6O54NMn3GD2snufuRlwNDoMVNFQG6+94OmNjHahnM4yMAVD8tkaZFi8w/nWDs03tiKl3ILbesJ22blY+bp1koXtkyjEQdr9AG4lv9CQ+ys9cFEHsxObuAysbjh14l0oNtRBvVXUWOA3KOS8eaplKytuzo4/6DOrvs1SZqym/muP7Hbp6iIWxV7ngousDq6hFJOfR9Ap7vmeEOH9opDU9YezuTM7+6LHBl+LYlkqil1/hg==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1665391911; bh=eHTJpuaa0ZPrHWRgJ6jW4gY/365zgeV5yCxzq4COVqz=;
 h=X-Sonic-MF:From:To:Subject:Date:From:Subject;
 b=muE9FMlkhxT2JS1rWUS7HQCepII8bSAq2BULjwdudBZ9lXRliR/xqlPosOrW/ZxTmYzhcFCfjrpyyuQtUR7XFGQGHCYsA4KysPypgu6vY8Qwd21jxhKi+Ui/I5ag2/FJlxMpQ5jlDZ5WiYkF95qWygl/HbtE7vgreviYxG0CvvScjeWellr+Vid15zb6mTmTMF/DXNE6MfjEVTPZbxuxMWbTqpGmz90uHwkepABdRlrvU6YAnZYPBVPFM/lVcMx2aES1omLyCF6VOVG7otz0Oz8U67b9KCspNtv5C+qeR1zyWKBMs62rWRd5toicwjHid52UZj+z8PSgmP88uKYgKw==
X-YMail-OSG: lpejnPgVM1mJ7y7Fhv8TIg1LovIt33gjtxJFR15ezsFsqrhGVLoASha7RxJddtD
 SrQI5KfPadweE5V3X1nOqhPrlUWpA3KrN0vXpu6Lo1MG5wXAxy3in2PqViyeVfiK20aX.nNb.k_I
 VPWhQL.yvylY3Pci7eTu_mHe40nO819J44c7ik1KVpCDqq0M0UfbkqZ.B8tebuSMLqpy1z4831d1
 5.AncU2sjePQVJjCkmoasi8GGQ6GmwjL46n.0uQhWVBiNOiTzZEoV_BfKGnq7asXNr.oEtPSolRJ
 nbd3cpdqZnsM.PYA8Bv0QVpDtVcsJfb8Sun7CYPWs055uoDzqgopJwCTDDuSFRYmgNLmBIIZG4dQ
 oI.C96isKCz_PKw0oNUVS1nc_nyT6iUBimnChV.LsXnB2zQAYdyb98q959pCpQs3hLu7dOfrH.RP
 UtFts3DLcRHiIzWgiB0KVmIxuBlnAh6dcqK9VknIUMD1gyKiUktiPlDpdmraTGlVy_Yuvbw6DQIq
 ePEZ45nycwGAWcNXYsznjH4jEjGLVSblJ6Rqu2oGgs7HNYB7yVLHYp5qrkVUqmXodjAJQh70fmzy
 8AhZQK6Xyfaph.VHJ5QevTma4ArDiaUTmZbRvAWBke8oba.tywyaX8PFh3dd0CwdPBoa5yu67RQF
 CsBKgBVUwwG_08WOoFYNoasrtT.aLPIFHd9EbBQFBeDjmDkXs4yJJ7YpbAyGdZ7oRN70CTtwql14
 SoaByCoef1G5Fn7Ak5AsL26MPcLCCyLe1ov8Y2h9cEhh_fy3fITB01LfSNu2N34SyJR6Noc7B2D_
 5loKoy.7MktIRnwJnMa37cxrwRtvzlIGqrr0VBd2CAHNxnOZO_qZvdEdHCGG5yqMKU9jDTq6M_xx
 H1RMFfimqX3I4F1KHvy8hk9fe6fVx_Ey_TyD.C9XQhRyfTbER0j0PTdYEmyuq4CLLInMm02niY2E
 tmnMCBRmuDhDyfj5mK5x5sOMdbDUEiehMihMEwqE6KKCT6DvW0gcK9qcrx9lkFrgXA0FIZj.1ZGE
 I1Xnk.nPC3t3MHTPgOLqb8wx2mjPck4QJLcR7z3ymVPmki9mnvteat.e68p5FGujYK5oVTs18i0F
 u9RA5DCQ0RvwwUQeOGQ8mebYXVJXcbjflyzkY_aAHdh._PqLLm9Lf0Sat7fKv86JHpAM9O4fgeCx
 g8udO7CRWD1NBWFSnrZ2UmnK8VvHUb6UpAyAqHXzSi6irdn7YYBImzMyKfcN7dza.53Alq35fRlC
 dKYEle2LyYIl.qIeQSr672gcYbcYKneDWwfcwssEmMq5KPOmxwBkUn2xASR.JhKq9MhdNhK4NzkS
 tmUwvyKPPdyXiJGc7x_ToB_Zd3tPuNYylDTFI3yDN510zyHN8e4JRM6sMIssM8wQXYrB5Z6cabxL
 o2boOy5Ji8preqhBJl3alRAE1YjTN5EqXr820KlGb24p1p.lrAAELTmNxcBJKdmprKJjaVoO5D3i
 EzdRkBIWC.9GGSaZ3KNsB6q3deM0Xn4vYkBHhV21WPUfXhKNsRWO4bLGJHzHfmpsVmQk.uCwWiyv
 K6VnWTZqomHjt3u4DyxFDK14tjzKE93n1r_vY5W52dc390R16vYT67XkK9PxRfh2A8bq3yZSRqZH
 Caec9.OQ0JDCYWw_Pce0TW_1S7wUFnNqWCXx22RDjMt4b19Pegb0SFrnUVLPRak5owgcmdgCOiOZ
 UuFhDoIOHq1CburzjIuDWA0HdD.t4UEhAumKnMwjTq9WK5m01eDQ9vAbMBYTMg8w.RzVAlEV92JQ
 1hRfeHlUtkKobN0kocbJCp5.3HxgdZO9hj8hs50.gYkbL80IeIsrY0nxPJGwPN9eoxjssY2QmR80
 5TF1UDBOqq6pLu_avmyiHZL5zE00t2NVBrw.k0WzbPHL3vYZ73FEJrxFtV7q.5ut4fGLjh2QmcBR
 en8dTxKDIENXCtIUv4HZHA45F7twOyueJ8bUWdZ6892CLA60o8q_6bGw4v9235l32ABSiQFc155t
 2U0ZuhNk29K.8gKfZcY1LC6DnMRhzGCkQAocyiuW1eFEOnhwJnqjuQPMZe88IDQPVfLJh8ipj.PP
 E_VkFk3bpe9c_v1c6lxIjwG_niEtihRYkirYFQUbpUBLvo6W83aNk6y1AMi9cL4rfqKZD4BeN5wM
 H4CubZdugfQwf6wl.SeH5AfQW4Vs2cTXzg7vwhyP55mVekWuVtlcZFaV_oNy7d2ofGg3h4ZlFtNI
 PlAXZDFx_vhQAR4UjLvy0JKj5AQUwRjIVb3CpXvHd6OfsovUNa3zvDstcZMqlbWUmYnyMmdXLoc0
 -
X-Sonic-MF: <luangruo@HIDDEN>
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic309.consmr.mail.ne1.yahoo.com with HTTP; Mon, 10 Oct 2022 08:51:51 +0000
Received: by hermes--production-sg3-7794f55d99-vtvjs (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 9e38578f86ef6b32ab33c388af94002c; 
 Mon, 10 Oct 2022 08:51:44 +0000 (UTC)
From: Po Lu <luangruo@HIDDEN>
To: Manuel Giraud <manuel@HIDDEN>
Subject: Re: bug#58406: 29.0.50; Bars refactoring?
References: <87a6641648.fsf@HIDDEN> <87bkqkm777.fsf@HIDDEN>
 <87tu4cyszl.fsf@HIDDEN>
Date: Mon, 10 Oct 2022 16:51:40 +0800
In-Reply-To: <87tu4cyszl.fsf@HIDDEN> (Manuel Giraud's message of "Mon,
 10 Oct 2022 10:37:18 +0200")
Message-ID: <8735bwm57n.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Mailer: WebService/1.1.20702
 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo
Content-Length: 1112
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 58406
Cc: 58406 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

Manuel Giraud <manuel@HIDDEN> writes:

> mouse over highlight: like the relief on tool bar button or, even
> better, with highlight face like on the modeline.

I'm afraid I don't see the utility of that in a menu bar, since it
doesn't consist of "buttons" in the sense that the tool bar or tab bar
do, and no program does that anymore.

> I understand that it is too close to Emacs 29.  Do you think the menu
> bar could be made to mimic some feature of the tool bar (like tab bar
> did)?  Or do you think it would add to the cargo cult?

I'd rather not touch any of the *bar code before Emacs 29 is cut.  Most
people do not use the bars, leading to many latent bugs.  Examples:
mouse face not being cleared when tooltips are enabled and the mouse
moves outside the frame, last_tool_bar_item not being cleared in the
same case, and last_tab_bar_item not being cleared, leading to mouse
highlight not working after the mouse is released outside a frame.

These bugs are particularly nasty because they only happen in rare
situations, but can completely ruin the visual appearance of a frame
when they do.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#58406; Package emacs. Full text available.

Message received at 58406 <at> debbugs.gnu.org:


Received: (at 58406) by debbugs.gnu.org; 10 Oct 2022 08:45:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 10 04:45:37 2022
Received: from localhost ([127.0.0.1]:45934 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ohoPo-0000xj-NT
	for submit <at> debbugs.gnu.org; Mon, 10 Oct 2022 04:45:37 -0400
Received: from eggs.gnu.org ([209.51.188.92]:35756)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1ohoPm-0000xW-Le
 for 58406 <at> debbugs.gnu.org; Mon, 10 Oct 2022 04:45:35 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:43192)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1ohoPg-0004wj-Kn; Mon, 10 Oct 2022 04:45:28 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=KkxhU/eRxyivyKIi77tWtPbeYmd/ZAD8Ibsxvp1HsuI=; b=qjhaOvjxDx+u
 0qzC7DGkt70l9nRvxgqrumMcRIm61iM5yP4AZkWv+sywLuE3JtMdEOJTiKvVHLiQK8fdSqAV3HVw0
 CSM6gP5c6qn5UvqCIFV3WlKURZULZzEyjvYixQiM1YuzeIidRqwmOszprQEamIk7zHe0JwucuJfwH
 Q2ckhWs8G4Sz3lyvWoYQtcq29n3uBcuCtgfKhVXq6ToGDKxQTeryfqtLR2EeMtJyXE9yl2hKVZIi9
 MtTOAtsZD1ww7faVTKKViIQDR8TfCVnB/qu6uwwdqlsdEy7DEsmidwtxEv4B9Cy+KvFiKoNrZ5Zlp
 ZDXAQD8yXUn9vFx/Vr+g5A==;
Received: from [87.69.77.57] (port=3543 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1ohoPd-0003Ny-Fh; Mon, 10 Oct 2022 04:45:27 -0400
Date: Mon, 10 Oct 2022 11:45:31 +0300
Message-Id: <83y1togj84.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Manuel Giraud <manuel@HIDDEN>
In-Reply-To: <87a6641648.fsf@HIDDEN> (message from Manuel Giraud on Mon, 
 10 Oct 2022 09:37:43 +0200)
Subject: Re: bug#58406: 29.0.50; Bars refactoring?
References: <87a6641648.fsf@HIDDEN>
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: 58406
Cc: 58406 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

> From: Manuel Giraud <manuel@HIDDEN>
> Date: Mon, 10 Oct 2022 09:37:43 +0200
> 
> I'm trying to have some kind of highlight feature on the no-toolkit menu
> bar.  As this feature is already present in tool/tab bar, I'd like to
> mimic those.
> 
> While trying this, I think that I found that some "bar" functions could
> be factorized (up to a certain point I guess).  Here is a patch that
> shows my direction.
> 
> Do you think that this approach could make it into master or would it be
> frown upon?  And if so, what would be a better way?

The approach is OK, and welcome.  But let's please wait with this
refactoring until after the emacs-29 branch is cut.  OK?

Some minor comments below:

> +  /* Get the text property `menu-item' at pos. The value of that
> +     property is the start index of this item's properties in
> +     F->tool_bar_items.  */

The "F->tool_bar_items" part of the comment is outdated.

Also, our style is to leave two spaces between sentences in comments
and documentation.

> +  /* Get the start of this tool-bar item's properties in
> +     f->tool_bar_items.  */

Likewise here: outdated reference to tool_bar_items.

> +  /* Is mouse on the highlighted item?  */
> +  if (bar == TAB_BAR)
> +    return *prop_idx == f->last_tab_bar_item ? 0 : 1;
> +  else if (EQ (window, hlinfo->mouse_face_window)
> +      && *vpos >= hlinfo->mouse_face_beg_row
> +      && *vpos <= hlinfo->mouse_face_end_row
> +      && (*vpos > hlinfo->mouse_face_beg_row
> +	  || *hpos >= hlinfo->mouse_face_beg_col)
> +      && (*vpos < hlinfo->mouse_face_end_row
> +	  || *hpos < hlinfo->mouse_face_end_col
> +	  || hlinfo->mouse_face_past_end))
> +    return 0;

The "else if" clause should only be used for the tool bar, not for the
menu bar, AFAIU.

> @@ -15485,6 +15451,7 @@ handle_tool_bar_click_with_device (struct frame *f, int x, int y, bool down_p,
>    Mouse_HLInfo *hlinfo = MOUSE_HL_INFO (f);
>    struct window *w = XWINDOW (f->tool_bar_window);
>    int hpos, vpos, prop_idx;
> +  bool close_p;

The value of this is ignored here, so it is better to call this
variable 'ignored' or 'dummy' or something to that effect.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#58406; Package emacs. Full text available.

Message received at 58406 <at> debbugs.gnu.org:


Received: (at 58406) by debbugs.gnu.org; 10 Oct 2022 08:37:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 10 04:37:24 2022
Received: from localhost ([127.0.0.1]:45905 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ohoHs-0000jb-Hk
	for submit <at> debbugs.gnu.org; Mon, 10 Oct 2022 04:37:24 -0400
Received: from ledu-giraud.fr ([51.159.28.247]:40026)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <manuel@HIDDEN>) id 1ohoHq-0000jS-Km
 for 58406 <at> debbugs.gnu.org; Mon, 10 Oct 2022 04:37:23 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=aMqrMHlHXJjtiK9I
 B5ntIRaviuvK5kELCLEv8j9Bk7w=;
 h=date:references:in-reply-to:subject:
 cc:to:from; d=ledu-giraud.fr; b=Erx1mzOfRTXgU/bR7nn7LY3Kamkuj7g3BCuLir
 WbqzrZ9iDkCTfIbUJhgYKm2YuiNQhseBbSwrwbvsA2iaQ/ZCeU2fdnK7raNbe8pZ5S4HqJ
 efRH+U56Wj7Xy60EiI60fmQBzDWuQ/PDiXspyYNooKrsW8pTAIEUEiHrORzu40o3WvU0ZZ
 v0b5uZnEwwvZ9cKRdJKtgJU9NpmHaSyTsD/47/AhLhuuq1Vy9Y0ZF5gvzg8RJGkS4+J8Sp
 9I6k93s2BXEWW7Wn59WnadA6JYk/PMD2Z5iqUpFfsaqxSSO9AzdznbbEa8wCwhC+65/4HJ
 cOzmQkSpu1np4kxZpGtvQI9w==
Received: from elite.giraud (<unknown> [10.1.1.1])
 by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id d7c67829
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Mon, 10 Oct 2022 10:37:19 +0200 (CEST)
From: Manuel Giraud <manuel@HIDDEN>
To: Po Lu <luangruo@HIDDEN>
Subject: Re: bug#58406: 29.0.50; Bars refactoring?
In-Reply-To: <87bkqkm777.fsf@HIDDEN> (Po Lu's message of "Mon, 10 Oct 2022
 16:08:44 +0800")
References: <87a6641648.fsf@HIDDEN> <87bkqkm777.fsf@HIDDEN>
Date: Mon, 10 Oct 2022 10:37:18 +0200
Message-ID: <87tu4cyszl.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 3.3 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: Po Lu <luangruo@HIDDEN> writes: > Manuel Giraud
 <manuel@HIDDEN>
 writes: > >> I'm trying to have some kind of highlight feature on the
 no-toolkit
 menu >> bar. As this feature is already present in tool/tab bar, I'd like
 to >> [...] 
 Content analysis details:   (3.3 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 2.6 RCVD_IN_SBL            RBL: Received via a relay in Spamhaus SBL
 [51.159.28.247 listed in zen.spamhaus.org]
 0.1 URIBL_SBL_A Contains URL's A record listed in the Spamhaus SBL
 blocklist [URIs: ledu-giraud.fr]
 0.6 URIBL_SBL Contains an URL's NS IP listed in the Spamhaus SBL
 blocklist [URIs: ledu-giraud.fr]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
X-Debbugs-Envelope-To: 58406
Cc: 58406 <at> debbugs.gnu.org, Manuel Giraud <manuel@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.3 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Po Lu <luangruo@HIDDEN> writes: > Manuel Giraud <manuel@HIDDEN>
    writes: > >> I'm trying to have some kind of highlight feature on the no-toolkit
    menu >> bar. As this feature is already present in tool/tab bar, I'd like
    to >> [...] 
 
 Content analysis details:   (2.3 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  2.6 RCVD_IN_SBL            RBL: Received via a relay in Spamhaus SBL
                             [51.159.28.247 listed in zen.spamhaus.org]
  0.1 URIBL_SBL_A            Contains URL's A record listed in the Spamhaus SBL
                             blocklist
                             [URIs: ledu-giraud.fr]
  0.6 URIBL_SBL              Contains an URL's NS IP listed in the Spamhaus SBL
                             blocklist
                             [URIs: ledu-giraud.fr]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

Po Lu <luangruo@HIDDEN> writes:

> Manuel Giraud <manuel@HIDDEN> writes:
>
>> I'm trying to have some kind of highlight feature on the no-toolkit menu
>> bar.  As this feature is already present in tool/tab bar, I'd like to
>> mimic those.
>
> What kind of highlight?

mouse over highlight: like the relief on tool bar button or, even
better, with highlight face like on the modeline.

>> +enum bar_type
>> +  {
>> +    MENU_BAR,
>> +    TAB_BAR,
>> +    TOOL_BAR
>> +  };
>
> These enums are definitely named too generally.  They could conflict
> with other libraries down the road.

Ok.

[...]

> Why ENUM_BF?

A mistake.  I thought it was the way to use enum types in emacs.

> BTW, I really don't recommend doing this kind of refactoring so close to
> cutting the Emacs 29 branch.  Last year I and Alan Third found and fixed
> several obscure bugs related to the tab bar code being a poor cargo cult
> of the tool bar code, introducing subtle differences between both pieces
> of code.  Any refactoring there is likely to introduce more bugs, or to
> reintroduce old ones, and those bugs are much too subtle to find before
> November (or even February.)

I understand that it is too close to Emacs 29.  Do you think the menu
bar could be made to mimic some feature of the tool bar (like tab bar
did)?  Or do you think it would add to the cargo cult?
-- 
Manuel Giraud




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#58406; Package emacs. Full text available.

Message received at 58406 <at> debbugs.gnu.org:


Received: (at 58406) by debbugs.gnu.org; 10 Oct 2022 08:09:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 10 04:09:02 2022
Received: from localhost ([127.0.0.1]:45836 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ohnqP-0006EQ-Rb
	for submit <at> debbugs.gnu.org; Mon, 10 Oct 2022 04:09:02 -0400
Received: from sonic311-23.consmr.mail.ne1.yahoo.com ([66.163.188.204]:37304)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <luangruo@HIDDEN>) id 1ohnqN-0006Dq-JN
 for 58406 <at> debbugs.gnu.org; Mon, 10 Oct 2022 04:09:00 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1665389332; bh=m2gKyl0L6pmE5h3EgmUMKqQiagQpXCkPNQSD39orkh4=;
 h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To;
 b=VcMIKqTxoeZE+sku2m0wfw9Dc1FEmsaSC3xh7qQJkhMweemxYtLlb5BxBgXurfaziSklcrBOphcNbwy62CMkSr7/NUNMXdjmGeBdyf8bVXP06L6MROxh5TuEK+TbZpQLp5gZYbUL74BTz4U8Yo8uURyLe3nyzSipdUGm0Ay0Ub7DW2VvOXZlVvnvZGtwBREIpqhT8VfiIM0cJdpclz+CXLo0R0b7erVnh1ZtMPJR1GsFOnHOwd13mQmzBG0gZd57TaHs4Tca8FY4wsfsUwJ6BEUjlm+xv5mmENiSvg431z+32gewLn0loLjr0yqTSJEB+uYFy+Kv6y4R0jp+sxO8dQ==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1665389332; bh=cy92M79gMD+AZJzAU4UyByGEF7mHKJy3dth8VUILFvU=;
 h=X-Sonic-MF:From:To:Subject:Date:From:Subject;
 b=YvJioCGRAjNNUDHYX3fpt7WZQ6OMcTrR3VfaYYwcXBbENDU+gkMYJJtxyK0TGOw0TyWol1AagFZxHSGrlKpZmhapyl9HTTnt+e51tgRX10rlnTRkrY0PF4YQVMNXEpDnM0reWSDfkhmKjZMGlbdKL11RVTJZvelciBteeTEjKnXNLrDR0fG8lp6KiKjriIBPWpOWzUhlen7VXAXQkBkNBpPfF4pJAxloj0lBImL+/RBJZm/jD0tV1jxGU9Ji3fgLltiz86TGU3aX16OHsO8YMMqxowQYHWi5hoWTTqBIoGwGDIQdIO6JsiWYnAT5kiV4pd5hPra9fbnQaTY5QC8Luw==
X-YMail-OSG: ZS_TGXMVM1nUMUCUv5PZJX8r10FH86PngdGe_vCHmBH2BXsxnKTXv9DlvKjxG4Z
 iDEovRcE9kkxt9JcGE532tlzh2vFH4HDFo05URndaztdCuYdk8KtKQZZ6RSgmpIsRWzG4JpVqviQ
 Ssj.ad72Bv.27_eDECJ8LwAVEyKrUjpB6fweGrwGaQTEoqJju_rezgoeyquW4JWgmVd0Fj_caOgt
 csdtb4f9bW3p59TQrEGnK4oPyO2aYAFqganXCMhfEgGaq.pYmYiEyO.ufgbHkMk3OvnfKmeKcYSM
 PnOHA6nZkIETitv7X9T4ppEuwdrJ4SkffoB1OlSo2Hkb3VmGzAFlMgVFkTvvLi0ppDVSbYtcNUG2
 kto20o5w2VvWzl_ardjSAFnLsVCIaiBXtJMbvlhKOSgatVOxzkGpsgL1DvePIopA_rWVq3DgVBig
 WIn.V2qE.nk6M7mQIS_qe9NBWdQpZZ7muV7TL6802LHi27dLQZ50aU6gG2mXGAP9yL0dgvB6dTv2
 skeQ_zqtEGBJ8GoYPBNlIqC6_UHD3DgVSpT5m83ilrqOY3pTQ6hnRc0XBZyugJ_Yew9JRxHyMHde
 QLOsuwqi1li53hVYesyvFM_eeHPsy79jeZPwAPrke3mZsdyqlZM6OLOXeKW64sYOhUt2CbGbBezI
 .IOGbgE7z_8EH_LP.voSy1hv.HDMPv3_rt5chSevCGMSzr89LZiK7axjOmrgFfMwhcxi2vyW90kZ
 q.EET36e0GjWKEIFBdpqCl_3vgRboK.LHMYteIvkM8c6orVDZkLAprauYRQvwMa.De.9u2bDEiGF
 YGgoPCViE6BCU78a2Fsn0g42fYghpRVGtdvxOxH4bTG2hnKSNFgoM5q9aL5hBmozF5lfC_1UQnob
 .JzsHlzefj5yvMnVodoEcJTXaFS2oIRu2lrC54Y3JDYi1h47cc5LLuRvH3X4G.TCZ0qHjvptqLwK
 RtMWth_jqcNo8W7YASUyk9mpy7GSi024GyfFOh3gR8HDg6r3hnvuqtO1_I3SZKO8Ln2hl3oxf2UC
 4MEQrtcskwLrTtFTLoqQqhOKYULyQMt3QxTjQOJkGmzxxGo.yUuVdfUCpZnWwiFk2l7j7kpAq5ZY
 3i4n72d5fPcYPxSyyIIe31xK.6QoVnSVNknlr8OB.GsqfEyjCJGSXLQn.1l9RI5GdTllgPKt0y_c
 x4AtS6vpKDuViLlFXd.op9PDBG80qirBH85rPZkd_NKfhuSOKcngzZrd3WRNtC7cD1J5fEonGiHJ
 W6BYaQ0uT0HdqYZwOmpg7oHIIb8fHWvbjpX6mgeR.YeFVctqk5VLXNvU7ldaAuetXsL9x.fYuGKa
 7HZj_dCO.cvp79N4DkpKRvt1ofDcUWuwr_DLyn6T9v9jdnsT_jVSQOHCGeFtZaG7mle3DsYgHcf7
 CPIPT00u4JsNcLyhp2GnlhCzjlBRjsfntCD8az4gx5txszfD07TYbUG1IavBLLvIgSgmZ49HxpIj
 7GBHZEJxTAowa9l5cDDKk4LfC6xllEPqo6gOea92PJpxqbdlhLCUs7gNGPMW.gXgDpjZzJqBur35
 CQFi1cARl28KHfW5TJ6RYzNa4mmmjzoFLKACer2J96uV1OUqTaBFXl0fOe_rT1ZJWEeafdeNOi3L
 2qpV6EWvD.CdujlIYldDzLEEHe2Guf.fgm61wkWAHfWh4lekZ4jw9X49MyxKRs4CzkPMeU_ri4H9
 NB.m7Lyf8NWGinCIqcaQlIr2eYNIMR.fB3EFQtH73fd8jA92XK6iYU4l_D.eC7CD501DQwyrUhB4
 8rhEjtyBSlBpg2ITzfnfuMOg6EmTLfnIfHVEE.aJGAHcQ2XQdImhuatL0nTdIpve3XGz5xDw6aC4
 Tcru1EK_YUgKZdiBqAlPXtg1UaUxMniNgxaPnUMjxdhjVnunDlLRlyyv0NY15OkG6nCkvkYCz2PS
 nGkVygecWReW6vDVQoRuXO0EydRkUvQPBmXeKZJKxEpnwOjfoahAC6wMpb4teQO.Oekdjg59h9O7
 5_qmsqNo21Iv9Z64AW6SSsZaP3fQit4zPDuZyq2xINCyMXLLJTrI18u2.IxixIwBkz2GFyfc50gi
 XYZduC9JvwMOuhYb0ehQbjA0mAlJB4FiSW2_udtTK_pvNWhXQxoRWYUc3p3Jx9hFtskWrn8c6Owe
 EhGzxgjebEynkPmD8EbbEjatsSUX6i7MuLRCR3_oVPzXjAifujZftxhleIEnnSO8Q12OosITXSIE
 Z.9P9GNTWebGnocPpRLpdV.ZZJbs8VwgzFI3mujiRHPw6DP8xF7DPIj4tpIV51HmN7tivgSnan9g
 Xgg--
X-Sonic-MF: <luangruo@HIDDEN>
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic311.consmr.mail.ne1.yahoo.com with HTTP; Mon, 10 Oct 2022 08:08:52 +0000
Received: by hermes--production-sg3-7794f55d99-zgcwh (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID eb91fd9854cc89c3c315473ae1dda635; 
 Mon, 10 Oct 2022 08:08:49 +0000 (UTC)
From: Po Lu <luangruo@HIDDEN>
To: Manuel Giraud <manuel@HIDDEN>
Subject: Re: bug#58406: 29.0.50; Bars refactoring?
References: <87a6641648.fsf@HIDDEN>
Date: Mon, 10 Oct 2022 16:08:44 +0800
In-Reply-To: <87a6641648.fsf@HIDDEN> (Manuel Giraud's message of "Mon,
 10 Oct 2022 09:37:43 +0200")
Message-ID: <87bkqkm777.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Mailer: WebService/1.1.20702
 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo
Content-Length: 1386
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 58406
Cc: 58406 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

Manuel Giraud <manuel@HIDDEN> writes:

> I'm trying to have some kind of highlight feature on the no-toolkit menu
> bar.  As this feature is already present in tool/tab bar, I'd like to
> mimic those.

What kind of highlight?

> +enum bar_type
> +  {
> +    MENU_BAR,
> +    TAB_BAR,
> +    TOOL_BAR
> +  };

These enums are definitely named too generally.  They could conflict
with other libraries down the road.

> +/* Get information about the bar item which is displayed in GLYPH on
> +   frame F.  Return in *PROP_IDX the index where bar item properties
> +   start in the bar items.  For TAB_BAR, return in CLOSE_P an
> +   indication whether the click was on the close-tab icon of the tab.
> +   Value is false if GLYPH doesn't display a bar item.  */
> +
> +static bool
> +bar_item_info (ENUM_BF(bar_type) bar, struct frame *f, struct glyph *glyph,
> +	       int *prop_idx, bool *close_p)

Why ENUM_BF?

BTW, I really don't recommend doing this kind of refactoring so close to
cutting the Emacs 29 branch.  Last year I and Alan Third found and fixed
several obscure bugs related to the tab bar code being a poor cargo cult
of the tool bar code, introducing subtle differences between both pieces
of code.  Any refactoring there is likely to introduce more bugs, or to
reintroduce old ones, and those bugs are much too subtle to find before
November (or even February.)




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#58406; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 10 Oct 2022 07:38:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 10 03:38:10 2022
Received: from localhost ([127.0.0.1]:45760 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ohnMX-0005PQ-85
	for submit <at> debbugs.gnu.org; Mon, 10 Oct 2022 03:38:10 -0400
Received: from lists.gnu.org ([209.51.188.17]:49030)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <manuel@HIDDEN>) id 1ohnMU-0005PG-E8
 for submit <at> debbugs.gnu.org; Mon, 10 Oct 2022 03:38:07 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:37962)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <manuel@HIDDEN>)
 id 1ohnMU-0001ok-4p
 for bug-gnu-emacs@HIDDEN; Mon, 10 Oct 2022 03:38:06 -0400
Received: from ledu-giraud.fr ([51.159.28.247]:9704)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <manuel@HIDDEN>)
 id 1ohnMQ-0002lm-96
 for bug-gnu-emacs@HIDDEN; Mon, 10 Oct 2022 03:38:05 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=HJNV/RWMobN9FuQ8
 HhC35ZqM6fyWqDRpBZQ8x6kcr0M=; h=date:subject:to:from;
 d=ledu-giraud.fr; b=cuT8B5SZoCcE+55wNvGw4y5JHfHcOcusMQACyURiBe6MnUUsGg
 UcH4GP3P+/vcNU4VnmFWU3cbzK43FRoIxhHhQD2cJQ3L41Uy0CQX8HBfwKzfgvdmQwyB3s
 kA0PZIg1+r6IWvTzb0DHxxNdOndOPAQ8suMe+CKVfRc+NHdI1oppASclQ78UULZxu1MuWo
 B9qp7ZpXqPUpbORpTZ6KKktFjoWdWEamE8wNbe4r7cHPK3wkqjikIRaV6yztZocQybFLl9
 E9J7bbN3ziGUYbc1Ih+tCToOtm/4o6f5rhMURlMSCGylj3EXP6Y0v7NFTWU6TfV2k4Ur8H
 riLO080nzHZA==
Received: from elite.giraud (<unknown> [10.1.1.1])
 by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 432ee3fc
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <bug-gnu-emacs@HIDDEN>;
 Mon, 10 Oct 2022 09:37:44 +0200 (CEST)
From: Manuel Giraud <manuel@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 29.0.50; Bars refactoring?
Date: Mon, 10 Oct 2022 09:37:43 +0200
Message-ID: <87a6641648.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@HIDDEN;
 helo=ledu-giraud.fr
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_SBL=0.141,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
 URIBL_SBL_A=0.1 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Hi, I'm trying to have some kind of highlight feature on the
 no-toolkit menu bar. As this feature is already present in tool/tab bar,
 I'd like to mimic those. While trying this, I think that I found that some
 "bar" functions could be factorized (up to a certain point I guess). Here
 is a patch that shows my direction. 
 Content analysis details:   (2.0 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 2.6 RCVD_IN_SBL            RBL: Received via a relay in Spamhaus SBL
 [51.159.28.247 listed in zen.spamhaus.org]
 0.1 URIBL_SBL_A Contains URL's A record listed in the Spamhaus SBL
 blocklist [URIs: ledu-giraud.fr]
 0.6 URIBL_SBL Contains an URL's NS IP listed in the Spamhaus SBL
 blocklist [URIs: ledu-giraud.fr]
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 0.9 SPF_FAIL               SPF: sender does not match SPF record (fail)
 [SPF failed: Please see http://www.openspf.org/Why?s=mfrom;
 id=manuel%40ledu-giraud.fr; ip=209.51.188.17; r=debbugs.gnu.org]
 -2.3 RCVD_IN_DNSWL_MED      RBL: Sender listed at https://www.dnswl.org/,
 medium trust [209.51.188.17 listed in list.dnswl.org]
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)

--=-=-=
Content-Type: text/plain


Hi,

I'm trying to have some kind of highlight feature on the no-toolkit menu
bar.  As this feature is already present in tool/tab bar, I'd like to
mimic those.

While trying this, I think that I found that some "bar" functions could
be factorized (up to a certain point I guess).  Here is a patch that
shows my direction.

Do you think that this approach could make it into master or would it be
frown upon?  And if so, what would be a better way?

Best regards,

--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=0001-start-bars-refactoring.patch

From cc5a4e5702c4eeb427d91776204b844ceda61a32 Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@HIDDEN>
Date: Sun, 9 Oct 2022 13:27:31 +0200
Subject: [PATCH] start bars refactoring

---
 src/frame.h |   7 ++
 src/xdisp.c | 280 ++++++++++++++++++++++++----------------------------
 2 files changed, 137 insertions(+), 150 deletions(-)

diff --git a/src/frame.h b/src/frame.h
index 458b6257e4..4c78f0a555 100644
--- a/src/frame.h
+++ b/src/frame.h
@@ -76,6 +76,13 @@ #define EMACS_FRAME_H
 #endif
 #endif /* HAVE_WINDOW_SYSTEM */
 
+enum bar_type
+  {
+    MENU_BAR,
+    TAB_BAR,
+    TOOL_BAR
+  };
+
 /* The structure representing a frame.  */
 
 struct frame
diff --git a/src/xdisp.c b/src/xdisp.c
index 9534e27843..a822b0fe1c 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -13524,6 +13524,110 @@ gui_consider_frame_title (Lisp_Object frame)
 
 #endif /* not HAVE_WINDOW_SYSTEM */
 
+
+/***********************************************************************
+			      Generics for Bars
+ ***********************************************************************/
+
+/* Get information about the bar item which is displayed in GLYPH on
+   frame F.  Return in *PROP_IDX the index where bar item properties
+   start in the bar items.  For TAB_BAR, return in CLOSE_P an
+   indication whether the click was on the close-tab icon of the tab.
+   Value is false if GLYPH doesn't display a bar item.  */
+
+static bool
+bar_item_info (ENUM_BF(bar_type) bar, struct frame *f, struct glyph *glyph,
+	       int *prop_idx, bool *close_p)
+{
+  Lisp_Object prop, string;
+  ptrdiff_t charpos;
+
+  if (bar == TOOL_BAR)
+    string = f->current_tool_bar_string;
+  else if (bar == TAB_BAR)
+    string = f->current_tab_bar_string;
+  else
+    return false;
+
+  /* This function can be called asynchronously, which means we must
+     exclude any possibility that Fget_text_property signals an
+     error.  */
+  charpos = min (SCHARS (string), glyph->charpos);
+  charpos = max (0, charpos);
+
+  /* Get the text property `menu-item' at pos. The value of that
+     property is the start index of this item's properties in
+     F->tool_bar_items.  */
+  prop = Fget_text_property (make_fixnum (charpos), Qmenu_item, string);
+  if (! FIXNUMP (prop))
+    return false;
+  *prop_idx = XFIXNUM (prop);
+
+  if (bar == TAB_BAR)
+    *close_p = !NILP (Fget_text_property (make_fixnum (charpos),
+					  Qclose_tab,
+					  string));
+
+  return true;
+}
+
+/* Get information about the bar item at position X/Y on frame F.
+   Return in *GLYPH a pointer to the glyph of the bar item in the
+   current matrix of the bar window of F, or NULL if not on a bar
+   item.  Return in *PROP_IDX the index of the bar item in bar items.
+   Value is
+
+   -1	if X/Y is not on a bar item
+   0	if X/Y is on the same item that was highlighted before.
+   1	otherwise.  */
+
+static int
+get_bar_item (ENUM_BF(bar_type) bar, struct frame *f, int x, int y,
+	      struct glyph **glyph, int *hpos, int *vpos, int *prop_idx,
+	      bool *close_p)
+{
+  Mouse_HLInfo *hlinfo = MOUSE_HL_INFO (f);
+  Lisp_Object window;
+  struct window *w;
+  int area;
+
+  if (bar == TOOL_BAR)
+    window = f->tool_bar_window;
+  else if (bar == MENU_BAR)
+    window = f->menu_bar_window;
+  else if (bar == TAB_BAR)
+    window = f->tab_bar_window;
+  else
+    return -1;
+
+  w = XWINDOW (window);
+
+  /* Find the glyph under X/Y.  */
+  *glyph = x_y_to_hpos_vpos (w, x, y, hpos, vpos, 0, 0, &area);
+  if (*glyph == NULL)
+    return -1;
+
+  /* Get the start of this tool-bar item's properties in
+     f->tool_bar_items.  */
+  if (!bar_item_info (bar, f, *glyph, prop_idx, close_p))
+    return -1;
+
+  /* Is mouse on the highlighted item?  */
+  if (bar == TAB_BAR)
+    return *prop_idx == f->last_tab_bar_item ? 0 : 1;
+  else if (EQ (window, hlinfo->mouse_face_window)
+      && *vpos >= hlinfo->mouse_face_beg_row
+      && *vpos <= hlinfo->mouse_face_end_row
+      && (*vpos > hlinfo->mouse_face_beg_row
+	  || *hpos >= hlinfo->mouse_face_beg_col)
+      && (*vpos < hlinfo->mouse_face_end_row
+	  || *hpos < hlinfo->mouse_face_end_col
+	  || hlinfo->mouse_face_past_end))
+    return 0;
+
+  return 1;
+}
+
 
 /***********************************************************************
 			      Menu Bars
@@ -14471,73 +14575,6 @@ redisplay_tab_bar (struct frame *f)
   return false;
 }
 
-/* Get information about the tab-bar item which is displayed in GLYPH
-   on frame F.  Return in *PROP_IDX the index where tab-bar item
-   properties start in F->tab_bar_items.  Return in CLOSE_P an
-   indication whether the click was on the close-tab icon of the tab.
-   Value is false if GLYPH doesn't display a tab-bar item.  */
-
-static bool
-tab_bar_item_info (struct frame *f, struct glyph *glyph,
-		   int *prop_idx, bool *close_p)
-{
-  Lisp_Object prop;
-  ptrdiff_t charpos;
-
-  /* This function can be called asynchronously, which means we must
-     exclude any possibility that Fget_text_property signals an
-     error.  */
-  charpos = min (SCHARS (f->current_tab_bar_string), glyph->charpos);
-  charpos = max (0, charpos);
-
-  /* Get the text property `menu-item' at pos. The value of that
-     property is the start index of this item's properties in
-     F->tab_bar_items.  */
-  prop = Fget_text_property (make_fixnum (charpos),
-			     Qmenu_item, f->current_tab_bar_string);
-  if (! FIXNUMP (prop))
-    return false;
-  *prop_idx = XFIXNUM (prop);
-
-  *close_p = !NILP (Fget_text_property (make_fixnum (charpos),
-                                        Qclose_tab,
-                                        f->current_tab_bar_string));
-
-  return true;
-}
-
-
-/* Get information about the tab-bar item at position X/Y on frame F.
-   Return in *GLYPH a pointer to the glyph of the tab-bar item in
-   the current matrix of the tab-bar window of F, or NULL if not
-   on a tab-bar item.  Return in *PROP_IDX the index of the tab-bar
-   item in F->tab_bar_items.  Value is
-
-   -1	if X/Y is not on a tab-bar item
-   0	if X/Y is on the same item that was highlighted before.
-   1	otherwise.  */
-
-static int
-get_tab_bar_item (struct frame *f, int x, int y, struct glyph **glyph,
-		   int *hpos, int *vpos, int *prop_idx, bool *close_p)
-{
-  struct window *w = XWINDOW (f->tab_bar_window);
-  int area;
-
-  /* Find the glyph under X/Y.  */
-  *glyph = x_y_to_hpos_vpos (w, x, y, hpos, vpos, 0, 0, &area);
-  if (*glyph == NULL)
-    return -1;
-
-  /* Get the start of this tab-bar item's properties in
-     f->tab_bar_items.  */
-  if (!tab_bar_item_info (f, *glyph, prop_idx, close_p))
-    return -1;
-
-  return *prop_idx == f->last_tab_bar_item ? 0 : 1;
-}
-
-
 /* EXPORT:
    Handle mouse button event on the tab-bar of frame F, at
    frame-relative coordinates X/Y.  DOWN_P is true for a button press,
@@ -14557,7 +14594,7 @@ handle_tab_bar_click (struct frame *f, int x, int y, bool down_p,
   int ts;
 
   frame_to_window_pixel_xy (w, &x, &y);
-  ts = get_tab_bar_item (f, x, y, &glyph, &hpos, &vpos, &prop_idx, &close_p);
+  ts = get_bar_item (TAB_BAR, f, x, y, &glyph, &hpos, &vpos, &prop_idx, &close_p);
   if (ts == -1)
     return Fcons (Qtab_bar, Qnil);
 
@@ -14624,7 +14661,7 @@ note_tab_bar_highlight (struct frame *f, int x, int y)
       return;
     }
 
-  rc = get_tab_bar_item (f, x, y, &glyph, &hpos, &vpos, &prop_idx, &close_p);
+  rc = get_bar_item (TAB_BAR, f, x, y, &glyph, &hpos, &vpos, &prop_idx, &close_p);
   if (rc < 0)
     {
       /* Not on tab-bar item.  */
@@ -15400,77 +15437,6 @@ redisplay_tool_bar (struct frame *f)
   return false;
 }
 
-/* Get information about the tool-bar item which is displayed in GLYPH
-   on frame F.  Return in *PROP_IDX the index where tool-bar item
-   properties start in F->tool_bar_items.  Value is false if
-   GLYPH doesn't display a tool-bar item.  */
-
-static bool
-tool_bar_item_info (struct frame *f, struct glyph *glyph, int *prop_idx)
-{
-  Lisp_Object prop;
-  ptrdiff_t charpos;
-
-  /* This function can be called asynchronously, which means we must
-     exclude any possibility that Fget_text_property signals an
-     error.  */
-  charpos = min (SCHARS (f->current_tool_bar_string), glyph->charpos);
-  charpos = max (0, charpos);
-
-  /* Get the text property `menu-item' at pos. The value of that
-     property is the start index of this item's properties in
-     F->tool_bar_items.  */
-  prop = Fget_text_property (make_fixnum (charpos),
-			     Qmenu_item, f->current_tool_bar_string);
-  if (! FIXNUMP (prop))
-    return false;
-  *prop_idx = XFIXNUM (prop);
-  return true;
-}
-
-
-/* Get information about the tool-bar item at position X/Y on frame F.
-   Return in *GLYPH a pointer to the glyph of the tool-bar item in
-   the current matrix of the tool-bar window of F, or NULL if not
-   on a tool-bar item.  Return in *PROP_IDX the index of the tool-bar
-   item in F->tool_bar_items.  Value is
-
-   -1	if X/Y is not on a tool-bar item
-   0	if X/Y is on the same item that was highlighted before.
-   1	otherwise.  */
-
-static int
-get_tool_bar_item (struct frame *f, int x, int y, struct glyph **glyph,
-		   int *hpos, int *vpos, int *prop_idx)
-{
-  Mouse_HLInfo *hlinfo = MOUSE_HL_INFO (f);
-  struct window *w = XWINDOW (f->tool_bar_window);
-  int area;
-
-  /* Find the glyph under X/Y.  */
-  *glyph = x_y_to_hpos_vpos (w, x, y, hpos, vpos, 0, 0, &area);
-  if (*glyph == NULL)
-    return -1;
-
-  /* Get the start of this tool-bar item's properties in
-     f->tool_bar_items.  */
-  if (!tool_bar_item_info (f, *glyph, prop_idx))
-    return -1;
-
-  /* Is mouse on the highlighted item?  */
-  if (EQ (f->tool_bar_window, hlinfo->mouse_face_window)
-      && *vpos >= hlinfo->mouse_face_beg_row
-      && *vpos <= hlinfo->mouse_face_end_row
-      && (*vpos > hlinfo->mouse_face_beg_row
-	  || *hpos >= hlinfo->mouse_face_beg_col)
-      && (*vpos < hlinfo->mouse_face_end_row
-	  || *hpos < hlinfo->mouse_face_end_col
-	  || hlinfo->mouse_face_past_end))
-    return 0;
-
-  return 1;
-}
-
 
 /* EXPORT:
    Handle mouse button event on the tool-bar of frame F, at
@@ -15485,6 +15451,7 @@ handle_tool_bar_click_with_device (struct frame *f, int x, int y, bool down_p,
   Mouse_HLInfo *hlinfo = MOUSE_HL_INFO (f);
   struct window *w = XWINDOW (f->tool_bar_window);
   int hpos, vpos, prop_idx;
+  bool close_p;
   struct glyph *glyph;
   Lisp_Object enabled_p;
   int ts;
@@ -15497,7 +15464,7 @@ handle_tool_bar_click_with_device (struct frame *f, int x, int y, bool down_p,
      highlight, since tool-bar items are not highlighted in that
      case.  */
   frame_to_window_pixel_xy (w, &x, &y);
-  ts = get_tool_bar_item (f, x, y, &glyph, &hpos, &vpos, &prop_idx);
+  ts = get_bar_item (TOOL_BAR, f, x, y, &glyph, &hpos, &vpos, &prop_idx, &close_p);
   if (ts == -1
       || (ts != 0 && !NILP (Vmouse_highlight)))
     return;
@@ -15555,11 +15522,10 @@ handle_tool_bar_click (struct frame *f, int x, int y, bool down_p,
    note_mouse_highlight.  */
 
 static void
-note_tool_bar_highlight (struct frame *f, int x, int y)
+note_bar_highlight (ENUM_BF(bar_type) bar, struct frame *f, int x, int y)
 {
-  Lisp_Object window = f->tool_bar_window;
-  struct window *w = XWINDOW (window);
-  Display_Info *dpyinfo = FRAME_DISPLAY_INFO (f);
+  Lisp_Object window;
+  struct window *w;
   Mouse_HLInfo *hlinfo = MOUSE_HL_INFO (f);
   int hpos, vpos;
   struct glyph *glyph;
@@ -15567,10 +15533,22 @@ note_tool_bar_highlight (struct frame *f, int x, int y)
   int i;
   Lisp_Object enabled_p;
   int prop_idx;
+  bool close_p;
   enum draw_glyphs_face draw = DRAW_IMAGE_RAISED;
-  bool mouse_down_p;
   int rc;
 
+  /* Select bar window.  */
+  if (bar == TOOL_BAR)
+    window = f->tool_bar_window;
+  else if (bar == MENU_BAR)
+    window = f->menu_bar_window;
+  else if (bar == TAB_BAR)
+    window = f->tab_bar_window;
+  else
+    return;
+
+  w = XWINDOW (window);
+
   /* Function note_mouse_highlight is called with negative X/Y
      values when mouse moves outside of the frame.  */
   if (x <= 0 || y <= 0)
@@ -15579,20 +15557,22 @@ note_tool_bar_highlight (struct frame *f, int x, int y)
       return;
     }
 
-  rc = get_tool_bar_item (f, x, y, &glyph, &hpos, &vpos, &prop_idx);
+  rc = get_bar_item (bar, f, x, y, &glyph, &hpos, &vpos, &prop_idx, &close_p);
   if (rc < 0)
     {
-      /* Not on tool-bar item.  */
+      /* Not on bar item.  */
       clear_mouse_face (hlinfo);
       return;
     }
   else if (rc == 0)
-    /* On same tool-bar item as before.  */
+    /* On same bar item as before.  */
     goto set_help_echo;
 
   clear_mouse_face (hlinfo);
 
+  bool mouse_down_p = false;
   /* Mouse is down, but on different tool-bar item?  */
+  Display_Info *dpyinfo = FRAME_DISPLAY_INFO (f);
   mouse_down_p = (gui_mouse_grabbed (dpyinfo)
 		  && f == dpyinfo->last_mouse_frame);
 
@@ -35049,7 +35029,7 @@ note_mouse_highlight (struct frame *f, int x, int y)
      buffer.  */
   if (EQ (window, f->tool_bar_window))
     {
-      note_tool_bar_highlight (f, x, y);
+      note_bar_highlight (TOOL_BAR, f, x, y);
       return;
     }
 #endif
-- 
2.37.3


--=-=-=
Content-Type: text/plain



In GNU Emacs 29.0.50 (build 1, x86_64-unknown-openbsd7.2, cairo version
 1.17.6) of 2022-10-09 built on elite.giraud
Repository revision: 300a6ab95ca970899b3fef8852af06d4548d0395
Repository branch: mgi/menubar
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: OpenBSD elite.giraud 7.2 GENERIC.MP#739 amd64

Configured using:
 'configure --prefix=/home/manuel/emacs --bindir=/home/manuel/bin
 --with-x-toolkit=no --without-sound --without-compress-install
 CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib'

Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBOTF LIBXML2 MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG
SQLITE3 THREADS TIFF WEBP X11 XDBE XIM XINPUT2 XPM ZLIB

Important settings:
  value of $LC_ALL: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Dired by name

Minor modes in effect:
  global-git-commit-mode: t
  magit-auto-revert-mode: t
  gnus-dired-mode: t
  icomplete-mode: t
  display-time-mode: t
  display-battery-mode: t
  shell-dirtrack-mode: t
  global-so-long-mode: t
  repeat-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  buffer-read-only: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/home/manuel/.emacs.d/elpa/transient-20220918.2101/transient hides /home/manuel/emacs/share/emacs/29.0.50/lisp/transient

Features:
(shadow sort mail-extr emacsbug whitespace magit-patch magit-extras
misearch multi-isearch bug-reference face-remap magit-bookmark
magit-submodule magit-obsolete magit-blame magit-stash magit-reflog
magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote
magit-commit magit-sequence magit-notes magit-worktree magit-tag
magit-merge magit-branch magit-reset magit-files magit-refs magit-status
magit magit-repos magit-apply magit-wip magit-log which-func imenu
magit-diff smerge-mode diff git-commit log-edit pcvs-util add-log
magit-core magit-autorevert autorevert filenotify magit-margin
magit-transient magit-process with-editor magit-mode transient magit-git
magit-base magit-section dash compat-27 compat-26 compat compat-macs
gnus-dired sh-script smie executable pulse vc-git diff-mode
vc-dispatcher vc-svn shortdoc help-fns radix-tree cl-print paredit
edmacro icomplete time battery exwm-randr xcb-randr exwm-config exwm
exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor
xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb
xcb-xproto xcb-types xcb-debug kmacro server stimmung-themes
modus-operandi-theme modus-themes ytdious osm mingus libmpdee reporter
edebug debug backtrace transmission diary-lib diary-loaddefs color
calc-bin calc-ext calc calc-loaddefs rect calc-macs w3m-load mu4e
mu4e-org mu4e-main mu4e-view mu4e-headers mu4e-compose mu4e-draft
mu4e-actions smtpmail mu4e-search mu4e-lists mu4e-bookmarks mu4e-mark
mu4e-message flow-fill mule-util hl-line mu4e-contacts mu4e-update
mu4e-folders mu4e-server mu4e-context mu4e-vars mu4e-helpers mu4e-config
bookmark ido supercite regi ebdb-message ebdb-gnus gnus-msg gnus-art
mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill
kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus
gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int
gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa epg
rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231
rfc2047 rfc2045 ietf-drums gmm-utils mailheader gnus-win gnus nnheader
gnus-util mail-utils range mm-util mail-prsvr ebdb-mua ebdb-com crm
ebdb-format ebdb mailabbrev eieio-opt speedbar ezimage dframe eieio-base
pcase timezone org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro
org-footnote org-src ob-comint org-pcomplete org-list org-faces
org-entities org-version ob-emacs-lisp ob-core ob-eval org-table
oc-basic bibtex ol org-keys oc org-compat org-macs org-loaddefs
find-func cal-menu calendar cal-loaddefs visual-basic-mode cl web-mode
disp-table erlang-start smart-tabs-mode skeleton cc-mode cc-fonts
cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs
slime-asdf grep slime-tramp tramp tramp-loaddefs trampver
tramp-integration cus-edit cus-load wid-edit files-x tramp-compat rx
shell pcomplete parse-time iso8601 time-date ls-lisp format-spec
slime-fancy slime-indentation slime-cl-indent cl-indent
slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references
slime-compiler-notes-tree slime-scratch slime-presentations advice
bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context
slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c
slime-editing-commands slime-autodoc slime-repl elp slime-parse slime
derived cl-extra help-mode lisp-mnt gud apropos compile
text-property-search etags fileloop generator xref project arc-mode
archive-mode noutline outline icons pp comint ansi-osc ansi-color ring
hyperspec thingatpt slime-autoloads dired-aux dired-x dired
dired-loaddefs so-long notifications dbus xml repeat easy-mmode
auctex-autoloads tex-site boxquote-autoloads debbugs-autoloads
hyperbole-autoloads magit-autoloads git-commit-autoloads
magit-section-autoloads dash-autoloads paredit-autoloads
rust-mode-autoloads stimmung-themes-autoloads transient-autoloads
with-editor-autoloads info compat-autoloads ytdious-autoloads package
browse-url url url-proxy url-privacy url-expand url-methods url-history
url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers
url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache
json subr-x map byte-opt gv bytecomp byte-compile cconv url-vars
cl-loaddefs cl-lib rmc iso-transl tooltip eldoc paren electric uniquify
ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs faces cus-face macroexp files window
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget keymap hashtable-print-readable backquote threads dbusbind
kqueue lcms2 dynamic-setting system-font-setting font-render-setting
cairo xinput2 x multi-tty make-network-process emacs)

Memory information:
((conses 16 783040 73048)
 (symbols 48 57310 3)
 (strings 32 175122 8336)
 (string-bytes 1 5700851)
 (vectors 16 96473)
 (vector-slots 8 1272766 67536)
 (floats 8 572 583)
 (intervals 56 15839 533)
 (buffers 1000 25))

-- 
Manuel Giraud

--=-=-=--




Acknowledgement sent to Manuel Giraud <manuel@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#58406; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 13 Oct 2022 14:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.