GNU bug report logs - #58610
[PATCH] gnu: rust-generic-array-0.14: Fix build.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58610 in the body.
You can then email your comments to 58610 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Cc: Michael Rohleder <mike <at> rohleder.de>
Subject: [PATCH] gnu: rust-generic-array-0.14: Fix build.
Date: Tue, 18 Oct 2022 16:59:43 +0200

* gnu/packages/crates-io.scm (rust-generic-array-0.14)[arguments]: Add #:tests? #false.
---
 gnu/packages/crates-io.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 502972ffc5..afd1305018 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -24886,7 +24886,8 @@ (define-public rust-generic-array-0.14
           "05qqwm9v5asbil9z28wjkmpfvs1c5c99n8n9gwxis3d3r3n6c52h"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:cargo-inputs
+     `(#:tests? #false                  ;doc test fails
+       #:cargo-inputs
        (("rust-serde" ,rust-serde-1)
         ("rust-typenum" ,rust-typenum-1)
         ("rust-version-check" ,rust-version-check-0.9))
-- 
2.38.0

Message #8 received at 58610 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 58610 <at> debbugs.gnu.org
Subject: Re: [bug#58610] [PATCH] gnu: rust-generic-array-0.14: Fix build.
Date: Fri, 21 Oct 2022 17:18:17 +0100

[Message part 1 (text/plain, inline)]

Michael Rohleder <mike <at> rohleder.de> writes:

> * gnu/packages/crates-io.scm (rust-generic-array-0.14)[arguments]: Add #:tests? #false.
> ---
>  gnu/packages/crates-io.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

This may fix the build, but instead we'd just be shipping software where
the test suite fails.

If we do want to go that way of disabling the test suite, I think it
would be good to make sure the issue is reported upstream, and link to
that bug report in the package definition, does that make sense?

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 58610 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>
Cc: Michael Rohleder <mike <at> rohleder.de>, 58610 <at> debbugs.gnu.org
Subject: Re: bug#58610: [PATCH] gnu: rust-generic-array-0.14: Fix build.
Date: Tue, 03 Jan 2023 17:02:42 -0500

Hello Michael,

Christopher Baines <mail <at> cbaines.net> writes:

> Michael Rohleder <mike <at> rohleder.de> writes:
>
>> * gnu/packages/crates-io.scm (rust-generic-array-0.14)[arguments]: Add #:tests? #false.
>> ---
>>  gnu/packages/crates-io.scm | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> This may fix the build, but instead we'd just be shipping software where
> the test suite fails.
>
> If we do want to go that way of disabling the test suite, I think it
> would be good to make sure the issue is reported upstream, and link to
> that bug report in the package definition, does that make sense?

Friendly ping.

-- 
Thanks,
Maxim

Message #18 received at 58610-done <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 58610-done <at> debbugs.gnu.org
Subject: Re: bug#58610: [PATCH] gnu: rust-generic-array-0.14: Fix build.
Date: Sat, 07 Jan 2023 00:15:20 +0100

[Message part 1 (text/plain, inline)]

Hello Christopher!

Thank you for reviewing and sorry for the delay!

Christopher Baines <mail <at> cbaines.net> writes:
> This may fix the build, but instead we'd just be shipping software where
> the test suite fails.
>
> If we do want to go that way of disabling the test suite, I think it
> would be good to make sure the issue is reported upstream, and link to
> that bug report in the package definition, does that make sense?

I guess this make a lot of sense, but I can't do this, because I don't
have any rust/cargo knowledge, no gh account etc.

This patch was just a quick hack to get synapse working.  I should have
thought about fixing it better than just disabling a test.

Sorry for the waste of time and the noise -> closing.

-- 
There are two types of hard drives: those that have failed, and those that will.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.