GNU bug report logs - #58638
[PATCH core-updates 0/2] build/gnu: Support compressing non-numeric man sections.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58638 in the body.
You can then email your comments to 58638 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lilah Tascheter <lilah <at> lunabee.space>
To: guix-patches <at> gnu.org
Cc: Lilah Tascheter <lilah <at> lunabee.space>
Subject: [PATCH core-updates 0/2] build/gnu: Support compressing non-numeric
 man sections.
Date: Wed, 19 Oct 2022 10:24:19 -0500

The regex currently used by compress-documentation to compress manpages only
supports numeric man sections, which sometimes isn't the case (eg
man-pages-posix section 0p). Guix compiles with this change, but I haven't been
able to actually test packages with it due to these patches rebuilding
everything.

I'm not sure if something similar should be done for the infopage regex? I'm not
familiar with it.

Lilah Tascheter (2):
  build/gnu: Support compressing non-numeric man sections.
  gnu: man-pages-posix: Remove redundant manpage compression.

 gnu/packages/man.scm            | 8 ++++----
 guix/build/gnu-build-system.scm | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)


base-commit: 511d584906c6304a3dc6ffcf7096bb14c6bee222
-- 
2.37.3

Message #8 received at 58638 <at> debbugs.gnu.org (full text, mbox):

From: Lilah Tascheter <lilah <at> lunabee.space>
To: 58638 <at> debbugs.gnu.org
Cc: Lilah Tascheter <lilah <at> lunabee.space>
Subject: [PATCH core-updates 1/2] build/gnu: Support compressing non-numeric
 man sections.
Date: Wed, 19 Oct 2022 10:27:26 -0500

* guix/build/gnu-build-system.scm (compress-documentation)
  [maybe-compress]: Expand regex to include man sections with alphabetic
  suffixes.
---
 guix/build/gnu-build-system.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/build/gnu-build-system.scm b/guix/build/gnu-build-system.scm
index d84411c090..8f2997b4da 100644
--- a/guix/build/gnu-build-system.scm
+++ b/guix/build/gnu-build-system.scm
@@ -675,7 +675,7 @@ (define* (compress-documentation #:key outputs
 
   (define (maybe-compress output)
     (maybe-compress-directory (string-append output "/share/man")
-                              "\\.[0-9]+$")
+                              "\\.[0-9]+[:alpha:]*$")
     (maybe-compress-directory (string-append output "/share/info")
                               "\\.info(-[0-9]+)?$"))
 
-- 
2.37.3

Message #11 received at 58638 <at> debbugs.gnu.org (full text, mbox):

From: Lilah Tascheter <lilah <at> lunabee.space>
To: 58638 <at> debbugs.gnu.org
Cc: Lilah Tascheter <lilah <at> lunabee.space>
Subject: [PATCH core-updates 2/2] gnu: man-pages-posix: Remove redundant
 manpage compression.
Date: Wed, 19 Oct 2022 10:27:57 -0500

* gnu/packages/man.scm (man-pages-posix)[arguments]: Don't run build
  phase.
---
 gnu/packages/man.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/man.scm b/gnu/packages/man.scm
index 9a3297fcaf..b56262d832 100644
--- a/gnu/packages/man.scm
+++ b/gnu/packages/man.scm
@@ -315,11 +315,11 @@ (define-public man-pages-posix
     (build-system gnu-build-system)
     (arguments
      `(#:tests? #f
-       ;; The compress-documentation phase doesn't pick up on our manpages as
-       ;; its regex doesn't support trailing letters, so manually compress.
-       #:make-flags ,#~(list (string-append "prefix=" #$output) "gz")
+       #:make-flags ,#~(list (string-append "prefix=" #$output))
        #:license-file-regexp "POSIX-COPYRIGHT"
-       #:phases (modify-phases %standard-phases (delete 'configure))))
+       ;; The build phase only compresses documentation, which we already do.
+       #:phases (modify-phases %standard-phases (delete 'configure)
+                                                (delete 'build))))
     (home-page "https://www.kernel.org/doc/man-pages/")
     (synopsis "Man pages from the POSIX.1-2013 standard")
     (description
-- 
2.37.3

Message #16 received at 58638-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Lilah Tascheter <lilah <at> lunabee.space>
Cc: 58638-done <at> debbugs.gnu.org
Subject: Re: [bug#58638] [PATCH core-updates 2/2] gnu: man-pages-posix:
 Remove redundant manpage compression.
Date: Sat, 20 Jan 2024 15:31:44 -0500

Hi,

Lilah Tascheter <lilah <at> lunabee.space> writes:

> * gnu/packages/man.scm (man-pages-posix)[arguments]: Don't run build
>   phase.

Applied this series, thanks!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.