GNU bug report logs - #58665
Indentation in lisp/emacs-lisp/syntax.el is wrong

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58665 in the body.
You can then email your comments to 58665 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Blandy <jblandy <at> mozilla.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Indentation in lisp/emacs-lisp/syntax.el is wrong
Date: Thu, 20 Oct 2022 10:23:30 -0700

[Message part 1 (text/plain, inline)]

2022-10-20  Jim Blandy  <jimb <at> red-bean.com>

        * lisp/emacs-lisp/syntax.el: Fix indentation in `syntax-ppss'.

[Message part 2 (text/html, inline)]

[indent-syntax.el.patch (text/x-patch, attachment)]

Message #8 received at 58665 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Blandy <jblandy <at> mozilla.com>
Cc: 58665 <at> debbugs.gnu.org
Subject: Re: bug#58665: Indentation in lisp/emacs-lisp/syntax.el is wrong
Date: Thu, 20 Oct 2022 20:57:20 +0300

> From: Jim Blandy <jblandy <at> mozilla.com>
> Date: Thu, 20 Oct 2022 10:23:30 -0700
> 
> 2022-10-20  Jim Blandy  <jimb <at> red-bean.com>
> 
>         * lisp/emacs-lisp/syntax.el: Fix indentation in `syntax-ppss'.

Thanks, but we don't like pure-whitespace changes.  We fix these
issues when we change code around the places with wrong indentation.

Message #11 received at 58665 <at> debbugs.gnu.org (full text, mbox):

From: Jim Blandy <jblandy <at> mozilla.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58665 <at> debbugs.gnu.org
Subject: Re: bug#58665: Indentation in lisp/emacs-lisp/syntax.el is wrong
Date: Thu, 20 Oct 2022 14:18:13 -0700

[Message part 1 (text/plain, inline)]

This code changes almost never. It's been like that since 2016. It doesn't
make sense to let it sit there with formatting that obscures the structure
of the code.

On Thu, Oct 20, 2022 at 10:57 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Jim Blandy <jblandy <at> mozilla.com>
> > Date: Thu, 20 Oct 2022 10:23:30 -0700
> >
> > 2022-10-20  Jim Blandy  <jimb <at> red-bean.com>
> >
> >         * lisp/emacs-lisp/syntax.el: Fix indentation in `syntax-ppss'.
>
> Thanks, but we don't like pure-whitespace changes.  We fix these
> issues when we change code around the places with wrong indentation.
>

[Message part 2 (text/html, inline)]

Message #18 received at 58665 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Jim Blandy <jblandy <at> mozilla.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 58665 <at> debbugs.gnu.org
Subject: Re: bug#58665: Indentation in lisp/emacs-lisp/syntax.el is wrong
Date: Sun, 3 Sep 2023 03:21:33 -0700

Jim Blandy <jblandy <at> mozilla.com> writes:

> This code changes almost never. It's been like that since 2016. It
> doesn't make sense to let it sit there with formatting that obscures
> the structure of the code.
>
> On Thu, Oct 20, 2022 at 10:57 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
>  > From: Jim Blandy <jblandy <at> mozilla.com>
>  > Date: Thu, 20 Oct 2022 10:23:30 -0700
>  >
>  > 2022-10-20  Jim Blandy  <jimb <at> red-bean.com>
>  >
>  >         * lisp/emacs-lisp/syntax.el: Fix indentation in `syntax-ppss'.
>
>  Thanks, but we don't like pure-whitespace changes.  We fix these
>  issues when we change code around the places with wrong indentation.

I agree that we should avoid making whitespace-only changes in general.
Jim makes the point that readability counts.  He also points out that
this code changes so infrequently that we do not need to be overly
worried about any annoying merge conflicts.  I think these are valid
points.

So on balance, I'd be willing to make an exception and take this patch.
If Eli is still not convinced, I think it would be better to close this
bug and move on.  I think we can all agree it's not worth spending
energy discussing it further.

Message #21 received at 58665 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: jblandy <at> mozilla.com, 58665 <at> debbugs.gnu.org
Subject: Re: bug#58665: Indentation in lisp/emacs-lisp/syntax.el is wrong
Date: Sun, 03 Sep 2023 13:39:19 +0300

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Sun, 3 Sep 2023 03:21:33 -0700
> Cc: Eli Zaretskii <eliz <at> gnu.org>, 58665 <at> debbugs.gnu.org
> 
> Jim Blandy <jblandy <at> mozilla.com> writes:
> 
> > This code changes almost never. It's been like that since 2016. It
> > doesn't make sense to let it sit there with formatting that obscures
> > the structure of the code.
> >
> > On Thu, Oct 20, 2022 at 10:57 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
> >
> >  > From: Jim Blandy <jblandy <at> mozilla.com>
> >  > Date: Thu, 20 Oct 2022 10:23:30 -0700
> >  >
> >  > 2022-10-20  Jim Blandy  <jimb <at> red-bean.com>
> >  >
> >  >         * lisp/emacs-lisp/syntax.el: Fix indentation in `syntax-ppss'.
> >
> >  Thanks, but we don't like pure-whitespace changes.  We fix these
> >  issues when we change code around the places with wrong indentation.
> 
> I agree that we should avoid making whitespace-only changes in general.
> Jim makes the point that readability counts.  He also points out that
> this code changes so infrequently that we do not need to be overly
> worried about any annoying merge conflicts.  I think these are valid
> points.
> 
> So on balance, I'd be willing to make an exception and take this patch.
> If Eli is still not convinced, I think it would be better to close this
> bug and move on.  I think we can all agree it's not worth spending
> energy discussing it further.

If you think this change could be useful, I won't object applying it.

Message #26 received at 58665-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58665-done <at> debbugs.gnu.org, jblandy <at> mozilla.com
Subject: Re: bug#58665: Indentation in lisp/emacs-lisp/syntax.el is wrong
Date: Sun, 3 Sep 2023 03:45:00 -0700

Version: 30.1

Eli Zaretskii <eliz <at> gnu.org> writes:

> If you think this change could be useful, I won't object applying it.

Thanks, installed on master as commit 2ed99b6aa97.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.