GNU bug report logs - #58712
Incorrect vtable edges recognizing

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58712 in the body.
You can then email your comments to 58712 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lämppi Lütti <lamppilutti <at> protonmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: Incorrect vtable edges recognizing
Date: Sat, 22 Oct 2022 07:21:45 +0000

[Message part 1 (text/plain, inline)]

Functions `vtable-beginning-of-table' and `vtable-beginning-of-table' recognize
edges incorrectly. Because of this `vtable-narrow-current-column',
`vtable-widen-current-column', `vtable-sort-by-current-column' and
`vtable-header-line-sort' remove all text before and after the table.
There is small patch to fix this.

[Message part 2 (text/html, inline)]

[0001-Fix-vtable-edges-recognizing.patch (text/x-patch, attachment)]

Message #10 received at 58712 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Lämppi Lütti <lamppilutti <at> protonmail.com>
Cc: 58712 <at> debbugs.gnu.org
Subject: Re: bug#58712: Incorrect vtable edges recognizing
Date: Thu, 24 Nov 2022 12:01:47 -0800

Lämppi Lütti <lamppilutti <at> protonmail.com> writes:

> Functions `vtable-beginning-of-table' and `vtable-beginning-of-table' recognize
> edges incorrectly. Because of this `vtable-narrow-current-column',
> `vtable-widen-current-column', `vtable-sort-by-current-column' and
> `vtable-header-line-sort' remove all text before and after the table.
>
> There is small patch to fix this.

Do you have a recipe to reproduce this issue?  That would make it easier
to test the patch.  Thanks in advance.

Message #13 received at 58712 <at> debbugs.gnu.org (full text, mbox):

From: Lämppi Lütti <lamppilutti <at> protonmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 58712 <at> debbugs.gnu.org
Subject: Ответ: Re: bug#58712: Incorrect vtable edges recognizing
Date: Fri, 25 Nov 2022 13:08:44 +0000

> Lämppi Lütti lamppilutti <at> protonmail.com writes:
> 
> > Functions `vtable-beginning-of-table' and` vtable-beginning-of-table' recognize
> > edges incorrectly. Because of this `vtable-narrow-current-column',` vtable-widen-current-column', `vtable-sort-by-current-column' and` vtable-header-line-sort' remove all text before and after the table.
> > 
> > There is small patch to fix this.
> 
> 
> Do you have a recipe to reproduce this issue? That would make it easier
> to test the patch. Thanks in advance.

Steps for reproduce the bag:

1. Open buffer and insert some lines in it.
2. With cursor between the lines do M-x eval-expression RET
   (make-vtable :objects '(("Foo" 1034) ("Gazonk" 45))).
3. With cursor on the table do M-x vtable-sort-by-current-collumn several
   times (or any other function listed in first letter).

Without the patch lines above and below the table will be removed.

Message #18 received at 58712-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Lämppi Lütti <lamppilutti <at> protonmail.com>
Cc: 58712-done <at> debbugs.gnu.org
Subject: Re: bug#58712: Incorrect vtable edges recognizing
Date: Thu, 7 Sep 2023 13:27:22 -0700

Version: 30.1

Lämppi Lütti <lamppilutti <at> protonmail.com> writes:

> 1. Open buffer and insert some lines in it.
> 2. With cursor between the lines do M-x eval-expression RET
>    (make-vtable :objects '(("Foo" 1034) ("Gazonk" 45))).
> 3. With cursor on the table do M-x vtable-sort-by-current-collumn several
>    times (or any other function listed in first letter).
>
> Without the patch lines above and below the table will be removed.

Thanks for the reproducer, with that I was able to reproduce the bug and
confirm that your patch fixes it.

Installed on master as commit 55c2180d2c3.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.