GNU bug report logs - #58756
sqlite-returning tests fails with older SQLite library versions

Previous Next

Package: emacs;

Reported by: Mattias Engdegård <mattias.engdegard <at> gmail.com>

Date: Mon, 24 Oct 2022 09:51:01 UTC

Severity: normal

Tags: patch

Merged with 58766

Found in version 29.0.50

Done: Mattias Engdegård <mattias.engdegard <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58756 in the body.
You can then email your comments to 58756 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#58756; Package emacs. (Mon, 24 Oct 2022 09:51:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Mattias Engdegård <mattias.engdegard <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 24 Oct 2022 09:51:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Emacs Bug Report <bug-gnu-emacs <at> gnu.org>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>
Subject: sqlite-returning tests fails with older SQLite library versions
Date: Mon, 24 Oct 2022 11:50:00 +0200

[Message part 1 (text/plain, inline)]
The recently added sqlite-returning test fails when the SQLite library does not implement RETURNING, added in 3.35.

What about adding a Lisp function for retrieving the SQLite library version? It can be used to skip this particular test but would also be useful on its own.

Proof-of-concept patch attached.


[sqlite-version.diff (application/octet-stream, attachment)]
Added tag(s) patch. Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Sat, 12 Nov 2022 20:46:02 GMT) Full text and rfc822 format available.
Forcibly Merged 58756 58766. Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Sat, 12 Nov 2022 20:46:04 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58756; Package emacs. (Thu, 24 Nov 2022 20:02:03 GMT) Full text and rfc822 format available.

Message #12 received at 58756 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: 58756 <at> debbugs.gnu.org, 58766 <at> debbugs.gnu.org,
 Lars Ingebrigtsen <larsi <at> gnus.org>
Subject: Re: bug#58766: 29.0.50; Error in sqlite tests
Date: Thu, 24 Nov 2022 12:01:37 -0800

Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:

> The recently added sqlite-returning test fails when the SQLite library
> does not implement RETURNING, added in 3.35.
>
> What about adding a Lisp function for retrieving the SQLite library
> version? It can be used to skip this particular test but would also be
> useful on its own.
>
> Proof-of-concept patch attached.

LGTM.
Reply sent to Mattias Engdegård <mattias.engdegard <at> gmail.com>:
You have taken responsibility. (Fri, 25 Nov 2022 10:19:02 GMT) Full text and rfc822 format available.
Notification sent to Mattias Engdegård <mattias.engdegard <at> gmail.com>:
bug acknowledged by developer. (Fri, 25 Nov 2022 10:19:02 GMT) Full text and rfc822 format available.

Message #17 received at 58756-done <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 58756-done <at> debbugs.gnu.org, 58766 <at> debbugs.gnu.org,
 Lars Ingebrigtsen <larsi <at> gnus.org>
Subject: Re: bug#58766: 29.0.50; Error in sqlite tests
Date: Fri, 25 Nov 2022 11:18:09 +0100

Thank you, pushed to master (adding an entry to the manual).
Reply sent to Mattias Engdegård <mattias.engdegard <at> gmail.com>:
You have taken responsibility. (Fri, 25 Nov 2022 10:19:02 GMT) Full text and rfc822 format available.
Notification sent to Steve Downey <sdowney <at> gmail.com>:
bug acknowledged by developer. (Fri, 25 Nov 2022 10:19:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 23 Dec 2022 12:24:15 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 123 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.