GNU bug report logs - #58803
coreutils-8.32 test failure on i586-gnu

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58803 in the body.
You can then email your comments to 58803 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: bug-guix <at> gnu.org
Subject: coreutils-8.32 test failure on i586-gnu
Date: Wed, 26 Oct 2022 19:20:07 +0200

Native builds of coreutils-8.32 (ca. commit
3734857fc55df2c599c2fe5cc4ae49f5d47879fc) have one test failure on
i586-gnu:

--8<---------------cut here---------------start------------->8---
+ skip_if_root_
+ uid_is_privileged_
++ id -u
+ my_uid=999
+ case $my_uid in
+ return 1
+ touch unreadable
+ chmod a-r unreadable
+ df unreadable
df: Warning: cannot read table of mounted file systems: No such file or directory
Filesystem     1K-blocks    Used Available Use% Mounted on
-               12288000 2916208   8757392  25% /
+ mkfifo_or_skip_ fifo
+ test 1 = 1
+ mkfifo fifo
+ timeout 10 df fifo
df: Warning: cannot read table of mounted file systems: No such file or directory
+ fail=1
+ test 1 = 1
+ dump_mount_list_
+ cat /proc/self/mountinfo
cat: /proc/self/mountinfo: No such file or directory
+ cat /proc/self/mounts
cat: /proc/self/mounts: No such file or directory
+ cat /proc/mounts
/dev/hd0s1 / ext2fs writable,store-type=typed 0 0
proc /proc /hurd/procfs defaults 0 0
none /dev/shm /hurd/tmpfs writable,no-sync,size=1514772K 0 0
+ Exit 1
+ set +e
+ exit 1
+ exit 1
+ remove_tmp_
+ __st=1
+ cleanup_
+ :
+ test '' = yes
+ cd /tmp/guix-build-coreutils-8.32.drv-0/coreutils-8.32
+ chmod -R u+rwx /tmp/guix-build-coreutils-8.32.drv-0/coreutils-8.32/gt-unreadable.sh.6E92
+ rm -rf /tmp/guix-build-coreutils-8.32.drv-0/coreutils-8.32/gt-unreadable.sh.6E92
+ exit 1
FAIL tests/df/unreadable.sh (exit status: 1)
--8<---------------cut here---------------end--------------->8---

Indeed, ‘df’ seems to read FIFOs as if they were regular files:

--8<---------------cut here---------------start------------->8---
ludo <at> childhurd ~$ mkfifo fifo
ludo <at> childhurd ~$ ls -l fifo
prw-r--r-- 1 ludo users 0 Oct 21 07:08 fifo
ludo <at> childhurd ~$ df ./fifo
df: Warning: cannot read table of mounted file systems: No such file or directory
^C
--8<---------------cut here---------------end--------------->8---

It would seem that it’s stuck on a ‘dir_lookup’ RPC:

--8<---------------cut here---------------start------------->8---
  135<--132(pid83)->io_identity_request () = 0    137<--136(pid83)    131<--133(pid83) 29419
task109(pid83)-> 3206 (pn{ 18}) = 0 
task109(pid83)-> 3206 (pn{ 19}) = 0 
task109(pid83)-> 3206 (pn{ 17}) = 0 
task109(pid83)-> 3206 (pn{ 19}) = 0 
task109(pid83)-> 3206 (pn{ 17}) = 0 
task109(pid83)-> 3206 (pn{ 16}) = 0 
task109(pid83)-> 3206 (pn{ 14}) = 0 
task109(pid83)-> 3206 (pn{ 17}) = 0 
task109(pid83)-> 3206 (pn{ 14}) = 0 
task109(pid83)-> 2023 (17022976 4096) = 0 
  86<--120(pid83)->dir_lookup ("home/ludo/fifo" 65 0) ...113
task109(pid83)-> 2021 (0 4096 1) = 0 17018880
task109(pid83)-> 3208 (pn{ 13} 0 1) = 0 
task109(pid83)-> 3206 (pn{ 13}) = 0 
--8<---------------cut here---------------end--------------->8---

… where 65 = O_NOTRANS | O_RDONLY.

Passing O_NOTRANS (without O_RDONLY) like the ‘stat’ command does works
fine.

Maybe /hurd/fifo needs to implement ‘trivfs_check_open_hook’ to avoid
actually opening?

Ludo’.

Message #8 received at 58803 <at> debbugs.gnu.org (full text, mbox):

From: Samuel Thibault <samuel.thibault <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>, 58803 <at> debbugs.gnu.org,
 bug-hurd <at> gnu.org
Subject: Re: coreutils-8.32 test failure on i586-gnu
Date: Sat, 26 Nov 2022 12:53:38 +0100

Hello,

It seems that replying on the web interface didn't work, so replying
again here by mail.

Ludovic Courtès, le mer. 26 oct. 2022 19:20:07 +0200, a ecrit:
> ludo <at> childhurd ~$ mkfifo fifo
> ludo <at> childhurd ~$ ls -l fifo
> prw-r--r-- 1 ludo users 0 Oct 21 07:08 fifo
> ludo <at> childhurd ~$ df ./fifo
> df: Warning: cannot read table of mounted file systems: No such file or directory
> ^C

Using coreutils 9.1, I am not getting the issue any more:

€ mkfifo foo
€ ls -l foo
prw-r--r-- 1 samy samy 0 Nov 26 11:47 foo
€ df ./foo
Filesystem      Size  Used Avail Use% Mounted on
-                20G   18G  1.8G  91% /

> Maybe /hurd/fifo needs to implement ‘trivfs_check_open_hook’ to avoid
> actually opening?

I don't think it will change the behavior? trivfs_S_dir_lookup will call
trivfs_open after trivfs_check_open_hook anyway.

Samuel

Message #11 received at 58803 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: 58803 <at> debbugs.gnu.org
Cc: bug-hurd <at> gnu.org
Subject: Re: coreutils-8.32 test failure on i586-gnu
Date: Sat, 26 Nov 2022 16:35:29 +0100

Hi,

Samuel Thibault <samuel.thibault <at> gnu.org> skribis:

> It seems that replying on the web interface didn't work, so replying
> again here by mail.

Weird.

> Ludovic Courtès, le mer. 26 oct. 2022 19:20:07 +0200, a ecrit:
>> ludo <at> childhurd ~$ mkfifo fifo
>> ludo <at> childhurd ~$ ls -l fifo
>> prw-r--r-- 1 ludo users 0 Oct 21 07:08 fifo
>> ludo <at> childhurd ~$ df ./fifo
>> df: Warning: cannot read table of mounted file systems: No such file or directory
>> ^C
>
> Using coreutils 9.1, I am not getting the issue any more:
>
> € mkfifo foo
> € ls -l foo
> prw-r--r-- 1 samy samy 0 Nov 26 11:47 foo
> € df ./foo
> Filesystem      Size  Used Avail Use% Mounted on
> -                20G   18G  1.8G  91% /

Oh nice.  This may be a side effect of Coreutils commit
a3c04f8da14f0fe2a0561bf5562032b8ce5dafa9 (which made it in 9.0), which
opens the file with O_NONBLOCK.

>> Maybe /hurd/fifo needs to implement ‘trivfs_check_open_hook’ to avoid
>> actually opening?
>
> I don't think it will change the behavior? trivfs_S_dir_lookup will call
> trivfs_open after trivfs_check_open_hook anyway.

Indeed, that was misguided, sorry for the confusion.

Ludo’.

Message #16 received at 58803-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: 58803-done <at> debbugs.gnu.org
Subject: Re: bug#58803: coreutils-8.32 test failure on i586-gnu
Date: Tue, 18 Jul 2023 22:09:36 +0200

Ludovic Courtès <ludo <at> gnu.org> skribis:

>> Ludovic Courtès, le mer. 26 oct. 2022 19:20:07 +0200, a ecrit:
>>> ludo <at> childhurd ~$ mkfifo fifo
>>> ludo <at> childhurd ~$ ls -l fifo
>>> prw-r--r-- 1 ludo users 0 Oct 21 07:08 fifo
>>> ludo <at> childhurd ~$ df ./fifo
>>> df: Warning: cannot read table of mounted file systems: No such file or directory
>>> ^C
>>
>> Using coreutils 9.1, I am not getting the issue any more:
>>
>> € mkfifo foo
>> € ls -l foo
>> prw-r--r-- 1 samy samy 0 Nov 26 11:47 foo
>> € df ./foo
>> Filesystem      Size  Used Avail Use% Mounted on
>> -                20G   18G  1.8G  91% /
>
> Oh nice.  This may be a side effect of Coreutils commit
> a3c04f8da14f0fe2a0561bf5562032b8ce5dafa9 (which made it in 9.0), which
> opens the file with O_NONBLOCK.

This is confirmed to be fixed with Coreutils 9.1 as discussed at:

  https://issues.guix.gnu.org/64711

Closing!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.