GNU bug report logs - #58848
29.0.50; Make makefile browser mode obsolete?

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefankangas <at> gmail.com>

Date: Fri, 28 Oct 2022 21:08:02 UTC

Severity: wishlist

Tags: patch

Found in version 29.0.50

Fixed in version 30.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58848 in the body.
You can then email your comments to 58848 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#58848; Package emacs. (Fri, 28 Oct 2022 21:08:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Stefan Kangas <stefankangas <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 28 Oct 2022 21:08:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Make makefile browser mode obsolete?
Date: Fri, 28 Oct 2022 14:07:44 -0700
[Message part 1 (text/plain, inline)]
Severity: wishlist

While looking at make-mode.el, I found out that there's a "browser" mode
in there, that's basically a poor mans imenu.  Richard added this
comment to make-mode.el in 1994, and I'm inclined to agree:

    ;; * Consider removing browser mode.  It seems useless.

I have no idea what the situation was in 1994, but these days we have
imenu (and various associated frontends), so I think it is fully
redundant.

I also tried

    git log --grep=browse lisp/progmodes/make-mode.el

and it seems like the only changes in it over the years have been
cleanup type changes (fixing quoting in docstrings, and similar).
I also note that "emacs makefile browser" and "emacs make browser" gives
no hits on a web search, and I also can't find anything in the bug tracker.

So how about making that stuff obsolete, as in the attached?  In the
unlikely event that anyone is really attached to it, they will then have
a decade or so to pipe up.
[0001-Make-makefile-browser-obsolete.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58848; Package emacs. (Tue, 13 Dec 2022 22:17:02 GMT) Full text and rfc822 format available.

Message #8 received at 58848 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: 58848 <at> debbugs.gnu.org
Subject: Re: bug#58848: 29.0.50; Make makefile browser mode obsolete?
Date: Tue, 13 Dec 2022 14:16:28 -0800
[Message part 1 (text/plain, inline)]
tags 58848 + patch
thanks

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Severity: wishlist
>
> While looking at make-mode.el, I found out that there's a "browser" mode
> in there, that's basically a poor mans imenu.  Richard added this
> comment to make-mode.el in 1994, and I'm inclined to agree:
>
>     ;; * Consider removing browser mode.  It seems useless.
>
> I have no idea what the situation was in 1994, but these days we have
> imenu (and various associated frontends), so I think it is fully
> redundant.
>
> I also tried
>
>     git log --grep=browse lisp/progmodes/make-mode.el
>
> and it seems like the only changes in it over the years have been
> cleanup type changes (fixing quoting in docstrings, and similar).
> I also note that "emacs makefile browser" and "emacs make browser" gives
> no hits on a web search, and I also can't find anything in the bug tracker.
>
> So how about making that stuff obsolete, as in the attached?  In the
> unlikely event that anyone is really attached to it, they will then have
> a decade or so to pipe up.

I've updated the patch for Emacs 30, added a NEWS and proper commit
message.
[0001-Make-Makefile-browser-obsolete.patch (text/x-diff, attachment)]

Added tag(s) patch. Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Tue, 13 Dec 2022 22:17:03 GMT) Full text and rfc822 format available.

Reply sent to Stefan Kangas <stefankangas <at> gmail.com>:
You have taken responsibility. (Tue, 29 Aug 2023 16:33:02 GMT) Full text and rfc822 format available.

Notification sent to Stefan Kangas <stefankangas <at> gmail.com>:
bug acknowledged by developer. (Tue, 29 Aug 2023 16:33:02 GMT) Full text and rfc822 format available.

Message #15 received at 58848-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: 58848-done <at> debbugs.gnu.org
Subject: Re: bug#58848: 29.0.50; Make makefile browser mode obsolete?
Date: Tue, 29 Aug 2023 18:32:08 +0200
Version: 30.1

> > So how about making that stuff obsolete, as in the attached?  In the
> > unlikely event that anyone is really attached to it, they will then have
> > a decade or so to pipe up.
>
> I've updated the patch for Emacs 30, added a NEWS and proper commit
> message.

No further comments within 9 months.  Now pushed to master as commit
f7712bc82a9.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 27 Sep 2023 11:24:10 GMT) Full text and rfc822 format available.

This bug report was last modified 202 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.