GNU bug report logs - #58889
29.0.50; C-x p f on svn project fails

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58889 in the body.
You can then email your comments to 58889 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; C-x p f on svn project fails
Date: Sun, 30 Oct 2022 15:15:37 +0800

Trying to navigate with C-x p f in an SVN repository fails, because the
SVN repository has an ignore property with empty lines.  This is the
detailed error.

Debugger entered--Lisp error: (args-out-of-range "" 0)
  #f(compiled-function (entry) #<bytecode -0x1726de7462823143>)("")
  mapcar(#f(compiled-function (entry) #<bytecode -0x1726de7462823143>) ("" ""))
  #f(compiled-function (project dir) #<bytecode 0x187989c589069892>)((vc SVN "~/project/") "~/project/")
  apply(#f(compiled-function (project dir) #<bytecode 0x187989c589069892>) (vc SVN "~/project/") "~/project/")
  project-ignores((vc SVN "~/project/") "~/project/")
  project--dir-ignores((vc SVN "~/project/") "~/project/")
  #f(compiled-function (dir) #<bytecode 0x68383878a42445c>)("~/project/")
  mapcan(#f(compiled-function (dir) #<bytecode 0x68383878a42445c>) ("~/project/"))
  #f(compiled-function (project &optional dirs) #<bytecode -0x1baeb702532f0340>)((vc SVN "~/project/") ("~/project/"))
  apply(#f(compiled-function (project &optional dirs) #<bytecode -0x1baeb702532f0340>) (vc SVN "~/project/") ("~/project/"))
  project-files((vc SVN "~/project/") ("~/project/"))
  project-find-file-in(#("Flipped90:" 0 10 (fontified t)) ("~/project/") (vc SVN "~/project/") nil)
  project-find-file(nil)
  funcall-interactively(project-find-file nil)
  command-execute(project-find-file)

Would someone please take a look at this?

In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu) of 2022-10-29 built
 on trinity
Repository revision: f826f56a413a07eee2782655809e1f5e102c6153
Repository branch: HEAD
Windowing system distributor 'The X.Org Foundation', version 11.0.100000000000
System Description: Fedora Linux 36 (Workstation Edition)

Configured using:
 'configure --with-native-compilation --with-x-toolkit=no
 --without-cairo'

Configured features:
ACL DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2
LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY
OLDXMENU PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF WEBP X11
XDBE XFT XIM XINPUT2 XPM ZLIB

Important settings:
  value of $LANG: en_GB.utf8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: C/*l

Minor modes in effect:
  erc-list-mode: t
  erc-menu-mode: t
  erc-autojoin-mode: t
  erc-ring-mode: t
  erc-pcomplete-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-netsplit-mode: t
  erc-networks-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  sly-symbol-completion-mode: t
  global-edit-server-edit-mode: t
  global-git-commit-mode: t
  display-time-mode: t
  electric-pair-mode: t
  desktop-save-mode: t
  telega-active-locations-mode: t
  shell-dirtrack-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  lost-selection-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  abbrev-mode: t

Message #8 received at 58889 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Po Lu <luangruo <at> yahoo.com>, 58889 <at> debbugs.gnu.org
Subject: Re: bug#58889: 29.0.50; C-x p f on svn project fails
Date: Sun, 30 Oct 2022 21:25:17 +0200

Hi!

On 30.10.2022 09:15, Po Lu via Bug reports for GNU Emacs, the Swiss army 
knife of text editors wrote:
> Trying to navigate with C-x p f in an SVN repository fails, because the
> SVN repository has an ignore property with empty lines.  This is the
> detailed error.
> 
> Debugger entered--Lisp error: (args-out-of-range "" 0)
>    #f(compiled-function (entry) #<bytecode -0x1726de7462823143>)("")
>    mapcar(#f(compiled-function (entry) #<bytecode -0x1726de7462823143>) ("" ""))
>    #f(compiled-function (project dir) #<bytecode 0x187989c589069892>)((vc SVN "~/project/") "~/project/")
>    apply(#f(compiled-function (project dir) #<bytecode 0x187989c589069892>) (vc SVN "~/project/") "~/project/")
>    project-ignores((vc SVN "~/project/") "~/project/")
>    project--dir-ignores((vc SVN "~/project/") "~/project/")
>    #f(compiled-function (dir) #<bytecode 0x68383878a42445c>)("~/project/")
>    mapcan(#f(compiled-function (dir) #<bytecode 0x68383878a42445c>) ("~/project/"))
>    #f(compiled-function (project &optional dirs) #<bytecode -0x1baeb702532f0340>)((vc SVN "~/project/") ("~/project/"))
>    apply(#f(compiled-function (project &optional dirs) #<bytecode -0x1baeb702532f0340>) (vc SVN "~/project/") ("~/project/"))
>    project-files((vc SVN "~/project/") ("~/project/"))
>    project-find-file-in(#("Flipped90:" 0 10 (fontified t)) ("~/project/") (vc SVN "~/project/") nil)
>    project-find-file(nil)
>    funcall-interactively(project-find-file nil)
>    command-execute(project-find-file)
> 
> Would someone please take a look at this?

Does this help? I don't have an SVN repository to test.

diff --git a/lisp/vc/vc-svn.el b/lisp/vc/vc-svn.el
index 270877041a..f240ebafca 100644
--- a/lisp/vc/vc-svn.el
+++ b/lisp/vc/vc-svn.el
@@ -366,7 +366,7 @@ vc-svn-ignore-completion-table
   (with-temp-buffer
     (when (zerop (vc-svn-command
                   t t nil "propget" "svn:ignore" (expand-file-name 
directory)))
-      (split-string (buffer-string) "\n"))))
+      (split-string (buffer-string) "\n" t))))

 (defun vc-svn-find-admin-dir (file)
   "Return the administrative directory of FILE."

Message #11 received at 58889 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 58889 <at> debbugs.gnu.org
Subject: Re: bug#58889: 29.0.50; C-x p f on svn project fails
Date: Tue, 01 Nov 2022 09:51:11 +0800

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> Hi!
>
> On 30.10.2022 09:15, Po Lu via Bug reports for GNU Emacs, the Swiss
> army knife of text editors wrote:
>> Trying to navigate with C-x p f in an SVN repository fails, because the
>> SVN repository has an ignore property with empty lines.  This is the
>> detailed error.
>> Debugger entered--Lisp error: (args-out-of-range "" 0)
>>    #f(compiled-function (entry) #<bytecode -0x1726de7462823143>)("")
>>    mapcar(#f(compiled-function (entry) #<bytecode -0x1726de7462823143>) ("" ""))
>>    #f(compiled-function (project dir) #<bytecode 0x187989c589069892>)((vc SVN "~/project/") "~/project/")
>>    apply(#f(compiled-function (project dir) #<bytecode 0x187989c589069892>) (vc SVN "~/project/") "~/project/")
>>    project-ignores((vc SVN "~/project/") "~/project/")
>>    project--dir-ignores((vc SVN "~/project/") "~/project/")
>>    #f(compiled-function (dir) #<bytecode 0x68383878a42445c>)("~/project/")
>>    mapcan(#f(compiled-function (dir) #<bytecode 0x68383878a42445c>) ("~/project/"))
>>    #f(compiled-function (project &optional dirs) #<bytecode -0x1baeb702532f0340>)((vc SVN "~/project/") ("~/project/"))
>>    apply(#f(compiled-function (project &optional dirs) #<bytecode -0x1baeb702532f0340>) (vc SVN "~/project/") ("~/project/"))
>>    project-files((vc SVN "~/project/") ("~/project/"))
>>    project-find-file-in(#("Flipped90:" 0 10 (fontified t)) ("~/project/") (vc SVN "~/project/") nil)
>>    project-find-file(nil)
>>    funcall-interactively(project-find-file nil)
>>    command-execute(project-find-file)
>> Would someone please take a look at this?
>
> Does this help? I don't have an SVN repository to test.
>
> diff --git a/lisp/vc/vc-svn.el b/lisp/vc/vc-svn.el
> index 270877041a..f240ebafca 100644
> --- a/lisp/vc/vc-svn.el
> +++ b/lisp/vc/vc-svn.el
> @@ -366,7 +366,7 @@ vc-svn-ignore-completion-table
>    (with-temp-buffer
>      (when (zerop (vc-svn-command
>                    t t nil "propget" "svn:ignore" (expand-file-name
>                    directory)))
> -      (split-string (buffer-string) "\n"))))
> +      (split-string (buffer-string) "\n" t))))
>
>  (defun vc-svn-find-admin-dir (file)
>    "Return the administrative directory of FILE."

This seems to work, thanks.

Message #14 received at 58889 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 58889 <at> debbugs.gnu.org
Subject: Re: bug#58889: 29.0.50; C-x p f on svn project fails
Date: Wed, 2 Nov 2022 00:47:37 +0200

On 01.11.2022 03:51, Po Lu via Bug reports for GNU Emacs, the Swiss army 
knife of text editors wrote:
>> Does this help? I don't have an SVN repository to test.
>>
>> diff --git a/lisp/vc/vc-svn.el b/lisp/vc/vc-svn.el
>> index 270877041a..f240ebafca 100644
>> --- a/lisp/vc/vc-svn.el
>> +++ b/lisp/vc/vc-svn.el
>> @@ -366,7 +366,7 @@ vc-svn-ignore-completion-table
>>     (with-temp-buffer
>>       (when (zerop (vc-svn-command
>>                     t t nil "propget" "svn:ignore" (expand-file-name
>>                     directory)))
>> -      (split-string (buffer-string) "\n"))))
>> +      (split-string (buffer-string) "\n" t))))
>>
>>   (defun vc-svn-find-admin-dir (file)
>>     "Return the administrative directory of FILE."
> This seems to work, thanks.

Thanks for testing, pushed to master.

Message #19 received at 58889-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Po Lu <luangruo <at> yahoo.com>, 58889-done <at> debbugs.gnu.org
Subject: Re: bug#58889: 29.0.50; C-x p f on svn project fails
Date: Thu, 24 Nov 2022 11:40:25 -0800

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 01.11.2022 03:51, Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text
> editors wrote:
>>> Does this help? I don't have an SVN repository to test.
>>>
>>> diff --git a/lisp/vc/vc-svn.el b/lisp/vc/vc-svn.el
>>> index 270877041a..f240ebafca 100644
>>> --- a/lisp/vc/vc-svn.el
>>> +++ b/lisp/vc/vc-svn.el
>>> @@ -366,7 +366,7 @@ vc-svn-ignore-completion-table
>>>     (with-temp-buffer
>>>       (when (zerop (vc-svn-command
>>>                     t t nil "propget" "svn:ignore" (expand-file-name
>>>                     directory)))
>>> -      (split-string (buffer-string) "\n"))))
>>> +      (split-string (buffer-string) "\n" t))))
>>>
>>>   (defun vc-svn-find-admin-dir (file)
>>>     "Return the administrative directory of FILE."
>> This seems to work, thanks.
>
> Thanks for testing, pushed to master.

I'm therefore closing this bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.