Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 58893) by debbugs.gnu.org; 6 Nov 2022 19:15:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 06 14:15:47 2022 Received: from localhost ([127.0.0.1]:60611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1orl7S-0007JF-Ph for submit <at> debbugs.gnu.org; Sun, 06 Nov 2022 14:15:46 -0500 Received: from mail-wr1-f47.google.com ([209.85.221.47]:42587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <felician.nemeth@HIDDEN>) id 1orl7R-0007J1-3G for 58893 <at> debbugs.gnu.org; Sun, 06 Nov 2022 14:15:45 -0500 Received: by mail-wr1-f47.google.com with SMTP id cl5so13434305wrb.9 for <58893 <at> debbugs.gnu.org>; Sun, 06 Nov 2022 11:15:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=0cxZ+lhIxKlPFuGsdydkoqhXBgLuNcfSenkd9xj4fuw=; b=XFsQfOP6h6aAv+z0tyZqiaDTK/4ySA0bRrspeNdet0KweZ31AdpZVqeAIpy/rvoU2x MQC+cuq3gMOyGx3kzNO9n/tvq0gzAy+IURrkyefuPkcKkNIH6LIc7uU1p3krUtaPSQnw uxVgWIWla1CnCwMg697GUxsbPHj0CeDxumqTU254rkFV7K/3wpX9lkgR5hRgaE+sLBar sI65i7IzLME/916Oct3qPOEd4u4U/DKCLSgXw/+LaZBlF3b9LQ463Cks6TQXeZvYOhMy kIksN6TTgh5bViO1YGczkkcGZEkg+6bTS7tHIap237Vk9rJCCmes2Y4/5qz9uubsryhb UvKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0cxZ+lhIxKlPFuGsdydkoqhXBgLuNcfSenkd9xj4fuw=; b=avuepH8LRFPJCljhF5y0bxz2RcN1kvX72DQZCWIVM5oegBPRER2eNNZQNAyGwRk54L o4KRe0dQdC3seiMk50Xe0bVQ73SEG6IZOIONXohsz0YdgwC0KlsyaCMQK32goELY608i BQhnPmMcd481mc0HiOCFCwQpH6uE9utOHq3TU33FmR7wuSe7Jr1CBxFrNySNSlcbwjQM HJnvPV+L1I+elZTSvk1piRNujjo/5shNXxqJEMsGhv3zYxRZ34o7pWpLiWP7q0O7o8As 3CAlsS53i9futHbMH9exlvu1a2CVqEyOe7nLHkHEScyBqP6KwiH+AvcXyU2MI7fgnsY/ w1Ow== X-Gm-Message-State: ACrzQf2upcFPXup2tg5ZGlLbMste5NkfDz0Z94Yj0EE4FBjT0JiAt4Ix v7pXgANKtltJEF5JogKgIWRjuvoq4iU= X-Google-Smtp-Source: AMsMyM4ssZ1/OqGLFCX6Zw0wU/f9VeJB1VAXyvM3wmTrf6C/rDNS31mC7nKukgL6r0C4q+mI5y58hQ== X-Received: by 2002:a5d:64c3:0:b0:236:695d:39f7 with SMTP id f3-20020a5d64c3000000b00236695d39f7mr30061727wri.614.1667762138911; Sun, 06 Nov 2022 11:15:38 -0800 (PST) Received: from betli.gmail.com (catv-86-101-66-128.catv.fixed.vodafone.hu. [86.101.66.128]) by smtp.gmail.com with ESMTPSA id j22-20020a05600c1c1600b003a6125562e1sm6254527wms.46.2022.11.06.11.15.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Nov 2022 11:15:38 -0800 (PST) From: Felician Nemeth <felician.nemeth@HIDDEN> To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Subject: Re: bug#58893: 29.0.50; Feedback on Eglot manual References: <874jvlk5pm.fsf@HIDDEN> <83o7ttfvto.fsf@HIDDEN> <CALDnm50uE-d=fx=Bj28nMg12TecDP+iYWNqEWHPTvHzCtTRGwg@HIDDEN> Date: Sun, 06 Nov 2022 20:15:37 +0100 In-Reply-To: <CALDnm50uE-d=fx=Bj28nMg12TecDP+iYWNqEWHPTvHzCtTRGwg@HIDDEN> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Wed, 2 Nov 2022 08:26:00 +0000") Message-ID: <87iljrhp2e.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEWOdXElERN7LDLZs6/l 0dDQq6TepMcqAAACW0lEQVQ4jWWSzY7bMAyEaSm6mypylxjkroTRvUW8d9lavf+r7NDOZotWQHzg lyGHP0Sn5ed9qKrLWWIWos9/QJWIeCSywPNTd/AE0LtwFj7A+3WT5PwfeBrQKcsBnkfwVcNySWQr 3i34XN6gRNgis/v4uwSKHCD9lPitB0Aq9BHfHX4cgsI7cJJfLdZg/4bbCzoRmkD9MsagQSBDedZi CgNxkVSJmSOStTBUBKkywEnEoZzbwWj+ACiVJkF6pOpak2PMCqkMYDpaw+gatLR8atMOrB3JGzmm 3rSQo+tkxU+UAbhQSgtslULhsXKk6+IyQ1QTzeQB0MzjlpkCEUCeUdviWrwBcxVqpZjP+v0MYPA0 aq2rvIEZe4GRM0v+9QIB03rsABVSk5y+Mz3LSzExtJLlCCO6dV1uzDQFTBad+gO0TqqL9XE8x4ek +orvYiMJgzC8e+r6TqaPaK6QyqVNvoHtsRrooQ6tTi4vgaSkd8wIikodB3B0iIk58avsDdYNajpS bSKJ+mQnipGszB6zW4lGgsOkKHE2RWVcBpwhaIv3BYIAu3WsnC7YYKLRchp6w8fRGZIWiZuFsVai 7gbcUcJEhiDZ3K1+uzZvBlfaEO8oH4MLu6/hrKVM7QpQcIXJFuC1XjfbfKRxNslk94l9cYcEihV2 HWyNDQAXaLsvnrSyp7HaQhrAn13V6/XW11nh0XINBOEAV+tHK4EvAGNGvEwc0eZw8Vyr56imYEsV sOW9jxm/yb9AH1ufqGMviIK7A0Tc/723oM3tJ4HTOu9gDr3ftbdkxfdjsUv5AqWKwyfCYo5WAAAA AElFTkSuQmCC MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58893 Cc: Eli Zaretskii <eliz@HIDDEN>, 58893 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) >> > * Snippet completion >> > >> > Yasnippet should be enabled in the current buffer before Eglot connects >> > to the LSP server. > > Felici=C3=A1n, are you sure? If that's true, then I think it's a bug. I > don't want users to have to remember this. So I think the current > gist "just install yasnippet" should be enough. Eglot does not enable yasnippet mode anywhere. eglot--snippet-expansion-fn only checks whether yas-minor-mode/yas-global-mode is enabled. So if it is considered as a bug, then I think the fix is to make eglot--snippet-expansion-fn and eglot--managed-mode turn yas-minor-mode on when it is available and yasnippet is not in eglot-stay-out-of.
bug-gnu-emacs@HIDDEN:bug#58893; Package emacs.
Full text available.Received: (at 58893) by debbugs.gnu.org; 2 Nov 2022 08:25:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 02 04:25:21 2022 Received: from localhost ([127.0.0.1]:44872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oq93o-0002Qt-V2 for submit <at> debbugs.gnu.org; Wed, 02 Nov 2022 04:25:21 -0400 Received: from mail-oa1-f48.google.com ([209.85.160.48]:46908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1oq93m-0002Qd-8I for 58893 <at> debbugs.gnu.org; Wed, 02 Nov 2022 04:25:18 -0400 Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-13b6c1c89bdso19520901fac.13 for <58893 <at> debbugs.gnu.org>; Wed, 02 Nov 2022 01:25:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rrqoAId9bU2tKjxCYrdSx9EuqpSfkakPVwvflsLwWK8=; b=nAjUoZLCLXRP6/dornTEbCbGB+V+IRoRB234ab4rWjpy2lBJQ3WDVbTSn12EEATbLX BWu7QOxQ8LdYiS6LgA6IZy0TawYB6DRgksuhJcK5c6wnwUcRcXgJkEfa91b8luwToOlx RKMZlTxvToTV6MgfmOon4Qlz1d6aQL4M81vPka+ST3s0iJQZSm1xLHPsBB1em9vQJlDi 3tDbr14bfHeMpVMcOySnlYpWp+eGfMcfl8ckaQBYgbfy4bqA9oYWbdxbrfjj6mAAVDTn KL9RGnygzPknHCWBTCvRpCzRYvmajw1quPASB2xw8Elhj1GjXkDkayf+Iv4qGTlHIHAh RHaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rrqoAId9bU2tKjxCYrdSx9EuqpSfkakPVwvflsLwWK8=; b=1g/oxr6v/h/EuP13f6kgGZ/Dxvb758WvrSMwucXgwb62hynuTnVBGSMQcEUt3ZuVPt ElVanm7xy16OTiTd2va1zCQbNFQ80Vaacg/k0p6snPulEYm/c3jHM5XuD50QhWypW7fB b6sqKWivnBAKfvevfiZfNLm0EZIR1CdP8xipOLH1UmwiabBl1v86YsWQVihUMNB3arWR EQm36WMd4DOGh1gShBW306mD1rt5/r1j9jI/mG08Bmc8drDwEDxneuYcPi0XbYo3hiAw tigWyGuGqBrzwpm1IAiXe7EEDpqAoq4FB3ih+7DSz19CoFzF57jE2T7EPRfj+XEBSLw/ ZzBQ== X-Gm-Message-State: ACrzQf0oHmeUeczOCG12T4wzwhLtjtJ1z600uhLXJKDZQI/KzyqNUCeu OtabeAULysgf7Vi9RcgaUegEOzI3mHRTe8+0fV0= X-Google-Smtp-Source: AMsMyM6B2Z9izarvx8ZZ0HZ1OZWB2tFx+mQEQ3eBVbIT6Iq6F/tY+We8t13MUJV+LsXSEWo/hnUrQQCodjRFlxqqrUo= X-Received: by 2002:a05:6870:e242:b0:13b:d561:ad02 with SMTP id d2-20020a056870e24200b0013bd561ad02mr14200438oac.215.1667377512369; Wed, 02 Nov 2022 01:25:12 -0700 (PDT) MIME-Version: 1.0 References: <874jvlk5pm.fsf@HIDDEN> <83o7ttfvto.fsf@HIDDEN> In-Reply-To: <83o7ttfvto.fsf@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Wed, 2 Nov 2022 08:26:00 +0000 Message-ID: <CALDnm50uE-d=fx=Bj28nMg12TecDP+iYWNqEWHPTvHzCtTRGwg@HIDDEN> Subject: Re: bug#58893: 29.0.50; Feedback on Eglot manual To: Eli Zaretskii <eliz@HIDDEN> Content-Type: multipart/alternative; boundary="00000000000054d2b905ec789468" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58893 Cc: Felician Nemeth <felician.nemeth@HIDDEN>, 58893 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --00000000000054d2b905ec789468 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Oct 30, 2022 at 10:31 AM Eli Zaretskii <eliz@HIDDEN> wrote: > > > From: Felician Nemeth <felician.nemeth@HIDDEN> > The Eglot-specific commands you mention are AFAIU direct calls to the > Eglot's Xref backend, so why do we need to describe them in the > manual, when Xref itself is already described? I think what Felici=C3=A1n may be hinting at, and I agree, is that Eglot is Emacs's identifiable frontend to "code intelligence" features for many new users. We observed this many times. Users almost never know anything about Xref, Flymake, Eldoc, etc and these facilities. Rather they think it's Eglot that it "does" the definition-finding, diagnostics, documentatio= n respectively. This is not technically correct, and we do clarify it to those users, but it is also not at all unreasonable for a new user. Also many new users com from the lsp-mode package where these things are effectively all "done" by the package. The former README went to lengths to give visibility to them, and it was quite effective. This is not entirely lost in the new manual, but is much less obvious. I understand both points of view, though. Perhaps the solution is to more prominently advertise the Xref, the Flymake and the Eldoc manuals (and Eglot's of course) in some "Emacs IDE tutorial manual". > I'm not sure what exactly are you proposing to mention in the manual > in this respect. If we are going to add the description of how to add > directories to a project, then yes, Eglot should be mentioned there > (but only in passing, IMO, since Eglot follows the project settings > automatically, AFAIU). Yes, I think Felici=C3=A1n's idea makes sense. There's already a part of a manual about workspace folders in the descriptino of eglot-workspace-configuration. But it should really be brought into a dedicated section about LSP workspace folders and Eglot's translation of Emacs abstractions to them. This a common pain point for many users, and they have to be able to look it up quickly. > > * Snippet completion > > > > Yasnippet should be enabled in the current buffer before Eglot connects > > to the LSP server. Felici=C3=A1n, are you sure? If that's true, then I think it's a bug. I d= on't want users to have to remember this. So I think the current gist "just install yasnippet" should be enough. --00000000000054d2b905ec789468 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">On Sun, Oct 30, 2022 at 10:31 AM Eli Zaretskii <<a href= =3D"mailto:eliz@HIDDEN">eliz@HIDDEN</a>> wrote:<br>><br>> > F= rom: Felician Nemeth <<a href=3D"mailto:felician.nemeth@HIDDEN">felic= ian.nemeth@HIDDEN</a>><br><br>> The Eglot-specific commands you me= ntion are AFAIU direct calls to the<br>> Eglot's Xref backend, so wh= y do we need to describe them in the<br>> manual, when Xref itself is al= ready described?<br><br>I think what Felici=C3=A1n may be hinting at, and I= agree, is that Eglot is<br>Emacs's identifiable frontend to "code= intelligence" features for<br>many new users.=C2=A0 We observed this = many times. Users almost never know<br>anything about Xref, Flymake, Eldoc,= etc and these facilities.=C2=A0 Rather they think<br>it's Eglot that i= t "does" the definition-finding, diagnostics, documentation<br>= =C2=A0respectively. This is not technically correct, and we do clarify it t= o those<br>users, but it is also not at all unreasonable for a new user.<br= ><br>Also many new users com from the lsp-mode package where these things<b= r>are effectively all "done" by the package.<br><br>The former RE= ADME went to lengths to give visibility to them,<br>and it was quite effect= ive.=C2=A0 This is not entirely lost in the new manual,<br>but is much less= obvious.<br><br>I understand both points of view, though.=C2=A0 Perhaps th= e solution is<br>to more prominently advertise the Xref, the Flymake and th= e Eldoc<br>manuals (and Eglot's =C2=A0of course) in some "Emacs ID= E tutorial manual".<br><br>> I'm not sure what exactly are you = proposing to mention in the manual<br>> in this respect.=C2=A0 If we are= going to add the description of how to add<br>> directories to a projec= t, then yes, Eglot should be mentioned there<br>> (but only in passing, = IMO, since Eglot follows the project settings<br><div>> automatically, A= FAIU).=C2=A0 <br></div><div><br></div><div>Yes, I think Felici=C3=A1n's= idea makes sense.=C2=A0 There's already a part of <br></div><div>a man= ual about workspace folders in the descriptino of <br></div><div>eglot-work= space-configuration.</div><div><br></div><div>But it should really be broug= ht into a dedicated section about LSP workspace <br></div><div>folders and = Eglot's translation of Emacs abstractions to them.=C2=A0 This a <br></d= iv><div>common pain point for many users, and they have to be able to look<= /div><div>it up quickly.<br></div><br>> > * Snippet completion<br>>= ; ><br>> > Yasnippet should be enabled in the current buffer befor= e Eglot connects<br><div>> > to the LSP server.</div><div><br></div><= div>Felici=C3=A1n, are you sure?=C2=A0 If that's true, then I think it&= #39;s a bug.=C2=A0 I don't want users</div><div>to have to remember thi= s.=C2=A0 So I think the current gist "just install yasnippet" <br= ></div><div>should be enough.<br></div></div> --00000000000054d2b905ec789468--
bug-gnu-emacs@HIDDEN:bug#58893; Package emacs.
Full text available.
Received: (at 58893) by debbugs.gnu.org; 30 Oct 2022 14:15:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 30 10:15:58 2022
Received: from localhost ([127.0.0.1]:38802 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1op96U-00048d-Bb
for submit <at> debbugs.gnu.org; Sun, 30 Oct 2022 10:15:58 -0400
Received: from mail-ej1-f51.google.com ([209.85.218.51]:35739)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <felician.nemeth@HIDDEN>) id 1op96S-00048R-5h
for 58893 <at> debbugs.gnu.org; Sun, 30 Oct 2022 10:15:57 -0400
Received: by mail-ej1-f51.google.com with SMTP id k2so23702758ejr.2
for <58893 <at> debbugs.gnu.org>; Sun, 30 Oct 2022 07:15:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=mime-version:face:user-agent:message-id:in-reply-to:date:references
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=a7/lYAQ8P0UFGTTS37wAb8i6ZQs+Db814rd6Jon6i4Q=;
b=liFdtfZ2koCvce4p96SzlW8wLvvvHFw2l4IIJgSBEwBLm9JA9AYkP2ovNRQsGhs2LW
Q+BKK0RcaXfa5zaBVsUvLdPrPjBFVHKZZuT+fXQujSNnGpqUCUI0WUz3oWWJHIitHliu
ayqEokzB3/QTcOldr82/Q+Qf7ueTNmxD03L5a4bPiIJQPbnLhaM+uUYjPiOgNEzmeZpn
ED+9Lfaz/Q7LFS2OUHXC/qu4qqldCDJTDUrTdn4Onvteylw1pn0vMGW1p5zypr4Ybzam
9c2FgBDME6QH7t9vAFbJ/M+LC5wU1aZjncqdxmFHs9McZ+W5QSHOKArJBvxzReRXXVta
5Akg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=mime-version:face:user-agent:message-id:in-reply-to:date:references
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=a7/lYAQ8P0UFGTTS37wAb8i6ZQs+Db814rd6Jon6i4Q=;
b=PSSqRRv80Ekn1lwJNatY2Z3J3sku7vlyEpXAQuoB0/d9QfDz6VkXOULs/0Sso0ik1B
9jikfPmNgmwlhTCSjSNOy5eMzRAZ513VzI8i47rkA/G1kd9mEo2qOSxZ7vQOre4jkosy
2Ejq1jjDUcF0tL3vHwymO4CJO5qMEIqfk/Dtz4ilhrBRqFMhs3Kgxhjb+6ghvHCxGz0p
5ke/kCZbZTOqrBqduF3JYQoIqC3399e3vLzf0Q+WFMC96NYFADetWQ73lvHm8+KLolaY
3ANEVG+TMaDJxEgVzt0oaKas2ihuW3b7LI0Q1K4XVYJIfxWt+77veInqxqgAvNePuUxX
WgUQ==
X-Gm-Message-State: ACrzQf1QsL61GkKa8ZYXn6e/SBJXhbwvC+/dv8AXynfhILXdoYNW8rZU
QDZBEal6d6rcmPYzbJPsXIvZwQ+Rgyo=
X-Google-Smtp-Source: AMsMyM6sdLkZUj8ildCKTLmccHspytt/9S+Y9YAY7uiY5sb39bWbKYsn1F9lqHIaqXBgyWPwt2LQdQ==
X-Received: by 2002:a17:907:2c72:b0:7a4:a4b4:9fcb with SMTP id
ib18-20020a1709072c7200b007a4a4b49fcbmr8381465ejc.403.1667139349920;
Sun, 30 Oct 2022 07:15:49 -0700 (PDT)
Received: from betli.gmail.com (catv-86-101-66-128.catv.fixed.vodafone.hu.
[86.101.66.128]) by smtp.gmail.com with ESMTPSA id
f24-20020a17090631d800b007ad98918743sm1878602ejf.1.2022.10.30.07.15.49
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 30 Oct 2022 07:15:49 -0700 (PDT)
From: Felician Nemeth <felician.nemeth@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#58893: 29.0.50; Feedback on Eglot manual
References: <874jvlk5pm.fsf@HIDDEN> <83o7ttfvto.fsf@HIDDEN>
Date: Sun, 30 Oct 2022 15:15:48 +0100
In-Reply-To: <83o7ttfvto.fsf@HIDDEN> (Eli Zaretskii's message of "Sun, 30 Oct
2022 12:29:55 +0200")
Message-ID: <87pme9iei3.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEWOdXElERN7LDLZs6/l
0dDQq6TepMcqAAACW0lEQVQ4jWWSzY7bMAyEaSm6mypylxjkroTRvUW8d9lavf+r7NDOZotWQHzg
lyGHP0Sn5ed9qKrLWWIWos9/QJWIeCSywPNTd/AE0LtwFj7A+3WT5PwfeBrQKcsBnkfwVcNySWQr
3i34XN6gRNgis/v4uwSKHCD9lPitB0Aq9BHfHX4cgsI7cJJfLdZg/4bbCzoRmkD9MsagQSBDedZi
CgNxkVSJmSOStTBUBKkywEnEoZzbwWj+ACiVJkF6pOpak2PMCqkMYDpaw+gatLR8atMOrB3JGzmm
3rSQo+tkxU+UAbhQSgtslULhsXKk6+IyQ1QTzeQB0MzjlpkCEUCeUdviWrwBcxVqpZjP+v0MYPA0
aq2rvIEZe4GRM0v+9QIB03rsABVSk5y+Mz3LSzExtJLlCCO6dV1uzDQFTBad+gO0TqqL9XE8x4ek
+orvYiMJgzC8e+r6TqaPaK6QyqVNvoHtsRrooQ6tTi4vgaSkd8wIikodB3B0iIk58avsDdYNajpS
bSKJ+mQnipGszB6zW4lGgsOkKHE2RWVcBpwhaIv3BYIAu3WsnC7YYKLRchp6w8fRGZIWiZuFsVai
7gbcUcJEhiDZ3K1+uzZvBlfaEO8oH4MLu6/hrKVM7QpQcIXJFuC1XjfbfKRxNslk94l9cYcEihV2
HWyNDQAXaLsvnrSyp7HaQhrAn13V6/XW11nh0XINBOEAV+tHK4EvAGNGvEwc0eZw8Vyr56imYEsV
sOW9jxm/yb9AH1ufqGMviIK7A0Tc/723oM3tJ4HTOu9gDr3ftbdkxfdjsUv5AqWKwyfCYo5WAAAA
AElFTkSuQmCC
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 58893
Cc: 58893 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
I wanted to raise these topics, but if you think these are non-issues,
then I'm OK with closing this bug report. I continue in-line.
Eli Zaretskii <eliz@HIDDEN> writes:
>> From: Felician Nemeth <felician.nemeth@HIDDEN>
>> Date: Sun, 30 Oct 2022 10:42:45 +0100
>>
>> I'm not sure whether it is necessary to document all the commands
>> defined by Eglot, but the manual mentions xref-find-definitions, so
>> probably it should call the reader's attention to
>> eglot-find-declaration, eglot-find-implementation,
>> eglot-find-typeDefinition, and xref-find-references as well.
>
> Xref-related Eglot features are already mentioned in the Emacs user
> manual, where Xref is described. Eglot is documented there as an
> additional backend for Xref. I think that's the right place for that
> to be documented.
>
> The Eglot-specific commands you mention are AFAIU direct calls to the
> Eglot's Xref backend, so why do we need to describe them in the
> manual, when Xref itself is already described?
For completeness and discoverability. eglot.texi documents all the
elgot-code-action-* commands as well. But the users can bump into these
commands with M-x eglot- TAB, and eglot-menu has these as well. So
maybe these commands can be omitted from the manual.
>> * WorkspaceFolders
>>
>> The LSP protocol supports multiple workspace folders. Eglot relies on
>> project-external-roots to get the additional folders (besides
>> project-root). This is not mentioned in the manual. However, (info
>> "(emacs)Projects") doesn't talk about how the user should configure
>> these external roots.
>>
>> Maybe a simple solution is to rework the relevant part from NEWS.md into
>> the eglot.texi. NEWS.md has this:
>>
>> Eglot now advertises project-root and project-external-roots as
>> workspace-folders. (Configuring tags-table-list sets the external
>> roots of a simple git project.)
>
> I'm not sure what exactly are you proposing to mention in the manual
> in this respect. If we are going to add the description of how to add
> directories to a project, then yes, Eglot should be mentioned there
> (but only in passing, IMO, since Eglot follows the project settings
> automatically, AFAIU). But as long as we don't have such a
> description in the manual, how can we say anything in this respect
> about Eglot?
We can add a few sentences to the "Buffers, Projects, and Eglot" part of
eglot.texi. Here is my initial attempt:
diff --git a/doc/misc/eglot.texi b/doc/misc/eglot.texi
index 5a20028702..3fe0fe4518 100644
--- a/doc/misc/eglot.texi
+++ b/doc/misc/eglot.texi
@@ -519,6 +519,13 @@ Eglot and Buffers
e.g.@: a VCS repository (@pxref{Version Control,,, emacs, GNU Emacs
Manual}).
+@item
+A multi-directory project: if a project has set
+@code{project-external-roots}, then Eglot advertises these additional
+directories to the LSP server as extra workspace folders. (For a
+simple VC project, @code{project-external-roots} is derived from
+@code{tags-table-list}).
+
@item
An EDE project: source files in a directory hierarchy managed via the
Emacs Development Environment (@pxref{EDE,,, emacs, GNU Emacs
>> * Snippet completion
>>
>> Yasnippet should be enabled in the current buffer before Eglot connects
>> to the LSP server.
>
> That's a detail best left for README's, in particular that of
> Yasnippet, IMO. The manual mentions Yasnippet as an optional package,
> and leaves it at that, because it really isn't TRT to start describing
> unbundled packages in our manuals.
Usually, it is enough to enable yasnippet right before the user wants to
have a snippet completion. However, the LSP server sends snippet-based
completion items only if yasnippet is already enabled when Eglot first
communicates with the LSP server. But once again, maybe this is
straightforward and an uninteresting detail. Or maybe this is enough to
clarify the situation:
-insertion of code templates (snippets), is installed, and the language
+insertion of code templates (snippets), is installed and enabled, and the language
Thank you.
bug-gnu-emacs@HIDDEN:bug#58893; Package emacs.
Full text available.Received: (at 58893) by debbugs.gnu.org; 30 Oct 2022 10:30:22 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 30 06:30:22 2022 Received: from localhost ([127.0.0.1]:37390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1op5aA-00007f-7Z for submit <at> debbugs.gnu.org; Sun, 30 Oct 2022 06:30:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1op5a7-00007P-HS for 58893 <at> debbugs.gnu.org; Sun, 30 Oct 2022 06:30:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1op5a2-0005Ah-92; Sun, 30 Oct 2022 06:30:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PVjTfuZHC3Nn6qC0JV9jtTYWW+bOQb7KCPEzX8dkLcM=; b=kb3geKeOP5EH NbM63LvtUpDMyA5AZ05znYDY41MyeZS98uWzvkKbBJpCrchvSZC2gruGUo2nS2/7YJ8cSOAkGWDK3 /+1CdSVZ0MJcohyu1gIdCuRPoR+aEXAprPKaRtyj4KrWZFPGW1o5TqL1BbwPPcTZfBMNxji5eoagv ldccLzhfLKg+8vb2Pb/dzX5G4qxlDjMp6eUn/phmPZ/bWqTeziuRZ6xUhYE1cXJvxv893xcWObrqR l+GCDwqQjFTnnYDx4JtrGFX1S6AonN3OcsecBH7R3dE02SCpZ0qw+wjXYRNMICDtkiWzOaS3P7plU oxIAsMpphA594cxBIXhc3Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1op5a1-0005RQ-Ng; Sun, 30 Oct 2022 06:30:14 -0400 Date: Sun, 30 Oct 2022 12:29:55 +0200 Message-Id: <83o7ttfvto.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Felician Nemeth <felician.nemeth@HIDDEN> In-Reply-To: <874jvlk5pm.fsf@HIDDEN> (message from Felician Nemeth on Sun, 30 Oct 2022 10:42:45 +0100) Subject: Re: bug#58893: 29.0.50; Feedback on Eglot manual References: <874jvlk5pm.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58893 Cc: 58893 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Felician Nemeth <felician.nemeth@HIDDEN> > Date: Sun, 30 Oct 2022 10:42:45 +0100 > > I'm not sure whether it is necessary to document all the commands > defined by Eglot, but the manual mentions xref-find-definitions, so > probably it should call the reader's attention to > eglot-find-declaration, eglot-find-implementation, > eglot-find-typeDefinition, and xref-find-references as well. Xref-related Eglot features are already mentioned in the Emacs user manual, where Xref is described. Eglot is documented there as an additional backend for Xref. I think that's the right place for that to be documented. The Eglot-specific commands you mention are AFAIU direct calls to the Eglot's Xref backend, so why do we need to describe them in the manual, when Xref itself is already described? > * WorkspaceFolders > > The LSP protocol supports multiple workspace folders. Eglot relies on > project-external-roots to get the additional folders (besides > project-root). This is not mentioned in the manual. However, (info > "(emacs)Projects") doesn't talk about how the user should configure > these external roots. > > Maybe a simple solution is to rework the relevant part from NEWS.md into > the eglot.texi. NEWS.md has this: > > Eglot now advertises project-root and project-external-roots as > workspace-folders. (Configuring tags-table-list sets the external > roots of a simple git project.) I'm not sure what exactly are you proposing to mention in the manual in this respect. If we are going to add the description of how to add directories to a project, then yes, Eglot should be mentioned there (but only in passing, IMO, since Eglot follows the project settings automatically, AFAIU). But as long as we don't have such a description in the manual, how can we say anything in this respect about Eglot? > * Snippet completion > > Yasnippet should be enabled in the current buffer before Eglot connects > to the LSP server. That's a detail best left for README's, in particular that of Yasnippet, IMO. The manual mentions Yasnippet as an optional package, and leaves it at that, because it really isn't TRT to start describing unbundled packages in our manuals. Thanks.
bug-gnu-emacs@HIDDEN:bug#58893; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 30 Oct 2022 09:42:52 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 30 05:42:52 2022 Received: from localhost ([127.0.0.1]:37352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1op4qB-0007Ap-Tv for submit <at> debbugs.gnu.org; Sun, 30 Oct 2022 05:42:52 -0400 Received: from lists.gnu.org ([209.51.188.17]:35334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <felician.nemeth@HIDDEN>) id 1op4qA-0007Ai-J5 for submit <at> debbugs.gnu.org; Sun, 30 Oct 2022 05:42:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <felician.nemeth@HIDDEN>) id 1op4qA-0001SR-Cm for bug-gnu-emacs@HIDDEN; Sun, 30 Oct 2022 05:42:50 -0400 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <felician.nemeth@HIDDEN>) id 1op4q8-0002vl-Jv for bug-gnu-emacs@HIDDEN; Sun, 30 Oct 2022 05:42:50 -0400 Received: by mail-ej1-x635.google.com with SMTP id bj12so22663034ejb.13 for <bug-gnu-emacs@HIDDEN>; Sun, 30 Oct 2022 02:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:face:user-agent:message-id:date:subject:to:from:from :to:cc:subject:date:message-id:reply-to; bh=VhGt9HxEuAjcdCc2FXl0Q9d56aNpDoxMx+AwGwOG6iU=; b=HXtr5t2GnPajTJDDWIG73TmO3EPhXb48xvnRdJCF1RGDJtVykHlbeHgk1uh8vRyuss zC9q/Z/CgrT7Uec7ORPqd0UwP9OkxUqDhC5Aby8NIu5EjAS75oTwctWW6MaD3jswni0a BTl0lZp/xh0fuXwMQv5sm9bA1SA9iboRCefeBrmkyOS06PuT8909Qk2j7Rpp7VW4m0FR Wvea7U+u1TJe7aZYtUKrsb3CSXRZhAj80QzYoEj+aI/aj0nqpZFNUd4Q4XexuMCs13SY WXkdiGXhjWDgjPLxmD2F5O3TUPuHpJZb7EH9rmRubn3YNDn60yTvyFP4Hp9wOtf+u9fd pyiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:face:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VhGt9HxEuAjcdCc2FXl0Q9d56aNpDoxMx+AwGwOG6iU=; b=Wkd1Pw7T0hunzSPr4S3/oPmbr19MMF41id1Q1NrwKtrxQFmxvWdelnqfluD8Z7YEkn zDu6Q62JHyG54wDiniQpPJEcg0qq19cATHTYDJKDrY/zSmz++k9/U28cKVFrrTvnuRkJ rXahJKUBd2yY+BhRbx0XNsZh+Y0rA5d4owQhlLp2TUkHm4NGsmirX0PBTUkILL62b6/M E8EEfenPP8yZAAIt9LnbQVDkMaQHsCGRR/1MhUZAg+SUIf/sRwBjNfj8rXVEHETSC/LW TNB6lLdHll7iTT9AIhWxxxzCtJ2PimRqsySWBPGCtrOQJlq9Glkhs3kHi7QMjJdaJN1x ntbQ== X-Gm-Message-State: ACrzQf0GWL/lTC99p/Ok7QiDdipb0mojb21wHuhcLCB6oOowfwTlSjjV EPTCftpnyhg8VUSfQwlgE4uE4mh0peM= X-Google-Smtp-Source: AMsMyM4Xt/Hwu22Pq5nqe7SbQmJDt4mN8u0A93bkiSdtu0aI2zqnxuh/xsDm7U9Z0bYNeGo34qSzjg== X-Received: by 2002:a17:906:eecb:b0:73c:5bcb:8eb3 with SMTP id wu11-20020a170906eecb00b0073c5bcb8eb3mr7567602ejb.284.1667122966823; Sun, 30 Oct 2022 02:42:46 -0700 (PDT) Received: from betli.gmail.com (catv-86-101-66-128.catv.fixed.vodafone.hu. [86.101.66.128]) by smtp.gmail.com with ESMTPSA id t31-20020a056402241f00b00459cd13fd34sm1829148eda.85.2022.10.30.02.42.46 for <bug-gnu-emacs@HIDDEN> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Oct 2022 02:42:46 -0700 (PDT) From: Felician Nemeth <felician.nemeth@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 29.0.50; Feedback on Eglot manual Date: Sun, 30 Oct 2022 10:42:45 +0100 Message-ID: <874jvlk5pm.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEU2EgDVmFNHKAa4dz4q AwCDUSH2zWrE61tmAAACeklEQVQ4jU2UwY7jIAyGEZN5ABSFc9Ytcx6K6DmqmHsD8tyZKrz/I+xv yI6WKlHlj982tomiVckiWrUrgRU5jlqMpJKCkch5W419DQAiQGHDxdrWmm0/2kXCApiUmrZLq20s cjexq3VL25QuxjY7wOcJVEpb+jLeGLAK+OMyaa1hx9rFbkwHFWBVA2y8w1wHaLE7GuDdw5cEuOM5 SLIdrpwBkN0ezwI7nYoiilqthbcYc89KgC5+NnaOHGbZz0T6BCEgOLJ0vmYXuNdPAIXgDZJhF2Yu fjnPNwAsoUTUN/P8q3AAyz4zB/xmifEfiIbvS4jh7b7QqZiSm4MJC5kXNpCRaOsoyQXAMN2XCJfs j94NKfo7ACKUEgKE3y+Sg4jibUZ1A0jgYpxtvYMC3gHaHPq6x32ACeALIZoZxB+l9VrRNIA1ncRg wwC8pvQIvYO+a2yt3VXMVyli6L0VV6aOrJa4CpilVQA+eHt0xavk61akih5BUMay/0BAqu783C5h FifY/3QsAIoWYk6PgpwAzLI652+96e2IfN2cF+BD1uT23F21Ghh5OUl4RlO15oh5A2iv+Zk2wsjZ 2DtB5Sm3A4P0+kyb2vs4iEW7G9ohoN3Stl2kVat6MCkXldo6OKaE8P6GhmrKKxWZXQH1iklhhn+d iVeNf6mDdkV0ltFwApRbp+kXSGBFHGV2aPqnIIyQyzhD5n47khqKI08bIapcas4O+hPkct20NAEv ALRuZFUp3PrnQSAm+4lTdHCsYYZ/nGqQrM5z3NS3zefFxkfFPRFbsjpIfbTlvF3ibpVZQ9nzqv60 F/KXSRLJ1AGappJulZll70N/qz6EfwEOCdYOuTHAzAAAAABJRU5ErkJggg== MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=felician.nemeth@HIDDEN; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) All in all, I think the new eglot.texi is really informative. Nevertheless, having reread Eglot's github page, I've found some information that's missing from the manual. Maybe it's worth including some of them to the manual. * Missing commands I'm not sure whether it is necessary to document all the commands defined by Eglot, but the manual mentions xref-find-definitions, so probably it should call the reader's attention to eglot-find-declaration, eglot-find-implementation, eglot-find-typeDefinition, and xref-find-references as well. * WorkspaceFolders The LSP protocol supports multiple workspace folders. Eglot relies on project-external-roots to get the additional folders (besides project-root). This is not mentioned in the manual. However, (info "(emacs)Projects") doesn't talk about how the user should configure these external roots. Maybe a simple solution is to rework the relevant part from NEWS.md into the eglot.texi. NEWS.md has this: Eglot now advertises project-root and project-external-roots as workspace-folders. (Configuring tags-table-list sets the external roots of a simple git project.) * Snippet completion Yasnippet should be enabled in the current buffer before Eglot connects to the LSP server. Thanks.
Felician Nemeth <felician.nemeth@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#58893; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.